Sessions are now the unit of the product instead of an implicit capture run. - Nothing is deleted by default: the fixed 10-session cap is gone. An age limit (Never / 7 / 14 / 30 / 90 / 180 / 365 days) is chosen in Settings > Sessions and applied on launch, after archiving, and by "Clean up now". Sent PDFs are never touched. - Each session carries review details: lane, deployed version, commit, reviewer (pre-filled with the Mac user) and a free note. They persist in session.json and are inherited by the next session, so a review run is typed once. - PDF file names are Redline-<yyyyMMdd-HHmm>-<LANE>-<SHORTID>.pdf, and every page carries a two-line reference footer (tool, build time, session / lane, deployed build, commit, reviewer, note). The PDF document info carries the same values in Author and Keywords. - Verification: 159 tests, a headless panel self-test, and a LaunchServices-driven end-to-end run that types and clicks the real panel.
139 lines
4.9 KiB
Swift
139 lines
4.9 KiB
Swift
import Foundation
|
|
import ShotdeckCore
|
|
import Testing
|
|
|
|
// PDF naming scheme + the persisted session age limit.
|
|
|
|
// MARK: - PDF file names
|
|
|
|
@Test
|
|
func laneSlugKeepsLettersDigitsAndSingleDashes() {
|
|
#expect(PDFFileName.laneSlug("OMS test lane") == "OMS-TEST-LANE")
|
|
#expect(PDFFileName.laneSlug(" dev03 ") == "DEV03")
|
|
#expect(PDFFileName.laneSlug("v1.4.2 / stage") == "V1-4-2-STAGE")
|
|
#expect(PDFFileName.laneSlug("") == "")
|
|
#expect(PDFFileName.laneSlug("--") == "")
|
|
}
|
|
|
|
@Test
|
|
func laneSlugIsCappedSoTheFileNameStaysShort() {
|
|
let long = String(repeating: "abcdefghij", count: 5)
|
|
let slug = PDFFileName.laneSlug(long)
|
|
#expect(slug.count == PDFFileName.laneMaxLength)
|
|
#expect(!slug.hasSuffix("-"))
|
|
}
|
|
|
|
@Test
|
|
func fileNameIsSortableAndUniquePerSession() {
|
|
let sessionID = UUID(uuidString: "4F2A9C1D-0000-4000-8000-000000000000")!
|
|
let builtAt = Date(timeIntervalSince1970: 1_777_482_180)
|
|
|
|
let withLane = PDFFileName.make(builtAt: builtAt, lane: "dev03", sessionID: sessionID)
|
|
#expect(withLane == "Redline-\(DubaiTime.fileMinuteStamp(builtAt))-DEV03-4F2A9C1D.pdf")
|
|
|
|
let withoutLane = PDFFileName.make(builtAt: builtAt, lane: "", sessionID: sessionID)
|
|
#expect(withoutLane == "Redline-\(DubaiTime.fileMinuteStamp(builtAt))-4F2A9C1D.pdf")
|
|
|
|
// Two sessions in the same minute never collide.
|
|
let other = UUID(uuidString: "9B8C7D6E-0000-4000-8000-000000000000")!
|
|
#expect(PDFFileName.make(builtAt: builtAt, lane: "dev03", sessionID: other)
|
|
!= withLane)
|
|
}
|
|
|
|
@Test
|
|
func sessionLabelIsLaneOrShortID() {
|
|
let id = UUID(uuidString: "4F2A9C1D-0000-4000-8000-000000000000")!
|
|
#expect(PDFFileName.sessionLabel(lane: "dev03", sessionID: id) == "DEV03-4F2A9C1D")
|
|
#expect(PDFFileName.sessionLabel(lane: "", sessionID: id) == "4F2A9C1D")
|
|
}
|
|
|
|
// MARK: - Retention setting
|
|
|
|
@Test
|
|
func retentionDefaultsToNever() throws {
|
|
let suite = try makeDefaults()
|
|
defer { suite.defaults.removePersistentDomain(forName: suite.name) }
|
|
|
|
#expect(RetentionSettings.load(defaults: suite.defaults) == .never)
|
|
#expect(RetentionSettings.load(defaults: suite.defaults).cutoff() == nil)
|
|
}
|
|
|
|
@Test
|
|
func retentionRoundTripsThroughDefaults() throws {
|
|
let suite = try makeDefaults()
|
|
defer { suite.defaults.removePersistentDomain(forName: suite.name) }
|
|
|
|
RetentionSettings.save(.days(30), defaults: suite.defaults)
|
|
#expect(RetentionSettings.load(defaults: suite.defaults) == .days(30))
|
|
|
|
RetentionSettings.save(.never, defaults: suite.defaults)
|
|
#expect(RetentionSettings.load(defaults: suite.defaults) == .never)
|
|
#expect(suite.defaults.object(forKey: RetentionSettings.defaultsKey) == nil)
|
|
}
|
|
|
|
@Test
|
|
func retentionCutoffIsTheDayCountBeforeNow() {
|
|
let now = Date(timeIntervalSince1970: 1_777_482_180)
|
|
let cutoff = try? #require(SessionRetention.days(30).cutoff(now: now))
|
|
let expected = Calendar(identifier: .gregorian).date(byAdding: .day, value: -30, to: now)
|
|
#expect(cutoff == expected)
|
|
}
|
|
|
|
@Test
|
|
func retentionPresetsReadAsPlainEnglish() {
|
|
#expect(SessionRetention.never.displayName == "Never (default)")
|
|
#expect(SessionRetention.days(7).displayName == "7 days")
|
|
#expect(SessionRetention.days(365).displayName == "1 year")
|
|
#expect(SessionRetention.never.policyDescription == "All sessions kept.")
|
|
#expect(SessionRetention.days(14).policyDescription == "Sessions older than 14 days are deleted.")
|
|
}
|
|
|
|
// MARK: - Review context
|
|
|
|
@Test
|
|
func reviewContextTrimsCapsAndCollapsesLineBreaks() {
|
|
let long = String(repeating: "x", count: ReviewContext.maxFieldLength + 40)
|
|
let context = ReviewContext(
|
|
lane: " dev03 ", deployedVersion: "v1.4.2\n(build 41)", commit: " a1b2c3d4 ",
|
|
reviewer: "Ben Hippler", note: long)
|
|
#expect(context.lane == "dev03")
|
|
#expect(context.deployedVersion == "v1.4.2 (build 41)")
|
|
#expect(context.commit == "a1b2c3d4")
|
|
#expect(context.note.count == ReviewContext.maxFieldLength)
|
|
}
|
|
|
|
@Test
|
|
func reviewContextSummaryDropsEmptyParts() {
|
|
#expect(ReviewContext(lane: "dev03", commit: "a1b2c3d4").summaryLine == "dev03 · a1b2c3d4")
|
|
#expect(ReviewContext().summaryLine == "")
|
|
#expect(ReviewContext().isEmpty)
|
|
}
|
|
|
|
@Test
|
|
func reviewContextDecodesPartialJSON() throws {
|
|
let json = Data(#"{"lane":"dev03","commit":"a1b2c3d4"}"#.utf8)
|
|
let context = try JSONDecoder().decode(ReviewContext.self, from: json)
|
|
#expect(context.lane == "dev03")
|
|
#expect(context.commit == "a1b2c3d4")
|
|
#expect(context.reviewer == "")
|
|
#expect(context.note == "")
|
|
}
|
|
|
|
// MARK: - Fixtures
|
|
|
|
private struct DefaultsSuite {
|
|
let name: String
|
|
let defaults: UserDefaults
|
|
}
|
|
|
|
private func makeDefaults() throws -> DefaultsSuite {
|
|
let name = "shotdeck-retention-settings-\(UUID().uuidString)"
|
|
guard let defaults = UserDefaults(suiteName: name) else {
|
|
throw SettingsFixtureError.noSuite
|
|
}
|
|
defaults.removePersistentDomain(forName: name)
|
|
return DefaultsSuite(name: name, defaults: defaults)
|
|
}
|
|
|
|
private enum SettingsFixtureError: Error { case noSuite }
|