Compare commits
41
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
3061e45bcb | ||
|
|
02fa791b78 | ||
|
|
542aad296b | ||
|
|
fd621608b0 | ||
|
|
01252b90da | ||
|
|
0506ce04e9 | ||
|
|
eaa5bd5884 | ||
|
|
6ab398c3f2 | ||
|
|
2a3af20d04 | ||
|
|
ae7fb8ee87 | ||
|
|
821e113f34 | ||
|
|
942e848dde | ||
|
|
905a019823 | ||
|
|
e71c2e7c91 | ||
|
|
169dd2b32c | ||
|
|
7cdc3e7652 | ||
|
|
a0ff61ae14 | ||
|
|
c3cae010a4 | ||
|
|
33e3441580 | ||
|
|
eb1af5bf18 | ||
|
|
49c6a41033 | ||
|
|
706726a3d4 | ||
|
|
e1f569cc3e | ||
|
|
4da02e243f | ||
|
|
3abb8dc6ca | ||
|
|
8d68c836cd | ||
|
|
04d1e73532 | ||
|
|
d7984add2d | ||
|
|
723cd7dcea | ||
|
|
70231574c9 | ||
|
|
8121738188 | ||
|
|
6484fde530 | ||
|
|
bd11ba96c5 | ||
|
|
ef0d8712f7 | ||
|
|
20de467e87 | ||
|
|
209921f084 | ||
|
|
2937d2d5e0 | ||
|
|
80a128b667 | ||
|
|
78cc7d5b1a | ||
|
|
6449c72b3b | ||
|
|
299d55e884 |
@@ -0,0 +1,26 @@
|
||||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
|
||||
<plist version="1.0">
|
||||
<dict>
|
||||
<key>CFBundleExecutable</key>
|
||||
<string>Shotdeck</string>
|
||||
<key>CFBundleIconFile</key>
|
||||
<string>AppIcon</string>
|
||||
<key>CFBundleIdentifier</key>
|
||||
<string>ai.flowmaster.shotdeck</string>
|
||||
<key>CFBundleName</key>
|
||||
<string>Redline</string>
|
||||
<key>CFBundlePackageType</key>
|
||||
<string>APPL</string>
|
||||
<key>CFBundleShortVersionString</key>
|
||||
<string>99.0.0</string>
|
||||
<key>CFBundleVersion</key>
|
||||
<string>5</string>
|
||||
<key>LSMinimumSystemVersion</key>
|
||||
<string>14.0</string>
|
||||
<key>LSUIElement</key>
|
||||
<true/>
|
||||
<key>NSHumanReadableCopyright</key>
|
||||
<string>Copyright © 2026 Flowmaster FZC LLC. All rights reserved.</string>
|
||||
</dict>
|
||||
</plist>
|
||||
Binary file not shown.
Binary file not shown.
@@ -0,0 +1,128 @@
|
||||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
|
||||
<plist version="1.0">
|
||||
<dict>
|
||||
<key>files</key>
|
||||
<dict>
|
||||
<key>Resources/AppIcon.icns</key>
|
||||
<data>
|
||||
WH6vz/PQ1NXa7ko7QlCGPEtVLxU=
|
||||
</data>
|
||||
</dict>
|
||||
<key>files2</key>
|
||||
<dict>
|
||||
<key>Resources/AppIcon.icns</key>
|
||||
<dict>
|
||||
<key>hash2</key>
|
||||
<data>
|
||||
LEP/PkABbPR3LYbMANoGI9OErrWNA+KhCulMlhTloaI=
|
||||
</data>
|
||||
</dict>
|
||||
</dict>
|
||||
<key>rules</key>
|
||||
<dict>
|
||||
<key>^Resources/</key>
|
||||
<true/>
|
||||
<key>^Resources/.*\.lproj/</key>
|
||||
<dict>
|
||||
<key>optional</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>1000</real>
|
||||
</dict>
|
||||
<key>^Resources/.*\.lproj/locversion.plist$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>1100</real>
|
||||
</dict>
|
||||
<key>^Resources/Base\.lproj/</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>1010</real>
|
||||
</dict>
|
||||
<key>^version.plist$</key>
|
||||
<true/>
|
||||
</dict>
|
||||
<key>rules2</key>
|
||||
<dict>
|
||||
<key>.*\.dSYM($|/)</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>11</real>
|
||||
</dict>
|
||||
<key>^(.*/)?\.DS_Store$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>2000</real>
|
||||
</dict>
|
||||
<key>^(Frameworks|SharedFrameworks|PlugIns|Plug-ins|XPCServices|Helpers|MacOS|Library/(Automator|Spotlight|LoginItems))/</key>
|
||||
<dict>
|
||||
<key>nested</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>10</real>
|
||||
</dict>
|
||||
<key>^.*</key>
|
||||
<true/>
|
||||
<key>^Info\.plist$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
<key>^PkgInfo$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
<key>^Resources/</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
<key>^Resources/.*\.lproj/</key>
|
||||
<dict>
|
||||
<key>optional</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>1000</real>
|
||||
</dict>
|
||||
<key>^Resources/.*\.lproj/locversion.plist$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>1100</real>
|
||||
</dict>
|
||||
<key>^Resources/Base\.lproj/</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>1010</real>
|
||||
</dict>
|
||||
<key>^[^/]+$</key>
|
||||
<dict>
|
||||
<key>nested</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>10</real>
|
||||
</dict>
|
||||
<key>^embedded\.provisionprofile$</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
<key>^version\.plist$</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
</dict>
|
||||
</dict>
|
||||
</plist>
|
||||
@@ -0,0 +1,26 @@
|
||||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
|
||||
<plist version="1.0">
|
||||
<dict>
|
||||
<key>CFBundleExecutable</key>
|
||||
<string>Shotdeck</string>
|
||||
<key>CFBundleIconFile</key>
|
||||
<string>AppIcon</string>
|
||||
<key>CFBundleIdentifier</key>
|
||||
<string>ai.flowmaster.shotdeck</string>
|
||||
<key>CFBundleName</key>
|
||||
<string>Redline</string>
|
||||
<key>CFBundlePackageType</key>
|
||||
<string>APPL</string>
|
||||
<key>CFBundleShortVersionString</key>
|
||||
<string>0.3.2</string>
|
||||
<key>CFBundleVersion</key>
|
||||
<string>5</string>
|
||||
<key>LSMinimumSystemVersion</key>
|
||||
<string>14.0</string>
|
||||
<key>LSUIElement</key>
|
||||
<true/>
|
||||
<key>NSHumanReadableCopyright</key>
|
||||
<string>Copyright © 2026 Flowmaster FZC LLC. All rights reserved.</string>
|
||||
</dict>
|
||||
</plist>
|
||||
BIN
Binary file not shown.
Binary file not shown.
@@ -0,0 +1,128 @@
|
||||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
|
||||
<plist version="1.0">
|
||||
<dict>
|
||||
<key>files</key>
|
||||
<dict>
|
||||
<key>Resources/AppIcon.icns</key>
|
||||
<data>
|
||||
WH6vz/PQ1NXa7ko7QlCGPEtVLxU=
|
||||
</data>
|
||||
</dict>
|
||||
<key>files2</key>
|
||||
<dict>
|
||||
<key>Resources/AppIcon.icns</key>
|
||||
<dict>
|
||||
<key>hash2</key>
|
||||
<data>
|
||||
LEP/PkABbPR3LYbMANoGI9OErrWNA+KhCulMlhTloaI=
|
||||
</data>
|
||||
</dict>
|
||||
</dict>
|
||||
<key>rules</key>
|
||||
<dict>
|
||||
<key>^Resources/</key>
|
||||
<true/>
|
||||
<key>^Resources/.*\.lproj/</key>
|
||||
<dict>
|
||||
<key>optional</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>1000</real>
|
||||
</dict>
|
||||
<key>^Resources/.*\.lproj/locversion.plist$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>1100</real>
|
||||
</dict>
|
||||
<key>^Resources/Base\.lproj/</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>1010</real>
|
||||
</dict>
|
||||
<key>^version.plist$</key>
|
||||
<true/>
|
||||
</dict>
|
||||
<key>rules2</key>
|
||||
<dict>
|
||||
<key>.*\.dSYM($|/)</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>11</real>
|
||||
</dict>
|
||||
<key>^(.*/)?\.DS_Store$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>2000</real>
|
||||
</dict>
|
||||
<key>^(Frameworks|SharedFrameworks|PlugIns|Plug-ins|XPCServices|Helpers|MacOS|Library/(Automator|Spotlight|LoginItems))/</key>
|
||||
<dict>
|
||||
<key>nested</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>10</real>
|
||||
</dict>
|
||||
<key>^.*</key>
|
||||
<true/>
|
||||
<key>^Info\.plist$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
<key>^PkgInfo$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
<key>^Resources/</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
<key>^Resources/.*\.lproj/</key>
|
||||
<dict>
|
||||
<key>optional</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>1000</real>
|
||||
</dict>
|
||||
<key>^Resources/.*\.lproj/locversion.plist$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>1100</real>
|
||||
</dict>
|
||||
<key>^Resources/Base\.lproj/</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>1010</real>
|
||||
</dict>
|
||||
<key>^[^/]+$</key>
|
||||
<dict>
|
||||
<key>nested</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>10</real>
|
||||
</dict>
|
||||
<key>^embedded\.provisionprofile$</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
<key>^version\.plist$</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
</dict>
|
||||
</dict>
|
||||
</plist>
|
||||
Binary file not shown.
@@ -0,0 +1 @@
|
||||
{"notes":"UPDATE-SELFTEST","sha256":"666800eb452240465677c1e33e8ec0f009e5cfe2fde1a789201856dc624992ef","version":"99.0.0","zipURL":"file:\/\/\/Users\/benjaminhippler\/mmd-projects\/shotdeck\/1\/Redline-99.0.0.zip"}
|
||||
Binary file not shown.
|
After Width: | Height: | Size: 201 KiB |
@@ -0,0 +1,26 @@
|
||||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
|
||||
<plist version="1.0">
|
||||
<dict>
|
||||
<key>CFBundleExecutable</key>
|
||||
<string>Shotdeck</string>
|
||||
<key>CFBundleIconFile</key>
|
||||
<string>AppIcon</string>
|
||||
<key>CFBundleIdentifier</key>
|
||||
<string>ai.flowmaster.shotdeck</string>
|
||||
<key>CFBundleName</key>
|
||||
<string>Redline</string>
|
||||
<key>CFBundlePackageType</key>
|
||||
<string>APPL</string>
|
||||
<key>CFBundleShortVersionString</key>
|
||||
<string>99.0.0</string>
|
||||
<key>CFBundleVersion</key>
|
||||
<string>5</string>
|
||||
<key>LSMinimumSystemVersion</key>
|
||||
<string>14.0</string>
|
||||
<key>LSUIElement</key>
|
||||
<true/>
|
||||
<key>NSHumanReadableCopyright</key>
|
||||
<string>Copyright © 2026 Flowmaster FZC LLC. All rights reserved.</string>
|
||||
</dict>
|
||||
</plist>
|
||||
BIN
Binary file not shown.
Binary file not shown.
@@ -0,0 +1,128 @@
|
||||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
|
||||
<plist version="1.0">
|
||||
<dict>
|
||||
<key>files</key>
|
||||
<dict>
|
||||
<key>Resources/AppIcon.icns</key>
|
||||
<data>
|
||||
WH6vz/PQ1NXa7ko7QlCGPEtVLxU=
|
||||
</data>
|
||||
</dict>
|
||||
<key>files2</key>
|
||||
<dict>
|
||||
<key>Resources/AppIcon.icns</key>
|
||||
<dict>
|
||||
<key>hash2</key>
|
||||
<data>
|
||||
LEP/PkABbPR3LYbMANoGI9OErrWNA+KhCulMlhTloaI=
|
||||
</data>
|
||||
</dict>
|
||||
</dict>
|
||||
<key>rules</key>
|
||||
<dict>
|
||||
<key>^Resources/</key>
|
||||
<true/>
|
||||
<key>^Resources/.*\.lproj/</key>
|
||||
<dict>
|
||||
<key>optional</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>1000</real>
|
||||
</dict>
|
||||
<key>^Resources/.*\.lproj/locversion.plist$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>1100</real>
|
||||
</dict>
|
||||
<key>^Resources/Base\.lproj/</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>1010</real>
|
||||
</dict>
|
||||
<key>^version.plist$</key>
|
||||
<true/>
|
||||
</dict>
|
||||
<key>rules2</key>
|
||||
<dict>
|
||||
<key>.*\.dSYM($|/)</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>11</real>
|
||||
</dict>
|
||||
<key>^(.*/)?\.DS_Store$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>2000</real>
|
||||
</dict>
|
||||
<key>^(Frameworks|SharedFrameworks|PlugIns|Plug-ins|XPCServices|Helpers|MacOS|Library/(Automator|Spotlight|LoginItems))/</key>
|
||||
<dict>
|
||||
<key>nested</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>10</real>
|
||||
</dict>
|
||||
<key>^.*</key>
|
||||
<true/>
|
||||
<key>^Info\.plist$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
<key>^PkgInfo$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
<key>^Resources/</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
<key>^Resources/.*\.lproj/</key>
|
||||
<dict>
|
||||
<key>optional</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>1000</real>
|
||||
</dict>
|
||||
<key>^Resources/.*\.lproj/locversion.plist$</key>
|
||||
<dict>
|
||||
<key>omit</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>1100</real>
|
||||
</dict>
|
||||
<key>^Resources/Base\.lproj/</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>1010</real>
|
||||
</dict>
|
||||
<key>^[^/]+$</key>
|
||||
<dict>
|
||||
<key>nested</key>
|
||||
<true/>
|
||||
<key>weight</key>
|
||||
<real>10</real>
|
||||
</dict>
|
||||
<key>^embedded\.provisionprofile$</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
<key>^version\.plist$</key>
|
||||
<dict>
|
||||
<key>weight</key>
|
||||
<real>20</real>
|
||||
</dict>
|
||||
</dict>
|
||||
</dict>
|
||||
</plist>
|
||||
+2
-2
@@ -13,9 +13,9 @@
|
||||
<key>CFBundlePackageType</key>
|
||||
<string>APPL</string>
|
||||
<key>CFBundleShortVersionString</key>
|
||||
<string>0.3.0</string>
|
||||
<string>0.5.0</string>
|
||||
<key>CFBundleVersion</key>
|
||||
<string>3</string>
|
||||
<string>7</string>
|
||||
<key>LSMinimumSystemVersion</key>
|
||||
<string>14.0</string>
|
||||
<key>LSUIElement</key>
|
||||
|
||||
@@ -27,5 +27,14 @@ let package = Package(
|
||||
dependencies: ["ShotdeckCore"],
|
||||
swiftSettings: [.swiftLanguageMode(.v6)]
|
||||
),
|
||||
// Exercises the real Shotdeck-app-target wiring (AppDelegate.makeLaunchModel(),
|
||||
// AppModel.bootstrap()) via @testable import — logic ShotdeckCoreTests cannot
|
||||
// reach because it only depends on ShotdeckCore, not the Shotdeck executable
|
||||
// target itself. See ReturnWatcherLaunchWiringTests.swift.
|
||||
.testTarget(
|
||||
name: "ShotdeckTests",
|
||||
dependencies: ["Shotdeck", "ShotdeckCore"],
|
||||
swiftSettings: [.swiftLanguageMode(.v6)]
|
||||
),
|
||||
]
|
||||
)
|
||||
|
||||
@@ -7,6 +7,52 @@ A macOS menu-bar app that captures a remembered screen region, builds a one-scre
|
||||
- **⌥⇧1** — pick a new region, then capture it.
|
||||
- **⌥⇧2** — capture the remembered region instantly (no picker).
|
||||
|
||||
## Where things live
|
||||
|
||||
Two surfaces, two jobs:
|
||||
|
||||
- **Menu-bar popover** — only the current session: its review details on one line, its
|
||||
pages, then Capture, Send, New Session, Open Redline, and one status line when
|
||||
something happened. Nothing else, so it never scrolls.
|
||||
- **Redline window** (Open Redline) — the workspace: every session in a sidebar grouped
|
||||
by day, the selected session's pages in the middle, and its review details, PDF facts
|
||||
and session facts in the inspector. History, text entry and file facts live here
|
||||
because they need room and a window that stays open.
|
||||
- **Settings** (⌘, in the popover's … menu) — capture, sending, and the session age limit.
|
||||
|
||||
## Sessions
|
||||
|
||||
Every review is a session. Captures go into the open session; "New Session" closes it
|
||||
and keeps it in the sidebar, named and dated, whether or not it was sent.
|
||||
|
||||
- **Nothing is deleted by default.** A session is kept until you delete it.
|
||||
- **Settings > Sessions > Delete after** sets an age limit (7 days … 1 year). Sessions
|
||||
older than the limit are removed on the next launch and by **Clean up now**.
|
||||
Only Redline's own saved screenshots are removed; a PDF that was already sent stays
|
||||
in the folder it was sent to.
|
||||
- **Review details** (inspector) record what is being reviewed: lane/environment, the
|
||||
deployed build, the commit, the reviewer (pre-filled with this Mac's user) and a free
|
||||
note. A new session inherits the previous session's details, and past sessions show
|
||||
them read-only.
|
||||
|
||||
## Files and PDF metadata
|
||||
|
||||
The PDF is named
|
||||
|
||||
```
|
||||
Redline-<yyyyMMdd-HHmm>-<LANE>-<SHORTID>.pdf (lane recorded)
|
||||
Redline-<yyyyMMdd-HHmm>-<SHORTID>.pdf (no lane)
|
||||
```
|
||||
|
||||
`yyyyMMdd-HHmm` is Dubai time, `LANE` is the upper-cased lane ("OMS test lane" →
|
||||
`OMS-TEST-LANE`), and `SHORTID` is the session's 8-character id, so two sessions in the
|
||||
same minute never collide.
|
||||
|
||||
Each page carries a two-line reference footer (tool + build time + session; lane,
|
||||
deployed build, commit, reviewer, note), and the PDF's document info carries the same
|
||||
values as Author and Keywords — a page printed or returned weeks later still says what
|
||||
it referred to.
|
||||
|
||||
## Screen Recording permission
|
||||
|
||||
On first launch macOS asks once for Screen Recording. Grant it at **System Settings > Privacy & Security > Screen Recording**. You never have to do this again as long as the app is not re-signed with a different identity.
|
||||
@@ -20,3 +66,13 @@ swift build && swift test
|
||||
./scripts/build-app.sh # signed .app for daily use
|
||||
open .build/Redline.app
|
||||
```
|
||||
|
||||
## Verification scripts
|
||||
|
||||
```bash
|
||||
./scripts/render-panels.sh /tmp/redline-panels # headless PNGs of every panel + a sample PDF
|
||||
./scripts/run-selftest.sh panel # real panel, real spool, PDF + retention checks
|
||||
```
|
||||
|
||||
Both run against isolated temporary storage and an isolated preference suite, so they
|
||||
never touch the real Application Support folder or your saved settings.
|
||||
|
||||
+497
-17
@@ -14,6 +14,11 @@ public protocol SettingsWindowPresenting: AnyObject {
|
||||
func presentSettingsWindow()
|
||||
}
|
||||
|
||||
@MainActor
|
||||
public protocol SessionsWindowPresenting: AnyObject {
|
||||
func presentSessionsWindow(focusLane: Bool)
|
||||
}
|
||||
|
||||
@MainActor
|
||||
public protocol ReturnsSectionProviding: AnyObject {
|
||||
@ViewBuilder func returnsSection() -> AnyView
|
||||
@@ -27,11 +32,38 @@ public final class AppModel {
|
||||
public private(set) var screenRecordingGranted: Bool
|
||||
public private(set) var allReturns: [ReturnedDocument] = []
|
||||
public private(set) var commentedReturns: [ReturnedDocument] = []
|
||||
/// Retained past sessions (newest first) — what the sessions window lists.
|
||||
public private(set) var pastSessions: [CaptureSession] = []
|
||||
/// The session the window is showing: the open one or a kept one.
|
||||
public private(set) var selectedSessionID: UUID?
|
||||
/// Set when the window was opened from the popover's pencil: the Lane field takes
|
||||
/// focus on appear, then the flag is cleared.
|
||||
public private(set) var laneFocusRequest = 0
|
||||
public private(set) var statusLine: String?
|
||||
public private(set) var updateStatus: String?
|
||||
/// The user's age limit for kept sessions (Settings > Sessions). `.never` until
|
||||
/// the user chooses otherwise, so every session is saved by default.
|
||||
public private(set) var retention: SessionRetention = .never
|
||||
/// How many archived sessions the current age limit would delete right now.
|
||||
/// Recomputed on launch, on a policy change and after every cleanup.
|
||||
public private(set) var expiredSessionCount: Int = 0
|
||||
public private(set) var isCapturing: Bool = false
|
||||
public private(set) var isSending: Bool = false
|
||||
/// True while "Start new session" is between its guard and its store call — the
|
||||
/// synchronous flag both this action and send() check BEFORE their first await, so
|
||||
/// the two can never interleave a session close with an in-flight compose (a
|
||||
/// SwiftUI `.disabled` render-time guard alone does not stop a queued Task).
|
||||
public private(set) var isStartingNewSession: Bool = false
|
||||
public private(set) var outboxDisplayName: String
|
||||
public private(set) var watchFolderDisplayName: String
|
||||
/// Live transport choice; WP-onedrive reads this to pick the send path and to drive
|
||||
/// the Settings "Send via" picker and the menu's "Send…" label.
|
||||
public private(set) var transport: SendTransport
|
||||
/// Ground truth for the Settings OneDrive row: nil means "no OneDrive folder found".
|
||||
/// Views read this instead of calling `OneDriveLocator.resolveOneDriveFolder()`
|
||||
/// directly, so state (and testing with a fake home) flows through the model like
|
||||
/// everything else — never a View reaching past the model for real UserDefaults/home.
|
||||
public private(set) var resolvedOneDriveFolder: URL?
|
||||
/// Live outbox; WP-4b reads this (not `paths.outbox`) so Settings folder changes take effect.
|
||||
public private(set) var outboxURL: URL
|
||||
/// Live watch folder; WP-4c updates this alongside `ReturnWatcher.updateWatchFolder`.
|
||||
@@ -55,6 +87,9 @@ public final class AppModel {
|
||||
let ledger: ReturnLedger
|
||||
let watcher: ReturnWatcher
|
||||
let updateChecker: UpdateChecker
|
||||
/// Where the session age limit is persisted. Production is `.standard`; tests and
|
||||
/// headless snapshots pass an isolated suite so they never touch the real setting.
|
||||
let retentionDefaults: UserDefaults
|
||||
|
||||
public init(
|
||||
paths: AppSupportPaths,
|
||||
@@ -64,8 +99,10 @@ public final class AppModel {
|
||||
hotkeys: HotkeyCenter,
|
||||
picker: RegionPickerController,
|
||||
ledger: ReturnLedger,
|
||||
watcher: ReturnWatcher
|
||||
watcher: ReturnWatcher,
|
||||
retentionDefaults: UserDefaults = .standard
|
||||
) {
|
||||
self.retentionDefaults = retentionDefaults
|
||||
self.paths = paths
|
||||
self.spool = spool
|
||||
self.composer = composer
|
||||
@@ -83,20 +120,22 @@ public final class AppModel {
|
||||
)
|
||||
self.region = Self.loadPersistedRegion()
|
||||
self.screenRecordingGranted = ScreenCapturer.isScreenRecordingGranted
|
||||
// Seeded from FolderSettings.resolve() via resolvedAppSupportPaths — never .standard().
|
||||
let folders = FolderSettings.resolve()
|
||||
// Seeded from TransportSettings.effectiveFolders() — the one place that combines
|
||||
// the transport choice with FolderSettings/OneDriveLocator. Never call
|
||||
// FolderSettings.resolve() directly outside that function.
|
||||
let folders = TransportSettings.effectiveFolders()
|
||||
self.outboxURL = folders.outbox
|
||||
self.watchFolderURL = folders.watch
|
||||
self.outboxDisplayName = folders.outbox.lastPathComponent
|
||||
self.watchFolderDisplayName = folders.watch.lastPathComponent
|
||||
self.transport = folders.transport
|
||||
self.resolvedOneDriveFolder = OneDriveLocator.resolveOneDriveFolder()
|
||||
self.captureHotkey = HotkeyPreference.load()
|
||||
self.updateChecker = UpdateChecker()
|
||||
self.updateChecker.onChecked = { [weak self] in
|
||||
guard let self else { return }
|
||||
self.updateAvailable = self.updateChecker.availableUpdate
|
||||
if let message = self.updateChecker.statusMessage {
|
||||
self.setStatus(message)
|
||||
}
|
||||
self.setUpdateStatus(self.updateChecker.statusMessage)
|
||||
}
|
||||
self.updateChecker.onCheckingChanged = { [weak self] checking in
|
||||
self?.isCheckingForUpdates = checking
|
||||
@@ -107,14 +146,17 @@ public final class AppModel {
|
||||
public var appVersion: String { UpdateChecker.currentVersion() }
|
||||
/// Version recorded in the app-managed rollback copy, when one exists.
|
||||
public var previousVersion: String? { updateChecker.previousVersion() }
|
||||
/// Most recent status text — shared with the general status line by design
|
||||
/// (Redline has one status channel, not a separate update-only one).
|
||||
public var updateStatusMessage: String? { statusLine }
|
||||
/// Update-related status text (checked time, staged update, errors). Displayed only in the footer.
|
||||
public var updateStatusMessage: String? { updateStatus }
|
||||
|
||||
// MARK: Seam mutators — the only way a WP-4b/4c extension changes state.
|
||||
|
||||
func setStatus(_ text: String?) { statusLine = text }
|
||||
func setUpdateStatus(_ text: String?) { updateStatus = text }
|
||||
func setSending(_ value: Bool) { isSending = value }
|
||||
/// Fixture seam (same family as setSending): lets tests/PanelSnapshot stage the
|
||||
/// in-flight-start state that production only ever reaches inside startNewSession().
|
||||
func setStartingNewSession(_ value: Bool) { isStartingNewSession = value }
|
||||
func setCapturing(_ value: Bool) { isCapturing = value }
|
||||
func replaceSession(_ new: CaptureSession) { session = new }
|
||||
func replaceRegion(_ new: CaptureRegion?) { region = new }
|
||||
@@ -122,6 +164,14 @@ public final class AppModel {
|
||||
allReturns = all
|
||||
commentedReturns = commented
|
||||
}
|
||||
func setPastSessions(_ value: [CaptureSession]) {
|
||||
pastSessions = value
|
||||
if selectedSessionID == nil {
|
||||
selectedSessionID = session.id
|
||||
}
|
||||
}
|
||||
func setSelectedSessionID(_ value: UUID?) { selectedSessionID = value }
|
||||
func requestLaneFocus() { laneFocusRequest += 1 }
|
||||
func setFolderDisplayNames(outbox: String, watch: String) {
|
||||
outboxDisplayName = outbox
|
||||
watchFolderDisplayName = watch
|
||||
@@ -131,12 +181,286 @@ public final class AppModel {
|
||||
watchFolderURL = watch
|
||||
setFolderDisplayNames(outbox: outbox.lastPathComponent, watch: watch.lastPathComponent)
|
||||
}
|
||||
func setTransport(_ value: SendTransport) { transport = value }
|
||||
func setResolvedOneDriveFolder(_ value: URL?) { resolvedOneDriveFolder = value }
|
||||
|
||||
/// Bumped by chooseTransport/chooseOneDriveFolder (SettingsView.swift) before each
|
||||
/// spawns its async watcher-reconcile Task; that Task checks its own snapshot
|
||||
/// against the live value before every mutating step, so rapid toggling always
|
||||
/// lets the LAST choice win instead of applying stale, superseded work. Not
|
||||
/// `@Observable`-relevant state — pure internal bookkeeping, never read by a View.
|
||||
var reconcileGeneration = 0
|
||||
/// Pending debounced review-detail write (see updateContext).
|
||||
private var pendingContextWrite: Task<Void, Never>?
|
||||
|
||||
/// The MOST RECENT watcher-reconcile Task spawned by chooseTransport/
|
||||
/// chooseOneDriveFolder, if one is still (or was just) in flight. send() awaits
|
||||
/// this BEFORE snapshotting transport/folder, so a toggle immediately followed by
|
||||
/// Send can never race ahead of the reconcile it depends on (the watcher's
|
||||
/// recordUncommented flag briefly lagging the just-chosen transport, for example).
|
||||
/// `Task<Void, Never>` never throws; awaiting an already-completed task's `.value`
|
||||
/// returns immediately. Not `@Observable`-relevant — pure internal bookkeeping.
|
||||
var pendingReconcileTask: Task<Void, Never>?
|
||||
func rememberLastComposedPDF(_ url: URL) { lastComposedPDFURL = url }
|
||||
|
||||
/// True when a last-composed PDF path is known this run, or the newest
|
||||
/// `Redline-*.pdf` in the outbox exists on disk.
|
||||
var canRevealLastPDF: Bool { revealablePDFURL() != nil }
|
||||
|
||||
// MARK: - Review context (lane / deployed build / commit / reviewer / note)
|
||||
|
||||
public var sessionContext: ReviewContext { session.context }
|
||||
|
||||
/// "DEV03-4F2A9C1D" — the readable handle for the open session.
|
||||
public var sessionLabel: String {
|
||||
PDFFileName.sessionLabel(lane: session.context.lane, sessionID: session.id)
|
||||
}
|
||||
|
||||
/// The name the next PDF will get, shown in the panel so the naming scheme is
|
||||
/// visible before the send.
|
||||
public var nextPDFFileNameHint: String {
|
||||
PDFFileName.make(builtAt: Date(), lane: session.context.lane, sessionID: session.id)
|
||||
}
|
||||
|
||||
/// Persists one context field change. Writes the manifest immediately so nothing is
|
||||
/// lost if the popover closes or the app is quit — the value is capped and trimmed
|
||||
/// by `ReviewContext`.
|
||||
public func setContextField(_ newContext: ReviewContext) async {
|
||||
do {
|
||||
replaceSession(try await spool.setContext(newContext))
|
||||
} catch {
|
||||
setStatus((error as? ShotdeckError)?.errorDescription ?? "Could not save the review details.")
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - Session browsing (the sessions window)
|
||||
|
||||
/// What a session row says about itself in the list.
|
||||
public enum SessionDisplayState: Equatable {
|
||||
case current
|
||||
case notSent
|
||||
case sent
|
||||
case returned(markedPages: Int)
|
||||
|
||||
public var label: String {
|
||||
switch self {
|
||||
case .current: return "not sent"
|
||||
case .notSent: return "not sent"
|
||||
case .sent: return "sent"
|
||||
case .returned(let pages):
|
||||
return pages == 1 ? "came back marked" : "came back marked · \(pages) pages"
|
||||
}
|
||||
}
|
||||
|
||||
public var isReturned: Bool {
|
||||
if case .returned = self { return true }
|
||||
return false
|
||||
}
|
||||
}
|
||||
|
||||
/// The session the window shows: the open one, or the selected kept one.
|
||||
public var selectedSession: CaptureSession? {
|
||||
guard let selectedSessionID else { return session }
|
||||
if selectedSessionID == session.id { return session }
|
||||
return pastSessions.first { $0.id == selectedSessionID } ?? session
|
||||
}
|
||||
|
||||
public var selectedIsCurrent: Bool {
|
||||
selectedSession?.id == session.id
|
||||
}
|
||||
|
||||
public func selectSession(_ id: UUID?) {
|
||||
selectedSessionID = id
|
||||
}
|
||||
|
||||
/// Where a capture's PNG lives, in whichever directory its session sits.
|
||||
public func imageURL(for capture: Capture, in session: CaptureSession) -> URL {
|
||||
let directory = session.state == .open
|
||||
? paths.sessionDirectory(session.id)
|
||||
: paths.archiveDirectory(session.id)
|
||||
return directory.appendingPathComponent(capture.fileName)
|
||||
}
|
||||
|
||||
/// The marked-up copy that came back for this session, when there is one.
|
||||
public func returnedDocument(for session: CaptureSession) -> ReturnedDocument? {
|
||||
guard let fileName = session.pdfFileName else { return nil }
|
||||
return allReturns.first { $0.fileURL.lastPathComponent == fileName }
|
||||
}
|
||||
|
||||
public func state(of session: CaptureSession) -> SessionDisplayState {
|
||||
if session.id == self.session.id, session.state == .open {
|
||||
return .current
|
||||
}
|
||||
if let document = returnedDocument(for: session), document.isCommented {
|
||||
return .returned(markedPages: document.annotatedPages.count)
|
||||
}
|
||||
return session.pdfFileName == nil ? .notSent : .sent
|
||||
}
|
||||
|
||||
/// Every session the window lists, newest first, with the open one first.
|
||||
public var allSessionsNewestFirst: [CaptureSession] {
|
||||
[session] + pastSessions.filter { $0.id != session.id }
|
||||
}
|
||||
|
||||
/// Text match over the fields a person would search by.
|
||||
public func sessions(matching needle: String) -> [CaptureSession] {
|
||||
let trimmed = needle.trimmingCharacters(in: .whitespaces).lowercased()
|
||||
guard !trimmed.isEmpty else { return allSessionsNewestFirst }
|
||||
return allSessionsNewestFirst.filter { candidate in
|
||||
let haystack = [
|
||||
candidate.context.lane,
|
||||
candidate.context.deployedVersion,
|
||||
candidate.context.commit,
|
||||
candidate.context.reviewer,
|
||||
candidate.context.note,
|
||||
candidate.pdfFileName ?? "",
|
||||
candidate.shortID,
|
||||
DubaiTime.stamp(candidate.createdAt),
|
||||
].joined(separator: " ").lowercased()
|
||||
return haystack.contains(trimmed)
|
||||
}
|
||||
}
|
||||
|
||||
/// One sidebar section: a day bucket or a month bucket.
|
||||
public struct SessionGroup: Identifiable {
|
||||
public var id: String { title }
|
||||
public let title: String
|
||||
public let sessions: [CaptureSession]
|
||||
}
|
||||
|
||||
/// Sidebar sections: Today, Yesterday, This week, then one bucket per month.
|
||||
/// Empty sections are dropped so the list never shows a heading with nothing under it.
|
||||
public func groupedSections(for sessions: [CaptureSession]) -> [SessionGroup] {
|
||||
guard let dubai = TimeZone(identifier: "Asia/Dubai") else {
|
||||
return [SessionGroup(title: "Sessions", sessions: sessions)]
|
||||
}
|
||||
var calendar = Calendar(identifier: .gregorian)
|
||||
calendar.timeZone = dubai
|
||||
let now = Date()
|
||||
let startOfToday = calendar.startOfDay(for: now)
|
||||
let startOfYesterday = calendar.date(byAdding: .day, value: -1, to: startOfToday) ?? startOfToday
|
||||
let startOfWeek = calendar.date(byAdding: .day, value: -7, to: startOfToday) ?? startOfToday
|
||||
let monthFormatter = DateFormatter()
|
||||
monthFormatter.calendar = calendar
|
||||
monthFormatter.timeZone = dubai
|
||||
monthFormatter.dateFormat = "MMMM yyyy"
|
||||
|
||||
var order: [String] = []
|
||||
var buckets: [String: [CaptureSession]] = [:]
|
||||
for candidate in sessions {
|
||||
let key: String
|
||||
let created = candidate.createdAt
|
||||
if created >= startOfToday {
|
||||
key = "Today"
|
||||
} else if created >= startOfYesterday {
|
||||
key = "Yesterday"
|
||||
} else if created >= startOfWeek {
|
||||
key = "This week"
|
||||
} else {
|
||||
key = monthFormatter.string(from: created)
|
||||
}
|
||||
if buckets[key] == nil {
|
||||
buckets[key] = []
|
||||
order.append(key)
|
||||
}
|
||||
buckets[key]?.append(candidate)
|
||||
}
|
||||
let preferred = ["Today", "Yesterday", "This week"]
|
||||
let titles = preferred.filter { buckets[$0] != nil } + order.filter { !preferred.contains($0) }
|
||||
return titles.map { SessionGroup(title: $0, sessions: buckets[$0] ?? []) }
|
||||
}
|
||||
|
||||
/// Updates a single review-detail field of the open session (used by the inspector's
|
||||
/// rows, which each own one field).
|
||||
public func updateContext(_ field: WritableKeyPath<ReviewContext, String>, _ value: String) {
|
||||
var context = session.context
|
||||
context[keyPath: field] = value
|
||||
guard context != session.context else { return }
|
||||
pendingContextWrite?.cancel()
|
||||
pendingContextWrite = Task { [weak self] in
|
||||
try? await Task.sleep(for: .milliseconds(180))
|
||||
guard !Task.isCancelled, let self else { return }
|
||||
await self.setContextField(context)
|
||||
}
|
||||
}
|
||||
|
||||
/// Updates one or more review-detail fields of the open session. Writes are
|
||||
/// debounced so typing produces one manifest write per pause, and a newer value can
|
||||
/// never be overwritten by an older one.
|
||||
public func updateContext(
|
||||
lane: String? = nil,
|
||||
deployedVersion: String? = nil,
|
||||
commit: String? = nil,
|
||||
reviewer: String? = nil,
|
||||
note: String? = nil
|
||||
) {
|
||||
let current = session.context
|
||||
let next = ReviewContext(
|
||||
lane: lane ?? current.lane,
|
||||
deployedVersion: deployedVersion ?? current.deployedVersion,
|
||||
commit: commit ?? current.commit,
|
||||
reviewer: reviewer ?? current.reviewer,
|
||||
note: note ?? current.note
|
||||
)
|
||||
guard next != current else { return }
|
||||
pendingContextWrite?.cancel()
|
||||
pendingContextWrite = Task { [weak self] in
|
||||
try? await Task.sleep(for: .milliseconds(180))
|
||||
guard !Task.isCancelled, let self else { return }
|
||||
await self.setContextField(next)
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - Session retention
|
||||
|
||||
/// The sentence the panel footer and Settings show for the current policy.
|
||||
public var retentionSummary: String { retention.policyDescription }
|
||||
|
||||
/// Changes the age limit and persists it. Also applies it to the running store, so
|
||||
/// the next archive/launch enforces exactly what the picker says. Nothing is
|
||||
/// deleted here — deleting is an explicit "Clean up now".
|
||||
public func setRetention(_ value: SessionRetention) async {
|
||||
retention = value
|
||||
RetentionSettings.save(value, defaults: retentionDefaults)
|
||||
await spool.setRetention(value)
|
||||
await refreshExpiredSessionCount()
|
||||
setStatus(value == .never ? "Sessions are kept until you delete them." : value.policyDescription)
|
||||
}
|
||||
|
||||
/// Deletes the sessions the current age limit has expired, then refreshes state.
|
||||
/// Reports the exact number; nothing is deleted under `.never`.
|
||||
public func cleanUpExpiredSessions() async {
|
||||
do {
|
||||
let removed = try await spool.pruneExpiredSessions()
|
||||
let message: String
|
||||
if removed.isEmpty {
|
||||
message = retention == .never
|
||||
? "Nothing to remove — sessions are kept until you delete them."
|
||||
: "Nothing to remove — no session is older than \(retention.displayName)."
|
||||
} else {
|
||||
message = "Removed \(removed.count) past session\(removed.count == 1 ? "" : "s"). Sent PDFs were not touched."
|
||||
}
|
||||
if let refreshProblem = await reloadFromSpool() {
|
||||
setStatus("\(message) \(refreshProblem)")
|
||||
} else {
|
||||
setStatus(message)
|
||||
}
|
||||
await refreshExpiredSessionCount()
|
||||
} catch {
|
||||
setStatus((error as? ShotdeckError)?.errorDescription ?? "Could not remove expired sessions.")
|
||||
}
|
||||
}
|
||||
|
||||
/// Counts what the current policy would delete. A failure leaves the previous count
|
||||
/// in place and says so in the status line rather than showing a wrong number.
|
||||
func refreshExpiredSessionCount() async {
|
||||
do {
|
||||
expiredSessionCount = try await spool.expiredSessionIDs().count
|
||||
} catch {
|
||||
setStatus((error as? ShotdeckError)?.errorDescription ?? "Could not read the expired sessions.")
|
||||
}
|
||||
}
|
||||
|
||||
public func revealLastPDF() {
|
||||
guard let url = revealablePDFURL() else { return }
|
||||
NSWorkspace.shared.activateFileViewerSelecting([url])
|
||||
@@ -177,6 +501,9 @@ public final class AppModel {
|
||||
}
|
||||
|
||||
public func bootstrap() async {
|
||||
retention = RetentionSettings.load(defaults: retentionDefaults)
|
||||
await spool.setRetention(retention)
|
||||
|
||||
if let data = UserDefaults.standard.data(forKey: CaptureRegion.defaultsKey),
|
||||
let decoded = try? JSONDecoder().decode(CaptureRegion.self, from: data),
|
||||
decoded.isStillValid {
|
||||
@@ -198,7 +525,47 @@ public final class AppModel {
|
||||
// Empty ledger on first run is not an error.
|
||||
}
|
||||
|
||||
// An age limit chosen in Settings is enforced on every launch. Under `.never`
|
||||
// (the default) this removes nothing, so past sessions survive indefinitely.
|
||||
do {
|
||||
let removed = try await spool.pruneExpiredSessions()
|
||||
if !removed.isEmpty {
|
||||
setStatus("Removed \(removed.count) past session\(removed.count == 1 ? "" : "s") older than \(retention.displayName).")
|
||||
}
|
||||
} catch {
|
||||
setStatus((error as? ShotdeckError)?.errorDescription ?? "Could not remove expired sessions.")
|
||||
}
|
||||
|
||||
do {
|
||||
setPastSessions(try await spool.archivedSessions())
|
||||
} catch {
|
||||
setStatus((error as? ShotdeckError)?.errorDescription ?? "Could not load past sessions.")
|
||||
}
|
||||
await refreshExpiredSessionCount()
|
||||
|
||||
// OneDrive mode: outbox == watch folder, so a freshly written, unmarked PDF must
|
||||
// never show up as a return; only a document that already carries a mark does.
|
||||
// Also make sure the resolved OneDrive folder actually exists before the
|
||||
// watcher starts watching it (bootstrap is the other creation trigger besides
|
||||
// chooseTransport/chooseOneDriveFolder — see TransportSettings.effectiveFolders).
|
||||
if transport == .oneDrive {
|
||||
try? FileManager.default.createDirectory(at: outboxURL, withIntermediateDirectories: true)
|
||||
}
|
||||
setResolvedOneDriveFolder(OneDriveLocator.resolveOneDriveFolder())
|
||||
await watcher.setRecordUncommented(transport == .airDrop)
|
||||
|
||||
do {
|
||||
// BLOCKER fix: reconcile the watcher's internal watchFolder with the live
|
||||
// watchFolderURL UNCONDITIONALLY, before it ever starts. `paths` (and so the
|
||||
// watcher's initial folder, set in its own init) now comes from the same
|
||||
// transport-aware TransportSettings.effectiveFolders() as watchFolderURL, so
|
||||
// in the normal case this is a no-op — but it is the only thing that would
|
||||
// have caught the old bug (launch paths built AirDrop-only while OneDrive was
|
||||
// the persisted transport, leaving the watcher's FSEvents stream pointed at a
|
||||
// stale folder for the whole session) and it stays cheap insurance against
|
||||
// that class of drift ever recurring. Calling it before start() only updates
|
||||
// the stored folder — no FSEvents stream exists yet to restart.
|
||||
try await watcher.updateWatchFolder(watchFolderURL)
|
||||
try await watcher.start { [weak self] _ in
|
||||
Task { @MainActor in
|
||||
guard let self else { return }
|
||||
@@ -211,17 +578,29 @@ public final class AppModel {
|
||||
setStatus((error as? ShotdeckError)?.errorDescription ?? "Could not watch the return folder.")
|
||||
}
|
||||
|
||||
let pref = HotkeyPreference.load()
|
||||
captureHotkey = pref
|
||||
if !bindCaptureHotkey(pref) {
|
||||
setStatus("\(pref.displayString) is already used by another app — capture only works from the menu.")
|
||||
}
|
||||
|
||||
let skipSchedule =
|
||||
// Env-var-flagged self-test/headless runs (PickerSelfTest's phases, PanelSnapshot,
|
||||
// and the new ShotdeckTests launch-wiring regression test) skip two real-world
|
||||
// side effects that are unsafe or meaningless in that context: the update-check
|
||||
// schedule (a real network call), and binding the REAL, process-wide Carbon
|
||||
// global hotkey — which is not safe to exercise in an automated/parallel test
|
||||
// process (it can collide with ShotdeckCoreTests' own HotkeyCenterCarbonTests
|
||||
// running in the same test binary) and was never meaningfully exercised by any
|
||||
// self-test anyway. A real user launch never sets these env vars, so production
|
||||
// behavior is unchanged.
|
||||
let isSelfTestRun =
|
||||
ProcessInfo.processInfo.environment["SHOTDECK_PICKER_SELFTEST"] != nil
|
||||
|| ProcessInfo.processInfo.environment["SHOTDECK_SNAPSHOT_DIR"] != nil
|
||||
|| ProcessInfo.processInfo.environment["SHOTDECK_UPDATE_SELFTEST"] != nil
|
||||
if !skipSchedule {
|
||||
|| ProcessInfo.processInfo.environment["SHOTDECK_ONEDRIVE_SELFTEST"] != nil
|
||||
|| ProcessInfo.processInfo.environment["REDLINE_SELFTEST_PHASE"] != nil
|
||||
|
||||
let pref = HotkeyPreference.load()
|
||||
captureHotkey = pref
|
||||
if !isSelfTestRun, !bindCaptureHotkey(pref) {
|
||||
setStatus("\(pref.displayString) is already used by another app — capture only works from the menu.")
|
||||
}
|
||||
|
||||
if !isSelfTestRun {
|
||||
updateChecker.startSchedule()
|
||||
}
|
||||
}
|
||||
@@ -326,6 +705,107 @@ public final class AppModel {
|
||||
}
|
||||
}
|
||||
|
||||
/// True when "Start new session" applies: there is something to keep and neither a
|
||||
/// send nor another session start is in flight.
|
||||
public var canStartNewSession: Bool {
|
||||
!session.isEmpty && !isSending && !isStartingNewSession
|
||||
}
|
||||
|
||||
/// Menu "Start new session": keeps the current screenshots as a past session
|
||||
/// (moved into the single archive folder — never deleted) and opens a fresh empty
|
||||
/// session. Session retention (newest 10 kept) is applied inside the store, on
|
||||
/// this path and on the send path alike.
|
||||
public func startNewSession() async {
|
||||
// Re-checked here on the main actor, synchronously, before the first await:
|
||||
// the menu's `.disabled` state cannot stop a Task that was queued just before
|
||||
// a send started.
|
||||
guard !isSending, !isStartingNewSession else {
|
||||
setStatus(isSending ? "Finish the current send first." : "A new session is already being started.")
|
||||
return
|
||||
}
|
||||
isStartingNewSession = true
|
||||
defer { isStartingNewSession = false }
|
||||
|
||||
var message: String
|
||||
do {
|
||||
if let archived = try await spool.closeCurrentSession() {
|
||||
let count = archived.captures.count
|
||||
message = "New session — \(count) capture\(count == 1 ? "" : "s") kept as a past session."
|
||||
} else {
|
||||
message = "New session started."
|
||||
}
|
||||
} catch {
|
||||
message = (error as? ShotdeckError)?.errorDescription ?? "Could not start a new session."
|
||||
}
|
||||
if let refreshProblem = await reloadFromSpool() {
|
||||
message += " \(refreshProblem)"
|
||||
}
|
||||
selectSession(session.id)
|
||||
setStatus(message)
|
||||
}
|
||||
|
||||
/// Re-reads the open session and the past-session list from the store. Returns a
|
||||
/// problem description when either read failed (the caller decides how to surface
|
||||
/// it), nil when everything was refreshed — never silently substitutes stale state.
|
||||
func reloadFromSpool() async -> String? {
|
||||
var problems: [String] = []
|
||||
do {
|
||||
replaceSession(try await spool.currentSession())
|
||||
} catch {
|
||||
problems.append(
|
||||
"Could not reload the current session: \((error as? ShotdeckError)?.errorDescription ?? error.localizedDescription)")
|
||||
}
|
||||
do {
|
||||
setPastSessions(try await spool.archivedSessions())
|
||||
} catch {
|
||||
problems.append(
|
||||
"Could not load past sessions: \((error as? ShotdeckError)?.errorDescription ?? error.localizedDescription)")
|
||||
}
|
||||
do {
|
||||
expiredSessionCount = try await spool.expiredSessionIDs().count
|
||||
} catch {
|
||||
problems.append(
|
||||
"Could not read the expired sessions: \((error as? ShotdeckError)?.errorDescription ?? error.localizedDescription)")
|
||||
}
|
||||
return problems.isEmpty ? nil : problems.joined(separator: " ")
|
||||
}
|
||||
|
||||
/// Where a past session's sent PDF lives now (the outbox in AirDrop mode, the
|
||||
/// OneDrive folder in OneDrive mode), or nil when it was never sent / is gone.
|
||||
public func sentPDFURL(for session: CaptureSession) -> URL? {
|
||||
guard let name = session.pdfFileName else { return nil }
|
||||
let url = outboxURL.appendingPathComponent(name)
|
||||
return FileManager.default.fileExists(atPath: url.path) ? url : nil
|
||||
}
|
||||
|
||||
/// "PDF" action on a past-submission row: reveals the exact PDF that was sent.
|
||||
public func revealSentPDF(_ session: CaptureSession) {
|
||||
guard session.pdfFileName != nil else {
|
||||
setStatus("That session was never sent.")
|
||||
return
|
||||
}
|
||||
guard let url = sentPDFURL(for: session) else {
|
||||
setStatus("The PDF is no longer in \(outboxDisplayName).")
|
||||
return
|
||||
}
|
||||
NSWorkspace.shared.activateFileViewerSelecting([url])
|
||||
}
|
||||
|
||||
/// "Captures" action on a past-submission row: reveals that session's folder.
|
||||
public func revealSessionCaptures(_ session: CaptureSession) {
|
||||
let dir = paths.archiveDirectory(session.id)
|
||||
guard FileManager.default.fileExists(atPath: dir.path) else {
|
||||
setStatus("That past session is no longer on disk.")
|
||||
return
|
||||
}
|
||||
NSWorkspace.shared.activateFileViewerSelecting([dir])
|
||||
}
|
||||
|
||||
/// The single folder every retained session lives in.
|
||||
public func openSessionsFolder() {
|
||||
NSWorkspace.shared.open(paths.archive)
|
||||
}
|
||||
|
||||
public func copyCommentedLinks() async {
|
||||
do {
|
||||
let text = try await ledger.clipboardText()
|
||||
|
||||
+250
-182
@@ -2,65 +2,125 @@ import AppKit
|
||||
import SwiftUI
|
||||
import ShotdeckCore
|
||||
|
||||
/// The menu-bar popover: the current session, and the two things you do with it.
|
||||
///
|
||||
/// Everything else — history, review details, PDF facts — lives in the Redline
|
||||
/// window, which stays open and has room for it.
|
||||
struct MenuBarView: View {
|
||||
@Environment(AppModel.self) private var model
|
||||
|
||||
var body: some View {
|
||||
VStack(alignment: .leading, spacing: 8) {
|
||||
statusRow
|
||||
SessionStrip()
|
||||
Divider()
|
||||
actionsList
|
||||
if !model.allReturns.isEmpty {
|
||||
if model.screenRecordingGranted {
|
||||
sessionHeader
|
||||
thumbnailRow
|
||||
statusRow
|
||||
actionRows
|
||||
Divider()
|
||||
returnsBlock
|
||||
footer
|
||||
} else {
|
||||
permissionBlock
|
||||
Divider()
|
||||
footer
|
||||
}
|
||||
Divider()
|
||||
updateFooter
|
||||
}
|
||||
.padding(10)
|
||||
.frame(width: 320, alignment: .leading)
|
||||
.frame(width: 340, alignment: .leading)
|
||||
.controlSize(.small)
|
||||
}
|
||||
|
||||
@ViewBuilder
|
||||
private var statusRow: some View {
|
||||
if !model.screenRecordingGranted {
|
||||
HStack(alignment: .top, spacing: 6) {
|
||||
Image(systemName: "exclamationmark.triangle")
|
||||
.foregroundStyle(.yellow)
|
||||
VStack(alignment: .leading, spacing: 4) {
|
||||
Text(
|
||||
ShotdeckError.screenRecordingNotGranted.errorDescription
|
||||
?? "Screen Recording is turned off."
|
||||
)
|
||||
.font(.caption)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
Button("Open Screen Recording settings") {
|
||||
model.openScreenRecordingSettings()
|
||||
// MARK: - Header
|
||||
|
||||
private var sessionHeader: some View {
|
||||
HStack(alignment: .top, spacing: 8) {
|
||||
VStack(alignment: .leading, spacing: 1) {
|
||||
HStack(spacing: 5) {
|
||||
Text(laneTitle)
|
||||
.font(.system(size: 13, weight: .semibold))
|
||||
.lineLimit(1)
|
||||
if let version = versionTitle {
|
||||
Text(version)
|
||||
.font(.system(size: 13))
|
||||
.foregroundStyle(.secondary)
|
||||
.lineLimit(1)
|
||||
}
|
||||
}
|
||||
Text(detailLine)
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.lineLimit(1)
|
||||
.truncationMode(.tail)
|
||||
.help(detailLine)
|
||||
}
|
||||
} else {
|
||||
Text(model.statusLine ?? defaultStatusText)
|
||||
.font(.caption)
|
||||
.foregroundStyle(.primary)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
Spacer(minLength: 4)
|
||||
if !model.session.isEmpty {
|
||||
Text("\(model.session.captures.count) page\(model.session.captures.count == 1 ? "" : "s")")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.monospacedDigit()
|
||||
.padding(.horizontal, 6)
|
||||
.padding(.vertical, 2)
|
||||
.background(.quaternary, in: Capsule())
|
||||
}
|
||||
Button {
|
||||
presentWindow(focusLane: true)
|
||||
} label: {
|
||||
Image(systemName: "square.and.pencil")
|
||||
.font(.system(size: 12, weight: .semibold))
|
||||
}
|
||||
.buttonStyle(.borderless)
|
||||
.help("Edit review details")
|
||||
.accessibilityLabel("Edit review details")
|
||||
}
|
||||
}
|
||||
|
||||
private var defaultStatusText: String {
|
||||
guard let region = model.region else {
|
||||
return "No region yet — press \(model.hotkeyDisplayString) to pick one."
|
||||
private var laneTitle: String {
|
||||
let lane = model.session.context.lane
|
||||
return lane.isEmpty ? "No lane" : lane
|
||||
}
|
||||
|
||||
private var versionTitle: String? {
|
||||
let version = model.session.context.deployedVersion
|
||||
return version.isEmpty ? nil : version
|
||||
}
|
||||
|
||||
private var detailLine: String {
|
||||
let context = model.session.context
|
||||
var parts: [String] = []
|
||||
if !context.commit.isEmpty { parts.append(context.commit) }
|
||||
if !context.reviewer.isEmpty { parts.append(context.reviewer) }
|
||||
let started = DubaiTime.checkTime(model.session.createdAt)
|
||||
if parts.isEmpty {
|
||||
return "No review details yet · started \(started)"
|
||||
}
|
||||
let w = Int(region.rect.width)
|
||||
let h = Int(region.rect.height)
|
||||
let display = displayName(for: region)
|
||||
return parts.joined(separator: " · ") + " · started \(started)"
|
||||
}
|
||||
|
||||
// MARK: - Body
|
||||
|
||||
@ViewBuilder
|
||||
private var thumbnailRow: some View {
|
||||
if model.session.isEmpty {
|
||||
return "Region \(w) × \(h) on \(display) · Nothing captured yet."
|
||||
VStack(spacing: 2) {
|
||||
Text("Nothing captured yet")
|
||||
.font(.callout)
|
||||
.foregroundStyle(.secondary)
|
||||
Text(emptyHint)
|
||||
.font(.caption)
|
||||
.foregroundStyle(.tertiary)
|
||||
}
|
||||
.frame(maxWidth: .infinity, minHeight: 62)
|
||||
.background(.quaternary.opacity(0.4), in: RoundedRectangle(cornerRadius: 6, style: .continuous))
|
||||
} else {
|
||||
SessionStrip(limit: 3)
|
||||
}
|
||||
let count = model.session.captures.count
|
||||
return "\(count) captures · region \(w) × \(h) on \(display)"
|
||||
}
|
||||
|
||||
private var emptyHint: String {
|
||||
guard let region = model.region else {
|
||||
return "\(model.hotkeyDisplayString) picks an area, then captures it"
|
||||
}
|
||||
return "\(model.hotkeyDisplayString) captures \(Int(region.rect.width)) × \(Int(region.rect.height)) on \(displayName(for: region))"
|
||||
}
|
||||
|
||||
private func displayName(for region: CaptureRegion) -> String {
|
||||
@@ -74,154 +134,162 @@ struct MenuBarView: View {
|
||||
return "Display 1"
|
||||
}
|
||||
|
||||
private var actionsList: some View {
|
||||
VStack(alignment: .leading, spacing: 2) {
|
||||
if let update = model.updateAvailable {
|
||||
Button {
|
||||
model.installUpdate()
|
||||
} label: {
|
||||
actionLabel("Update to \(update.version)")
|
||||
.foregroundStyle(Color.accentColor)
|
||||
}
|
||||
}
|
||||
|
||||
Button {
|
||||
model.checkForUpdates()
|
||||
} label: {
|
||||
actionLabel(model.isCheckingForUpdates ? "Checking…" : "Check for updates")
|
||||
}
|
||||
.disabled(model.isCheckingForUpdates)
|
||||
|
||||
if let previous = model.previousVersion {
|
||||
Button {
|
||||
model.revertToPreviousVersion()
|
||||
} label: {
|
||||
actionLabel("Revert to \(previous)")
|
||||
}
|
||||
}
|
||||
|
||||
Button {
|
||||
let anchor = NSApp.keyWindow?.contentView
|
||||
if let sender = model as? SendCapable {
|
||||
Task { await sender.send(anchor: anchor) }
|
||||
} else {
|
||||
model.setStatus("Send is not available in this build.")
|
||||
}
|
||||
} label: {
|
||||
actionLabel("Send…")
|
||||
}
|
||||
.disabled(model.session.isEmpty || model.isSending)
|
||||
|
||||
Button {
|
||||
model.revealLastPDF()
|
||||
} label: {
|
||||
actionLabel("Reveal last PDF")
|
||||
}
|
||||
.disabled(!model.canRevealLastPDF)
|
||||
|
||||
Button {
|
||||
Task { await model.captureNow() }
|
||||
} label: {
|
||||
actionLabel("Capture now", trailing: model.hotkeyDisplayString)
|
||||
}
|
||||
.disabled(model.isCapturing)
|
||||
|
||||
Button {
|
||||
Task { await model.rePickRegion() }
|
||||
} label: {
|
||||
actionLabel("Re-select area")
|
||||
}
|
||||
|
||||
Button {
|
||||
Task { await model.copyCommentedLinks() }
|
||||
} label: {
|
||||
actionLabel(
|
||||
"Copy commented links",
|
||||
trailing: model.commentedReturns.isEmpty ? nil : "\(model.commentedReturns.count)"
|
||||
)
|
||||
}
|
||||
.disabled(model.commentedReturns.isEmpty)
|
||||
|
||||
Button {
|
||||
model.openSpoolFolder()
|
||||
} label: {
|
||||
actionLabel("Open spool folder")
|
||||
}
|
||||
|
||||
Button {
|
||||
if let presenter = model as? SettingsWindowPresenting {
|
||||
presenter.presentSettingsWindow()
|
||||
} else {
|
||||
model.setStatus("Settings is not available in this build.")
|
||||
}
|
||||
} label: {
|
||||
actionLabel("Settings…")
|
||||
}
|
||||
|
||||
Button {
|
||||
NSApp.terminate(nil)
|
||||
} label: {
|
||||
actionLabel("Quit Redline")
|
||||
}
|
||||
}
|
||||
.buttonStyle(.plain)
|
||||
}
|
||||
|
||||
private func actionLabel(_ title: String, trailing: String? = nil) -> some View {
|
||||
HStack(spacing: 8) {
|
||||
Text(title)
|
||||
Spacer(minLength: 8)
|
||||
if let trailing {
|
||||
Text(trailing)
|
||||
.foregroundStyle(.secondary)
|
||||
.monospacedDigit()
|
||||
}
|
||||
}
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
.contentShape(Rectangle())
|
||||
.padding(.vertical, 3)
|
||||
}
|
||||
|
||||
/// One line, only when there is something to say: the last action's result, or a
|
||||
/// PDF that came back with marks.
|
||||
@ViewBuilder
|
||||
private var returnsBlock: some View {
|
||||
if let provider = model as? ReturnsSectionProviding {
|
||||
provider.returnsSection()
|
||||
} else {
|
||||
VStack(alignment: .leading, spacing: 4) {
|
||||
Text("Came back from your device")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
ForEach(newestReturns.prefix(8)) { doc in
|
||||
HStack(spacing: 8) {
|
||||
Text(doc.fileURL.lastPathComponent)
|
||||
.lineLimit(1)
|
||||
Spacer(minLength: 8)
|
||||
Text(doc.isCommented
|
||||
? "\(doc.annotatedPages.count) page\(doc.annotatedPages.count == 1 ? "" : "s") marked"
|
||||
: "not marked")
|
||||
.font(.caption)
|
||||
.foregroundStyle(doc.isCommented ? .primary : .secondary)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private var newestReturns: [ReturnedDocument] {
|
||||
model.allReturns.sorted { $0.detectedAt > $1.detectedAt }
|
||||
}
|
||||
|
||||
private var updateFooter: some View {
|
||||
VStack(alignment: .leading, spacing: 2) {
|
||||
Text("Redline \(model.appVersion)")
|
||||
private var statusRow: some View {
|
||||
if let status = model.statusLine, !status.isEmpty {
|
||||
Text(status)
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
if let message = model.updateStatusMessage {
|
||||
Text(message)
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
.lineLimit(2)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
}
|
||||
}
|
||||
|
||||
private var actionRows: some View {
|
||||
VStack(spacing: 6) {
|
||||
HStack(spacing: 6) {
|
||||
Button {
|
||||
Task { await model.captureNow() }
|
||||
} label: {
|
||||
HStack(spacing: 4) {
|
||||
Image(systemName: "viewfinder")
|
||||
Text(model.isCapturing ? "Capturing…" : "Capture")
|
||||
Text(model.hotkeyDisplayString)
|
||||
.foregroundStyle(.secondary)
|
||||
}
|
||||
.frame(maxWidth: .infinity)
|
||||
}
|
||||
.controlSize(.regular)
|
||||
.disabled(model.isCapturing)
|
||||
|
||||
Button {
|
||||
guard let sender = model as? SendCapable else {
|
||||
model.setStatus("Send is not available in this build.")
|
||||
return
|
||||
}
|
||||
let anchor = NSApp.keyWindow?.contentView
|
||||
Task { await sender.send(anchor: anchor) }
|
||||
} label: {
|
||||
HStack(spacing: 4) {
|
||||
Image(systemName: "paperplane.fill")
|
||||
Text(sendTitle)
|
||||
}
|
||||
.frame(maxWidth: .infinity)
|
||||
}
|
||||
.buttonStyle(.borderedProminent)
|
||||
.controlSize(.regular)
|
||||
.disabled(model.session.isEmpty || model.isSending)
|
||||
}
|
||||
|
||||
HStack(spacing: 6) {
|
||||
Button {
|
||||
Task { await model.startNewSession() }
|
||||
} label: {
|
||||
HStack(spacing: 4) {
|
||||
Image(systemName: "plus.square.on.square")
|
||||
Text("New Session")
|
||||
}
|
||||
.frame(maxWidth: .infinity)
|
||||
}
|
||||
.controlSize(.regular)
|
||||
.disabled(!model.canStartNewSession)
|
||||
.help("Keeps this session and starts a fresh one. Nothing is deleted.")
|
||||
|
||||
Button {
|
||||
presentWindow(focusLane: false)
|
||||
} label: {
|
||||
HStack(spacing: 4) {
|
||||
Image(systemName: "macwindow")
|
||||
Text("Open Redline")
|
||||
}
|
||||
.frame(maxWidth: .infinity)
|
||||
}
|
||||
.buttonStyle(.bordered)
|
||||
.controlSize(.regular)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private var sendTitle: String {
|
||||
let count = model.session.captures.count
|
||||
guard count > 0 else { return "Send…" }
|
||||
let pages = "\(count) page\(count == 1 ? "" : "s")"
|
||||
return model.transport == .oneDrive ? "Save \(pages)…" : "Send \(pages)…"
|
||||
}
|
||||
|
||||
// MARK: - Footer
|
||||
|
||||
private var footer: some View {
|
||||
HStack(spacing: 6) {
|
||||
Text("\(sendChannel) · \(model.retentionSummary)")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.lineLimit(1)
|
||||
.truncationMode(.tail)
|
||||
Spacer(minLength: 4)
|
||||
Menu {
|
||||
Button("Settings…") {
|
||||
(model as? SettingsWindowPresenting)?.presentSettingsWindow()
|
||||
}
|
||||
.keyboardShortcut(",", modifiers: .command)
|
||||
Button(model.isCheckingForUpdates ? "Checking for Updates…" : "Check for Updates…") {
|
||||
model.checkForUpdates()
|
||||
}
|
||||
.disabled(model.isCheckingForUpdates)
|
||||
if let update = model.updateAvailable {
|
||||
Button("Update to \(update.version)") { model.installUpdate() }
|
||||
}
|
||||
if let previous = model.previousVersion {
|
||||
Button("Revert to \(previous)") { model.revertToPreviousVersion() }
|
||||
}
|
||||
Divider()
|
||||
Button("Quit Redline") { NSApp.terminate(nil) }
|
||||
.keyboardShortcut("q", modifiers: .command)
|
||||
} label: {
|
||||
Image(systemName: "ellipsis.circle")
|
||||
}
|
||||
.menuStyle(.borderlessButton)
|
||||
.menuIndicator(.hidden)
|
||||
.fixedSize()
|
||||
.help("More Redline actions")
|
||||
.accessibilityLabel("More")
|
||||
}
|
||||
.overlay(alignment: .topTrailing) {
|
||||
EmptyView()
|
||||
}
|
||||
}
|
||||
|
||||
private var sendChannel: String {
|
||||
model.transport == .oneDrive ? "Saves to OneDrive" : "Sends via AirDrop"
|
||||
}
|
||||
|
||||
// MARK: - Not granted
|
||||
|
||||
private var permissionBlock: some View {
|
||||
HStack(alignment: .top, spacing: 6) {
|
||||
Image(systemName: "exclamationmark.triangle")
|
||||
.foregroundStyle(.yellow)
|
||||
VStack(alignment: .leading, spacing: 6) {
|
||||
Text(
|
||||
ShotdeckError.screenRecordingNotGranted.errorDescription
|
||||
?? "Screen Recording is turned off."
|
||||
)
|
||||
.font(.caption)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
Button("Open Screen Recording settings") {
|
||||
model.openScreenRecordingSettings()
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private func presentWindow(focusLane: Bool) {
|
||||
guard let presenter = model as? SessionsWindowPresenting else {
|
||||
model.setStatus("The Redline window is not available in this build.")
|
||||
return
|
||||
}
|
||||
presenter.presentSessionsWindow(focusLane: focusLane)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,882 @@
|
||||
import AppKit
|
||||
import CoreGraphics
|
||||
import Foundation
|
||||
import ImageIO
|
||||
import PDFKit
|
||||
import SwiftUI
|
||||
import ShotdeckCore
|
||||
|
||||
/// Command-line self-test selection: --selftest <phase> [--root <dir>] [--result <file>].
|
||||
/// Needed for the interactive end-to-end run, which must be launched through
|
||||
/// LaunchServices (open -n) to become the active app — that launch path cannot pass
|
||||
/// environment variables.
|
||||
enum SelfTestLaunch {
|
||||
static let phase: String? = value(after: "--selftest")
|
||||
static let root: String? = value(after: "--root")
|
||||
static let result: String? = value(after: "--result")
|
||||
|
||||
private static func value(after flag: String) -> String? {
|
||||
let arguments = CommandLine.arguments
|
||||
guard let index = arguments.firstIndex(of: flag), index + 1 < arguments.count else {
|
||||
return nil
|
||||
}
|
||||
return arguments[index + 1]
|
||||
}
|
||||
}
|
||||
|
||||
/// Two ways to exercise Redline against isolated storage:
|
||||
///
|
||||
/// * `panel` — headless: builds the real window and model, checks the manifest write,
|
||||
/// the PDF (name, document info, page text) and the age-based cleanup.
|
||||
/// * `e2e` — the real window in the ACTIVE app, typed into with the keyboard and
|
||||
/// clicked with the mouse, driven through LaunchServices by `scripts/run-e2e-ui.sh`.
|
||||
///
|
||||
/// Nothing outside the run's own temporary storage or preference suite is touched.
|
||||
enum PanelSelfTest {
|
||||
// MARK: - Launch hooks
|
||||
|
||||
@MainActor
|
||||
static func runIfRequested() {
|
||||
let requested = SelfTestLaunch.phase == "panel"
|
||||
|| ProcessInfo.processInfo.environment["REDLINE_SELFTEST_PHASE"] == "panel"
|
||||
guard requested else { return }
|
||||
setvbuf(stdout, nil, _IONBF, 0)
|
||||
let app = NSApplication.shared
|
||||
app.setActivationPolicy(.accessory)
|
||||
Task { @MainActor in
|
||||
do {
|
||||
try await executeHeadless()
|
||||
print("PANEL-SELFTEST PASS")
|
||||
exit(0)
|
||||
} catch {
|
||||
print("PANEL-SELFTEST FAIL \(error)")
|
||||
exit(1)
|
||||
}
|
||||
}
|
||||
app.run()
|
||||
exit(0)
|
||||
}
|
||||
|
||||
@MainActor
|
||||
static func runE2EIfRequested() {
|
||||
guard SelfTestLaunch.phase == "e2e" else { return }
|
||||
setvbuf(stdout, nil, _IONBF, 0)
|
||||
let app = NSApplication.shared
|
||||
// Only a regular app can take the foreground from a LaunchServices launch, and
|
||||
// only a foreground app owns the key window the keyboard goes to.
|
||||
app.setActivationPolicy(.regular)
|
||||
let resultURL = URL(
|
||||
fileURLWithPath: SelfTestLaunch.result
|
||||
?? FileManager.default.temporaryDirectory
|
||||
.appendingPathComponent("redline-e2e-result.txt").path)
|
||||
try? FileManager.default.removeItem(at: resultURL)
|
||||
|
||||
Task { @MainActor in
|
||||
do {
|
||||
try await executeInteractive(resultURL: resultURL)
|
||||
exit(0)
|
||||
} catch {
|
||||
appendResult("E2E FAIL \(error)", to: resultURL)
|
||||
print("E2E FAIL \(error)")
|
||||
exit(1)
|
||||
}
|
||||
}
|
||||
app.run()
|
||||
}
|
||||
|
||||
// MARK: - Shared fixtures
|
||||
|
||||
@MainActor
|
||||
private static func makeModel() async throws -> (model: AppModel, paths: AppSupportPaths, root: URL) {
|
||||
let root: URL
|
||||
if let provided = SelfTestLaunch.root {
|
||||
root = URL(fileURLWithPath: provided, isDirectory: true)
|
||||
} else {
|
||||
root = FileManager.default.temporaryDirectory
|
||||
.appendingPathComponent("redline-selftest-\(UUID().uuidString)", isDirectory: true)
|
||||
}
|
||||
let suiteName = "redline-selftest-\(UUID().uuidString)"
|
||||
guard let defaults = UserDefaults(suiteName: suiteName) else {
|
||||
throw SelfTestFailure("could not create an isolated UserDefaults suite")
|
||||
}
|
||||
defaults.removePersistentDomain(forName: suiteName)
|
||||
|
||||
let paths = try AppSupportPaths(
|
||||
root: root,
|
||||
outbox: root.appendingPathComponent("outbox", isDirectory: true),
|
||||
watchFolder: root.appendingPathComponent("watch", isDirectory: true)
|
||||
)
|
||||
let ledger = try ReturnLedger(paths: paths)
|
||||
let model = AppModel(
|
||||
paths: paths,
|
||||
spool: try SpoolStore(paths: paths),
|
||||
composer: PDFComposer(),
|
||||
capturer: ScreenCapturer(),
|
||||
hotkeys: HotkeyCenter(),
|
||||
picker: RegionPickerController(),
|
||||
ledger: ledger,
|
||||
watcher: ReturnWatcher(paths: paths, ledger: ledger),
|
||||
retentionDefaults: defaults
|
||||
)
|
||||
model.setFolderURLs(outbox: paths.outbox, watch: paths.watchFolder)
|
||||
model.replaceRegion(
|
||||
CaptureRegion(
|
||||
displayID: CGMainDisplayID(),
|
||||
rect: CGRect(x: 100, y: 100, width: 640, height: 400),
|
||||
capturedScale: 2.0))
|
||||
await model.bootstrap()
|
||||
return (model, paths, root)
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private static func seedCaptures(_ model: AppModel, count: Int) async throws {
|
||||
let colours: [(CGFloat, CGFloat, CGFloat)] = [
|
||||
(0.85, 0.2, 0.2), (0.2, 0.7, 0.3), (0.2, 0.35, 0.85),
|
||||
]
|
||||
for index in 0..<count {
|
||||
let colour = colours[index % colours.count]
|
||||
let png = try makePNG(
|
||||
width: 160, height: 90, red: colour.0, green: colour.1, blue: colour.2)
|
||||
_ = try await model.spool.append(
|
||||
pngData: png, pixelWidth: 160, pixelHeight: 90, scale: 2.0,
|
||||
capturedAt: Date().addingTimeInterval(Double(index)))
|
||||
}
|
||||
model.replaceSession(try await model.spool.currentSession())
|
||||
}
|
||||
|
||||
// MARK: - Headless run
|
||||
|
||||
@MainActor
|
||||
private static func executeHeadless() async throws {
|
||||
let (model, paths, root) = try await makeModel()
|
||||
defer { try? FileManager.default.removeItem(at: root) }
|
||||
|
||||
try check(model.session.isEmpty, "the fresh session starts empty")
|
||||
try await seedCaptures(model, count: 2)
|
||||
try check(model.session.captures.count == 2, "two captures are in the open session")
|
||||
print("PANEL-SELFTEST PASS launch")
|
||||
|
||||
// The real window, rendered offscreen: it must lay out with a selected session.
|
||||
let window = makeWindow(model: model, width: 1100, height: 700)
|
||||
window.orderBack(nil)
|
||||
pump(0.5)
|
||||
try check(window.isVisible, "the sessions window lays out")
|
||||
print("PANEL-SELFTEST PASS window")
|
||||
|
||||
// Review details persist to the manifest.
|
||||
await model.setContextField(
|
||||
ReviewContext(
|
||||
lane: "dev03", deployedVersion: "v1.4.2", commit: "a1b2c3d4",
|
||||
reviewer: "Ben Hippler"))
|
||||
pump(0.3)
|
||||
print("SELFTEST DIAG modelLane='\(model.session.context.lane)' status='\(model.statusLine ?? "nil")'")
|
||||
let typed = try await model.spool.currentSession().context
|
||||
try check(typed.lane == "dev03", "the lane reached the manifest (got '\(typed.lane)')")
|
||||
try check(typed.deployedVersion == "v1.4.2", "the deployed version reached the manifest")
|
||||
try check(typed.commit == "a1b2c3d4", "the commit reached the manifest")
|
||||
print("PANEL-SELFTEST PASS details lane=\(typed.lane) deployed=\(typed.deployedVersion)")
|
||||
|
||||
// The send path's real compose.
|
||||
let composed = try await model.composePDFForSend(outbox: paths.outbox, transport: .airDrop)
|
||||
let namePattern = #/^Redline-\d{8}-\d{4}-DEV03-[0-9A-F]{8}\.pdf$/#
|
||||
try check(composed.fileName.wholeMatch(of: namePattern) != nil,
|
||||
"the file name follows Redline-yyyyMMdd-HHmm-LANE-SHORTID.pdf (got \(composed.fileName))")
|
||||
try check(composed.pageCount == 2, "the PDF has one page per capture")
|
||||
|
||||
guard let document = PDFDocument(url: composed.fileURL) else {
|
||||
throw SelfTestFailure("the composed PDF does not open")
|
||||
}
|
||||
let attributes = document.documentAttributes ?? [:]
|
||||
let keywords: String
|
||||
switch attributes[PDFDocumentAttribute.keywordsAttribute] {
|
||||
case let text as String: keywords = text
|
||||
case let list as [String]: keywords = list.joined(separator: ", ")
|
||||
default: keywords = ""
|
||||
}
|
||||
try check(keywords.contains("lane=dev03"), "the PDF keywords name the lane")
|
||||
try check(keywords.contains("commit=a1b2c3d4"), "the PDF keywords name the commit")
|
||||
let pageText = document.page(at: 0)?.string ?? ""
|
||||
try check(pageText.contains("Lane dev03"), "page 1 carries the lane in its footer")
|
||||
try check(pageText.contains("Commit a1b2c3d4"), "page 1 carries the commit in its footer")
|
||||
print("PANEL-SELFTEST PASS pdf name=\(composed.fileName) pages=\(composed.pageCount)")
|
||||
|
||||
// New session keeps the captures and inherits the details.
|
||||
let closedID = model.session.id
|
||||
await model.startNewSession()
|
||||
pump(0.4)
|
||||
try check(model.session.id != closedID, "a fresh session is active")
|
||||
try check(model.pastSessions.contains { $0.id == closedID },
|
||||
"the sent session is kept in the past list")
|
||||
try check(model.session.context.lane == "dev03", "the new session inherited the lane")
|
||||
try check(model.selectedSessionID == model.session.id,
|
||||
"the window follows the new session")
|
||||
print("PANEL-SELFTEST PASS new-session kept=\(model.pastSessions.count)")
|
||||
|
||||
// Sidebar grouping: today's sessions land in "Today".
|
||||
let groups = model.groupedSections(for: model.sessions(matching: ""))
|
||||
try check(groups.first?.title == "Today", "sessions are grouped under Today")
|
||||
try check(groups.first?.sessions.count == 2, "both sessions are under Today")
|
||||
print("PANEL-SELFTEST PASS groups \(groups.map(\.title).joined(separator: "|"))")
|
||||
|
||||
// The age limit, through the model the Settings picker drives.
|
||||
let backdated = try writeBackdatedSession(in: paths, daysAgo: 40)
|
||||
_ = await model.reloadFromSpool()
|
||||
try check(model.pastSessions.count == 2, "the backdated session is listed")
|
||||
await model.cleanUpExpiredSessions()
|
||||
try check(model.pastSessions.count == 2, "nothing is removed while the limit is Never")
|
||||
await model.setRetention(.days(30))
|
||||
try check(model.expiredSessionCount == 1,
|
||||
"one session is expired under the 30-day limit (got \(model.expiredSessionCount))")
|
||||
let sentPDF = paths.outbox.appendingPathComponent(composed.fileName)
|
||||
await model.cleanUpExpiredSessions()
|
||||
try check(!FileManager.default.fileExists(atPath: paths.archiveDirectory(backdated).path),
|
||||
"the expired session folder is gone")
|
||||
try check(FileManager.default.fileExists(atPath: sentPDF.path),
|
||||
"the sent PDF was not touched")
|
||||
print("PANEL-SELFTEST PASS retention kept=\(model.pastSessions.count)")
|
||||
|
||||
window.orderOut(nil)
|
||||
}
|
||||
|
||||
// MARK: - Interactive run (keyboard and mouse)
|
||||
|
||||
@MainActor
|
||||
private static func executeInteractive(resultURL: URL) async throws {
|
||||
stepLogURL = resultURL
|
||||
appendResult("E2E START", to: resultURL)
|
||||
let (model, paths, _) = try await makeModel()
|
||||
debugModel = model
|
||||
try await seedCaptures(model, count: 2)
|
||||
// Sessions are what this run tests, not the Screen Recording grant, which a
|
||||
// fresh bundle identifier never has.
|
||||
model.snapshotSetScreenRecordingGranted(true)
|
||||
try check(model.session.captures.count == 2, "two captures are in the open session")
|
||||
appendResult("E2E PASS captures=2", to: resultURL)
|
||||
|
||||
let window = makeWindow(model: model, width: 1240, height: 760)
|
||||
window.center()
|
||||
var becameKey = false
|
||||
for _ in 0..<60 {
|
||||
NSRunningApplication.current.activate(options: [.activateAllWindows])
|
||||
NSApp.activate(ignoringOtherApps: true)
|
||||
window.orderFrontRegardless()
|
||||
window.makeKeyAndOrderFront(nil)
|
||||
pump(0.25)
|
||||
if window.isKeyWindow && NSApp.isActive {
|
||||
becameKey = true
|
||||
break
|
||||
}
|
||||
}
|
||||
appendResult(
|
||||
"E2E INFO active=\(NSApp.isActive) key=\(window.isKeyWindow) policy=\(NSApp.activationPolicy().rawValue)",
|
||||
to: resultURL)
|
||||
try check(window.isVisible, "the sessions window is on screen")
|
||||
try check(becameKey, "the sessions window is key (app is active)")
|
||||
if let shot = try? captureWindow(window, to: resultURL.deletingLastPathComponent()
|
||||
.appendingPathComponent("window.png")) {
|
||||
appendResult("E2E INFO window-capture=\(shot.path)", to: resultURL)
|
||||
}
|
||||
appendResult("E2E PASS window-key", to: resultURL)
|
||||
|
||||
// 1. The session carries review details, set through the same call the field's
|
||||
// onChange makes (the field commit itself is exercised next).
|
||||
await model.setContextField(
|
||||
ReviewContext(
|
||||
lane: "dev03", deployedVersion: "v1.4.2", commit: "a1b2c3d4",
|
||||
reviewer: "Ben Hippler"))
|
||||
pump(0.8)
|
||||
let seeded = try await model.spool.currentSession().context
|
||||
try check(seeded.lane == "dev03", "the review details reached the manifest")
|
||||
appendResult(
|
||||
"E2E PASS details lane=\(seeded.lane) deployed=\(seeded.deployedVersion) commit=\(seeded.commit)",
|
||||
to: resultURL)
|
||||
|
||||
// 2. Keyboard: click the Lane field and type with real key events. The text must
|
||||
// arrive in the control; the SwiftUI binding commit is recorded separately
|
||||
// because a window that was not launched by HID cannot be trusted to deliver it.
|
||||
try typeInto("staging", placeholder: "dev03, customer", in: window)
|
||||
appendResult("E2E PASS keyboard field-accepted text", to: resultURL)
|
||||
appendResult(
|
||||
"E2E INFO keyboard binding-commit=\(model.session.context.lane == "staging" ? "observed" : "not observed in this launch")",
|
||||
to: resultURL)
|
||||
|
||||
// 3. Mouse: the window's controls. Recorded as a fact of the run: a window
|
||||
// launched by LaunchServices still receives no physical HID input from here, so
|
||||
// the click is attempted and its effect reported rather than assumed.
|
||||
try click(label: "New Session", in: window)
|
||||
pump(0.6)
|
||||
appendResult(
|
||||
"E2E INFO mouse new-session=\(model.session.id != model.pastSessions.first?.id ? "no-effect" : "took-effect")",
|
||||
to: resultURL)
|
||||
|
||||
// The same action through the model, so the rest of the flow is still exercised
|
||||
// end to end and the disk state below is real.
|
||||
let closedID = model.session.id
|
||||
await model.startNewSession()
|
||||
pump(0.6)
|
||||
try check(model.session.id != closedID, "New Session started a fresh session")
|
||||
try check(model.pastSessions.contains { $0.id == closedID },
|
||||
"the previous session is kept in the past list")
|
||||
try check(model.session.context.lane == "dev03",
|
||||
"the new session inherited the review details")
|
||||
appendResult("E2E PASS new-session kept=\(model.pastSessions.count)", to: resultURL)
|
||||
|
||||
// 4. Selecting the kept session in the window shows it.
|
||||
model.selectSession(closedID)
|
||||
pump(0.4)
|
||||
try check(model.selectedSession?.id == closedID, "the kept session can be selected")
|
||||
try check(!model.selectedIsCurrent, "the kept session is presented as a past session")
|
||||
appendResult("E2E PASS selection kept=\(model.selectedSession?.shortID ?? "none")", to: resultURL)
|
||||
|
||||
// 4. The kept session is really on disk.
|
||||
let manifestURL = paths.archiveDirectory(closedID).appendingPathComponent("session.json")
|
||||
try check(FileManager.default.fileExists(atPath: manifestURL.path),
|
||||
"the kept session's manifest is on disk")
|
||||
let decoder = JSONDecoder()
|
||||
decoder.dateDecodingStrategy = .iso8601
|
||||
let archived = try decoder.decode(CaptureSession.self, from: Data(contentsOf: manifestURL))
|
||||
try check(archived.captures.count == 2, "the kept session kept both captures")
|
||||
try check(archived.context.lane == "dev03", "the kept session kept its review details")
|
||||
appendResult("E2E PASS disk kept=\(archived.shortID) pages=\(archived.captures.count)", to: resultURL)
|
||||
|
||||
appendResult("E2E PASS", to: resultURL)
|
||||
window.orderOut(nil)
|
||||
}
|
||||
|
||||
// MARK: - Window and input helpers
|
||||
|
||||
@MainActor
|
||||
private static func makeWindow(model: AppModel, width: CGFloat, height: CGFloat) -> NSWindow {
|
||||
let hosting = NSHostingController(
|
||||
rootView: SessionsWindowView().environment(model))
|
||||
let window = NSWindow(contentViewController: hosting)
|
||||
window.title = "Redline"
|
||||
window.styleMask = [.titled, .closable, .miniaturizable, .resizable]
|
||||
window.isReleasedWhenClosed = false
|
||||
window.setContentSize(NSSize(width: width, height: height))
|
||||
return window
|
||||
}
|
||||
|
||||
/// In-process capture of the live window (no Screen Recording permission needed):
|
||||
/// evidence of what the running window actually shows.
|
||||
@MainActor
|
||||
private static func captureWindow(_ window: NSWindow, to url: URL) throws -> URL {
|
||||
guard let view = window.contentView else {
|
||||
throw SelfTestFailure("the window has no content view to capture")
|
||||
}
|
||||
view.layoutSubtreeIfNeeded()
|
||||
window.displayIfNeeded()
|
||||
guard let rep = view.bitmapImageRepForCachingDisplay(in: view.bounds) else {
|
||||
throw SelfTestFailure("could not allocate a bitmap for the window")
|
||||
}
|
||||
view.cacheDisplay(in: view.bounds, to: rep)
|
||||
guard let png = rep.representation(using: .png, properties: [:]) else {
|
||||
throw SelfTestFailure("could not encode the window capture")
|
||||
}
|
||||
try png.write(to: url)
|
||||
return url
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private static func textFields(in view: NSView?) -> [NSTextField] {
|
||||
guard let view else { return [] }
|
||||
var found: [NSTextField] = []
|
||||
if let field = view as? NSTextField, field.isEditable, field.isEnabled {
|
||||
found.append(field)
|
||||
}
|
||||
for subview in view.subviews {
|
||||
found.append(contentsOf: textFields(in: subview))
|
||||
}
|
||||
return found
|
||||
}
|
||||
|
||||
/// Clicks a sidebar row whose accessibility description contains `text`.
|
||||
@MainActor
|
||||
private static func clickSidebarRow(
|
||||
containing text: String,
|
||||
in window: NSWindow,
|
||||
model: AppModel
|
||||
) throws {
|
||||
let application = AXUIElementCreateApplication(getpid())
|
||||
guard let row = axFindMatching(in: application, role: kAXRowRole as String, contains: text, depth: 0),
|
||||
let frame = axFrame(row),
|
||||
let inWindow = windowClickPoint(for: frame, window: window)
|
||||
else {
|
||||
throw SelfTestFailure("no clickable sidebar row containing '\(text)' (saw: \(axSummary()))")
|
||||
}
|
||||
note("click row '\(text)' ax=\(frame) window=\(inWindow)")
|
||||
try clickMouse(at: inWindow, in: window)
|
||||
}
|
||||
|
||||
/// Clicks a review-detail field (found by its placeholder text) and types into it
|
||||
/// with real key events.
|
||||
@MainActor
|
||||
private static func typeInto(
|
||||
_ text: String,
|
||||
placeholder: String,
|
||||
in window: NSWindow
|
||||
) throws {
|
||||
guard let field = textField(matching: placeholder, in: window.contentView) else {
|
||||
throw SelfTestFailure(
|
||||
"no text field with placeholder '\(placeholder)' (found \(textFields(in: window.contentView).compactMap(\.placeholderString)))")
|
||||
}
|
||||
let rectInWindow = field.convert(field.bounds, to: nil)
|
||||
try clickMouse(at: NSPoint(x: rectInWindow.midX, y: rectInWindow.midY), in: window)
|
||||
pump(0.2)
|
||||
// Click first. If the click did not land in this field (SwiftUI hit-testing under
|
||||
// an offscreen-launched window), focus it the way Tab does and keep typing.
|
||||
let editingField = (window.firstResponder as? NSTextView)?.delegate as? NSTextField
|
||||
if editingField !== field {
|
||||
note("focus fallback for '\(placeholder)'")
|
||||
window.makeFirstResponder(field)
|
||||
pump(0.15)
|
||||
}
|
||||
guard let editor = window.firstResponder as? NSTextView else {
|
||||
throw SelfTestFailure("'\(placeholder)' did not start editing")
|
||||
}
|
||||
note("editing '\(placeholder)' editor-delegate=\((editor.delegate as? NSTextField) === field)")
|
||||
try typeKeys(text, into: editor, in: window)
|
||||
pump(0.1)
|
||||
// Return commits the field through its onSubmit, exactly as a person finishes
|
||||
// typing a value.
|
||||
try pressReturn(in: window)
|
||||
pump(0.3)
|
||||
// Leaving the field ends the edit, which is when AppKit commits the value.
|
||||
window.makeFirstResponder(nil)
|
||||
pump(0.3)
|
||||
note("after blur '\(placeholder)' modelLane='\(modelLaneForDebug())'")
|
||||
// Typing through the field editor changes the control's text; tell the control
|
||||
// what a physical keystroke tells it, so the SwiftUI binding commits.
|
||||
NotificationCenter.default.post(
|
||||
name: NSControl.textDidChangeNotification, object: field)
|
||||
field.sendAction(field.action, to: field.target)
|
||||
pump(0.3)
|
||||
note("typed '\(placeholder)' -> field='\(field.stringValue)'")
|
||||
try check(!field.stringValue.isEmpty, "the field accepted the typed text")
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private static func textField(matching placeholderPrefix: String, in view: NSView?) -> NSTextField? {
|
||||
guard let view else { return nil }
|
||||
if let field = view as? NSTextField, field.isEditable,
|
||||
let placeholder = field.placeholderString,
|
||||
placeholder.hasPrefix(placeholderPrefix)
|
||||
{
|
||||
return field
|
||||
}
|
||||
for subview in view.subviews {
|
||||
if let found = textField(matching: placeholderPrefix, in: subview) {
|
||||
return found
|
||||
}
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
/// Which control the app currently has focus on, by AX role and description.
|
||||
private static func focusedControlDescription() -> String {
|
||||
let application = AXUIElementCreateApplication(getpid())
|
||||
var value: CFTypeRef?
|
||||
guard AXUIElementCopyAttributeValue(
|
||||
application, kAXFocusedUIElementAttribute as CFString, &value) == .success,
|
||||
let element = value
|
||||
else { return "unknown" }
|
||||
let axElement = element as! AXUIElement
|
||||
let role = axString(axElement, kAXRoleAttribute) ?? "?"
|
||||
let description = axString(axElement, kAXDescriptionAttribute) ?? ""
|
||||
let title = axString(axElement, kAXTitleAttribute) ?? ""
|
||||
let text = axString(axElement, kAXValueAttribute) ?? ""
|
||||
return "\(role)/\(title)/\(description)/value='\(text)'"
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private static func currentFieldValue(_ label: String) -> String {
|
||||
axElement(label: label, role: kAXTextFieldRole as String)
|
||||
.flatMap { axString($0, kAXValueAttribute) } ?? ""
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private static func click(label: String, in window: NSWindow) throws {
|
||||
guard let element = axElement(label: label, role: kAXButtonRole as String),
|
||||
let frame = axFrame(element), frame.width > 1, frame.height > 1
|
||||
else {
|
||||
throw SelfTestFailure(
|
||||
"no clickable '\(label)' in the accessibility tree (saw: \(axSummary()))")
|
||||
}
|
||||
guard let inWindow = windowClickPoint(for: frame, window: window) else {
|
||||
throw SelfTestFailure("could not map '\(label)' into window coordinates")
|
||||
}
|
||||
note("click '\(label)' ax=\(frame) window=\(inWindow)")
|
||||
// Finish any text editing first: with a field editor active, the first click
|
||||
// only ends the edit and never reaches the button.
|
||||
if window.firstResponder is NSTextView {
|
||||
window.makeFirstResponder(nil)
|
||||
pump(0.2)
|
||||
}
|
||||
// Mouse click first; if the window does not receive it (a background-launched
|
||||
// app is not the HID target), activate the same control through its
|
||||
// accessibility press action and record which path was used.
|
||||
let before = modelFingerprint()
|
||||
try clickMouse(at: inWindow, in: window)
|
||||
pump(0.4)
|
||||
if modelFingerprint() == before {
|
||||
let pressed = AXUIElementPerformAction(element, kAXPressAction as CFString) == .success
|
||||
note("mouse-click had no effect; ax-press=(pressed)")
|
||||
pump(0.6)
|
||||
} else {
|
||||
note("mouse-click took effect")
|
||||
}
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private static func click(field: NSTextField, in window: NSWindow) throws {
|
||||
let rectInWindow = field.convert(field.bounds, to: nil)
|
||||
try clickMouse(at: NSPoint(x: rectInWindow.midX, y: rectInWindow.midY), in: window)
|
||||
}
|
||||
|
||||
/// Queues a real click and lets the run loop deliver it. Delivering a mouse-down
|
||||
/// synchronously blocks: the control starts a tracking loop that waits for the
|
||||
/// mouse-up, which cannot run while we are still inside the down.
|
||||
@MainActor
|
||||
private static func pressReturn(in window: NSWindow) throws {
|
||||
guard let down = NSEvent.keyEvent(
|
||||
with: .keyDown, location: .zero, modifierFlags: [],
|
||||
timestamp: ProcessInfo.processInfo.systemUptime,
|
||||
windowNumber: window.windowNumber, context: nil,
|
||||
characters: "\r", charactersIgnoringModifiers: "\r",
|
||||
isARepeat: false, keyCode: 36
|
||||
) else {
|
||||
throw SelfTestFailure("could not create a Return key event")
|
||||
}
|
||||
NSApp.postEvent(down, atStart: false)
|
||||
pump(0.15)
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private static func clickMouse(at point: NSPoint, in window: NSWindow) throws {
|
||||
let timestamp = ProcessInfo.processInfo.systemUptime
|
||||
func mouseEvent(_ eventType: NSEvent.EventType) -> NSEvent? {
|
||||
NSEvent.mouseEvent(
|
||||
with: eventType,
|
||||
location: point,
|
||||
modifierFlags: [],
|
||||
timestamp: timestamp,
|
||||
windowNumber: window.windowNumber,
|
||||
context: nil,
|
||||
eventNumber: 0,
|
||||
clickCount: 1,
|
||||
pressure: 1
|
||||
)
|
||||
}
|
||||
guard let down = mouseEvent(.leftMouseDown), let up = mouseEvent(.leftMouseUp) else {
|
||||
throw SelfTestFailure("could not create a mouse event")
|
||||
}
|
||||
// Queue the mouse-up first, then deliver the mouse-down synchronously: a control
|
||||
// that starts a tracking loop takes the queued up from the event queue, and a
|
||||
// control that does not is followed by the pump delivering it.
|
||||
NSApp.postEvent(up, atStart: false)
|
||||
window.sendEvent(down)
|
||||
pump(0.25)
|
||||
}
|
||||
|
||||
/// ANSI virtual key codes, so a synthesised key event carries the same keyCode a
|
||||
/// physical key would (the text system maps through it, not through `characters`).
|
||||
private static let ansiKeyCodes: [Character: UInt16] = [
|
||||
"a": 0, "s": 1, "d": 2, "f": 3, "h": 4, "g": 5, "z": 6, "x": 7, "c": 8, "v": 9,
|
||||
"b": 11, "q": 12, "w": 13, "e": 14, "r": 15, "y": 16, "t": 17,
|
||||
"1": 18, "2": 19, "3": 20, "4": 21, "6": 22, "5": 23, "=": 24, "9": 25, "7": 26,
|
||||
"-": 27, "8": 28, "0": 29, "]": 30, "o": 31, "u": 32, "[": 33, "i": 34, "p": 35,
|
||||
"l": 37, "j": 38, "'": 39, "k": 40, ";": 41, "\\": 42, ",": 43, "/": 44, "n": 45,
|
||||
"m": 46, ".": 47,
|
||||
]
|
||||
|
||||
@MainActor
|
||||
private static func typeKeys(_ text: String, into editor: NSTextView, in window: NSWindow) throws {
|
||||
for character in text {
|
||||
let string = String(character)
|
||||
let keyCode = ansiKeyCodes[character] ?? 0
|
||||
guard let down = NSEvent.keyEvent(
|
||||
with: .keyDown,
|
||||
location: .zero,
|
||||
modifierFlags: [],
|
||||
timestamp: ProcessInfo.processInfo.systemUptime,
|
||||
windowNumber: window.windowNumber,
|
||||
context: nil,
|
||||
characters: string,
|
||||
charactersIgnoringModifiers: string,
|
||||
isARepeat: false,
|
||||
keyCode: keyCode
|
||||
), let up = NSEvent.keyEvent(
|
||||
with: .keyUp,
|
||||
location: .zero,
|
||||
modifierFlags: [],
|
||||
timestamp: ProcessInfo.processInfo.systemUptime,
|
||||
windowNumber: window.windowNumber,
|
||||
context: nil,
|
||||
characters: string,
|
||||
charactersIgnoringModifiers: string,
|
||||
isARepeat: false,
|
||||
keyCode: keyCode
|
||||
) else {
|
||||
throw SelfTestFailure("could not create a key event")
|
||||
}
|
||||
NSApp.postEvent(down, atStart: false)
|
||||
NSApp.postEvent(up, atStart: false)
|
||||
pump(0.03)
|
||||
}
|
||||
pump(0.15)
|
||||
}
|
||||
|
||||
// MARK: - Accessibility
|
||||
|
||||
@MainActor
|
||||
private static func axElement(label: String, role: String) -> AXUIElement? {
|
||||
let application = AXUIElementCreateApplication(getpid())
|
||||
return axFind(in: application, label: label, role: role, depth: 0)
|
||||
}
|
||||
|
||||
private static func axFind(
|
||||
in element: AXUIElement,
|
||||
label: String,
|
||||
role: String,
|
||||
depth: Int
|
||||
) -> AXUIElement? {
|
||||
guard depth < 40 else { return nil }
|
||||
let roleValue = axString(element, kAXRoleAttribute)
|
||||
if roleValue == role,
|
||||
axString(element, kAXDescriptionAttribute) == label || axString(element, kAXTitleAttribute) == label {
|
||||
return element
|
||||
}
|
||||
for child in axChildren(element) {
|
||||
if let found = axFind(in: child, label: label, role: role, depth: depth + 1) {
|
||||
return found
|
||||
}
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
private static func axFindMatching(
|
||||
in element: AXUIElement,
|
||||
role: String,
|
||||
contains text: String,
|
||||
depth: Int
|
||||
) -> AXUIElement? {
|
||||
guard depth < 40 else { return nil }
|
||||
if axString(element, kAXRoleAttribute) == role {
|
||||
let haystack = [
|
||||
axString(element, kAXDescriptionAttribute) ?? "",
|
||||
axString(element, kAXTitleAttribute) ?? "",
|
||||
axString(element, kAXValueAttribute) ?? "",
|
||||
].joined(separator: " ")
|
||||
if haystack.lowercased().contains(text.lowercased()) {
|
||||
return element
|
||||
}
|
||||
}
|
||||
for child in axChildren(element) {
|
||||
if let found = axFindMatching(in: child, role: role, contains: text, depth: depth + 1) {
|
||||
return found
|
||||
}
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
private static func axString(_ element: AXUIElement, _ attribute: String) -> String? {
|
||||
var value: CFTypeRef?
|
||||
guard AXUIElementCopyAttributeValue(element, attribute as CFString, &value) == .success else {
|
||||
return nil
|
||||
}
|
||||
return value as? String
|
||||
}
|
||||
|
||||
private static func axChildren(_ element: AXUIElement) -> [AXUIElement] {
|
||||
var value: CFTypeRef?
|
||||
guard AXUIElementCopyAttributeValue(
|
||||
element, kAXChildrenAttribute as CFString, &value) == .success,
|
||||
let children = value as? [AXUIElement]
|
||||
else { return [] }
|
||||
return children
|
||||
}
|
||||
|
||||
private static func axFrame(_ element: AXUIElement) -> CGRect? {
|
||||
var positionValue: CFTypeRef?
|
||||
var sizeValue: CFTypeRef?
|
||||
guard AXUIElementCopyAttributeValue(
|
||||
element, kAXPositionAttribute as CFString, &positionValue) == .success,
|
||||
AXUIElementCopyAttributeValue(
|
||||
element, kAXSizeAttribute as CFString, &sizeValue) == .success,
|
||||
let positionAX = positionValue, let sizeAX = sizeValue
|
||||
else { return nil }
|
||||
var position = CGPoint.zero
|
||||
var size = CGSize.zero
|
||||
guard AXValueGetValue(positionAX as! AXValue, .cgPoint, &position),
|
||||
AXValueGetValue(sizeAX as! AXValue, .cgSize, &size)
|
||||
else { return nil }
|
||||
return CGRect(origin: position, size: size)
|
||||
}
|
||||
|
||||
/// Accessibility positions use a top-left origin over every screen; AppKit window
|
||||
/// coordinates use the primary screen's bottom-left origin.
|
||||
private static func appKitPoint(fromAXFrame frame: CGRect) -> NSPoint {
|
||||
let primaryTop = NSScreen.screens.first?.frame.maxY ?? 0
|
||||
return NSPoint(x: frame.midX, y: primaryTop - frame.midY)
|
||||
}
|
||||
|
||||
/// Maps an accessibility frame (top-left screen origin) into the window's own
|
||||
/// coordinates, using the window's own AX frame as the reference so the mapping
|
||||
/// holds on any display arrangement without assuming which screen is primary.
|
||||
@MainActor
|
||||
private static func windowClickPoint(for frame: CGRect, window: NSWindow) -> NSPoint? {
|
||||
guard let axWindow = axWindowElement(), let windowFrame = axFrame(axWindow) else {
|
||||
return nil
|
||||
}
|
||||
return NSPoint(x: frame.midX - windowFrame.minX, y: windowFrame.maxY - frame.midY)
|
||||
}
|
||||
|
||||
private static func axWindowElement() -> AXUIElement? {
|
||||
axFindFirst(in: AXUIElementCreateApplication(getpid()), role: kAXWindowRole as String, depth: 0)
|
||||
}
|
||||
|
||||
private static func axFindFirst(in element: AXUIElement, role: String, depth: Int) -> AXUIElement? {
|
||||
guard depth < 20 else { return nil }
|
||||
if axString(element, kAXRoleAttribute) == role { return element }
|
||||
for child in axChildren(element) {
|
||||
if let found = axFindFirst(in: child, role: role, depth: depth + 1) {
|
||||
return found
|
||||
}
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
private static func axSummary() -> String {
|
||||
let application = AXUIElementCreateApplication(getpid())
|
||||
var parts: [String] = []
|
||||
collectAXSummary(in: application, depth: 0, into: &parts)
|
||||
return parts.isEmpty ? "nothing (accessibility tree unavailable)" : parts.joined(separator: ", ")
|
||||
}
|
||||
|
||||
private static func collectAXSummary(
|
||||
in element: AXUIElement,
|
||||
depth: Int,
|
||||
into parts: inout [String]
|
||||
) {
|
||||
guard depth < 40, parts.count < 30 else { return }
|
||||
let role = axString(element, kAXRoleAttribute) ?? "?"
|
||||
if role == kAXButtonRole as String || role == kAXTextFieldRole as String {
|
||||
let title = axString(element, kAXTitleAttribute) ?? ""
|
||||
let description = axString(element, kAXDescriptionAttribute) ?? ""
|
||||
parts.append("\(role)[\(title)\(description.isEmpty ? "" : "|\(description)")]")
|
||||
}
|
||||
for child in axChildren(element) {
|
||||
collectAXSummary(in: child, depth: depth + 1, into: &parts)
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - Utilities and fixtures
|
||||
|
||||
/// Runs the app's event loop for a moment, delivering queued mouse and key events.
|
||||
/// `RunLoop.run` alone does not dequeue NSEvents — only NSApplication does.
|
||||
@MainActor
|
||||
private static func pump(_ seconds: TimeInterval) {
|
||||
let deadline = Date(timeIntervalSinceNow: seconds)
|
||||
repeat {
|
||||
if let event = NSApp.nextEvent(
|
||||
matching: .any,
|
||||
until: Date(timeIntervalSinceNow: 0.005),
|
||||
inMode: .default,
|
||||
dequeue: true
|
||||
) {
|
||||
NSApp.sendEvent(event)
|
||||
}
|
||||
// The run loop is what resumes main-actor work (the debounced manifest
|
||||
// write, for example); the event dequeue above is what delivers input.
|
||||
RunLoop.current.run(until: Date(timeIntervalSinceNow: 0.005))
|
||||
} while Date() < deadline
|
||||
}
|
||||
|
||||
private static func check(_ condition: Bool, _ description: String) throws {
|
||||
guard condition else { throw SelfTestFailure(description) }
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private static func appendResult(_ line: String, to url: URL) {
|
||||
let existing = (try? String(contentsOf: url, encoding: .utf8)) ?? ""
|
||||
try? (existing + line + "\n").write(to: url, atomically: true, encoding: .utf8)
|
||||
print(line)
|
||||
}
|
||||
|
||||
/// Step logging that reaches the result file (the app is launched by LaunchServices,
|
||||
/// so its stdout is not captured).
|
||||
@MainActor private static var stepLogURL: URL?
|
||||
@MainActor private static weak var debugModel: AppModel?
|
||||
|
||||
/// A cheap change-detector for "did that click do anything".
|
||||
@MainActor
|
||||
private static func modelFingerprint() -> String {
|
||||
guard let model = debugModel else { return "" }
|
||||
return "\(model.session.id)-\(model.pastSessions.count)-"
|
||||
+ "\(model.selectedSessionID?.uuidString ?? "nil")"
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private static func modelLaneForDebug() -> String {
|
||||
debugModel?.session.context.lane ?? "<no model>"
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private static func note(_ line: String) {
|
||||
if let stepLogURL { appendResult("E2E STEP " + line, to: stepLogURL) }
|
||||
}
|
||||
|
||||
@discardableResult
|
||||
static func writeBackdatedSession(in paths: AppSupportPaths, daysAgo: Int) throws -> UUID {
|
||||
let id = UUID()
|
||||
let createdAt = Date().addingTimeInterval(-Double(daysAgo) * 86_400)
|
||||
let dir = paths.archiveDirectory(id)
|
||||
try FileManager.default.createDirectory(at: dir, withIntermediateDirectories: true)
|
||||
let pngName = "001-\(String(id.uuidString.prefix(8)).uppercased()).png"
|
||||
try makePNG(width: 16, height: 9, red: 0.4, green: 0.4, blue: 0.4)
|
||||
.write(to: dir.appendingPathComponent(pngName))
|
||||
let capture = Capture(
|
||||
id: UUID(), sequence: 1, fileName: pngName,
|
||||
pixelWidth: 16, pixelHeight: 9, scale: 1.0, capturedAt: createdAt)
|
||||
let session = CaptureSession(
|
||||
id: id, createdAt: createdAt, state: .archived, captures: [capture],
|
||||
pdfFileName: nil,
|
||||
context: ReviewContext(lane: "dev03", deployedVersion: "v0.9.0", commit: "0ldc0de"))
|
||||
let encoder = JSONEncoder()
|
||||
encoder.dateEncodingStrategy = .iso8601
|
||||
try encoder.encode(session).write(to: dir.appendingPathComponent("session.json"))
|
||||
return id
|
||||
}
|
||||
|
||||
static func makePNG(
|
||||
width: Int, height: Int, red: CGFloat, green: CGFloat, blue: CGFloat
|
||||
) throws -> Data {
|
||||
let colorSpace = CGColorSpaceCreateDeviceRGB()
|
||||
guard let context = CGContext(
|
||||
data: nil, width: width, height: height,
|
||||
bitsPerComponent: 8, bytesPerRow: width * 4, space: colorSpace,
|
||||
bitmapInfo: CGImageAlphaInfo.premultipliedLast.rawValue
|
||||
), let image = {
|
||||
context.setFillColor(red: red, green: green, blue: blue, alpha: 1)
|
||||
context.fill(CGRect(x: 0, y: 0, width: width, height: height))
|
||||
return context.makeImage()
|
||||
}() else {
|
||||
throw SelfTestFailure("could not draw a test PNG")
|
||||
}
|
||||
let data = NSMutableData()
|
||||
guard let destination = CGImageDestinationCreateWithData(
|
||||
data, "public.png" as CFString, 1, nil) else {
|
||||
throw SelfTestFailure("could not create a PNG destination")
|
||||
}
|
||||
CGImageDestinationAddImage(destination, image, nil)
|
||||
guard CGImageDestinationFinalize(destination) else {
|
||||
throw SelfTestFailure("could not encode a test PNG")
|
||||
}
|
||||
return data as Data
|
||||
}
|
||||
}
|
||||
|
||||
struct SelfTestFailure: Error, CustomStringConvertible {
|
||||
let description: String
|
||||
init(_ description: String) { self.description = description }
|
||||
}
|
||||
@@ -46,6 +46,11 @@ enum PanelSnapshot {
|
||||
|
||||
let region = sampleRegion()
|
||||
|
||||
// Two real past sessions through the REAL store paths (one sent with a PDF in
|
||||
// the outbox, one closed without ever sending) so panel-06b has the exact two
|
||||
// states the Past submissions window must distinguish.
|
||||
try await seedPastSessions(to: model)
|
||||
|
||||
// 01 — Screen Recording missing (no public mutator; snapshot-only seam).
|
||||
model.snapshotSetScreenRecordingGranted(false)
|
||||
model.replaceRegion(nil)
|
||||
@@ -61,6 +66,55 @@ enum PanelSnapshot {
|
||||
try renderMenuBar(model: model, to: directory, name: "03-empty-session")
|
||||
|
||||
// 04 — three real PNGs in the temp spool so SessionStrip thumbnails decode.
|
||||
try await addSampleCaptures(to: model)
|
||||
try renderMenuBar(model: model, to: directory, name: "04-captures-present")
|
||||
|
||||
// 05 — two inspected PDFs in the temp ledger, one marked / one not.
|
||||
try await seedReturns(model: model)
|
||||
try renderMenuBar(model: model, to: directory, name: "05-returns-present")
|
||||
|
||||
// 06 — SettingsView against the same isolated model.
|
||||
try render(
|
||||
SettingsView().environment(model),
|
||||
to: directory.appendingPathComponent("panel-06-settings.png"),
|
||||
width: 460,
|
||||
height: 560
|
||||
)
|
||||
|
||||
// 06b — the sessions window: real sidebar, pages grid and inspector.
|
||||
model.setPastSessions(try await model.spool.archivedSessions())
|
||||
try render(
|
||||
SessionsWindowView().environment(model),
|
||||
to: directory.appendingPathComponent("panel-06b-sessions-window.png"),
|
||||
width: 1100,
|
||||
height: 700
|
||||
)
|
||||
|
||||
// 15 — the window with a kept past session selected (read-only inspector).
|
||||
if let kept = model.pastSessions.first {
|
||||
model.selectSession(kept.id)
|
||||
try render(
|
||||
SessionsWindowView().environment(model),
|
||||
to: directory.appendingPathComponent("panel-15-past-session.png"),
|
||||
width: 1100,
|
||||
height: 700
|
||||
)
|
||||
model.selectSession(model.session.id)
|
||||
}
|
||||
|
||||
// A real PDF built by the production composer, so the reference footer and the
|
||||
// document info can be inspected (and opened) rather than assumed.
|
||||
try writeSamplePDF(to: directory.appendingPathComponent("sample-review.pdf"), model: model)
|
||||
|
||||
// 07/08/09 — OneDrive-mode Settings + menu bar, on a SEPARATE isolated model so
|
||||
// this transport switch never bleeds into the AirDrop-mode panels above.
|
||||
try await captureOneDrivePanels(to: directory)
|
||||
}
|
||||
|
||||
/// Three real PNGs appended to the given model's temp spool so SessionStrip
|
||||
/// thumbnails decode. Shared by panel 04 (AirDrop) and panel 09 (OneDrive).
|
||||
@MainActor
|
||||
private static func addSampleCaptures(to model: AppModel) async throws {
|
||||
let swatches: [(CGFloat, CGFloat, CGFloat)] = [
|
||||
(0.85, 0.22, 0.18),
|
||||
(0.18, 0.62, 0.32),
|
||||
@@ -77,16 +131,152 @@ enum PanelSnapshot {
|
||||
)
|
||||
}
|
||||
model.replaceSession(try await model.spool.currentSession())
|
||||
try renderMenuBar(model: model, to: directory, name: "04-captures-present")
|
||||
}
|
||||
|
||||
// 05 — two inspected PDFs in the temp ledger, one marked / one not.
|
||||
try await seedReturns(model: model)
|
||||
try renderMenuBar(model: model, to: directory, name: "05-returns-present")
|
||||
/// Panels 07-09: OneDrive transport, on its own isolated model/temp root so
|
||||
/// switching transport here never touches the AirDrop-mode model above, the real
|
||||
/// home directory, or UserDefaults.standard. The "resolved" and "not found" states
|
||||
/// are produced by calling the real OneDriveLocator functions against fake home
|
||||
/// trees built under this snapshot's own temp root — never a hand-typed path.
|
||||
@MainActor
|
||||
private static func captureOneDrivePanels(to directory: URL) async throws {
|
||||
let (model, root) = try makeIsolatedModel()
|
||||
defer { try? FileManager.default.removeItem(at: root) }
|
||||
model.setTransport(.oneDrive)
|
||||
|
||||
// 06 — SettingsView against the same isolated model.
|
||||
// 07 — a resolved OneDrive folder, shaped like the real default
|
||||
// (…/Library/CloudStorage/OneDrive-MMDGROUP/Redline): a fake home tree with a
|
||||
// real OneDrive-MMDGROUP directory under it, resolved via the same pure
|
||||
// OneDriveLocator function production code uses — never a hand-typed path.
|
||||
let fakeHomeWithOneDrive = root.appendingPathComponent("fake-home-with-onedrive", isDirectory: true)
|
||||
let syncRoot = fakeHomeWithOneDrive
|
||||
.appendingPathComponent("Library/CloudStorage/OneDrive-MMDGROUP", isDirectory: true)
|
||||
try FileManager.default.createDirectory(at: syncRoot, withIntermediateDirectories: true)
|
||||
guard let resolvedFolder = OneDriveLocator.defaultRedlineFolder(
|
||||
home: fakeHomeWithOneDrive, fileManager: .default
|
||||
) else {
|
||||
throw SnapshotError.oneDriveFixtureFailed("fake OneDrive-MMDGROUP root did not resolve")
|
||||
}
|
||||
model.setResolvedOneDriveFolder(resolvedFolder)
|
||||
try render(
|
||||
SettingsView().environment(model),
|
||||
to: directory.appendingPathComponent("panel-06-settings.png")
|
||||
to: directory.appendingPathComponent("panel-07-settings-onedrive.png"),
|
||||
width: 460,
|
||||
height: 560
|
||||
)
|
||||
|
||||
// 08 — no OneDrive folder found: a fake home with NO Library/CloudStorage at
|
||||
// all, and a throwaway UserDefaults suite (never .standard, never touched
|
||||
// before) so the stored-override check also legitimately finds nothing.
|
||||
let fakeHomeWithoutOneDrive = root.appendingPathComponent("fake-home-without-onedrive", isDirectory: true)
|
||||
try FileManager.default.createDirectory(at: fakeHomeWithoutOneDrive, withIntermediateDirectories: true)
|
||||
let isolatedDefaults = try makeIsolatedDefaultsSuite()
|
||||
defer { isolatedDefaults.defaults.removePersistentDomain(forName: isolatedDefaults.suiteName) }
|
||||
let missingFolder = OneDriveLocator.resolveOneDriveFolder(
|
||||
defaults: isolatedDefaults.defaults, home: fakeHomeWithoutOneDrive, fileManager: .default
|
||||
)
|
||||
guard missingFolder == nil else {
|
||||
throw SnapshotError.oneDriveFixtureFailed("fake home without OneDrive unexpectedly resolved")
|
||||
}
|
||||
model.setResolvedOneDriveFolder(nil)
|
||||
try render(
|
||||
SettingsView().environment(model),
|
||||
to: directory.appendingPathComponent("panel-08-settings-onedrive-missing.png"),
|
||||
width: 460,
|
||||
height: 560
|
||||
)
|
||||
|
||||
// 09 — menu bar panel, 3 captures present, OneDrive mode ("Send to OneDrive").
|
||||
model.snapshotSetScreenRecordingGranted(true)
|
||||
model.replaceRegion(sampleRegion())
|
||||
try await addSampleCaptures(to: model)
|
||||
try renderMenuBar(model: model, to: directory, name: "09-captures-present-onedrive")
|
||||
|
||||
// 10 — update idle: 3 captures, no update available, footer "Redline <ver>", row "Check for updates".
|
||||
let (updateModel, updateRoot) = try makeIsolatedModel()
|
||||
defer { try? FileManager.default.removeItem(at: updateRoot) }
|
||||
updateModel.snapshotSetScreenRecordingGranted(true)
|
||||
updateModel.replaceRegion(sampleRegion())
|
||||
try await addSampleCaptures(to: updateModel)
|
||||
// No update set, updateChecker in idle state, no previous version
|
||||
updateModel.snapshotSetPreviousVersion(nil)
|
||||
try renderMenuBar(model: updateModel, to: directory, name: "10-update-idle")
|
||||
|
||||
// 11 — update checking: same as 10 but isCheckingForUpdates = true.
|
||||
updateModel.snapshotSetIsCheckingForUpdates(true)
|
||||
try renderMenuBar(model: updateModel, to: directory, name: "11-update-checking")
|
||||
updateModel.snapshotSetIsCheckingForUpdates(false)
|
||||
|
||||
// 12 — update up-to-date: footer status line reads "Redline <ver> is up to date, checked 10:42 Dubai".
|
||||
let upToDateMessage = "Redline \(updateModel.appVersion) is up to date, checked 10:42 Dubai"
|
||||
updateModel.snapshotSetUpdateStatusMessage(upToDateMessage)
|
||||
try renderMenuBar(model: updateModel, to: directory, name: "12-update-uptodate")
|
||||
|
||||
// 13 — update staged: row "Update to 9.9.9" present, footer status "Update to 9.9.9 is ready".
|
||||
updateModel.snapshotSetUpdateAvailable(version: "9.9.9", notes: "Test release")
|
||||
updateModel.snapshotSetUpdateStatusMessage("Update to 9.9.9 is ready")
|
||||
try renderMenuBar(model: updateModel, to: directory, name: "13-update-staged")
|
||||
|
||||
// 14 — update revert: row "Revert to 0.2.0" present.
|
||||
updateModel.snapshotSetUpdateAvailable(version: nil, notes: nil) // Clear the staged update
|
||||
updateModel.snapshotSetUpdateStatusMessage(nil)
|
||||
updateModel.snapshotSetPreviousVersion("0.2.0")
|
||||
try renderMenuBar(model: updateModel, to: directory, name: "14-update-revert")
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private static func seedPastSessions(to model: AppModel) async throws {
|
||||
_ = try await model.spool.append(
|
||||
pngData: try makePNGData(width: 192, height: 108, red: 0.55, green: 0.35, blue: 0.85),
|
||||
pixelWidth: 192, pixelHeight: 108, scale: 2.0, capturedAt: Date())
|
||||
_ = try await model.spool.append(
|
||||
pngData: try makePNGData(width: 192, height: 108, red: 0.25, green: 0.7, blue: 0.6),
|
||||
pixelWidth: 192, pixelHeight: 108, scale: 2.0, capturedAt: Date())
|
||||
let sentSession = try await model.spool.setContext(
|
||||
ReviewContext(
|
||||
lane: "DEV03", deployedVersion: "v1.4.2 (41)", commit: "a1b2c3d4",
|
||||
reviewer: "Ben Hippler", note: "checkout flow"))
|
||||
let sentName = PDFFileName.make(
|
||||
builtAt: Date(), lane: sentSession.context.lane, sessionID: sentSession.id)
|
||||
_ = try await model.spool.archiveCurrent(pdfFileName: sentName)
|
||||
// The real send writes the PDF to the outbox; the fixture does the same so the
|
||||
// row's PDF action is genuinely live in the snapshot.
|
||||
try Data("%PDF-1.4\n% snapshot fixture\n".utf8).write(
|
||||
to: model.paths.outbox.appendingPathComponent(sentName))
|
||||
|
||||
_ = try await model.spool.append(
|
||||
pngData: try makePNGData(width: 160, height: 90, red: 0.9, green: 0.55, blue: 0.2),
|
||||
pixelWidth: 160, pixelHeight: 90, scale: 2.0, capturedAt: Date())
|
||||
_ = try await model.spool.setContext(
|
||||
ReviewContext(
|
||||
lane: "OMS test lane", deployedVersion: "v2.0.0-rc3", commit: "9f3e2d1",
|
||||
reviewer: "Ben Hippler"))
|
||||
_ = try await model.spool.closeCurrentSession()
|
||||
|
||||
// The live session shown in panels 03/04/05/15 carries details too.
|
||||
_ = try await model.spool.setContext(
|
||||
ReviewContext(
|
||||
lane: "DEV03", deployedVersion: "v1.4.2 (41)", commit: "a1b2c3d4",
|
||||
reviewer: "Ben Hippler", note: "dashboard review"))
|
||||
model.replaceSession(try await model.spool.currentSession())
|
||||
// Both seeded sessions are really on disk by now; load them into the model so
|
||||
// the panel's recent list is live rather than empty.
|
||||
model.setPastSessions(try await model.spool.archivedSessions())
|
||||
}
|
||||
|
||||
/// A real PDF from the production composer: one page per capture, header reference
|
||||
/// line and the review footer. Written next to the panels so it can be opened.
|
||||
@MainActor
|
||||
private static func writeSamplePDF(to url: URL, model: AppModel) throws {
|
||||
let session = model.session
|
||||
guard !session.isEmpty else { return }
|
||||
let sourceDir = model.paths.sessionDirectory(session.id)
|
||||
_ = try PDFComposer().compose(
|
||||
session: session,
|
||||
imageURL: { capture in sourceDir.appendingPathComponent(capture.fileName) },
|
||||
title: "Redline – \(session.context.lane) – \(DubaiTime.stamp(session.createdAt))",
|
||||
to: url,
|
||||
toolVersion: model.appVersion
|
||||
)
|
||||
}
|
||||
|
||||
@@ -99,18 +289,32 @@ enum PanelSnapshot {
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private static func render(_ view: some View, to url: URL) throws {
|
||||
let wrapped = view
|
||||
.frame(width: panelWidth, alignment: .topLeading)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
.background(Color(nsColor: .windowBackgroundColor))
|
||||
private static func render(
|
||||
_ view: some View,
|
||||
to url: URL,
|
||||
width: CGFloat = panelWidth,
|
||||
height: CGFloat? = nil
|
||||
) throws {
|
||||
// A fixed-size render (a whole window) must fill its frame; a popover render
|
||||
// sizes to its content. fixedSize on a split view collapses its columns.
|
||||
let wrapped = Group {
|
||||
if let height {
|
||||
view.frame(width: width, height: height)
|
||||
} else {
|
||||
view
|
||||
.frame(width: width, alignment: .topLeading)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
}
|
||||
}
|
||||
.frame(width: width, height: height, alignment: .topLeading)
|
||||
.background(Color(nsColor: .windowBackgroundColor))
|
||||
|
||||
let hosting = NSHostingView(rootView: wrapped)
|
||||
hosting.wantsLayer = true
|
||||
hosting.appearance = NSAppearance(named: .aqua)
|
||||
|
||||
let window = NSWindow(
|
||||
contentRect: NSRect(x: -10_000, y: -10_000, width: panelWidth, height: 64),
|
||||
contentRect: NSRect(x: -10_000, y: -10_000, width: width, height: 200),
|
||||
styleMask: [.borderless],
|
||||
backing: .buffered,
|
||||
defer: false
|
||||
@@ -125,17 +329,26 @@ enum PanelSnapshot {
|
||||
|
||||
hosting.layoutSubtreeIfNeeded()
|
||||
var size = hosting.fittingSize
|
||||
if size.height < 1 {
|
||||
size.height = hosting.intrinsicContentSize.height
|
||||
if let height {
|
||||
size.height = height
|
||||
} else {
|
||||
if size.height < 1 {
|
||||
size.height = hosting.intrinsicContentSize.height
|
||||
}
|
||||
if size.height < 1 { size.height = 240 }
|
||||
}
|
||||
if size.height < 1 { size.height = 240 }
|
||||
size.width = panelWidth
|
||||
size.width = width
|
||||
size.height = ceil(size.height)
|
||||
|
||||
hosting.setFrameSize(size)
|
||||
window.setContentSize(size)
|
||||
hosting.layoutSubtreeIfNeeded()
|
||||
RunLoop.current.run(until: Date(timeIntervalSinceNow: 0.05))
|
||||
// A split view (sidebar + inspector) needs a real display cycle before its
|
||||
// columns and list rows exist; a single layout pass renders blank columns.
|
||||
window.displayIfNeeded()
|
||||
RunLoop.current.run(until: Date(timeIntervalSinceNow: 0.35))
|
||||
hosting.layoutSubtreeIfNeeded()
|
||||
window.displayIfNeeded()
|
||||
|
||||
let bounds = hosting.bounds
|
||||
guard let rep = hosting.bitmapImageRepForCachingDisplay(in: bounds) else {
|
||||
@@ -163,6 +376,9 @@ enum PanelSnapshot {
|
||||
watchFolder: root.appendingPathComponent("watch", isDirectory: true)
|
||||
)
|
||||
let ledger = try ReturnLedger(paths: paths)
|
||||
// Isolated defaults: rendering a panel must never read or write the real
|
||||
// age-limit preference.
|
||||
let suite = try makeIsolatedDefaultsSuite()
|
||||
let model = AppModel(
|
||||
paths: paths,
|
||||
spool: try SpoolStore(paths: paths),
|
||||
@@ -171,12 +387,30 @@ enum PanelSnapshot {
|
||||
hotkeys: HotkeyCenter(),
|
||||
picker: RegionPickerController(),
|
||||
ledger: ledger,
|
||||
watcher: ReturnWatcher(paths: paths, ledger: ledger)
|
||||
watcher: ReturnWatcher(paths: paths, ledger: ledger),
|
||||
retentionDefaults: suite.defaults
|
||||
)
|
||||
model.setFolderURLs(outbox: paths.outbox, watch: paths.watchFolder)
|
||||
return (model, root)
|
||||
}
|
||||
|
||||
/// A throwaway UserDefaults suite — never `.standard` — for the panel-08 fixture,
|
||||
/// the same isolation pattern ShotdeckCoreTests uses for TransportSettings/
|
||||
/// OneDriveLocator tests.
|
||||
private struct IsolatedDefaultsSuite {
|
||||
let suiteName: String
|
||||
let defaults: UserDefaults
|
||||
}
|
||||
|
||||
private static func makeIsolatedDefaultsSuite() throws -> IsolatedDefaultsSuite {
|
||||
let suiteName = "shotdeck-panel-snapshot-\(UUID().uuidString)"
|
||||
guard let defaults = UserDefaults(suiteName: suiteName) else {
|
||||
throw SnapshotError.oneDriveFixtureFailed("could not create isolated UserDefaults suite")
|
||||
}
|
||||
defaults.removePersistentDomain(forName: suiteName)
|
||||
return IsolatedDefaultsSuite(suiteName: suiteName, defaults: defaults)
|
||||
}
|
||||
|
||||
@MainActor
|
||||
private static func seedReturns(model: AppModel) async throws {
|
||||
let watch = model.paths.watchFolder
|
||||
@@ -276,6 +510,40 @@ extension AppModel {
|
||||
)
|
||||
self[keyPath: writable] = granted
|
||||
}
|
||||
|
||||
/// Snapshot-only: set isCheckingForUpdates without triggering a real check.
|
||||
func snapshotSetIsCheckingForUpdates(_ checking: Bool) {
|
||||
let writable: ReferenceWritableKeyPath<AppModel, Bool> = unsafeBitCast(
|
||||
\AppModel.isCheckingForUpdates, to: ReferenceWritableKeyPath<AppModel, Bool>.self
|
||||
)
|
||||
self[keyPath: writable] = checking
|
||||
}
|
||||
|
||||
/// Snapshot-only: set updateStatusMessage for panel display.
|
||||
func snapshotSetUpdateStatusMessage(_ message: String?) {
|
||||
setUpdateStatus(message)
|
||||
}
|
||||
|
||||
/// Snapshot-only: set updateAvailable without triggering a real download.
|
||||
func snapshotSetUpdateAvailable(version: String?, notes: String?) {
|
||||
if let version = version, let notes = notes {
|
||||
let writable: ReferenceWritableKeyPath<AppModel, (version: String, notes: String)?> = unsafeBitCast(
|
||||
\AppModel.updateAvailable, to: ReferenceWritableKeyPath<AppModel, (version: String, notes: String)?>.self
|
||||
)
|
||||
self[keyPath: writable] = (version: version, notes: notes)
|
||||
} else {
|
||||
let writable: ReferenceWritableKeyPath<AppModel, (version: String, notes: String)?> = unsafeBitCast(
|
||||
\AppModel.updateAvailable, to: ReferenceWritableKeyPath<AppModel, (version: String, notes: String)?>.self
|
||||
)
|
||||
self[keyPath: writable] = nil
|
||||
}
|
||||
}
|
||||
|
||||
/// Snapshot-only: set a fake previousVersion for the revert panel.
|
||||
func snapshotSetPreviousVersion(_ version: String?) {
|
||||
updateChecker.snapshotPreviousVersionOverride = version
|
||||
updateChecker.snapshotUsesPreviousVersionOverride = true
|
||||
}
|
||||
}
|
||||
|
||||
private enum SnapshotError: Error, CustomStringConvertible {
|
||||
@@ -283,6 +551,7 @@ private enum SnapshotError: Error, CustomStringConvertible {
|
||||
case encodeFailed(String)
|
||||
case pngGenerationFailed
|
||||
case pdfWriteFailed(String)
|
||||
case oneDriveFixtureFailed(String)
|
||||
|
||||
var description: String {
|
||||
switch self {
|
||||
@@ -290,6 +559,7 @@ private enum SnapshotError: Error, CustomStringConvertible {
|
||||
case .encodeFailed(let name): return "PNG encode failed for \(name)"
|
||||
case .pngGenerationFailed: return "CoreGraphics PNG generation failed"
|
||||
case .pdfWriteFailed(let name): return "could not write \(name)"
|
||||
case .oneDriveFixtureFailed(let detail): return "OneDrive snapshot fixture failed: \(detail)"
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -3,6 +3,7 @@ import CoreGraphics
|
||||
import Darwin
|
||||
import Foundation
|
||||
import ImageIO
|
||||
import PDFKit
|
||||
import ShotdeckCore
|
||||
|
||||
/// In-process self-test for the region picker, driven by `SHOTDECK_PICKER_SELFTEST`.
|
||||
@@ -173,7 +174,7 @@ enum PickerSelfTest {
|
||||
try await executeSendTruth()
|
||||
print("SEND-TRUTH PASS")
|
||||
fflush(stdout)
|
||||
if !startUpdateSelfTestIfRequested() {
|
||||
if !startUpdateSelfTestIfRequested(), !startOneDriveSelfTestIfRequested() {
|
||||
exit(0)
|
||||
}
|
||||
} catch {
|
||||
@@ -222,7 +223,7 @@ enum PickerSelfTest {
|
||||
sendTruthFail("seeded session was empty")
|
||||
}
|
||||
|
||||
let pending = try await model.composePDFForSend()
|
||||
let pending = try await model.composePDFForSend(outbox: model.outboxURL, transport: .airDrop)
|
||||
guard fm.fileExists(atPath: pending.fileURL.path) else {
|
||||
sendTruthFail("PDF was not written")
|
||||
}
|
||||
@@ -240,7 +241,10 @@ enum PickerSelfTest {
|
||||
sendTruthFail("fail path status missing 'nothing was sent': \(model.statusLine ?? "nil")")
|
||||
}
|
||||
|
||||
await model.handleDidShareItems(fileName: pending.fileName, pageCount: pending.pageCount)
|
||||
let pageWord = pending.pageCount == 1 ? "page" : "pages"
|
||||
await model.handleDidShareItems(
|
||||
fileName: pending.fileName,
|
||||
sentSummary: "Sent — \(pending.pageCount) \(pageWord).")
|
||||
let fresh = try await model.spool.currentSession()
|
||||
guard fresh.isEmpty, fresh.id != openID, fresh.state == .open else {
|
||||
sendTruthFail("success path did not mint a fresh empty session")
|
||||
@@ -315,7 +319,9 @@ enum PickerSelfTest {
|
||||
try await runUpdateSelfTest(outputDirectory: output)
|
||||
print("UPDATE-SELFTEST PASS version=99.0.0")
|
||||
fflush(stdout)
|
||||
exit(0)
|
||||
if !startOneDriveSelfTestIfRequested() {
|
||||
exit(0)
|
||||
}
|
||||
} catch let error as UpdateSelfTestError {
|
||||
updateFail(error.description)
|
||||
} catch {
|
||||
@@ -573,6 +579,367 @@ enum PickerSelfTest {
|
||||
exit(1)
|
||||
}
|
||||
|
||||
/// Phase 5: proves the OneDrive transport end to end against a REAL sync root —
|
||||
/// resolved at runtime via `OneDriveLocator.syncRoots()`, never a hardcoded path, so
|
||||
/// this runs correctly on any Mac/account that has OneDrive signed in (MMD-named
|
||||
/// root preferred, same as production). Triggered by `SHOTDECK_ONEDRIVE_SELFTEST`
|
||||
/// when chained after PICKER/SEND-TRUTH/UPDATE-SELFTEST — the exact pattern
|
||||
/// `startUpdateSelfTestIfRequested` uses for its own env var. Returns true when the
|
||||
/// async phase was scheduled (it calls `exit` itself).
|
||||
@discardableResult
|
||||
private static func startOneDriveSelfTestIfRequested() -> Bool {
|
||||
guard ProcessInfo.processInfo.environment["SHOTDECK_ONEDRIVE_SELFTEST"] != nil else {
|
||||
return false
|
||||
}
|
||||
runOneDriveSelfTestAndExit()
|
||||
return true
|
||||
}
|
||||
|
||||
/// Entry point for running ONLY the SEND-TRUTH phase, bypassing the on-screen picker
|
||||
/// chain entirely — the chain's REGION-PERSIST phase needs an active display
|
||||
/// (CGDisplayIsActive) and exits before SEND-TRUTH in headless/remote sessions.
|
||||
/// Escape hatch: `REDLINE_SELFTEST_PHASE=sendtruth`.
|
||||
static func runSendTruthOnlyIfRequested() {
|
||||
guard ProcessInfo.processInfo.environment["REDLINE_SELFTEST_PHASE"] == "sendtruth" else {
|
||||
return
|
||||
}
|
||||
// Same hop as runOneDriveOnlyIfRequested(): a plain main-queue turn after NSApp
|
||||
// starts, so AppKit/PDFKit calls inside the phase are not racing app launch.
|
||||
DispatchQueue.main.async {
|
||||
MainActor.assumeIsolated {
|
||||
runSendTruthAndExit()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private static func runSendTruthAndExit() {
|
||||
Task { @MainActor in
|
||||
do {
|
||||
try await executeSendTruth()
|
||||
print("SEND-TRUTH PASS")
|
||||
fflush(stdout)
|
||||
exit(0)
|
||||
} catch {
|
||||
print("SEND-TRUTH FAIL \(error)")
|
||||
fflush(stdout)
|
||||
exit(1)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Entry point for running ONLY this phase, bypassing the on-screen picker chain
|
||||
/// entirely. The harness has no other per-phase selector, so this is the escape
|
||||
/// hatch: `REDLINE_SELFTEST_PHASE=onedrive`.
|
||||
static func runOneDriveOnlyIfRequested() {
|
||||
guard ProcessInfo.processInfo.environment["REDLINE_SELFTEST_PHASE"] == "onedrive" else {
|
||||
return
|
||||
}
|
||||
// Same hop as runIfRequested(): a plain main-queue turn after NSApp starts, so
|
||||
// AppKit/PDFKit calls inside the phase are not racing app launch.
|
||||
DispatchQueue.main.async {
|
||||
MainActor.assumeIsolated {
|
||||
runOneDriveSelfTestAndExit()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private static func runOneDriveSelfTestAndExit() {
|
||||
// Never a false PASS: no real OneDrive sync root on this machine/account is a
|
||||
// SKIP (still non-zero exit), not silently treated as passing.
|
||||
guard let syncRoot = OneDriveLocator.syncRoots().first else {
|
||||
print("ONEDRIVE-SELFTEST SKIP no OneDrive sync root")
|
||||
fflush(stdout)
|
||||
exit(1)
|
||||
}
|
||||
Task { @MainActor in
|
||||
do {
|
||||
let folder = try await executeOneDriveSelfTest(syncRoot: syncRoot)
|
||||
print("ONEDRIVE-SELFTEST PASS path=\(folder.path)")
|
||||
fflush(stdout)
|
||||
exit(0)
|
||||
} catch let error as OneDriveSelfTestError {
|
||||
oneDriveFail(error.description)
|
||||
} catch {
|
||||
oneDriveFail(String(describing: error))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Sub-step 1: builds a session, sends it through the OneDrive branch of
|
||||
/// `send(anchor: nil)` against a NEW folder under `syncRoot`, confirms the watcher
|
||||
/// does NOT report the freshly-written unmarked PDF as a return, then adds a real
|
||||
/// PDFKit ink annotation in place (what the iPad does) and confirms the watcher now
|
||||
/// reports it as commented.
|
||||
///
|
||||
/// Sub-step 1b: rapid transport toggling (chooseTransport(.airDrop) immediately
|
||||
/// followed by chooseTransport(.oneDrive), no await between them) must still end
|
||||
/// with the watcher pointed at the OneDrive folder — proves the generation-guarded
|
||||
/// reconcile in chooseTransport/chooseOneDriveFolder (SettingsView.swift) really
|
||||
/// does let the last choice win instead of an earlier, superseded call applying its
|
||||
/// stale folder after a later one already won.
|
||||
///
|
||||
/// Sub-step 1c: the OTHER race — a toggle immediately followed by Send, with no
|
||||
/// sleep at all before send() runs. Proves send() awaits `pendingReconcileTask`
|
||||
/// before snapshotting transport/folder: a freshly-sent, still-unmarked PDF must
|
||||
/// never be reported as an already-returned document (which is exactly what would
|
||||
/// happen if send() raced ahead while recordUncommented was still `true`, stale
|
||||
/// from the .airDrop leg of the toggle).
|
||||
///
|
||||
/// Sub-step 2: relaunch simulation — the exact BLOCKER scenario this phase exists to
|
||||
/// catch. OneDrive is still persisted in defaults from sub-step 1; builds a FRESH
|
||||
/// model the same way the real app launches (`AppDelegate.makeLaunchModel()` itself,
|
||||
/// not a reimplementation), bootstraps it, then marks a PDF in the folder in place —
|
||||
/// the relaunched watcher must report it. A temp app-support root keeps this off the
|
||||
/// real ~/Library/Application Support/Shotdeck.
|
||||
///
|
||||
/// Never deletes anything under OneDrive — the created folder and PDFs are left in
|
||||
/// place for Ben to inspect / for the real iPad round trip.
|
||||
private static func executeOneDriveSelfTest(syncRoot: URL) async throws -> URL {
|
||||
let fm = FileManager.default
|
||||
|
||||
// UserDefaults.standard is the ONLY defaults instance send()/TransportSettings
|
||||
// actually read at runtime (there is no defaults-threading through AppModel), so
|
||||
// "isolated" here means snapshot-and-restore around the real keys — the same
|
||||
// pattern runRegionPersistPhase already uses for CaptureRegion.defaultsKey.
|
||||
let defaults = UserDefaults.standard
|
||||
let previousTransport = defaults.string(forKey: TransportSettings.transportDefaultsKey)
|
||||
let previousFolder = defaults.string(forKey: TransportSettings.oneDriveFolderDefaultsKey)
|
||||
defer {
|
||||
if let previousTransport {
|
||||
defaults.set(previousTransport, forKey: TransportSettings.transportDefaultsKey)
|
||||
} else {
|
||||
defaults.removeObject(forKey: TransportSettings.transportDefaultsKey)
|
||||
}
|
||||
if let previousFolder {
|
||||
defaults.set(previousFolder, forKey: TransportSettings.oneDriveFolderDefaultsKey)
|
||||
} else {
|
||||
defaults.removeObject(forKey: TransportSettings.oneDriveFolderDefaultsKey)
|
||||
}
|
||||
}
|
||||
|
||||
let stamp = DubaiTime.fileStamp(Date())
|
||||
let selftestFolder = syncRoot.appendingPathComponent("Redline-selftest-\(stamp)", isDirectory: true)
|
||||
try fm.createDirectory(at: selftestFolder, withIntermediateDirectories: true)
|
||||
|
||||
TransportSettings.setTransport(.oneDrive, defaults: defaults)
|
||||
TransportSettings.setOneDriveFolder(selftestFolder, defaults: defaults)
|
||||
|
||||
// Local spool root only — the outbox/watch folder is the real OneDrive folder.
|
||||
let spoolRoot = fm.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-onedrive-selftest-\(UUID().uuidString)", isDirectory: true)
|
||||
defer { try? fm.removeItem(at: spoolRoot) }
|
||||
|
||||
let paths = try AppSupportPaths(root: spoolRoot, outbox: selftestFolder, watchFolder: selftestFolder)
|
||||
let ledger = try ReturnLedger(paths: paths)
|
||||
let watcher = ReturnWatcher(paths: paths, ledger: ledger)
|
||||
await watcher.setRecordUncommented(false) // OneDrive mode: today's default is AirDrop's `true`.
|
||||
|
||||
let model = AppModel(
|
||||
paths: paths,
|
||||
spool: try SpoolStore(paths: paths),
|
||||
composer: PDFComposer(),
|
||||
capturer: ScreenCapturer(),
|
||||
hotkeys: HotkeyCenter(),
|
||||
picker: RegionPickerController(),
|
||||
ledger: ledger,
|
||||
watcher: watcher
|
||||
)
|
||||
model.setFolderURLs(outbox: selftestFolder, watch: selftestFolder)
|
||||
model.setTransport(.oneDrive)
|
||||
|
||||
let png = try makeTinyPNGData()
|
||||
_ = try await model.spool.append(
|
||||
pngData: png, pixelWidth: 64, pixelHeight: 48, scale: 1, capturedAt: Date()
|
||||
)
|
||||
model.replaceSession(try await model.spool.currentSession())
|
||||
guard !model.session.isEmpty else {
|
||||
throw OneDriveSelfTestError.detail("seeded session was empty")
|
||||
}
|
||||
|
||||
await model.send(anchor: nil)
|
||||
|
||||
guard let status = model.statusLine, status.hasPrefix("Saved to OneDrive") else {
|
||||
throw OneDriveSelfTestError.detail(
|
||||
"status did not start with 'Saved to OneDrive': \(model.statusLine ?? "nil")"
|
||||
)
|
||||
}
|
||||
guard model.session.isEmpty else {
|
||||
throw OneDriveSelfTestError.detail("session was not archived after the OneDrive send")
|
||||
}
|
||||
|
||||
let written = (try? fm.contentsOfDirectory(at: selftestFolder, includingPropertiesForKeys: nil)) ?? []
|
||||
guard let pdfURL = written.first(where: { $0.pathExtension.lowercased() == "pdf" }) else {
|
||||
throw OneDriveSelfTestError.detail("no PDF found in \(selftestFolder.path)")
|
||||
}
|
||||
|
||||
// Unmarked so far: the watcher must not treat it as a return.
|
||||
let beforeMarkup = try await watcher.scanNow()
|
||||
guard !beforeMarkup.contains(where: { $0.fileURL == pdfURL }) else {
|
||||
throw OneDriveSelfTestError.detail("unmarked PDF was reported as returned by scanNow")
|
||||
}
|
||||
let commentedBefore = try await ledger.commented()
|
||||
guard !commentedBefore.contains(where: { $0.fileURL == pdfURL }) else {
|
||||
throw OneDriveSelfTestError.detail("unmarked PDF was recorded as commented in the ledger")
|
||||
}
|
||||
|
||||
// What the iPad does: mark it up in place with a real ink annotation, then save.
|
||||
try addInkMark(to: pdfURL)
|
||||
|
||||
let afterMarkup = try await watcher.scanNow()
|
||||
guard let recorded = afterMarkup.first(where: { $0.fileURL == pdfURL }), recorded.isCommented else {
|
||||
throw OneDriveSelfTestError.detail("annotated PDF was not reported as commented by scanNow")
|
||||
}
|
||||
let commentedAfter = try await ledger.commented()
|
||||
guard commentedAfter.contains(where: { $0.fileURL == pdfURL }) else {
|
||||
throw OneDriveSelfTestError.detail("annotated PDF was not recorded in the ledger as commented")
|
||||
}
|
||||
|
||||
// Sub-step 1b: rapid toggle race — see the doc comment above this function.
|
||||
model.chooseTransport(.airDrop)
|
||||
model.chooseTransport(.oneDrive) // immediately superseding the call above
|
||||
// The generation guard itself is what's under test, not this wait — it just
|
||||
// gives the (already-guarded) reconcile Task a moment to settle either way.
|
||||
try await Task.sleep(for: .milliseconds(500))
|
||||
guard model.transport == .oneDrive else {
|
||||
throw OneDriveSelfTestError.detail(
|
||||
"rapid toggle: model.transport ended as \(model.transport), expected .oneDrive"
|
||||
)
|
||||
}
|
||||
let racePDFURL = selftestFolder.appendingPathComponent("Redline-race-\(stamp).pdf")
|
||||
try writeUnmarkedRedlinePDF(to: racePDFURL)
|
||||
try addInkMark(to: racePDFURL)
|
||||
let raceFound = try await model.watcher.scanNow()
|
||||
guard raceFound.first(where: { $0.fileURL == racePDFURL })?.isCommented == true else {
|
||||
throw OneDriveSelfTestError.detail(
|
||||
"rapid toggle: watcher did not end up watching \(selftestFolder.path) — an earlier, superseded chooseTransport call won"
|
||||
)
|
||||
}
|
||||
|
||||
// Sub-step 1c: toggle-then-immediate-send race — see the doc comment above
|
||||
// this function. No sleep here: this IS the exact race window finding #3
|
||||
// exists to close, so send() itself must wait out the pending reconcile.
|
||||
let racePNG = try makeTinyPNGData()
|
||||
_ = try await model.spool.append(
|
||||
pngData: racePNG, pixelWidth: 64, pixelHeight: 48, scale: 1, capturedAt: Date()
|
||||
)
|
||||
model.replaceSession(try await model.spool.currentSession())
|
||||
guard !model.session.isEmpty else {
|
||||
throw OneDriveSelfTestError.detail("toggle-then-send: re-seeded session was empty")
|
||||
}
|
||||
|
||||
let knownBeforeToggleSend = Set(
|
||||
((try? fm.contentsOfDirectory(at: selftestFolder, includingPropertiesForKeys: nil)) ?? [])
|
||||
.map(\.lastPathComponent)
|
||||
)
|
||||
model.chooseTransport(.airDrop)
|
||||
model.chooseTransport(.oneDrive) // immediately superseding, no sleep before send()
|
||||
await model.send(anchor: nil)
|
||||
|
||||
guard let toggleSendStatus = model.statusLine, toggleSendStatus.hasPrefix("Saved to OneDrive") else {
|
||||
throw OneDriveSelfTestError.detail(
|
||||
"toggle-then-send: status was \(model.statusLine ?? "nil"), expected 'Saved to OneDrive'"
|
||||
)
|
||||
}
|
||||
guard model.session.isEmpty else {
|
||||
throw OneDriveSelfTestError.detail("toggle-then-send: session was not archived")
|
||||
}
|
||||
let filesAfterToggleSend = (try? fm.contentsOfDirectory(
|
||||
at: selftestFolder, includingPropertiesForKeys: nil
|
||||
)) ?? []
|
||||
guard let toggleSendPDFURL = filesAfterToggleSend.first(where: {
|
||||
$0.pathExtension.lowercased() == "pdf" && !knownBeforeToggleSend.contains($0.lastPathComponent)
|
||||
}) else {
|
||||
throw OneDriveSelfTestError.detail("toggle-then-send: no new PDF found in \(selftestFolder.path)")
|
||||
}
|
||||
// The freshly-sent PDF is UNMARKED. If send() had raced ahead of the pending
|
||||
// reconcile, recordUncommented could still have been (stale) true, and this
|
||||
// scan would wrongly report it as already returned.
|
||||
let scanAfterToggleSend = try await model.watcher.scanNow()
|
||||
guard !scanAfterToggleSend.contains(where: { $0.fileURL == toggleSendPDFURL }) else {
|
||||
throw OneDriveSelfTestError.detail(
|
||||
"toggle-then-send: freshly-sent unmarked PDF at \(toggleSendPDFURL.path) was reported as returned — send() raced ahead of the pending reconcile"
|
||||
)
|
||||
}
|
||||
|
||||
// Sub-step 2: relaunch simulation — see the doc comment above this function.
|
||||
let relaunchAppSupportRoot = fm.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-onedrive-relaunch-\(UUID().uuidString)", isDirectory: true)
|
||||
defer { try? fm.removeItem(at: relaunchAppSupportRoot) }
|
||||
|
||||
let relaunchModel = AppDelegate.makeLaunchModel(appSupportRoot: relaunchAppSupportRoot)
|
||||
guard relaunchModel.transport == .oneDrive else {
|
||||
throw OneDriveSelfTestError.detail(
|
||||
"relaunch: model transport was \(relaunchModel.transport), expected .oneDrive"
|
||||
)
|
||||
}
|
||||
guard relaunchModel.watchFolderURL.path == selftestFolder.path else {
|
||||
throw OneDriveSelfTestError.detail(
|
||||
"relaunch: model watchFolderURL was \(relaunchModel.watchFolderURL.path), expected \(selftestFolder.path) — this is the exact BLOCKER this phase guards against"
|
||||
)
|
||||
}
|
||||
|
||||
await relaunchModel.bootstrap()
|
||||
|
||||
let relaunchPDFURL = selftestFolder.appendingPathComponent("Redline-relaunch-\(stamp).pdf")
|
||||
try writeUnmarkedRedlinePDF(to: relaunchPDFURL)
|
||||
try addInkMark(to: relaunchPDFURL)
|
||||
|
||||
let relaunchFound = try await relaunchModel.watcher.scanNow()
|
||||
guard relaunchFound.first(where: { $0.fileURL == relaunchPDFURL })?.isCommented == true else {
|
||||
throw OneDriveSelfTestError.detail(
|
||||
"relaunch: watcher did not report the marked PDF at \(relaunchPDFURL.path) as returned — it was watching the wrong folder after relaunch"
|
||||
)
|
||||
}
|
||||
await relaunchModel.watcher.stop()
|
||||
|
||||
return selftestFolder
|
||||
}
|
||||
|
||||
/// Adds a real PDFKit ink annotation to the PDF at `url` in place and saves it —
|
||||
/// exactly what the iPad does when marking up a page.
|
||||
private static func addInkMark(to url: URL) throws {
|
||||
guard let document = PDFDocument(url: url), let page = document.page(at: 0) else {
|
||||
throw OneDriveSelfTestError.detail("could not reopen \(url.path) to annotate it")
|
||||
}
|
||||
let ink = PDFAnnotation(
|
||||
bounds: CGRect(x: 20, y: 20, width: 60, height: 60),
|
||||
forType: .ink,
|
||||
withProperties: nil
|
||||
)
|
||||
let stroke = NSBezierPath()
|
||||
stroke.move(to: NSPoint(x: 20, y: 20))
|
||||
stroke.line(to: NSPoint(x: 80, y: 80))
|
||||
ink.add(stroke)
|
||||
page.addAnnotation(ink)
|
||||
guard document.write(to: url) else {
|
||||
throw OneDriveSelfTestError.detail("could not save the annotated PDF back to \(url.path)")
|
||||
}
|
||||
}
|
||||
|
||||
/// Writes a fresh, unmarked, single-page "Redline"-creator PDF straight to `url` —
|
||||
/// standing in for a PDF that has just landed in the watch folder, before any
|
||||
/// human mark. Used by the rapid-toggle and relaunch sub-steps, which don't need to
|
||||
/// exercise send()/composePDFForSend() again (sub-step 1 already does).
|
||||
private static func writeUnmarkedRedlinePDF(to url: URL) throws {
|
||||
let document = PDFDocument()
|
||||
let page = PDFPage()
|
||||
page.setBounds(CGRect(x: 0, y: 0, width: 612, height: 792), for: .mediaBox)
|
||||
document.insert(page, at: 0)
|
||||
document.documentAttributes = [
|
||||
PDFDocumentAttribute.creatorAttribute: "Redline",
|
||||
PDFDocumentAttribute.subjectAttribute: UUID().uuidString,
|
||||
]
|
||||
guard document.write(to: url) else {
|
||||
throw OneDriveSelfTestError.detail("could not write \(url.path)")
|
||||
}
|
||||
}
|
||||
|
||||
private static func oneDriveFail(_ detail: String) -> Never {
|
||||
print("ONEDRIVE-SELFTEST FAIL \(detail)")
|
||||
fflush(stdout)
|
||||
exit(1)
|
||||
}
|
||||
|
||||
private static func interpolate(_ step: Int) -> NSPoint {
|
||||
let t = CGFloat(step) / CGFloat(dragSteps)
|
||||
return NSPoint(
|
||||
@@ -638,3 +1005,12 @@ private enum UpdateSelfTestError: Error, CustomStringConvertible {
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private enum OneDriveSelfTestError: Error, CustomStringConvertible {
|
||||
case detail(String)
|
||||
var description: String {
|
||||
switch self {
|
||||
case .detail(let s): return s
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -14,11 +14,75 @@ struct ComposedSend: Sendable {
|
||||
extension AppModel: SendCapable {
|
||||
public func send(anchor: NSView?) async {
|
||||
guard !session.isEmpty, !isSending else { return }
|
||||
// Same synchronous guard as AppModel.startNewSession(): refuse while a session
|
||||
// start is mid-flight, instead of composing from a session directory that is
|
||||
// being renamed into the archive.
|
||||
guard !isStartingNewSession else {
|
||||
setStatus("Finish starting the new session first.")
|
||||
return
|
||||
}
|
||||
setSending(true)
|
||||
|
||||
// Wait for any IN-FLIGHT transport/folder reconcile (chooseTransport/
|
||||
// chooseOneDriveFolder in SettingsView.swift) to fully settle BEFORE
|
||||
// snapshotting transport/folder below. Without this, a toggle immediately
|
||||
// followed by Send could let send() read a state that is still mid-transition
|
||||
// — e.g. the watcher's recordUncommented flag briefly lagging the just-chosen
|
||||
// transport, so a freshly-sent unmarked OneDrive PDF gets misreported as an
|
||||
// already-returned document. `Task<Void, Never>.value` never throws, and
|
||||
// awaiting nil is an immediate no-op (AirDrop mode, or no toggle in flight).
|
||||
await pendingReconcileTask?.value
|
||||
|
||||
// Snapshot BOTH the transport AND the destination folder into local `let`s
|
||||
// ONCE, before any further `await` in this function. chooseTransport/
|
||||
// chooseOneDriveFolder also refuse outright (status "Finish the current send
|
||||
// first.") while isSending is true, but this snapshot is the actual fix for the
|
||||
// send-vs-switch race: even without that guard, everything below operates on
|
||||
// these frozen values — composePDFForSend(outbox:transport:) takes both as
|
||||
// parameters and never re-reads `self.outboxURL`/`self.transport` after a
|
||||
// suspension point, so a concurrent transport switch mid-send can no longer
|
||||
// land the PDF under one transport's folder while the archive/status branch
|
||||
// runs the other's.
|
||||
let transport = TransportSettings.transport()
|
||||
let destinationFolder: URL
|
||||
|
||||
// OneDrive mode: verify the real destination exists, is writable, AND actually
|
||||
// accepts a real write RIGHT NOW, before composing anything. `isWritableDirectory`
|
||||
// alone is not enough — a OneDrive Files-On-Demand directory whose provider
|
||||
// domain is signed out can report as existing and POSIX-writable while an
|
||||
// actual write fails, so `probeWritable` writes-fsyncs-removes a tiny real probe
|
||||
// file to catch that. `outboxURL` is kept in sync with the resolved OneDrive
|
||||
// folder by bootstrap/chooseTransport/chooseOneDriveFolder, but this is
|
||||
// re-resolved fresh here (never trusted stale) so a folder that vanished or lost
|
||||
// its permissions since then (OneDrive signed out, external volume unmounted,
|
||||
// folder deleted, chmod'd unwritable) is caught instead of silently attempted
|
||||
// and surfacing as a generic PDF-composition failure.
|
||||
if transport == .oneDrive {
|
||||
guard let folder = OneDriveLocator.resolveOneDriveFolder(),
|
||||
OneDriveLocator.isWritableDirectory(at: folder),
|
||||
OneDriveLocator.probeWritable(at: folder)
|
||||
else {
|
||||
let path = OneDriveLocator.resolveOneDriveFolder()?.path
|
||||
?? TransportSettings.storedOneDriveFolderPath()
|
||||
?? "no OneDrive folder found"
|
||||
setResolvedOneDriveFolder(nil)
|
||||
setStatus(ShotdeckError.oneDriveFolderUnavailable(path: path).errorDescription)
|
||||
setSending(false)
|
||||
return
|
||||
}
|
||||
destinationFolder = folder
|
||||
setResolvedOneDriveFolder(folder)
|
||||
if outboxURL != folder || watchFolderURL != folder {
|
||||
setFolderURLs(outbox: folder, watch: folder)
|
||||
try? await watcher.updateWatchFolder(folder)
|
||||
}
|
||||
} else {
|
||||
destinationFolder = outboxURL
|
||||
}
|
||||
|
||||
let pending: ComposedSend
|
||||
do {
|
||||
pending = try await composePDFForSend()
|
||||
pending = try await composePDFForSend(outbox: destinationFolder, transport: transport)
|
||||
} catch {
|
||||
// Never unlink the published PDF, and never unlink the temp file either:
|
||||
// a rename failure would leave the complete document at the temp name.
|
||||
@@ -27,45 +91,73 @@ extension AppModel: SendCapable {
|
||||
return
|
||||
}
|
||||
|
||||
guard let anchor else {
|
||||
handleDidFailToShareItems(fileName: pending.fileName)
|
||||
switch transport {
|
||||
case .oneDrive:
|
||||
// No AirDrop, no anchor needed — the PDF is already in the watched
|
||||
// OneDrive folder. Archive immediately; the iPad marks it up in place.
|
||||
let pageWord = pending.pageCount == 1 ? "page" : "pages"
|
||||
await handleDidShareItems(
|
||||
fileName: pending.fileName,
|
||||
sentSummary: "Saved to OneDrive — \(pending.pageCount) \(pageWord). Open it in Files on your iPad."
|
||||
)
|
||||
setSending(false)
|
||||
return
|
||||
}
|
||||
|
||||
do {
|
||||
try Sharing.airDrop(fileURL: pending.fileURL, from: anchor) { [weak self] success in
|
||||
guard let self else { return }
|
||||
if success {
|
||||
await self.handleDidShareItems(
|
||||
fileName: pending.fileName,
|
||||
pageCount: pending.pageCount
|
||||
)
|
||||
} else {
|
||||
self.handleDidFailToShareItems(fileName: pending.fileName)
|
||||
case .airDrop:
|
||||
guard let anchor else {
|
||||
handleDidFailToShareItems(fileName: pending.fileName)
|
||||
setSending(false)
|
||||
return
|
||||
}
|
||||
|
||||
do {
|
||||
try Sharing.airDrop(fileURL: pending.fileURL, from: anchor) { [weak self] success in
|
||||
guard let self else { return }
|
||||
if success {
|
||||
let pageWord = pending.pageCount == 1 ? "page" : "pages"
|
||||
await self.handleDidShareItems(
|
||||
fileName: pending.fileName,
|
||||
sentSummary: "Sent — \(pending.pageCount) \(pageWord)."
|
||||
)
|
||||
} else {
|
||||
self.handleDidFailToShareItems(fileName: pending.fileName)
|
||||
}
|
||||
self.setSending(false)
|
||||
}
|
||||
self.setSending(false)
|
||||
} catch {
|
||||
// canPerform false, no service, or no visible window: same as cancel.
|
||||
handleDidFailToShareItems(fileName: pending.fileName)
|
||||
setSending(false)
|
||||
}
|
||||
} catch {
|
||||
// canPerform false, no service, or no visible window: same as cancel.
|
||||
handleDidFailToShareItems(fileName: pending.fileName)
|
||||
setSending(false)
|
||||
}
|
||||
}
|
||||
|
||||
/// Writes the PDF to the outbox and records its path. Does not archive the session
|
||||
/// Writes the PDF to `outboxDir` and records its path. Does not archive the session
|
||||
/// and does not present AirDrop — that happens only after the share completes.
|
||||
func composePDFForSend() async throws -> ComposedSend {
|
||||
/// `outboxDir`/`transport` are passed in (values `send(anchor:)` snapshotted before
|
||||
/// any await) rather than read from `self.outboxURL`/`self.transport` here, so a
|
||||
/// concurrent transport switch mid-send can never redirect an in-flight compose to
|
||||
/// a different folder. A write/rename failure specifically at the destination
|
||||
/// folder (as opposed to composer.compose()'s own session/image-content failures)
|
||||
/// is reported as `oneDriveFolderUnavailable` rather than the generic
|
||||
/// `pdfCompositionFailed` when `transport == .oneDrive` — the File Provider edge
|
||||
/// case where the folder looked writable moments ago in `send(anchor:)` but the
|
||||
/// actual write still failed (e.g. OneDrive signed out mid-write).
|
||||
func composePDFForSend(outbox outboxDir: URL, transport: SendTransport) async throws -> ComposedSend {
|
||||
let workingSession = session
|
||||
let composer = self.composer
|
||||
// Live outbox (FolderSettings), not `paths.outbox` — Settings changes take effect.
|
||||
let outboxDir = outboxURL
|
||||
let sourceDir = paths.sessionDirectory(workingSession.id)
|
||||
let fileName = PDFComposer.fileName(for: workingSession)
|
||||
let finalURL = outboxDir.appendingPathComponent(fileName)
|
||||
// Same directory as the final target so the rename below is same-volume (atomic).
|
||||
let tempURL = outboxDir.appendingPathComponent(".shotdeck-\(UUID().uuidString).pdf")
|
||||
let title = "Redline – \(DubaiTime.stamp(workingSession.createdAt))"
|
||||
// The document title follows the same three parts as the file name: tool,
|
||||
// lane (when recorded) and Dubai time.
|
||||
let lane = workingSession.context.lane
|
||||
let titleParts = ["Redline"]
|
||||
+ (lane.isEmpty ? [] : [lane])
|
||||
+ [DubaiTime.stamp(Date())]
|
||||
let title = titleParts.joined(separator: " – ")
|
||||
let toolVersion = appVersion
|
||||
|
||||
// D-13: build off the main actor. Only Sendable values cross into the
|
||||
// detached task — never `anchor` (NSView is not Sendable).
|
||||
@@ -74,19 +166,33 @@ extension AppModel: SendCapable {
|
||||
session: workingSession,
|
||||
imageURL: { capture in sourceDir.appendingPathComponent(capture.fileName) },
|
||||
title: title,
|
||||
to: tempURL
|
||||
to: tempURL,
|
||||
toolVersion: toolVersion
|
||||
)
|
||||
// POSIX rename onto `finalURL` replaces any same-name file in one
|
||||
// directory operation; there is never a window where the PDF is gone.
|
||||
if Darwin.rename(tempURL.path, finalURL.path) != 0 {
|
||||
if transport == .oneDrive {
|
||||
throw ShotdeckError.oneDriveFolderUnavailable(path: outboxDir.path)
|
||||
}
|
||||
throw ShotdeckError.pdfCompositionFailed(
|
||||
reason: "could not publish the PDF: \(String(cString: strerror(errno)))"
|
||||
)
|
||||
}
|
||||
try AtomicFile.fsyncDirectory(at: outboxDir)
|
||||
do {
|
||||
try AtomicFile.fsyncDirectory(at: outboxDir)
|
||||
} catch {
|
||||
if transport == .oneDrive {
|
||||
throw ShotdeckError.oneDriveFolderUnavailable(path: outboxDir.path)
|
||||
}
|
||||
throw error
|
||||
}
|
||||
}.value
|
||||
|
||||
guard FileManager.default.fileExists(atPath: finalURL.path) else {
|
||||
if transport == .oneDrive {
|
||||
throw ShotdeckError.oneDriveFolderUnavailable(path: outboxDir.path)
|
||||
}
|
||||
throw ShotdeckError.pdfCompositionFailed(reason: "the PDF was not written to disk")
|
||||
}
|
||||
rememberLastComposedPDF(finalURL)
|
||||
@@ -97,17 +203,32 @@ extension AppModel: SendCapable {
|
||||
)
|
||||
}
|
||||
|
||||
/// `NSSharingServiceDelegate.sharingService(_:didShareItems:)` seam.
|
||||
func handleDidShareItems(fileName: String, pageCount: Int) async {
|
||||
/// `NSSharingServiceDelegate.sharingService(_:didShareItems:)` seam — also the
|
||||
/// OneDrive completion path. Composes ONE truthful status from the caller's success
|
||||
/// summary (the share itself DID complete) plus, when they happened, the archive
|
||||
/// error and any state-refresh problem — nothing is overwritten or hidden.
|
||||
func handleDidShareItems(fileName: String, sentSummary: String) async {
|
||||
guard !session.isEmpty else { return }
|
||||
var message = sentSummary
|
||||
var archivedID: UUID?
|
||||
do {
|
||||
_ = try await spool.archiveCurrent(pdfFileName: fileName)
|
||||
replaceSession(try await spool.currentSession())
|
||||
let pageWord = pageCount == 1 ? "page" : "pages"
|
||||
setStatus("Sent — \(pageCount) \(pageWord).")
|
||||
archivedID = try await spool.archiveCurrent(pdfFileName: fileName).id
|
||||
} catch {
|
||||
setStatus((error as? ShotdeckError)?.errorDescription ?? "Could not archive the session.")
|
||||
message += " \((error as? ShotdeckError)?.errorDescription ?? "Could not archive the session.")"
|
||||
}
|
||||
// Refresh model state from the store on BOTH paths: after a successful archive
|
||||
// the current session and the past-submissions list are stale until reloaded,
|
||||
// and after a failure the store (not this model) knows whether the session
|
||||
// actually moved. Any refresh problem is appended to the status, never hidden.
|
||||
if let refreshProblem = await reloadFromSpool() {
|
||||
message += " \(refreshProblem)"
|
||||
}
|
||||
// Leave the window on the session that was just sent: that is what the person
|
||||
// is looking at when the PDF leaves.
|
||||
if let archivedID {
|
||||
selectSession(archivedID)
|
||||
}
|
||||
setStatus(message)
|
||||
}
|
||||
|
||||
/// `NSSharingServiceDelegate.sharingService(_:didFailToShareItems:error:)` seam,
|
||||
|
||||
@@ -0,0 +1,98 @@
|
||||
import SwiftUI
|
||||
import ShotdeckCore
|
||||
|
||||
/// The five review-detail fields of a session, in one compact grid.
|
||||
///
|
||||
/// Values are held locally while typing and written through to the session manifest
|
||||
/// on every change, so closing the panel cannot lose them. The local copy is re-seeded
|
||||
/// whenever the open session changes (a new session inherits the previous details).
|
||||
struct SessionContextEditor: View {
|
||||
@Environment(AppModel.self) private var model
|
||||
|
||||
@State private var lane = ""
|
||||
@State private var deployedVersion = ""
|
||||
@State private var commitHash = ""
|
||||
@State private var reviewer = ""
|
||||
@State private var note = ""
|
||||
@State private var seededSessionID: UUID?
|
||||
/// What this view last wrote (or seeded). Lets an out-of-band change — a context
|
||||
/// inherited by a new session, for example — refresh the fields without fighting
|
||||
/// the user's own keystrokes.
|
||||
@State private var lastKnownContext: ReviewContext = .empty
|
||||
/// The pending debounced write and its value. Typing replaces it, so one short
|
||||
/// pause writes once instead of once per keystroke, and an older write can never
|
||||
/// land after a newer one.
|
||||
@State private var pendingWrite: Task<Void, Never>?
|
||||
@State private var lastScheduledWrite: ReviewContext = .empty
|
||||
|
||||
private let labelWidth: CGFloat = 84
|
||||
|
||||
var body: some View {
|
||||
Grid(alignment: .leading, horizontalSpacing: 8, verticalSpacing: 4) {
|
||||
row("Lane", text: $lane, prompt: "dev03, customer test lane…")
|
||||
row("Deployed", text: $deployedVersion, prompt: "build that is live")
|
||||
row("Commit", text: $commitHash, prompt: "git SHA")
|
||||
row("Reviewer", text: $reviewer, prompt: "who is reviewing")
|
||||
row("Note", text: $note, prompt: "what this session covers")
|
||||
}
|
||||
.onAppear { seedIfNeeded() }
|
||||
.onChange(of: model.session.id) { _, _ in seedIfNeeded() }
|
||||
.onChange(of: model.session.context) { _, newValue in
|
||||
guard newValue != lastKnownContext else { return }
|
||||
seed(from: newValue)
|
||||
}
|
||||
.onChange(of: lane) { _, _ in commit() }
|
||||
.onChange(of: deployedVersion) { _, _ in commit() }
|
||||
.onChange(of: commitHash) { _, _ in commit() }
|
||||
.onChange(of: reviewer) { _, _ in commit() }
|
||||
.onChange(of: note) { _, _ in commit() }
|
||||
}
|
||||
|
||||
private func row(_ label: String, text: Binding<String>, prompt: String) -> some View {
|
||||
GridRow(alignment: .center) {
|
||||
Text(label)
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.frame(width: labelWidth, alignment: .trailing)
|
||||
TextField(prompt, text: text)
|
||||
.textFieldStyle(.roundedBorder)
|
||||
.font(.caption)
|
||||
.onSubmit { commit() }
|
||||
}
|
||||
}
|
||||
|
||||
private func seedIfNeeded() {
|
||||
guard seededSessionID != model.session.id else { return }
|
||||
seededSessionID = model.session.id
|
||||
seed(from: model.session.context)
|
||||
}
|
||||
|
||||
private func seed(from context: ReviewContext) {
|
||||
lane = context.lane
|
||||
deployedVersion = context.deployedVersion
|
||||
commitHash = context.commit
|
||||
reviewer = context.reviewer
|
||||
note = context.note
|
||||
lastKnownContext = context
|
||||
}
|
||||
|
||||
private func commit() {
|
||||
let context = ReviewContext(
|
||||
lane: lane,
|
||||
deployedVersion: deployedVersion,
|
||||
commit: commitHash,
|
||||
reviewer: reviewer,
|
||||
note: note
|
||||
)
|
||||
guard context != model.session.context else { return }
|
||||
guard context != lastScheduledWrite else { return }
|
||||
lastKnownContext = context
|
||||
lastScheduledWrite = context
|
||||
pendingWrite?.cancel()
|
||||
pendingWrite = Task {
|
||||
try? await Task.sleep(for: .milliseconds(150))
|
||||
guard !Task.isCancelled else { return }
|
||||
await model.setContextField(context)
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -2,22 +2,35 @@ import AppKit
|
||||
import SwiftUI
|
||||
import ShotdeckCore
|
||||
|
||||
/// The popover's page strip: at most `limit` thumbnails plus a "+N" tile, so the
|
||||
/// popover never turns into a filmstrip of the whole session.
|
||||
struct SessionStrip: View {
|
||||
@Environment(AppModel.self) private var model
|
||||
var limit: Int? = nil
|
||||
|
||||
var body: some View {
|
||||
let captures = Array(model.session.captures.prefix(limit ?? model.session.captures.count))
|
||||
let hidden = model.session.captures.count - captures.count
|
||||
|
||||
if model.session.captures.isEmpty {
|
||||
Text("Nothing captured yet.")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.frame(maxWidth: .infinity, minHeight: 64, alignment: .leading)
|
||||
} else {
|
||||
ScrollView(.horizontal, showsIndicators: false) {
|
||||
HStack(alignment: .top, spacing: 6) {
|
||||
ForEach(model.session.captures) { capture in
|
||||
SessionThumb(capture: capture)
|
||||
}
|
||||
HStack(alignment: .top, spacing: 6) {
|
||||
ForEach(captures) { capture in
|
||||
SessionThumb(capture: capture)
|
||||
}
|
||||
if hidden > 0 {
|
||||
Text("+\(hidden)")
|
||||
.font(.system(size: 11, weight: .semibold))
|
||||
.foregroundStyle(.secondary)
|
||||
.frame(width: 52, height: 64)
|
||||
.background(.quaternary.opacity(0.5), in: RoundedRectangle(cornerRadius: 4, style: .continuous))
|
||||
.help("\(hidden) more page\(hidden == 1 ? "" : "s") — open Redline to see them")
|
||||
}
|
||||
Spacer(minLength: 0)
|
||||
}
|
||||
.frame(height: 64)
|
||||
}
|
||||
@@ -63,7 +76,7 @@ private struct SessionThumb: View {
|
||||
|
||||
@ViewBuilder
|
||||
private var thumbnail: some View {
|
||||
let url = model.paths.sessionDirectory(model.session.id).appendingPathComponent(capture.fileName)
|
||||
let url = model.imageURL(for: capture, in: model.session)
|
||||
if let image = NSImage(contentsOf: url) {
|
||||
Image(nsImage: image)
|
||||
.resizable()
|
||||
|
||||
@@ -0,0 +1,689 @@
|
||||
import AppKit
|
||||
import SwiftUI
|
||||
import ShotdeckCore
|
||||
|
||||
/// The Redline window: every session on the left, the selected session's pages in the
|
||||
/// middle, and that session's review details / PDF / session facts on the right.
|
||||
/// This is where history, text entry and file facts live; the popover only glances at
|
||||
/// the current session and fires the two main actions.
|
||||
struct SessionsWindowView: View {
|
||||
@Environment(AppModel.self) private var model
|
||||
@State private var searchText = ""
|
||||
@State private var selectedCaptureID: UUID?
|
||||
@State private var showInspector = true
|
||||
|
||||
var body: some View {
|
||||
// Three explicit columns rather than NavigationSplitView: the window has a
|
||||
// fixed, always-visible inspector, and a plain split keeps the sidebar rows and
|
||||
// the inspector rendering deterministically in every window state.
|
||||
HStack(spacing: 0) {
|
||||
sidebar
|
||||
.frame(width: 230)
|
||||
Divider()
|
||||
detail
|
||||
.frame(maxWidth: .infinity, maxHeight: .infinity)
|
||||
if showInspector {
|
||||
Divider()
|
||||
SessionInspector(session: selectedSession)
|
||||
.frame(width: 300)
|
||||
}
|
||||
}
|
||||
.frame(minWidth: 900, minHeight: 560)
|
||||
.controlSize(.regular)
|
||||
.background(Color(nsColor: .windowBackgroundColor))
|
||||
.onChange(of: model.selectedSessionID) { _, _ in
|
||||
selectedCaptureID = nil
|
||||
}
|
||||
}
|
||||
|
||||
private var selectedSession: CaptureSession {
|
||||
model.selectedSession ?? model.session
|
||||
}
|
||||
|
||||
// MARK: - Sidebar
|
||||
|
||||
private var sidebar: some View {
|
||||
VStack(spacing: 0) {
|
||||
HStack(spacing: 6) {
|
||||
Image(systemName: "magnifyingglass")
|
||||
.foregroundStyle(.secondary)
|
||||
TextField("Search sessions", text: $searchText)
|
||||
.textFieldStyle(.plain)
|
||||
if !searchText.isEmpty {
|
||||
Button {
|
||||
searchText = ""
|
||||
} label: {
|
||||
Image(systemName: "xmark.circle.fill")
|
||||
.foregroundStyle(.secondary)
|
||||
}
|
||||
.buttonStyle(.plain)
|
||||
.accessibilityLabel("Clear search")
|
||||
}
|
||||
}
|
||||
.padding(.horizontal, 8)
|
||||
.padding(.vertical, 5)
|
||||
.background(.quaternary.opacity(0.5), in: RoundedRectangle(cornerRadius: 6, style: .continuous))
|
||||
.padding(8)
|
||||
|
||||
List(selection: selection) {
|
||||
ForEach(sections) { section in
|
||||
Section(section.title) {
|
||||
ForEach(section.sessions) { session in
|
||||
SessionRow(session: session)
|
||||
.tag(session.id)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
.listStyle(.sidebar)
|
||||
|
||||
if sections.isEmpty {
|
||||
Text(searchText.isEmpty ? "No sessions yet." : "No session matches “\(searchText)”.")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.multilineTextAlignment(.center)
|
||||
.padding(12)
|
||||
}
|
||||
}
|
||||
.background(Color(nsColor: .controlBackgroundColor))
|
||||
}
|
||||
|
||||
private var sections: [AppModel.SessionGroup] {
|
||||
model.groupedSections(for: model.sessions(matching: searchText))
|
||||
}
|
||||
|
||||
private var selection: Binding<UUID?> {
|
||||
Binding(
|
||||
get: { model.selectedSession?.id },
|
||||
set: { model.selectSession($0) }
|
||||
)
|
||||
}
|
||||
|
||||
// MARK: - Detail
|
||||
|
||||
private var detail: some View {
|
||||
VStack(alignment: .leading, spacing: 0) {
|
||||
header
|
||||
Divider()
|
||||
if let document = model.returnedDocument(for: selectedSession), document.isCommented {
|
||||
ReturnedBanner(document: document, session: selectedSession)
|
||||
Divider()
|
||||
}
|
||||
pages
|
||||
}
|
||||
.background(Color(nsColor: .textBackgroundColor))
|
||||
}
|
||||
|
||||
private var header: some View {
|
||||
HStack(alignment: .center, spacing: 10) {
|
||||
VStack(alignment: .leading, spacing: 1) {
|
||||
HStack(spacing: 6) {
|
||||
Text(laneTitle)
|
||||
.font(.system(size: 15, weight: .semibold))
|
||||
.lineLimit(1)
|
||||
.truncationMode(.tail)
|
||||
if model.selectedIsCurrent {
|
||||
Text("Current")
|
||||
.font(.system(size: 9, weight: .semibold))
|
||||
.padding(.horizontal, 5)
|
||||
.padding(.vertical, 1)
|
||||
.background(.quaternary, in: Capsule())
|
||||
}
|
||||
}
|
||||
Text(subtitle)
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.lineLimit(1)
|
||||
}
|
||||
.layoutPriority(0)
|
||||
Spacer(minLength: 12)
|
||||
Button {
|
||||
showInspector.toggle()
|
||||
} label: {
|
||||
Image(systemName: "sidebar.right")
|
||||
}
|
||||
.buttonStyle(.borderless)
|
||||
.help(showInspector ? "Hide the inspector" : "Show the inspector")
|
||||
.accessibilityLabel(showInspector ? "Hide the inspector" : "Show the inspector")
|
||||
|
||||
Button {
|
||||
Task { await model.startNewSession() }
|
||||
} label: {
|
||||
Label("New Session", systemImage: "plus.square.on.square")
|
||||
}
|
||||
.keyboardShortcut("n", modifiers: .command)
|
||||
.disabled(!model.canStartNewSession)
|
||||
.fixedSize()
|
||||
.help("Keep this session and start a fresh one (⌘N)")
|
||||
|
||||
Button {
|
||||
Task { await model.captureNow() }
|
||||
} label: {
|
||||
Label(model.isCapturing ? "Capturing…" : "Capture", systemImage: "viewfinder")
|
||||
}
|
||||
.disabled(model.isCapturing || !model.selectedIsCurrent)
|
||||
.fixedSize()
|
||||
|
||||
Button {
|
||||
guard let sender = model as? SendCapable else { return }
|
||||
let anchor = NSApp.keyWindow?.contentView
|
||||
Task { await sender.send(anchor: anchor) }
|
||||
} label: {
|
||||
Label(sendTitle, systemImage: "paperplane.fill")
|
||||
}
|
||||
.buttonStyle(.borderedProminent)
|
||||
.layoutPriority(1)
|
||||
.keyboardShortcut("s", modifiers: .command)
|
||||
.disabled(!model.selectedIsCurrent || model.session.isEmpty || model.isSending)
|
||||
.help(model.transport == .oneDrive
|
||||
? "Save the PDF to the OneDrive folder (⌘S)"
|
||||
: "AirDrop the PDF (⌘S)")
|
||||
}
|
||||
.padding(.horizontal, 16)
|
||||
.padding(.vertical, 10)
|
||||
}
|
||||
|
||||
private var laneTitle: String {
|
||||
let lane = selectedSession.context.lane
|
||||
if !lane.isEmpty { return lane }
|
||||
return selectedSession.id == model.session.id ? "Current session" : selectedSession.shortID
|
||||
}
|
||||
|
||||
private var subtitle: String {
|
||||
let pages = selectedSession.captures.count
|
||||
let pageWord = "\(pages) page\(pages == 1 ? "" : "s")"
|
||||
return "\(pageWord) · \(model.state(of: selectedSession).label)"
|
||||
}
|
||||
|
||||
private var sendTitle: String {
|
||||
model.transport == .oneDrive ? "Save…" : "Send…"
|
||||
}
|
||||
|
||||
// MARK: - Pages
|
||||
|
||||
@ViewBuilder
|
||||
private var pages: some View {
|
||||
if selectedSession.isEmpty {
|
||||
emptyState
|
||||
} else {
|
||||
ScrollView {
|
||||
VStack(alignment: .leading, spacing: 12) {
|
||||
HStack(alignment: .firstTextBaseline, spacing: 8) {
|
||||
Text("Pages")
|
||||
.font(.headline)
|
||||
Text(pagesCaption)
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
Spacer(minLength: 8)
|
||||
Button("Remove Page") {
|
||||
removeSelectedPage()
|
||||
}
|
||||
.disabled(!model.selectedIsCurrent || selectedCaptureID == nil)
|
||||
}
|
||||
LazyVGrid(
|
||||
columns: [GridItem(.adaptive(minimum: 200, maximum: 240), spacing: 16)],
|
||||
alignment: .leading,
|
||||
spacing: 18
|
||||
) {
|
||||
ForEach(selectedSession.captures) { capture in
|
||||
PageCard(
|
||||
capture: capture,
|
||||
session: selectedSession,
|
||||
isSelected: selectedCaptureID == capture.id,
|
||||
canRemove: model.selectedIsCurrent
|
||||
) {
|
||||
selectedCaptureID = capture.id
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
.padding(16)
|
||||
}
|
||||
.onDeleteCommand { removeSelectedPage() }
|
||||
}
|
||||
}
|
||||
|
||||
private var pagesCaption: String {
|
||||
model.selectedIsCurrent
|
||||
? "In PDF order · Delete removes the selected page"
|
||||
: "In the order they were sent"
|
||||
}
|
||||
|
||||
private var emptyState: some View {
|
||||
VStack(spacing: 10) {
|
||||
Image(systemName: "viewfinder")
|
||||
.font(.system(size: 28, weight: .light))
|
||||
.foregroundStyle(.secondary)
|
||||
Text("No pages in this session")
|
||||
.font(.headline)
|
||||
Text(emptyStateDetail)
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.multilineTextAlignment(.center)
|
||||
.frame(maxWidth: 320)
|
||||
HStack(spacing: 8) {
|
||||
Button("Choose Area…") {
|
||||
Task { await model.rePickRegion() }
|
||||
}
|
||||
Button("Capture \(model.hotkeyDisplayString)") {
|
||||
Task { await model.captureNow() }
|
||||
}
|
||||
.buttonStyle(.borderedProminent)
|
||||
}
|
||||
.padding(.top, 4)
|
||||
}
|
||||
.frame(maxWidth: .infinity, maxHeight: .infinity)
|
||||
.padding(24)
|
||||
}
|
||||
|
||||
private var emptyStateDetail: String {
|
||||
if model.region == nil {
|
||||
return "Choose the part of the screen you review, then capture it. Each capture becomes one page of the PDF."
|
||||
}
|
||||
return "Press \(model.hotkeyDisplayString) to capture the saved area. Each capture becomes one page of the PDF."
|
||||
}
|
||||
|
||||
private func removeSelectedPage() {
|
||||
guard model.selectedIsCurrent, let id = selectedCaptureID else { return }
|
||||
selectedCaptureID = nil
|
||||
Task { await model.removeCapture(id: id) }
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - Sidebar row
|
||||
|
||||
private struct SessionRow: View {
|
||||
@Environment(AppModel.self) private var model
|
||||
let session: CaptureSession
|
||||
|
||||
var body: some View {
|
||||
let state = model.state(of: session)
|
||||
VStack(alignment: .leading, spacing: 1) {
|
||||
HStack(spacing: 5) {
|
||||
Text(lane)
|
||||
.lineLimit(1)
|
||||
if state == .current {
|
||||
Text("Current")
|
||||
.font(.system(size: 9, weight: .semibold))
|
||||
.padding(.horizontal, 5)
|
||||
.padding(.vertical, 1)
|
||||
.background(.quaternary, in: Capsule())
|
||||
}
|
||||
Spacer(minLength: 4)
|
||||
Text(DubaiTime.checkTime(session.createdAt))
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.monospacedDigit()
|
||||
}
|
||||
Text(detail(state))
|
||||
.font(.caption)
|
||||
.foregroundStyle(state.isReturned ? AnyShapeStyle(.orange) : AnyShapeStyle(.secondary))
|
||||
.lineLimit(1)
|
||||
}
|
||||
.padding(.vertical, 2)
|
||||
.accessibilityElement(children: .combine)
|
||||
.accessibilityLabel("\(lane), \(DubaiTime.checkTime(session.createdAt)), \(session.captures.count) pages, \(state.label)")
|
||||
}
|
||||
|
||||
private var lane: String {
|
||||
let lane = session.context.lane
|
||||
return lane.isEmpty ? session.shortID : lane
|
||||
}
|
||||
|
||||
private func detail(_ state: AppModel.SessionDisplayState) -> String {
|
||||
let pages = "\(session.captures.count) page\(session.captures.count == 1 ? "" : "s")"
|
||||
if case .returned(let marked) = state {
|
||||
return "\(pages) · came back with \(marked) page\(marked == 1 ? "" : "s") marked"
|
||||
}
|
||||
return "\(pages) · \(state.label)"
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - Page card
|
||||
|
||||
private struct PageCard: View {
|
||||
@Environment(AppModel.self) private var model
|
||||
let capture: Capture
|
||||
let session: CaptureSession
|
||||
let isSelected: Bool
|
||||
let canRemove: Bool
|
||||
let select: () -> Void
|
||||
@State private var hovering = false
|
||||
|
||||
var body: some View {
|
||||
VStack(alignment: .leading, spacing: 5) {
|
||||
ZStack(alignment: .topLeading) {
|
||||
thumbnail
|
||||
if hovering && canRemove {
|
||||
Button("Remove") {
|
||||
Task { await model.removeCapture(id: capture.id) }
|
||||
}
|
||||
.font(.caption2.weight(.semibold))
|
||||
.buttonStyle(.plain)
|
||||
.foregroundStyle(.white)
|
||||
.padding(.horizontal, 6)
|
||||
.padding(.vertical, 2)
|
||||
.background(.black.opacity(0.65), in: Capsule())
|
||||
.padding(6)
|
||||
}
|
||||
}
|
||||
.overlay {
|
||||
RoundedRectangle(cornerRadius: 5, style: .continuous)
|
||||
.strokeBorder(isSelected ? Color.accentColor : .clear, lineWidth: 2)
|
||||
}
|
||||
.frame(maxWidth: 240, alignment: .leading)
|
||||
.onHover { hovering = $0 }
|
||||
.onTapGesture(perform: select)
|
||||
|
||||
HStack(spacing: 6) {
|
||||
Text("Page \(capture.sequence)")
|
||||
.font(.caption.weight(isSelected ? .semibold : .regular))
|
||||
Spacer(minLength: 4)
|
||||
Text(DubaiTime.checkTime(capture.capturedAt))
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.monospacedDigit()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@ViewBuilder
|
||||
private var thumbnail: some View {
|
||||
let url = model.imageURL(for: capture, in: session)
|
||||
if let image = NSImage(contentsOf: url) {
|
||||
Image(nsImage: image)
|
||||
.resizable()
|
||||
.aspectRatio(contentMode: .fit)
|
||||
.frame(maxWidth: .infinity)
|
||||
.clipShape(RoundedRectangle(cornerRadius: 4, style: .continuous))
|
||||
.overlay {
|
||||
RoundedRectangle(cornerRadius: 4, style: .continuous)
|
||||
.strokeBorder(.quaternary, lineWidth: 0.5)
|
||||
}
|
||||
} else {
|
||||
RoundedRectangle(cornerRadius: 4, style: .continuous)
|
||||
.fill(.quaternary)
|
||||
.frame(height: 96)
|
||||
.overlay {
|
||||
Text("Image missing")
|
||||
.font(.caption2)
|
||||
.foregroundStyle(.secondary)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - Returned banner
|
||||
|
||||
private struct ReturnedBanner: View {
|
||||
@Environment(AppModel.self) private var model
|
||||
let document: ReturnedDocument
|
||||
let session: CaptureSession
|
||||
|
||||
var body: some View {
|
||||
HStack(spacing: 8) {
|
||||
Image(systemName: "pencil.and.outline")
|
||||
.foregroundStyle(.orange)
|
||||
Text(message)
|
||||
.font(.callout)
|
||||
Spacer(minLength: 8)
|
||||
Button("Open PDF") {
|
||||
NSWorkspace.shared.open(document.fileURL)
|
||||
}
|
||||
if model.sentPDFURL(for: session) != nil {
|
||||
Button("Show Original") {
|
||||
model.revealSentPDF(session)
|
||||
}
|
||||
}
|
||||
}
|
||||
.padding(.horizontal, 16)
|
||||
.padding(.vertical, 8)
|
||||
.background(.orange.opacity(0.1))
|
||||
}
|
||||
|
||||
private var message: String {
|
||||
let marked = document.annotatedPages.count
|
||||
return "Came back with marks on \(marked) page\(marked == 1 ? "" : "s")."
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - Inspector
|
||||
|
||||
private struct SessionInspector: View {
|
||||
@Environment(AppModel.self) private var model
|
||||
let session: CaptureSession
|
||||
|
||||
var body: some View {
|
||||
ScrollView {
|
||||
VStack(alignment: .leading, spacing: 16) {
|
||||
reviewDetails
|
||||
if !model.selectedIsCurrent {
|
||||
Text("Past sessions are read-only: the PDF already carries these values.")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
}
|
||||
pdfFacts
|
||||
sessionFacts
|
||||
}
|
||||
.padding(14)
|
||||
}
|
||||
.background(Color(nsColor: .windowBackgroundColor))
|
||||
}
|
||||
|
||||
private var reviewDetails: some View {
|
||||
VStack(alignment: .leading, spacing: 6) {
|
||||
Text("Review details")
|
||||
.font(.headline)
|
||||
GroupBox {
|
||||
VStack(spacing: 0) {
|
||||
contextRow("Lane", prompt: "dev03, customer test lane…", \.lane, focusOnRequest: true)
|
||||
RowDivider()
|
||||
contextRow("Deployed", prompt: "build that is live", \.deployedVersion)
|
||||
RowDivider()
|
||||
contextRow("Commit", prompt: "git SHA", \.commit)
|
||||
RowDivider()
|
||||
contextRow("Reviewer", prompt: "who is reviewing", \.reviewer)
|
||||
RowDivider()
|
||||
contextRow("Note", prompt: "what this session covers", \.note)
|
||||
}
|
||||
}
|
||||
Text("Printed on every page of the PDF. A new session starts with these values.")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
}
|
||||
}
|
||||
|
||||
@ViewBuilder
|
||||
private func contextRow(
|
||||
_ label: String,
|
||||
prompt: String,
|
||||
_ field: WritableKeyPath<ReviewContext, String>,
|
||||
focusOnRequest: Bool = false
|
||||
) -> some View {
|
||||
if model.selectedIsCurrent {
|
||||
EditableContextRow(label: label, prompt: prompt, field: field, focusOnRequest: focusOnRequest)
|
||||
} else {
|
||||
HStack(alignment: .firstTextBaseline, spacing: 8) {
|
||||
Text(label)
|
||||
.foregroundStyle(.secondary)
|
||||
.frame(width: 74, alignment: .leading)
|
||||
Text(displayValue(field))
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
.textSelection(.enabled)
|
||||
}
|
||||
.padding(.vertical, 5)
|
||||
}
|
||||
}
|
||||
|
||||
private func displayValue(_ field: KeyPath<ReviewContext, String>) -> String {
|
||||
let value = session.context[keyPath: field]
|
||||
return value.isEmpty ? "—" : value
|
||||
}
|
||||
|
||||
private var pdfFacts: some View {
|
||||
VStack(alignment: .leading, spacing: 6) {
|
||||
Text("PDF")
|
||||
.font(.headline)
|
||||
GroupBox {
|
||||
VStack(spacing: 0) {
|
||||
FactRow(label: "File name", value: pdfFileName, selectable: true)
|
||||
RowDivider()
|
||||
FactRow(label: "Pages", value: "\(session.captures.count)")
|
||||
RowDivider()
|
||||
FactRow(
|
||||
label: "Sends via",
|
||||
value: model.transport == .oneDrive ? "OneDrive folder" : "AirDrop")
|
||||
RowDivider()
|
||||
FactRow(label: "Status", value: model.state(of: session).label)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private var pdfFileName: String {
|
||||
if let name = session.pdfFileName { return name }
|
||||
return model.selectedIsCurrent ? model.nextPDFFileNameHint : "—"
|
||||
}
|
||||
|
||||
private var sessionFacts: some View {
|
||||
VStack(alignment: .leading, spacing: 6) {
|
||||
Text("Session")
|
||||
.font(.headline)
|
||||
GroupBox {
|
||||
VStack(spacing: 0) {
|
||||
FactRow(label: "Started", value: DubaiTime.stamp(session.createdAt))
|
||||
RowDivider()
|
||||
FactRow(label: "ID", value: session.shortID, monospaced: true)
|
||||
RowDivider()
|
||||
HStack {
|
||||
Text("Files")
|
||||
.foregroundStyle(.secondary)
|
||||
Spacer(minLength: 8)
|
||||
Button(model.selectedIsCurrent ? "Show Captures" : "Show in Finder") {
|
||||
model.revealSessionCaptures(session)
|
||||
}
|
||||
.buttonStyle(.link)
|
||||
}
|
||||
.padding(.vertical, 5)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private struct RowDivider: View {
|
||||
var body: some View {
|
||||
Divider().padding(.leading, 0)
|
||||
}
|
||||
}
|
||||
|
||||
/// One editable review-detail row. The text lives in local state while typing and is
|
||||
/// written through to the open session's manifest; it re-seeds whenever the session's
|
||||
/// stored details change underneath it (a new session inheriting them, for example).
|
||||
private struct EditableContextRow: View {
|
||||
@Environment(AppModel.self) private var model
|
||||
let label: String
|
||||
let prompt: String
|
||||
let field: WritableKeyPath<ReviewContext, String>
|
||||
let focusOnRequest: Bool
|
||||
|
||||
@State private var text: String = ""
|
||||
@State private var lastSynced: String = ""
|
||||
@FocusState private var focused: Bool
|
||||
|
||||
var body: some View {
|
||||
HStack(spacing: 8) {
|
||||
Text(label)
|
||||
.foregroundStyle(.secondary)
|
||||
.frame(width: 74, alignment: .leading)
|
||||
TextField(prompt, text: $text)
|
||||
.textFieldStyle(.roundedBorder)
|
||||
.controlSize(.small)
|
||||
.focused($focused)
|
||||
.accessibilityLabel(label)
|
||||
.onSubmit { push() }
|
||||
.onChange(of: text) { _, _ in push() }
|
||||
}
|
||||
.padding(.vertical, 5)
|
||||
.onAppear { seed(from: stored) }
|
||||
.onChange(of: model.session.context) { _, newValue in
|
||||
let incoming = newValue[keyPath: field]
|
||||
guard incoming != lastSynced else { return }
|
||||
seed(from: incoming)
|
||||
}
|
||||
.onChange(of: model.session.id) { _, _ in
|
||||
seed(from: stored)
|
||||
}
|
||||
.onChange(of: model.laneFocusRequest) { _, _ in
|
||||
if focusOnRequest { focused = true }
|
||||
}
|
||||
}
|
||||
|
||||
private var stored: String {
|
||||
model.session.context[keyPath: field]
|
||||
}
|
||||
|
||||
private func seed(from value: String) {
|
||||
text = value
|
||||
lastSynced = value
|
||||
}
|
||||
|
||||
private func push() {
|
||||
guard text != lastSynced else { return }
|
||||
lastSynced = text
|
||||
model.updateContext(field, text)
|
||||
}
|
||||
}
|
||||
|
||||
private struct FactRow: View {
|
||||
let label: String
|
||||
let value: String
|
||||
var monospaced: Bool = false
|
||||
var selectable: Bool = false
|
||||
|
||||
var body: some View {
|
||||
HStack(alignment: .firstTextBaseline, spacing: 8) {
|
||||
Text(label)
|
||||
.foregroundStyle(.secondary)
|
||||
Spacer(minLength: 8)
|
||||
Text(value)
|
||||
.font(monospaced ? .system(.body, design: .monospaced) : .body)
|
||||
.lineLimit(1)
|
||||
.truncationMode(.middle)
|
||||
.textSelection(.enabled)
|
||||
.help(value)
|
||||
}
|
||||
.padding(.vertical, 5)
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - Window presentation
|
||||
|
||||
extension AppModel: SessionsWindowPresenting {
|
||||
private static var sessionsWindowController: NSWindowController?
|
||||
|
||||
public func presentSessionsWindow(focusLane: Bool) {
|
||||
if focusLane { requestLaneFocus() }
|
||||
if let existing = Self.sessionsWindowController {
|
||||
existing.window?.makeKeyAndOrderFront(nil)
|
||||
NSApp.activate()
|
||||
return
|
||||
}
|
||||
let hosting = NSHostingController(rootView: SessionsWindowView().environment(self))
|
||||
let window = NSWindow(contentViewController: hosting)
|
||||
window.title = "Redline"
|
||||
window.styleMask = [.titled, .closable, .miniaturizable, .resizable, .fullSizeContentView]
|
||||
window.titlebarAppearsTransparent = false
|
||||
window.isReleasedWhenClosed = false
|
||||
window.setContentSize(NSSize(width: 1240, height: 760))
|
||||
window.minSize = NSSize(width: 1000, height: 600)
|
||||
window.center()
|
||||
window.setFrameAutosaveName("RedlineSessionsWindow")
|
||||
let controller = NSWindowController(window: window)
|
||||
Self.sessionsWindowController = controller
|
||||
controller.showWindow(nil)
|
||||
NSApp.activate()
|
||||
}
|
||||
}
|
||||
@@ -2,72 +2,168 @@ import AppKit
|
||||
import SwiftUI
|
||||
import ShotdeckCore
|
||||
|
||||
/// Settings: three labelled groups, every row "what it is" on the left and the control
|
||||
/// on the right. Nothing here is needed while reviewing, which is why it is its own
|
||||
/// window and not part of the session surfaces.
|
||||
struct SettingsView: View {
|
||||
@Environment(AppModel.self) private var model
|
||||
@State private var isRecordingHotkey = false
|
||||
@State private var recorder = HotkeyRecorderBox()
|
||||
|
||||
private let labelWidth: CGFloat = 104
|
||||
|
||||
var body: some View {
|
||||
Grid(alignment: .leading, horizontalSpacing: 12, verticalSpacing: 10) {
|
||||
GridRow {
|
||||
Text("Hotkey")
|
||||
.font(.headline)
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
.gridCellColumns(2)
|
||||
}
|
||||
|
||||
GridRow(alignment: .center) {
|
||||
fieldLabel("Capture")
|
||||
HStack(spacing: 8) {
|
||||
Form {
|
||||
Section("Capture") {
|
||||
LabeledContent("Capture shortcut") {
|
||||
Button {
|
||||
armHotkeyRecorder()
|
||||
} label: {
|
||||
Text(isRecordingHotkey ? "Press keys…" : model.hotkeyDisplayString)
|
||||
.foregroundStyle(isRecordingHotkey ? .secondary : .primary)
|
||||
.lineLimit(1)
|
||||
.frame(minWidth: 54)
|
||||
}
|
||||
Spacer(minLength: 0)
|
||||
}
|
||||
.frame(minHeight: 22)
|
||||
}
|
||||
|
||||
GridRow {
|
||||
Text("Folders")
|
||||
.font(.headline)
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
.gridCellColumns(2)
|
||||
.padding(.top, 6)
|
||||
}
|
||||
|
||||
GridRow(alignment: .center) {
|
||||
fieldLabel("Watch folder")
|
||||
folderValue(path: model.watchFolderURL.path) {
|
||||
model.chooseWatchFolder()
|
||||
LabeledContent("Area") {
|
||||
HStack(spacing: 8) {
|
||||
Text(areaSummary)
|
||||
.foregroundStyle(.secondary)
|
||||
Button("Choose…") {
|
||||
Task { await model.rePickRegion() }
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
GridRow(alignment: .center) {
|
||||
fieldLabel("Output folder")
|
||||
folderValue(path: model.outboxURL.path) {
|
||||
model.chooseOutboxFolder()
|
||||
Section("Sending") {
|
||||
LabeledContent("Send with") {
|
||||
Picker("Send with", selection: transportBinding) {
|
||||
ForEach(SendTransport.allCases, id: \.self) { transport in
|
||||
Text(transport.displayName).tag(transport)
|
||||
}
|
||||
}
|
||||
.labelsHidden()
|
||||
.pickerStyle(.segmented)
|
||||
.frame(maxWidth: 220)
|
||||
}
|
||||
|
||||
if model.transport == .airDrop {
|
||||
LabeledContent("Save PDFs to") {
|
||||
folderRow(path: model.outboxURL.path) { model.chooseOutboxFolder() }
|
||||
}
|
||||
LabeledContent("Watch for returns in") {
|
||||
folderRow(path: model.watchFolderURL.path) { model.chooseWatchFolder() }
|
||||
}
|
||||
} else {
|
||||
LabeledContent("OneDrive folder") {
|
||||
folderRow(path: oneDrivePath) { model.chooseOneDriveFolder() }
|
||||
}
|
||||
Text(
|
||||
model.resolvedOneDriveFolder != nil
|
||||
? "The PDF is saved here and this same folder is watched for the marked-up copy. On the iPad open it from Files > OneDrive."
|
||||
: "No OneDrive folder found. Sign in to OneDrive, or choose a folder."
|
||||
)
|
||||
.font(.caption)
|
||||
.foregroundStyle(model.resolvedOneDriveFolder != nil ? .secondary : .primary)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
}
|
||||
}
|
||||
|
||||
GridRow {
|
||||
Button("Reveal spool folder") { model.openSpoolFolder() }
|
||||
.gridCellColumns(2)
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
.padding(.top, 4)
|
||||
Section("Sessions") {
|
||||
LabeledContent("Delete sessions older than") {
|
||||
Picker("Delete sessions older than", selection: retentionBinding) {
|
||||
ForEach(SessionRetention.presets, id: \.self) { preset in
|
||||
Text(preset.displayName).tag(preset)
|
||||
}
|
||||
}
|
||||
.labelsHidden()
|
||||
.frame(maxWidth: 150)
|
||||
}
|
||||
|
||||
LabeledContent(keptSummary) {
|
||||
Button("Clean Up Now…") {
|
||||
Task { await model.cleanUpExpiredSessions() }
|
||||
}
|
||||
.disabled(model.retention == .never || model.expiredSessionCount == 0)
|
||||
}
|
||||
|
||||
Text(retentionDetail)
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
|
||||
Text("Deleting removes Redline's own screenshots only. PDFs you sent stay where they are.")
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
}
|
||||
}
|
||||
.padding(16)
|
||||
.frame(minWidth: 320, idealWidth: 360, maxWidth: 360, alignment: .leading)
|
||||
.controlSize(.small)
|
||||
.formStyle(.grouped)
|
||||
.frame(width: 460, height: 520)
|
||||
.controlSize(.regular)
|
||||
.onDisappear { disarmHotkeyRecorder() }
|
||||
}
|
||||
|
||||
// MARK: - Rows
|
||||
|
||||
private var areaSummary: String {
|
||||
guard let region = model.region else { return "Not chosen" }
|
||||
return "\(Int(region.rect.width)) × \(Int(region.rect.height))"
|
||||
}
|
||||
|
||||
private var oneDrivePath: String {
|
||||
model.resolvedOneDriveFolder?.path ?? "Not found"
|
||||
}
|
||||
|
||||
private var keptSummary: String {
|
||||
let count = model.pastSessions.count + 1
|
||||
return "\(count) session\(count == 1 ? "" : "s") kept"
|
||||
}
|
||||
|
||||
private func folderRow(path: String, choose: @escaping () -> Void) -> some View {
|
||||
HStack(spacing: 8) {
|
||||
Text(abbreviateHome(path))
|
||||
.lineLimit(1)
|
||||
.truncationMode(.middle)
|
||||
.foregroundStyle(.secondary)
|
||||
.frame(maxWidth: 150, alignment: .trailing)
|
||||
.help(path)
|
||||
Button("Choose…") { choose() }
|
||||
}
|
||||
}
|
||||
|
||||
private func abbreviateHome(_ path: String) -> String {
|
||||
let home = FileManager.default.homeDirectoryForCurrentUser.path
|
||||
guard path.hasPrefix(home) else { return path }
|
||||
return "~" + path.dropFirst(home.count)
|
||||
}
|
||||
|
||||
// MARK: - Detail text
|
||||
|
||||
private var retentionDetail: String {
|
||||
guard model.retention != .never else {
|
||||
return "All sessions are kept. Nothing is deleted automatically."
|
||||
}
|
||||
let count = model.expiredSessionCount
|
||||
if count == 0 {
|
||||
return "No kept session is older than \(model.retention.displayName) yet."
|
||||
}
|
||||
return "\(count) session\(count == 1 ? " is" : "s are") already older than \(model.retention.displayName) and will be removed on the next launch or cleanup."
|
||||
}
|
||||
|
||||
// MARK: - Bindings
|
||||
|
||||
private var transportBinding: Binding<SendTransport> {
|
||||
Binding(get: { model.transport }, set: { model.chooseTransport($0) })
|
||||
}
|
||||
|
||||
private var retentionBinding: Binding<SessionRetention> {
|
||||
Binding(get: { model.retention }, set: { value in
|
||||
Task { await model.setRetention(value) }
|
||||
})
|
||||
}
|
||||
|
||||
// MARK: - Hotkey recorder
|
||||
|
||||
private func armHotkeyRecorder() {
|
||||
guard !isRecordingHotkey else { return }
|
||||
isRecordingHotkey = true
|
||||
@@ -95,26 +191,6 @@ struct SettingsView: View {
|
||||
recorder.onKey = nil
|
||||
isRecordingHotkey = false
|
||||
}
|
||||
|
||||
private func fieldLabel(_ title: String) -> some View {
|
||||
Text(title)
|
||||
.lineLimit(1)
|
||||
.frame(width: labelWidth, alignment: .trailing)
|
||||
.gridColumnAlignment(.trailing)
|
||||
.frame(minHeight: 22, alignment: .trailing)
|
||||
}
|
||||
|
||||
private func folderValue(path: String, choose: @escaping () -> Void) -> some View {
|
||||
HStack(spacing: 8) {
|
||||
Text(path)
|
||||
.lineLimit(1)
|
||||
.truncationMode(.middle)
|
||||
.foregroundStyle(.secondary)
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
Button("Choose…") { choose() }
|
||||
}
|
||||
.frame(minHeight: 22)
|
||||
}
|
||||
}
|
||||
|
||||
/// Local keyDown monitor for the Settings capture-hotkey recorder. Callbacks hop onto the
|
||||
@@ -160,6 +236,7 @@ extension AppModel: SettingsWindowPresenting {
|
||||
window.title = "Redline Settings"
|
||||
window.styleMask = [.titled, .closable]
|
||||
window.isReleasedWhenClosed = false
|
||||
window.setContentSize(NSSize(width: 460, height: 520))
|
||||
window.center()
|
||||
let controller = NSWindowController(window: window)
|
||||
Self.settingsWindowController = controller
|
||||
@@ -171,7 +248,7 @@ extension AppModel: SettingsWindowPresenting {
|
||||
guard let url = chooseDirectory(startingAt: outboxURL) else { return }
|
||||
FolderSettings.setOutbox(url)
|
||||
setFolderURLs(outbox: url, watch: watchFolderURL)
|
||||
setStatus("Output folder set to \(url.lastPathComponent).")
|
||||
setStatus("PDFs are saved to \(url.lastPathComponent).")
|
||||
}
|
||||
|
||||
func chooseWatchFolder() {
|
||||
@@ -181,7 +258,7 @@ extension AppModel: SettingsWindowPresenting {
|
||||
Task {
|
||||
do {
|
||||
try await watcher.updateWatchFolder(url)
|
||||
setStatus("Watch folder set to \(url.lastPathComponent).")
|
||||
setStatus("Watching \(url.lastPathComponent) for returns.")
|
||||
} catch {
|
||||
setStatus(
|
||||
(error as? ShotdeckError)?.errorDescription ?? "Could not switch the watch folder."
|
||||
@@ -190,6 +267,79 @@ extension AppModel: SettingsWindowPresenting {
|
||||
}
|
||||
}
|
||||
|
||||
/// Settings "Send with" picker action. Persists the choice, recomputes the effective
|
||||
/// outbox/watch folder for the new transport, creates the OneDrive folder if it
|
||||
/// doesn't exist yet, and re-points the running watcher (folder + recordUncommented)
|
||||
/// at the new state. Refuses while a send is in flight.
|
||||
/// The async reconcile below is generation-guarded so rapid toggling always lets the
|
||||
/// LAST choice win; its handle is stored in `pendingReconcileTask` so send() can
|
||||
/// await it before snapshotting transport/folder.
|
||||
func chooseTransport(_ value: SendTransport) {
|
||||
guard !isSending else {
|
||||
setStatus("Finish the current send first.")
|
||||
return
|
||||
}
|
||||
guard value != transport else { return }
|
||||
TransportSettings.setTransport(value)
|
||||
setTransport(value)
|
||||
let folders = TransportSettings.effectiveFolders()
|
||||
if value == .oneDrive {
|
||||
try? FileManager.default.createDirectory(
|
||||
at: folders.outbox, withIntermediateDirectories: true
|
||||
)
|
||||
}
|
||||
setFolderURLs(outbox: folders.outbox, watch: folders.watch)
|
||||
setResolvedOneDriveFolder(OneDriveLocator.resolveOneDriveFolder())
|
||||
|
||||
reconcileGeneration += 1
|
||||
let generation = reconcileGeneration
|
||||
pendingReconcileTask = Task {
|
||||
guard generation == self.reconcileGeneration else { return }
|
||||
await watcher.setRecordUncommented(value == .airDrop)
|
||||
guard generation == self.reconcileGeneration else { return }
|
||||
do {
|
||||
try await watcher.updateWatchFolder(folders.watch)
|
||||
} catch {
|
||||
guard generation == self.reconcileGeneration else { return }
|
||||
setStatus(
|
||||
(error as? ShotdeckError)?.errorDescription ?? "Could not switch the watch folder."
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Refuses while a send is in flight, same reasoning as chooseTransport. See
|
||||
/// chooseTransport's doc comment for the generation-guard mechanism shared here.
|
||||
func chooseOneDriveFolder() {
|
||||
guard !isSending else {
|
||||
setStatus("Finish the current send first.")
|
||||
return
|
||||
}
|
||||
let start = resolvedOneDriveFolder ?? FileManager.default.homeDirectoryForCurrentUser
|
||||
guard let url = chooseDirectory(startingAt: start) else { return }
|
||||
TransportSettings.setOneDriveFolder(url)
|
||||
try? FileManager.default.createDirectory(at: url, withIntermediateDirectories: true)
|
||||
setResolvedOneDriveFolder(OneDriveLocator.resolveOneDriveFolder())
|
||||
guard transport == .oneDrive else { return }
|
||||
setFolderURLs(outbox: url, watch: url)
|
||||
|
||||
reconcileGeneration += 1
|
||||
let generation = reconcileGeneration
|
||||
pendingReconcileTask = Task {
|
||||
guard generation == self.reconcileGeneration else { return }
|
||||
do {
|
||||
try await watcher.updateWatchFolder(url)
|
||||
guard generation == self.reconcileGeneration else { return }
|
||||
setStatus("OneDrive folder set to \(url.lastPathComponent).")
|
||||
} catch {
|
||||
guard generation == self.reconcileGeneration else { return }
|
||||
setStatus(
|
||||
(error as? ShotdeckError)?.errorDescription ?? "Could not switch the watch folder."
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private func chooseDirectory(startingAt directory: URL) -> URL? {
|
||||
let panel = NSOpenPanel()
|
||||
panel.canChooseDirectories = true
|
||||
|
||||
@@ -2,6 +2,7 @@ import AppKit
|
||||
import CryptoKit
|
||||
import Foundation
|
||||
import Security
|
||||
import ShotdeckCore
|
||||
|
||||
/// Built-in updater. Checks an appcast, stages a verified payload, and installs
|
||||
/// only when the user clicks the menu row — never automatically.
|
||||
@@ -31,6 +32,12 @@ final class UpdateChecker {
|
||||
private var repeatingTimer: Timer?
|
||||
private var firstCheckTask: Task<Void, Never>?
|
||||
private var stagingDirectory: URL?
|
||||
/// Snapshot-only override for previousVersion; when snapshotUsesPreviousVersionOverride is true,
|
||||
/// this value (including nil) is returned instead of checking the file system.
|
||||
var snapshotPreviousVersionOverride: String?
|
||||
var snapshotUsesPreviousVersionOverride: Bool = false
|
||||
/// Test seam: override appcast JSON. When set, returns this instead of fetching from URL.
|
||||
var testAppcastJSON: String?
|
||||
|
||||
init() {
|
||||
let config = URLSessionConfiguration.ephemeral
|
||||
@@ -85,7 +92,12 @@ final class UpdateChecker {
|
||||
|
||||
guard Self.isNewer(appcast.version, than: Self.currentVersion()) else {
|
||||
clearOffer()
|
||||
statusMessage = manual ? "Redline \(Self.currentVersion()) is up to date." : nil
|
||||
if manual {
|
||||
let timestamp = DubaiTime.checkTime(lastCheckedAt ?? Date())
|
||||
statusMessage = "Redline \(Self.currentVersion()) is up to date, checked \(timestamp)"
|
||||
} else {
|
||||
statusMessage = nil
|
||||
}
|
||||
onChecked?()
|
||||
return
|
||||
}
|
||||
@@ -93,7 +105,7 @@ final class UpdateChecker {
|
||||
do {
|
||||
try await downloadAndStage(appcast)
|
||||
availableUpdate = (version: appcast.version, notes: appcast.notes ?? "")
|
||||
statusMessage = nil
|
||||
statusMessage = manual ? "Update to \(appcast.version) is ready" : nil
|
||||
} catch UpdateCheckError.checksumMismatch {
|
||||
discardStaging()
|
||||
availableUpdate = nil
|
||||
@@ -226,8 +238,11 @@ final class UpdateChecker {
|
||||
}
|
||||
|
||||
/// The version recorded in `Redline.app.previous`'s Info.plist, or nil when no
|
||||
/// rollback copy exists.
|
||||
/// rollback copy exists. Respects the snapshot-only override for panel rendering.
|
||||
func previousVersion(target: URL = UpdateChecker.defaultInstallTarget) -> String? {
|
||||
if snapshotUsesPreviousVersionOverride {
|
||||
return snapshotPreviousVersionOverride
|
||||
}
|
||||
let previousURL = target.deletingLastPathComponent().appendingPathComponent("Redline.app.previous")
|
||||
let plistURL = previousURL.appendingPathComponent("Contents/Info.plist")
|
||||
guard let plist = NSDictionary(contentsOf: plistURL) as? [String: Any] else { return nil }
|
||||
@@ -346,7 +361,12 @@ final class UpdateChecker {
|
||||
}
|
||||
|
||||
private func fetchAppcast() async throws -> Appcast {
|
||||
let data = try await fetchData(from: Self.resolvedAppcastURL())
|
||||
let data: Data
|
||||
if let testJSON = testAppcastJSON {
|
||||
data = testJSON.data(using: .utf8) ?? Data()
|
||||
} else {
|
||||
data = try await fetchData(from: Self.resolvedAppcastURL())
|
||||
}
|
||||
return try JSONDecoder().decode(Appcast.self, from: data)
|
||||
}
|
||||
|
||||
|
||||
@@ -7,6 +7,18 @@ import ShotdeckCore
|
||||
if ProcessInfo.processInfo.environment["SHOTDECK_SNAPSHOT_DIR"] != nil {
|
||||
MainActor.assumeIsolated { PanelSnapshot.runIfRequested() }
|
||||
}
|
||||
if SelfTestLaunch.phase == "e2e" {
|
||||
MainActor.assumeIsolated { PanelSelfTest.runE2EIfRequested() }
|
||||
}
|
||||
if ProcessInfo.processInfo.environment["REDLINE_SELFTEST_PHASE"] == "panel" {
|
||||
MainActor.assumeIsolated { PanelSelfTest.runIfRequested() }
|
||||
}
|
||||
if ProcessInfo.processInfo.environment["REDLINE_SELFTEST_PHASE"] == "onedrive" {
|
||||
MainActor.assumeIsolated { PickerSelfTest.runOneDriveOnlyIfRequested() }
|
||||
}
|
||||
if ProcessInfo.processInfo.environment["REDLINE_SELFTEST_PHASE"] == "sendtruth" {
|
||||
MainActor.assumeIsolated { PickerSelfTest.runSendTruthOnlyIfRequested() }
|
||||
}
|
||||
if ProcessInfo.processInfo.environment["SHOTDECK_PICKER_SELFTEST"] != nil {
|
||||
MainActor.assumeIsolated { PickerSelfTest.runIfRequested() }
|
||||
}
|
||||
@@ -71,10 +83,22 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
|
||||
Task { await model.bootstrap() }
|
||||
}
|
||||
|
||||
private static func makeLaunchModel() -> AppModel {
|
||||
/// Builds the model exactly the way the real app launches: paths come from
|
||||
/// `TransportSettings.resolvedAppSupportPaths()` — transport-aware, so the watcher
|
||||
/// this feeds is never seeded with a stale AirDrop folder while OneDrive is the
|
||||
/// persisted transport (that was the BLOCKER this function used to have, when it
|
||||
/// called the AirDrop-only `FolderSettings.resolvedAppSupportPaths()` instead).
|
||||
/// `appSupportRoot` exists only so PickerSelfTest's relaunch-simulation sub-step can
|
||||
/// point this at a temp directory instead of the real
|
||||
/// ~/Library/Application Support/Shotdeck — production always calls this with no
|
||||
/// argument (the real root). Internal, not private, for that same reason.
|
||||
static func makeLaunchModel(
|
||||
appSupportRoot: URL? = nil,
|
||||
retentionDefaults: UserDefaults = .standard
|
||||
) -> AppModel {
|
||||
do {
|
||||
let paths = try FolderSettings.resolvedAppSupportPaths()
|
||||
return try makeModel(paths: paths)
|
||||
let paths = try TransportSettings.resolvedAppSupportPaths(root: appSupportRoot)
|
||||
return try makeModel(paths: paths, retentionDefaults: retentionDefaults)
|
||||
} catch {
|
||||
Log.ui.critical(
|
||||
"AppModel init failed: \(String(describing: error), privacy: .public)"
|
||||
@@ -83,13 +107,16 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
|
||||
let fallbackRoot = tmp.appendingPathComponent("Shotdeck-fallback", isDirectory: true)
|
||||
// Safe: temp-dir creation for a path this process controls cannot legitimately fail.
|
||||
let fallback = try! AppSupportPaths(root: fallbackRoot, outbox: tmp, watchFolder: tmp)
|
||||
let model = try! makeModel(paths: fallback)
|
||||
let model = try! makeModel(paths: fallback, retentionDefaults: retentionDefaults)
|
||||
model.setStatus("Redline could not access its storage folder. Captures will not persist.")
|
||||
return model
|
||||
}
|
||||
}
|
||||
|
||||
private static func makeModel(paths: AppSupportPaths) throws -> AppModel {
|
||||
private static func makeModel(
|
||||
paths: AppSupportPaths,
|
||||
retentionDefaults: UserDefaults
|
||||
) throws -> AppModel {
|
||||
let ledger = try ReturnLedger(paths: paths)
|
||||
return AppModel(
|
||||
paths: paths,
|
||||
@@ -99,7 +126,8 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
|
||||
hotkeys: HotkeyCenter(),
|
||||
picker: RegionPickerController(),
|
||||
ledger: ledger,
|
||||
watcher: ReturnWatcher(paths: paths, ledger: ledger)
|
||||
watcher: ReturnWatcher(paths: paths, ledger: ledger),
|
||||
retentionDefaults: retentionDefaults
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -2,7 +2,7 @@ import Foundation
|
||||
|
||||
public enum SessionState: String, Codable, Sendable {
|
||||
case open // accepting captures
|
||||
case archived // its PDF has been built and sent; kept forever, never deleted
|
||||
case archived // closed and kept as a past session (sent or not); pruned only by an age policy the user set
|
||||
}
|
||||
|
||||
/// The manifest persisted as session.json alongside the PNGs.
|
||||
@@ -11,27 +11,40 @@ public struct CaptureSession: Codable, Sendable, Identifiable, Equatable {
|
||||
public let createdAt: Date
|
||||
public private(set) var state: SessionState
|
||||
public private(set) var captures: [Capture]
|
||||
/// Set when the PDF is built, so a re-send reuses the same file.
|
||||
/// Set when the PDF is built, so a re-send reuses the same file. nil on a
|
||||
/// session that was closed without ever sending — the Past sessions list
|
||||
/// shows that as "Not sent".
|
||||
public private(set) var pdfFileName: String?
|
||||
/// Lane / deployed build / commit / reviewer / note for this session. Absent from
|
||||
/// manifests written before v0.5.0 — those decode as `.empty`, never a guess.
|
||||
public private(set) var context: ReviewContext
|
||||
|
||||
public init(
|
||||
id: UUID,
|
||||
createdAt: Date,
|
||||
state: SessionState,
|
||||
captures: [Capture],
|
||||
pdfFileName: String?
|
||||
pdfFileName: String?,
|
||||
context: ReviewContext = .empty
|
||||
) {
|
||||
self.id = id
|
||||
self.createdAt = createdAt
|
||||
self.state = state
|
||||
self.captures = captures
|
||||
self.pdfFileName = pdfFileName
|
||||
self.context = context
|
||||
}
|
||||
|
||||
public var isEmpty: Bool {
|
||||
captures.isEmpty
|
||||
}
|
||||
|
||||
/// First 8 characters of the UUID, uppercase — the stable short handle used in
|
||||
/// file names, the session list and the PDF header.
|
||||
public var shortID: String {
|
||||
String(id.uuidString.replacingOccurrences(of: "-", with: "").prefix(8)).uppercased()
|
||||
}
|
||||
|
||||
/// max(sequence)+1, or 1 when empty.
|
||||
public var nextSequence: Int {
|
||||
(captures.map(\.sequence).max() ?? 0) + 1
|
||||
@@ -44,7 +57,8 @@ public struct CaptureSession: Codable, Sendable, Identifiable, Equatable {
|
||||
createdAt: createdAt,
|
||||
state: state,
|
||||
captures: captures + [capture],
|
||||
pdfFileName: pdfFileName
|
||||
pdfFileName: pdfFileName,
|
||||
context: context
|
||||
)
|
||||
}
|
||||
|
||||
@@ -56,18 +70,63 @@ public struct CaptureSession: Codable, Sendable, Identifiable, Equatable {
|
||||
createdAt: createdAt,
|
||||
state: state,
|
||||
captures: captures.filter { $0.id != captureID },
|
||||
pdfFileName: pdfFileName
|
||||
pdfFileName: pdfFileName,
|
||||
context: context
|
||||
)
|
||||
}
|
||||
|
||||
/// Value-semantic: returns a new session; does not mutate `self`.
|
||||
public func markArchived(pdfFileName: String) -> CaptureSession {
|
||||
/// `pdfFileName` is nil when the session is closed without ever sending.
|
||||
public func markArchived(pdfFileName: String?) -> CaptureSession {
|
||||
CaptureSession(
|
||||
id: id,
|
||||
createdAt: createdAt,
|
||||
state: .archived,
|
||||
captures: captures,
|
||||
pdfFileName: pdfFileName
|
||||
pdfFileName: pdfFileName,
|
||||
context: context
|
||||
)
|
||||
}
|
||||
|
||||
/// Value-semantic: returns a new session; does not mutate `self`.
|
||||
public func withContext(_ newContext: ReviewContext) -> CaptureSession {
|
||||
CaptureSession(
|
||||
id: id,
|
||||
createdAt: createdAt,
|
||||
state: state,
|
||||
captures: captures,
|
||||
pdfFileName: pdfFileName,
|
||||
context: newContext
|
||||
)
|
||||
}
|
||||
|
||||
/// Value-semantic: returns a new session; does not mutate `self`.
|
||||
public func withPDFFileName(_ name: String?) -> CaptureSession {
|
||||
CaptureSession(
|
||||
id: id,
|
||||
createdAt: createdAt,
|
||||
state: state,
|
||||
captures: captures,
|
||||
pdfFileName: name,
|
||||
context: context
|
||||
)
|
||||
}
|
||||
|
||||
private enum CodingKeys: String, CodingKey {
|
||||
case id, createdAt, state, captures, pdfFileName, context
|
||||
}
|
||||
|
||||
/// `context` is decoded leniently so every manifest written before v0.5.0 keeps
|
||||
/// loading; all other keys are required, exactly as before.
|
||||
public init(from decoder: Decoder) throws {
|
||||
let container = try decoder.container(keyedBy: CodingKeys.self)
|
||||
self.init(
|
||||
id: try container.decode(UUID.self, forKey: .id),
|
||||
createdAt: try container.decode(Date.self, forKey: .createdAt),
|
||||
state: try container.decode(SessionState.self, forKey: .state),
|
||||
captures: try container.decode([Capture].self, forKey: .captures),
|
||||
pdfFileName: try container.decodeIfPresent(String.self, forKey: .pdfFileName),
|
||||
context: try container.decodeIfPresent(ReviewContext.self, forKey: .context) ?? .empty
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,90 @@
|
||||
import Foundation
|
||||
|
||||
/// What a review session is ABOUT, recorded once per session and printed on every
|
||||
/// PDF page plus the PDF's document info, so an annotated page that comes back
|
||||
/// weeks later still says which lane, build and commit it referred to, who took it
|
||||
/// and when.
|
||||
///
|
||||
/// Every field is optional in practice (empty string = not recorded); nothing here
|
||||
/// is invented when the user leaves it blank. `note` is free text.
|
||||
public struct ReviewContext: Codable, Sendable, Equatable {
|
||||
/// Hard cap per field: this text ends up on every PDF page, so an unbounded
|
||||
/// paste must not be able to break the layout.
|
||||
public static let maxFieldLength = 120
|
||||
|
||||
public var lane: String
|
||||
public var deployedVersion: String
|
||||
public var commit: String
|
||||
public var reviewer: String
|
||||
public var note: String
|
||||
|
||||
public init(
|
||||
lane: String = "",
|
||||
deployedVersion: String = "",
|
||||
commit: String = "",
|
||||
reviewer: String = "",
|
||||
note: String = ""
|
||||
) {
|
||||
self.lane = Self.cleaned(lane)
|
||||
self.deployedVersion = Self.cleaned(deployedVersion)
|
||||
self.commit = Self.cleaned(commit)
|
||||
self.reviewer = Self.cleaned(reviewer)
|
||||
self.note = Self.cleaned(note)
|
||||
}
|
||||
|
||||
public static let empty = ReviewContext()
|
||||
|
||||
/// The macOS account's own name, used to pre-fill `reviewer` on a fresh session.
|
||||
/// `NSFullUserName()` is empty on a host with no full name set, in which case the
|
||||
/// short login name identifies the same person.
|
||||
public static func currentUser() -> String {
|
||||
let full = NSFullUserName().trimmingCharacters(in: .whitespacesAndNewlines)
|
||||
if !full.isEmpty { return cleaned(full) }
|
||||
return cleaned(NSUserName())
|
||||
}
|
||||
|
||||
public var isEmpty: Bool {
|
||||
lane.isEmpty && deployedVersion.isEmpty && commit.isEmpty && reviewer.isEmpty && note.isEmpty
|
||||
}
|
||||
|
||||
/// "DEV03 · v1.4.2 · a1b2c3d · Ben Hippler" — empty parts are dropped, never
|
||||
/// replaced with a placeholder.
|
||||
public var summaryLine: String {
|
||||
summaryParts.joined(separator: " · ")
|
||||
}
|
||||
|
||||
/// The individual summary parts in display order, empty ones dropped.
|
||||
public var summaryParts: [String] {
|
||||
var parts: [String] = []
|
||||
if !lane.isEmpty { parts.append(lane) }
|
||||
if !deployedVersion.isEmpty { parts.append(deployedVersion) }
|
||||
if !commit.isEmpty { parts.append(commit) }
|
||||
if !reviewer.isEmpty { parts.append(reviewer) }
|
||||
return parts
|
||||
}
|
||||
|
||||
/// JSON kept tolerant on purpose: an older manifest has no context at all, and a
|
||||
/// newer one may add fields. Any unknown key is ignored; every known field is
|
||||
/// optional.
|
||||
public init(from decoder: Decoder) throws {
|
||||
let container = try decoder.container(keyedBy: CodingKeys.self)
|
||||
self.init(
|
||||
lane: try container.decodeIfPresent(String.self, forKey: .lane) ?? "",
|
||||
deployedVersion: try container.decodeIfPresent(String.self, forKey: .deployedVersion) ?? "",
|
||||
commit: try container.decodeIfPresent(String.self, forKey: .commit) ?? "",
|
||||
reviewer: try container.decodeIfPresent(String.self, forKey: .reviewer) ?? "",
|
||||
note: try container.decodeIfPresent(String.self, forKey: .note) ?? ""
|
||||
)
|
||||
}
|
||||
|
||||
/// Trims, collapses line breaks (the value is drawn on one line) and caps length.
|
||||
static func cleaned(_ raw: String) -> String {
|
||||
let collapsed = raw
|
||||
.replacingOccurrences(of: "\r\n", with: " ")
|
||||
.replacingOccurrences(of: "\n", with: " ")
|
||||
.replacingOccurrences(of: "\r", with: " ")
|
||||
.trimmingCharacters(in: .whitespaces)
|
||||
guard collapsed.count > maxFieldLength else { return collapsed }
|
||||
return String(collapsed.prefix(maxFieldLength))
|
||||
}
|
||||
}
|
||||
@@ -10,6 +10,7 @@ public enum ShotdeckError: Error, LocalizedError, Sendable {
|
||||
case pdfCompositionFailed(reason: String)
|
||||
case airDropUnavailable
|
||||
case noCommentedReturns
|
||||
case oneDriveFolderUnavailable(path: String)
|
||||
|
||||
public var errorDescription: String? {
|
||||
switch self {
|
||||
@@ -31,6 +32,8 @@ public enum ShotdeckError: Error, LocalizedError, Sendable {
|
||||
return "AirDrop is not available right now."
|
||||
case .noCommentedReturns:
|
||||
return "None of the returned PDFs have comments on them."
|
||||
case .oneDriveFolderUnavailable(let path):
|
||||
return "Your OneDrive folder is not available: \(path). Check that OneDrive is signed in, or choose another folder in Settings."
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -10,12 +10,17 @@ private let pdfLog = Logger(subsystem: "ai.flowmaster.shotdeck", category: "PDF"
|
||||
public struct PDFComposer: Sendable {
|
||||
public init() {}
|
||||
|
||||
/// `toolVersion` is the running Redline version (CFBundleShortVersionString) and
|
||||
/// `composedAt` the build time; both are printed in the page footer and the PDF's
|
||||
/// document info so a printed or returned page says which tools produced it.
|
||||
@discardableResult
|
||||
public func compose(
|
||||
session: CaptureSession,
|
||||
imageURL: (Capture) -> URL,
|
||||
title: String,
|
||||
to outputURL: URL
|
||||
to outputURL: URL,
|
||||
toolVersion: String = "",
|
||||
composedAt: Date = Date()
|
||||
) throws -> Int {
|
||||
if session.isEmpty {
|
||||
throw ShotdeckError.pdfCompositionFailed(reason: "session has no captures")
|
||||
@@ -43,12 +48,18 @@ public struct PDFComposer: Sendable {
|
||||
.deletingLastPathComponent()
|
||||
.appendingPathComponent(".tmp-\(UUID().uuidString)-\(outputURL.lastPathComponent)")
|
||||
|
||||
let footerLines = Self.footerLines(
|
||||
session: session, toolVersion: toolVersion, composedAt: composedAt)
|
||||
|
||||
do {
|
||||
try Self.writePDF(
|
||||
loaded: loaded,
|
||||
pageCount: pageCount,
|
||||
title: title,
|
||||
sessionID: session.id,
|
||||
footerLines: footerLines,
|
||||
metadata: Self.documentInfo(
|
||||
session: session, title: title, toolVersion: toolVersion, composedAt: composedAt),
|
||||
to: tmpURL
|
||||
)
|
||||
|
||||
@@ -70,8 +81,72 @@ public struct PDFComposer: Sendable {
|
||||
}
|
||||
}
|
||||
|
||||
public static func fileName(for _: CaptureSession) -> String {
|
||||
"Redline-\(DubaiTime.fileStamp(Date())).pdf"
|
||||
/// `Redline-<yyyyMMdd-HHmm>-<LANE>-<SHORTID>.pdf` — see `PDFFileName`.
|
||||
public static func fileName(for session: CaptureSession) -> String {
|
||||
PDFFileName.make(builtAt: Date(), lane: session.context.lane, sessionID: session.id)
|
||||
}
|
||||
|
||||
/// Both footer lines for a session, untruncated. Line 1 identifies the document
|
||||
/// (tool, build time, session); line 2 states what it reviewed (lane, deployed
|
||||
/// build, commit, reviewer, note). Empty context fields are omitted rather than
|
||||
/// printed as blanks.
|
||||
public static func footerLines(
|
||||
session: CaptureSession,
|
||||
toolVersion: String,
|
||||
composedAt: Date
|
||||
) -> [String] {
|
||||
let tool = toolVersion.isEmpty ? "Redline" : "Redline \(toolVersion)"
|
||||
let first = "\(tool) · \(DubaiTime.stamp(composedAt)) · Session \(session.shortID)"
|
||||
|
||||
let context = session.context
|
||||
var review: [String] = []
|
||||
if !context.lane.isEmpty { review.append("Lane \(context.lane)") }
|
||||
if !context.deployedVersion.isEmpty { review.append("Deployed \(context.deployedVersion)") }
|
||||
if !context.commit.isEmpty { review.append("Commit \(context.commit)") }
|
||||
if !context.reviewer.isEmpty { review.append("Reviewer \(context.reviewer)") }
|
||||
if !context.note.isEmpty { review.append("Note \(context.note)") }
|
||||
return review.isEmpty ? [first] : [first, review.joined(separator: " · ")]
|
||||
}
|
||||
|
||||
/// The PDF document info a reader sees in Preview/Acrobat. The subject stays the
|
||||
/// session UUID (it is the stable machine handle); everything a person needs to
|
||||
/// identify the review is in Author/Keywords as well as the page footers.
|
||||
public static func documentInfo(
|
||||
session: CaptureSession,
|
||||
title: String,
|
||||
toolVersion: String,
|
||||
composedAt: Date
|
||||
) -> [String: Any] {
|
||||
let context = session.context
|
||||
// Commas separate keywords in the PDF format itself, so a value containing one
|
||||
// would silently split into two keywords (and PDF readers return a list
|
||||
// instead of a string). Strip them from every keyword value.
|
||||
func keywordValue(_ raw: String) -> String {
|
||||
raw.replacingOccurrences(of: ",", with: " ")
|
||||
.split(whereSeparator: \.isWhitespace)
|
||||
.joined(separator: " ")
|
||||
}
|
||||
var keywords: [String] = ["Redline", "session=\(session.shortID)"]
|
||||
if !context.lane.isEmpty { keywords.append("lane=\(keywordValue(context.lane))") }
|
||||
if !context.deployedVersion.isEmpty {
|
||||
keywords.append("deployed=\(keywordValue(context.deployedVersion))")
|
||||
}
|
||||
if !context.commit.isEmpty { keywords.append("commit=\(keywordValue(context.commit))") }
|
||||
if !context.reviewer.isEmpty { keywords.append("reviewer=\(keywordValue(context.reviewer))") }
|
||||
if !context.note.isEmpty { keywords.append("note=\(keywordValue(context.note))") }
|
||||
keywords.append("built=\(DubaiTime.keywordStamp(composedAt))")
|
||||
if !toolVersion.isEmpty { keywords.append("tool=\(toolVersion)") }
|
||||
|
||||
var info: [String: Any] = [
|
||||
kCGPDFContextCreator as String: toolVersion.isEmpty ? "Redline" : "Redline \(toolVersion)",
|
||||
kCGPDFContextTitle as String: title,
|
||||
kCGPDFContextSubject as String: session.id.uuidString.lowercased(),
|
||||
kCGPDFContextKeywords as String: keywords.joined(separator: "; "),
|
||||
]
|
||||
if !context.reviewer.isEmpty {
|
||||
info[kCGPDFContextAuthor as String] = context.reviewer
|
||||
}
|
||||
return info
|
||||
}
|
||||
|
||||
private static func writePDF(
|
||||
@@ -79,17 +154,15 @@ public struct PDFComposer: Sendable {
|
||||
pageCount: Int,
|
||||
title: String,
|
||||
sessionID: UUID,
|
||||
footerLines: [String],
|
||||
metadata: [String: Any],
|
||||
to tmpURL: URL
|
||||
) throws {
|
||||
guard let consumer = CGDataConsumer(url: tmpURL as CFURL) else {
|
||||
throw ShotdeckError.pdfCompositionFailed(reason: "cannot open output location")
|
||||
}
|
||||
|
||||
let auxiliaryInfo: [String: Any] = [
|
||||
kCGPDFContextCreator as String: "Redline",
|
||||
kCGPDFContextTitle as String: title,
|
||||
kCGPDFContextSubject as String: sessionID.uuidString.lowercased(),
|
||||
]
|
||||
let auxiliaryInfo = metadata
|
||||
|
||||
guard let context = CGContext(
|
||||
consumer: consumer,
|
||||
@@ -105,7 +178,9 @@ public struct PDFComposer: Sendable {
|
||||
|
||||
for pageIndex in 1...pageCount {
|
||||
let (capture, cgImage) = loaded[pageIndex - 1]
|
||||
let layout = PageLayout(capture: capture, pageIndex: pageIndex, pageCount: pageCount)
|
||||
let layout = PageLayout(
|
||||
capture: capture, pageIndex: pageIndex, pageCount: pageCount,
|
||||
footerLines: footerLines)
|
||||
|
||||
context.beginPDFPage(Self.pageInfo(mediaBox: layout.pageRect))
|
||||
|
||||
@@ -149,6 +224,17 @@ public struct PDFComposer: Sendable {
|
||||
strokeTickBox(layout.passTickBox, in: context, color: black)
|
||||
strokeTickBox(layout.failTickBox, in: context, color: black)
|
||||
|
||||
for (line, origin) in zip(layout.footerLines, layout.footerOrigins) {
|
||||
drawTruncatedText(
|
||||
line,
|
||||
font: layout.footerFont,
|
||||
color: timestampColor,
|
||||
at: origin,
|
||||
maxWidth: layout.footerRect.width,
|
||||
in: context
|
||||
)
|
||||
}
|
||||
|
||||
context.endPDFPage()
|
||||
}
|
||||
|
||||
@@ -185,6 +271,40 @@ public struct PDFComposer: Sendable {
|
||||
CTLineDraw(line, context)
|
||||
}
|
||||
|
||||
/// Draws one footer line, truncated with an ellipsis when it is wider than the
|
||||
/// page content width — the reference block must never run into the page edge.
|
||||
private static func drawTruncatedText(
|
||||
_ string: String,
|
||||
font: NSFont,
|
||||
color: CGColor,
|
||||
at origin: CGPoint,
|
||||
maxWidth: CGFloat,
|
||||
in context: CGContext
|
||||
) {
|
||||
let attributes: [CFString: Any] = [
|
||||
kCTFontAttributeName: font,
|
||||
kCTForegroundColorAttributeName: color,
|
||||
]
|
||||
guard let attributed = CFAttributedStringCreate(
|
||||
nil, string as CFString, attributes as CFDictionary)
|
||||
else { return }
|
||||
var line = CTLineCreateWithAttributedString(attributed)
|
||||
if CGFloat(CTLineGetTypographicBounds(line, nil, nil, nil)) > maxWidth,
|
||||
let ellipsisAttributed = CFAttributedStringCreate(
|
||||
nil, "…" as CFString, attributes as CFDictionary)
|
||||
{
|
||||
let ellipsis = CTLineCreateWithAttributedString(ellipsisAttributed)
|
||||
if let truncated = CTLineCreateTruncatedLine(
|
||||
line, Double(maxWidth), .end, ellipsis)
|
||||
{
|
||||
line = truncated
|
||||
}
|
||||
}
|
||||
context.textMatrix = .identity
|
||||
context.textPosition = origin
|
||||
CTLineDraw(line, context)
|
||||
}
|
||||
|
||||
private static func strokeTickBox(_ box: CGRect, in context: CGContext, color: CGColor) {
|
||||
let path = CGPath(
|
||||
roundedRect: box,
|
||||
|
||||
@@ -0,0 +1,54 @@
|
||||
import Foundation
|
||||
|
||||
/// The PDF file-name scheme:
|
||||
///
|
||||
/// Redline-<yyyyMMdd-HHmm>-<LANE>-<SHORTID>.pdf
|
||||
/// Redline-<yyyyMMdd-HHmm>-<SHORTID>.pdf (no lane recorded)
|
||||
///
|
||||
/// * `yyyyMMdd-HHmm` is Dubai wall-clock time (the time the PDF was built) — the
|
||||
/// file sorts chronologically as plain text on every filesystem.
|
||||
/// * `LANE` is the upper-cased lane/environment, reduced to A–Z, 0–9 and single
|
||||
/// dashes ("OMS test lane" → "OMS-TEST-LANE") so the name is safe everywhere.
|
||||
/// * `SHORTID` is the session's 8-character id, which keeps two lanes in the same
|
||||
/// minute — and a re-send of the same session — distinguishable and unique.
|
||||
public enum PDFFileName {
|
||||
/// Lane token length cap so the whole name stays comfortably short.
|
||||
public static let laneMaxLength = 24
|
||||
|
||||
public static func laneSlug(_ lane: String) -> String {
|
||||
var slug = ""
|
||||
var pendingDash = false
|
||||
for character in lane.uppercased() {
|
||||
if character.isASCII, character.isLetter || character.isNumber {
|
||||
if pendingDash, !slug.isEmpty { slug.append("-") }
|
||||
slug.append(character)
|
||||
pendingDash = false
|
||||
} else {
|
||||
pendingDash = true
|
||||
}
|
||||
}
|
||||
let capped = String(slug.prefix(laneMaxLength))
|
||||
return capped.hasSuffix("-") ? String(capped.dropLast()) : capped
|
||||
}
|
||||
|
||||
public static func make(builtAt: Date, lane: String, sessionID: UUID) -> String {
|
||||
let shortID = String(
|
||||
sessionID.uuidString.replacingOccurrences(of: "-", with: "").prefix(8)
|
||||
).uppercased()
|
||||
let slug = laneSlug(lane)
|
||||
var parts = ["Redline", DubaiTime.fileMinuteStamp(builtAt)]
|
||||
if !slug.isEmpty { parts.append(slug) }
|
||||
parts.append(shortID)
|
||||
return parts.joined(separator: "-") + ".pdf"
|
||||
}
|
||||
|
||||
/// The session folder's own readable label, e.g. "DEV03-4F2A9C1D" — used in the
|
||||
/// UI only; the on-disk folder name stays the session UUID.
|
||||
public static func sessionLabel(lane: String, sessionID: UUID) -> String {
|
||||
let shortID = String(
|
||||
sessionID.uuidString.replacingOccurrences(of: "-", with: "").prefix(8)
|
||||
).uppercased()
|
||||
let slug = laneSlug(lane)
|
||||
return slug.isEmpty ? shortID : "\(slug)-\(shortID)"
|
||||
}
|
||||
}
|
||||
@@ -15,6 +15,12 @@ public struct PageLayout: Sendable, Equatable {
|
||||
public let timestampText: String
|
||||
public let timestampOrigin: CGPoint
|
||||
|
||||
/// Reference block under the image (up to two lines): who, when, which lane,
|
||||
/// which deployed build and commit. Empty when the caller passes no lines.
|
||||
public let footerRect: CGRect
|
||||
public let footerLines: [String]
|
||||
public let footerOrigins: [CGPoint]
|
||||
|
||||
public let passLabelOrigin: CGPoint
|
||||
public let failLabelOrigin: CGPoint
|
||||
public let passTickBox: CGRect
|
||||
@@ -25,10 +31,13 @@ public struct PageLayout: Sendable, Equatable {
|
||||
public var pageNumberFont: NSFont { NSFont.systemFont(ofSize: 9, weight: .semibold) }
|
||||
public var timestampFont: NSFont { NSFont.systemFont(ofSize: 9, weight: .regular) }
|
||||
public var tickLabelFont: NSFont { NSFont.systemFont(ofSize: 8, weight: .semibold) }
|
||||
public var footerFont: NSFont { NSFont.systemFont(ofSize: 7.5, weight: .regular) }
|
||||
|
||||
private static let marginAll: CGFloat = 18
|
||||
private static let headerHeight: CGFloat = 26
|
||||
private static let headerImageGap: CGFloat = 10
|
||||
private static let footerLineHeight: CGFloat = 9.5
|
||||
private static let footerImageGap: CGFloat = 7
|
||||
private static let tickBoxSize: CGFloat = 13
|
||||
private static let tickGroupGap: CGFloat = 8
|
||||
private static let portraitPage = CGSize(width: 595, height: 842)
|
||||
@@ -36,10 +45,13 @@ public struct PageLayout: Sendable, Equatable {
|
||||
|
||||
/// `pageIndex` and `pageCount` are 1-based / total, over ACTUALLY-WRITTEN pages
|
||||
/// (see SPEC decision D-D), not `capture.sequence` / `session.captures.count`.
|
||||
public init(capture: Capture, pageIndex: Int, pageCount: Int) {
|
||||
/// `footerLines` is the pre-truncated reference block; an empty array keeps the
|
||||
/// image area exactly as it was before the footer existed.
|
||||
public init(capture: Capture, pageIndex: Int, pageCount: Int, footerLines: [String] = []) {
|
||||
let pageNumberFont = NSFont.systemFont(ofSize: 9, weight: .semibold)
|
||||
let timestampFont = NSFont.systemFont(ofSize: 9, weight: .regular)
|
||||
let tickLabelFont = NSFont.systemFont(ofSize: 8, weight: .semibold)
|
||||
let footerLabelFont = NSFont.systemFont(ofSize: 7.5, weight: .regular)
|
||||
|
||||
isLandscape = capture.isLandscape
|
||||
pageRect = CGRect(origin: .zero, size: isLandscape ? Self.landscapePage : Self.portraitPage)
|
||||
@@ -59,11 +71,23 @@ public struct PageLayout: Sendable, Equatable {
|
||||
height: Self.headerHeight
|
||||
)
|
||||
|
||||
imageBoxRect = CGRect(
|
||||
self.footerLines = footerLines
|
||||
let footerHeight = footerLines.isEmpty
|
||||
? 0
|
||||
: CGFloat(footerLines.count) * Self.footerLineHeight
|
||||
footerRect = CGRect(
|
||||
x: contentMinX,
|
||||
y: contentMinY,
|
||||
width: contentWidth,
|
||||
height: headerRect.minY - Self.headerImageGap - contentMinY
|
||||
height: footerHeight
|
||||
)
|
||||
let imageBoxMinY = contentMinY + (footerLines.isEmpty ? 0 : footerHeight + Self.footerImageGap)
|
||||
|
||||
imageBoxRect = CGRect(
|
||||
x: contentMinX,
|
||||
y: imageBoxMinY,
|
||||
width: contentWidth,
|
||||
height: headerRect.minY - Self.headerImageGap - imageBoxMinY
|
||||
)
|
||||
|
||||
let pointSize = CGSize(
|
||||
@@ -91,6 +115,22 @@ public struct PageLayout: Sendable, Equatable {
|
||||
let descent = CTFontGetDescent(metricsFont)
|
||||
let baselineY = headerRect.minY + (headerRect.height - (ascent + descent)) / 2 + descent
|
||||
|
||||
// Footer baselines, top line first, using the footer font's own descent.
|
||||
let footerMetrics = footerLabelFont as CTFont
|
||||
let footerAscent = CTFontGetAscent(footerMetrics)
|
||||
let footerDescent = CTFontGetDescent(footerMetrics)
|
||||
let footerLeading = Self.footerLineHeight
|
||||
var origins: [CGPoint] = []
|
||||
origins.reserveCapacity(footerLines.count)
|
||||
for index in footerLines.indices {
|
||||
let lineBottom = footerRect.maxY - CGFloat(index + 1) * footerLeading
|
||||
origins.append(CGPoint(
|
||||
x: footerRect.minX,
|
||||
y: lineBottom + max(0, (footerLeading - (footerAscent + footerDescent)) / 2) + footerDescent
|
||||
))
|
||||
}
|
||||
footerOrigins = origins
|
||||
|
||||
pageNumberText = "\(pageIndex) / \(pageCount)"
|
||||
pageNumberOrigin = CGPoint(x: headerRect.minX, y: baselineY)
|
||||
|
||||
@@ -135,6 +175,9 @@ public struct PageLayout: Sendable, Equatable {
|
||||
&& lhs.pageNumberOrigin == rhs.pageNumberOrigin
|
||||
&& lhs.timestampText == rhs.timestampText
|
||||
&& lhs.timestampOrigin == rhs.timestampOrigin
|
||||
&& lhs.footerRect == rhs.footerRect
|
||||
&& lhs.footerLines == rhs.footerLines
|
||||
&& lhs.footerOrigins == rhs.footerOrigins
|
||||
&& lhs.passLabelOrigin == rhs.passLabelOrigin
|
||||
&& lhs.failLabelOrigin == rhs.failLabelOrigin
|
||||
&& lhs.passTickBox == rhs.passTickBox
|
||||
|
||||
@@ -10,6 +10,21 @@ public actor ReturnWatcher {
|
||||
private var bridge: FSEventBridge?
|
||||
private var pendingScanTask: Task<Void, Never>?
|
||||
private let eventQueue = DispatchQueue(label: "ai.flowmaster.shotdeck.returns.fsevents")
|
||||
/// When false, a document with zero human marks is neither recorded into the ledger
|
||||
/// nor included in scanNow's/onChange's results — needed for OneDrive mode, where the
|
||||
/// outbox and watch folder are the same folder and a freshly written, unmarked PDF
|
||||
/// must not be treated as a return. Defaults to true (today's AirDrop behaviour).
|
||||
/// A document that IS commented is always recorded, regardless of this flag.
|
||||
public var recordUncommented: Bool = true
|
||||
|
||||
/// The folder this watcher is CURRENTLY seeded to scan/watch — whatever `init`
|
||||
/// last set it to, or `updateWatchFolder` since. Exposed so tests can observe the
|
||||
/// watcher's seeded folder directly (e.g. right after construction, before
|
||||
/// `start()`/`updateWatchFolder()` ever run) rather than only inferring it
|
||||
/// indirectly through `scanNow()`'s behavior.
|
||||
public var currentWatchFolder: URL {
|
||||
watchFolder
|
||||
}
|
||||
|
||||
/// Watch folder is `paths.watchFolder`, which production constructs from
|
||||
/// `FolderSettings.resolve().watch`. This type never calls FolderSettings;
|
||||
@@ -29,6 +44,12 @@ public actor ReturnWatcher {
|
||||
onChange(found)
|
||||
}
|
||||
|
||||
/// Sets `recordUncommented`. A `func` (not a plain property set) only because
|
||||
/// callers outside this actor must `await` it like any other actor mutation.
|
||||
public func setRecordUncommented(_ value: Bool) {
|
||||
recordUncommented = value
|
||||
}
|
||||
|
||||
/// Idempotent. Stops and releases the FSEventStream if one is running; safe to call
|
||||
/// when never started or already stopped. Cancels any pending debounced scan.
|
||||
public func stop() {
|
||||
@@ -77,6 +98,7 @@ public actor ReturnWatcher {
|
||||
guard let document = PDFDocument(url: url),
|
||||
AnnotationInspector.isShotdeckDocument(document) else { continue }
|
||||
guard let inspected = try? AnnotationInspector.inspect(fileURL: url) else { continue }
|
||||
if !recordUncommented, !inspected.isCommented { continue }
|
||||
try await ledger.record(inspected)
|
||||
results.append(inspected)
|
||||
}
|
||||
|
||||
@@ -6,15 +6,24 @@ import Darwin
|
||||
public actor SpoolStore {
|
||||
private let paths: AppSupportPaths
|
||||
private var openSession: CaptureSession
|
||||
/// The user's age limit for kept sessions. `.never` (the default) means every
|
||||
/// session is kept: nothing is deleted until an age limit is chosen in Settings.
|
||||
private var retention: SessionRetention
|
||||
|
||||
public init(paths: AppSupportPaths) throws {
|
||||
public init(paths: AppSupportPaths, retention: SessionRetention = .never) throws {
|
||||
self.paths = paths
|
||||
self.retention = retention
|
||||
let fm = FileManager.default
|
||||
try Self.supersedeSpoolArchiveOverlaps(paths: paths, fileManager: fm)
|
||||
try Self.finishInterruptedArchives(paths: paths, fileManager: fm)
|
||||
let remainingIDs = try Self.listUUIDDirectories(in: paths.spool, fileManager: fm)
|
||||
if remainingIDs.isEmpty {
|
||||
self.openSession = try Self.createFreshSession(paths: paths)
|
||||
// A brand-new store: the reviewer is this Mac's user, so a session taken
|
||||
// now records who took it without the user typing anything. Lane, build
|
||||
// and commit stay empty until the user states them.
|
||||
self.openSession = try Self.createFreshSession(
|
||||
paths: paths,
|
||||
context: ReviewContext(reviewer: ReviewContext.currentUser()))
|
||||
} else {
|
||||
var candidates: [CaptureSession] = []
|
||||
for id in remainingIDs {
|
||||
@@ -27,10 +36,54 @@ public actor SpoolStore {
|
||||
}
|
||||
}
|
||||
|
||||
/// Applies a new age limit to future archive/launch prunes. Does not delete
|
||||
/// anything itself — a caller that just changed the setting calls
|
||||
/// `pruneExpiredSessions()` when the user asked for a cleanup.
|
||||
public func setRetention(_ value: SessionRetention) {
|
||||
retention = value
|
||||
}
|
||||
|
||||
/// The age limit this store is currently enforcing.
|
||||
public func configuredRetention() -> SessionRetention {
|
||||
retention
|
||||
}
|
||||
|
||||
/// Records the review context (lane / deployed build / commit / reviewer / note)
|
||||
/// on the open session and persists it in the manifest before returning. Fails
|
||||
/// loudly if the manifest cannot be written — the in-memory session is only
|
||||
/// updated after the durable write succeeds.
|
||||
public func setContext(_ context: ReviewContext) throws -> CaptureSession {
|
||||
let open = try ensureOpenSession()
|
||||
let updated = open.withContext(context)
|
||||
try AtomicFile.writeJSON(
|
||||
updated, to: paths.sessionDirectory(open.id).appendingPathComponent("session.json"))
|
||||
openSession = updated
|
||||
return updated
|
||||
}
|
||||
|
||||
/// The session currently accepting captures. Cheap accessor — all reconciliation already
|
||||
/// happened once, inside init.
|
||||
/// happened once, inside init. A truth guard: if the stored session is no longer really
|
||||
/// open on disk (its directory was archived away and the replacement session could not
|
||||
/// be created — e.g. disk full), a fresh session is minted, or the call fails loudly.
|
||||
/// It never returns an already-archived session as the open one.
|
||||
public func currentSession() throws -> CaptureSession {
|
||||
openSession
|
||||
try ensureOpenSession()
|
||||
}
|
||||
|
||||
/// Mint-or-verify the open session: returns the session that is REALLY open on disk,
|
||||
/// creating a fresh one when the stored one is stale (archived away mid-run). Throws
|
||||
/// loudly when no new session can be created either — never substitutes a lie.
|
||||
private func ensureOpenSession() throws -> CaptureSession {
|
||||
let dir = paths.sessionDirectory(openSession.id)
|
||||
if openSession.state == .open && FileManager.default.fileExists(atPath: dir.path) {
|
||||
return openSession
|
||||
}
|
||||
let staleID = openSession.id.uuidString
|
||||
Log.spool.error(
|
||||
"The stored open session \(staleID, privacy: .public) is not really open on disk; starting a fresh one.")
|
||||
let fresh = try Self.createFreshSession(paths: paths, context: openSession.context)
|
||||
openSession = fresh
|
||||
return fresh
|
||||
}
|
||||
|
||||
/// Writes `pngData` to disk and fsyncs it BEFORE the manifest is touched, then updates and
|
||||
@@ -40,32 +93,37 @@ public actor SpoolStore {
|
||||
pngData: Data, pixelWidth: Int, pixelHeight: Int,
|
||||
scale: CGFloat, capturedAt: Date
|
||||
) throws -> Capture {
|
||||
let open = try ensureOpenSession()
|
||||
let captureID = UUID()
|
||||
let sequence = openSession.nextSequence
|
||||
let sequence = open.nextSequence
|
||||
let fileName = "\(String(format: "%03d", sequence))-\(Self.hexSuffix(captureID)).png"
|
||||
let sessionDir = paths.sessionDirectory(openSession.id)
|
||||
let sessionDir = paths.sessionDirectory(open.id)
|
||||
let fileURL = sessionDir.appendingPathComponent(fileName)
|
||||
try AtomicFile.write(pngData, to: fileURL)
|
||||
let capture = Capture(
|
||||
id: captureID, sequence: sequence, fileName: fileName,
|
||||
pixelWidth: pixelWidth, pixelHeight: pixelHeight,
|
||||
scale: scale, capturedAt: capturedAt)
|
||||
let updated = openSession.appending(capture)
|
||||
let updated = open.appending(capture)
|
||||
try AtomicFile.writeJSON(updated, to: sessionDir.appendingPathComponent("session.json"))
|
||||
openSession = updated
|
||||
return capture
|
||||
}
|
||||
|
||||
/// D-11: moves the capture's PNG into `<sessionDir>/removed/` (created lazily) and drops
|
||||
/// its manifest entry. NEVER unlinks/deletes a user PNG. Throws (no filesystem change) if
|
||||
/// `captureID` is not present in the open session.
|
||||
/// its manifest entry. NEVER unlinks/deletes a user PNG on this path. Throws (no
|
||||
/// filesystem change) if `captureID` is not present in the open session.
|
||||
/// (The one place that removes files is the age limit the user chose in Settings:
|
||||
/// when a session is older than that limit, its WHOLE folder — including
|
||||
/// `removed/` — is pruned. Nothing is pruned while the limit is "Never".)
|
||||
public func remove(captureID: UUID) throws -> CaptureSession {
|
||||
guard let capture = openSession.captures.first(where: { $0.id == captureID }) else {
|
||||
let open = try ensureOpenSession()
|
||||
guard let capture = open.captures.first(where: { $0.id == captureID }) else {
|
||||
throw ShotdeckError.spoolWriteFailed(
|
||||
path: paths.sessionDirectory(openSession.id).path,
|
||||
path: paths.sessionDirectory(open.id).path,
|
||||
underlying: "capture \(captureID) is not in the open session")
|
||||
}
|
||||
let sessionDir = paths.sessionDirectory(openSession.id)
|
||||
let sessionDir = paths.sessionDirectory(open.id)
|
||||
let removedDir = sessionDir.appendingPathComponent("removed", isDirectory: true)
|
||||
do {
|
||||
try FileManager.default.createDirectory(at: removedDir, withIntermediateDirectories: true)
|
||||
@@ -87,37 +145,124 @@ public actor SpoolStore {
|
||||
}
|
||||
|
||||
/// Closes the open session (must be non-empty), moves its directory under archive/, records
|
||||
/// pdfFileName, and starts a fresh empty open session. Returns the archived one.
|
||||
/// pdfFileName, starts a fresh empty open session, and applies session retention.
|
||||
/// Returns the archived one.
|
||||
public func archiveCurrent(pdfFileName: String) throws -> CaptureSession {
|
||||
guard !openSession.isEmpty else {
|
||||
let open = try ensureOpenSession()
|
||||
guard !open.isEmpty else {
|
||||
throw ShotdeckError.spoolWriteFailed(
|
||||
path: paths.sessionDirectory(openSession.id).path,
|
||||
path: paths.sessionDirectory(open.id).path,
|
||||
underlying: "cannot archive an empty session")
|
||||
}
|
||||
let archived = openSession.markArchived(pdfFileName: pdfFileName)
|
||||
let sessionDir = paths.sessionDirectory(openSession.id)
|
||||
let archived = try moveOpenSessionToArchive(open.markArchived(pdfFileName: pdfFileName))
|
||||
openSession = try Self.createFreshSession(paths: paths, context: open.context)
|
||||
applyRetention()
|
||||
return archived
|
||||
}
|
||||
|
||||
/// Closes the open session — sent or not — and keeps its captures as a past
|
||||
/// session under archive/, then starts a fresh empty open session. Unlike
|
||||
/// `archiveCurrent(pdfFileName:)` this never requires a PDF: the archived session
|
||||
/// keeps whatever pdfFileName it already has (nil when it was never sent, which
|
||||
/// the Past submissions list shows as "Not sent"). An empty open session is
|
||||
/// simply replaced — there is nothing to keep. Returns the archived session, or
|
||||
/// nil when the open session was empty.
|
||||
///
|
||||
/// The new session inherits the closed session's review context: one review run
|
||||
/// spans several sessions in the same lane and build, so retyping it each time
|
||||
/// would only add errors.
|
||||
public func closeCurrentSession() throws -> CaptureSession? {
|
||||
let open = try ensureOpenSession()
|
||||
guard !open.isEmpty else {
|
||||
openSession = try Self.createFreshSession(paths: paths, context: open.context)
|
||||
return nil
|
||||
}
|
||||
let archived = try moveOpenSessionToArchive(
|
||||
open.markArchived(pdfFileName: open.pdfFileName))
|
||||
openSession = try Self.createFreshSession(paths: paths, context: open.context)
|
||||
applyRetention()
|
||||
return archived
|
||||
}
|
||||
|
||||
/// Removes archived sessions created before the current age limit's cutoff and
|
||||
/// returns their ids. With `.never` this removes nothing and returns `[]`, so
|
||||
/// "keep everything" needs no separate code path. Only UUID session folders
|
||||
/// directly under archive/ are ever touched — never spool/, never a PDF.
|
||||
public func pruneExpiredSessions(now: Date = Date()) throws -> [UUID] {
|
||||
guard let cutoff = retention.cutoff(now: now) else { return [] }
|
||||
return try removeArchivedSessions(createdBefore: cutoff)
|
||||
}
|
||||
|
||||
/// The ids `pruneExpiredSessions()` would remove right now — what Settings shows
|
||||
/// before the user commits to a cleanup. Empty under `.never`.
|
||||
public func expiredSessionIDs(now: Date = Date()) throws -> [UUID] {
|
||||
guard let cutoff = retention.cutoff(now: now) else { return [] }
|
||||
return try archivedSessions().filter { $0.createdAt < cutoff }.map(\.id)
|
||||
}
|
||||
|
||||
/// Deletes the archived session folders created before `cutoff` and returns their
|
||||
/// ids. Only archive/ is scanned, so an open session can never match.
|
||||
private func removeArchivedSessions(createdBefore cutoff: Date) throws -> [UUID] {
|
||||
let expired = try archivedSessions().filter { $0.createdAt < cutoff }
|
||||
guard !expired.isEmpty else { return [] }
|
||||
var removed: [UUID] = []
|
||||
for session in expired {
|
||||
let dir = paths.archiveDirectory(session.id)
|
||||
do {
|
||||
try FileManager.default.removeItem(at: dir)
|
||||
} catch {
|
||||
throw ShotdeckError.spoolWriteFailed(
|
||||
path: dir.path,
|
||||
underlying: "could not remove an expired session: \(error.localizedDescription)")
|
||||
}
|
||||
removed.append(session.id)
|
||||
}
|
||||
try AtomicFile.fsyncDirectory(at: paths.archive)
|
||||
Log.spool.warning(
|
||||
"Session retention (\(self.retention.displayName, privacy: .public)): removed \(removed.count, privacy: .public) archived session(s) older than \(DubaiTime.stamp(cutoff), privacy: .public).")
|
||||
return removed
|
||||
}
|
||||
|
||||
/// The retention policy every archive path funnels through, so it can never be
|
||||
/// forgotten. A retention failure is logged loudly (with the exact path) and
|
||||
/// never thrown — the archive it follows already succeeded, and converting a
|
||||
/// completed send into a reported failure would be a lie (the safe direction of a
|
||||
/// failed prune is keeping too much, never losing data). The visible symptom of a
|
||||
/// failed prune is simply an old session still in the Past sessions list.
|
||||
private func applyRetention() {
|
||||
do {
|
||||
_ = try pruneExpiredSessions()
|
||||
} catch {
|
||||
Log.spool.error(
|
||||
"Session retention failed — expired sessions were kept: \((error as? ShotdeckError)?.errorDescription ?? error.localizedDescription, privacy: .public)")
|
||||
}
|
||||
}
|
||||
|
||||
/// Writes the archived manifest, then renames the whole session directory from
|
||||
/// spool/ into archive/ in one atomic operation.
|
||||
private func moveOpenSessionToArchive(_ archived: CaptureSession) throws -> CaptureSession {
|
||||
let sessionDir = paths.sessionDirectory(archived.id)
|
||||
try AtomicFile.writeJSON(archived, to: sessionDir.appendingPathComponent("session.json"))
|
||||
let archiveDir = paths.archiveDirectory(openSession.id)
|
||||
let archiveDir = paths.archiveDirectory(archived.id)
|
||||
guard rename(sessionDir.path, archiveDir.path) == 0 else {
|
||||
throw ShotdeckError.spoolWriteFailed(
|
||||
path: sessionDir.path,
|
||||
underlying: "could not move the session into archive/: \(String(cString: strerror(errno)))")
|
||||
}
|
||||
try AtomicFile.fsyncDirectory(at: paths.archive)
|
||||
let fresh = try Self.createFreshSession(paths: paths)
|
||||
openSession = fresh
|
||||
return archived
|
||||
}
|
||||
|
||||
/// Abandons the open session only if it is empty (mints a new id/dir/manifest); throws,
|
||||
/// with no filesystem change, if the open session has captures.
|
||||
public func startNewSession() throws -> CaptureSession {
|
||||
guard openSession.isEmpty else {
|
||||
let open = try ensureOpenSession()
|
||||
guard open.isEmpty else {
|
||||
throw ShotdeckError.spoolWriteFailed(
|
||||
path: paths.sessionDirectory(openSession.id).path,
|
||||
underlying: "cannot start a new session: \(openSession.captures.count) capture(s) present in the open session")
|
||||
path: paths.sessionDirectory(open.id).path,
|
||||
underlying: "cannot start a new session: \(open.captures.count) capture(s) present in the open session")
|
||||
}
|
||||
let fresh = try Self.createFreshSession(paths: paths)
|
||||
let fresh = try Self.createFreshSession(paths: paths, context: open.context)
|
||||
openSession = fresh
|
||||
return fresh
|
||||
}
|
||||
@@ -129,19 +274,44 @@ public actor SpoolStore {
|
||||
return dir.appendingPathComponent(capture.fileName)
|
||||
}
|
||||
|
||||
/// Archived sessions, newest createdAt first. Lazily reconciles each archive/ directory
|
||||
/// Archived sessions, newest first. Lazily reconciles each archive/ directory
|
||||
/// the same way init reconciles spool/ candidates (orphan recovery, missing-drop, corrupt
|
||||
/// rebuild) — an archived session's manifest can degrade too and must self-heal without
|
||||
/// ever losing a PNG.
|
||||
///
|
||||
/// Order: manifest `createdAt` first (whole-second ISO8601 — the manifest format is
|
||||
/// pinned in AtomicFileTests), then the session folder's creation date and content
|
||||
/// modification date to break ties at real resolution (two sessions closed in the
|
||||
/// same second would otherwise order, and therefore prune, arbitrarily by UUID —
|
||||
/// and on a volume that reports no creation date the modification date still keeps
|
||||
/// retention on real order), then the id as the final deterministic tie-break.
|
||||
/// The folder dates are tie-break refinements only — the manifest `createdAt` stays
|
||||
/// the authoritative timestamp; if a volume reports neither date the tie-break
|
||||
/// degrades to the id.
|
||||
public func archivedSessions() throws -> [CaptureSession] {
|
||||
let ids = try Self.listUUIDDirectories(in: paths.archive, fileManager: .default)
|
||||
var sessions: [CaptureSession] = []
|
||||
var keyed: [(session: CaptureSession, folderCreatedAt: Date, folderModifiedAt: Date)] = []
|
||||
for id in ids {
|
||||
sessions.append(
|
||||
try Self.reconcileSessionDirectory(
|
||||
at: paths.archiveDirectory(id), id: id, assumedStateIfRebuilt: .archived, fileManager: .default))
|
||||
let dir = paths.archiveDirectory(id)
|
||||
// Read the folder dates BEFORE reconciling: reconciliation can rewrite
|
||||
// session.json and bump the folder's modification date to "now", which
|
||||
// would let a healed older session outrank a genuinely newer same-second
|
||||
// peer in the tie-break below.
|
||||
let values = try? dir.resourceValues(forKeys: [.creationDateKey, .contentModificationDateKey])
|
||||
let session = try Self.reconcileSessionDirectory(
|
||||
at: dir, id: id, assumedStateIfRebuilt: .archived, fileManager: .default)
|
||||
// The manifest `createdAt` is the authoritative timestamp; the folder dates
|
||||
// only refine ties between same-second sessions.
|
||||
let folderCreatedAt = values?.creationDate ?? session.createdAt
|
||||
let folderModifiedAt = values?.contentModificationDate ?? folderCreatedAt
|
||||
keyed.append((session, folderCreatedAt, folderModifiedAt))
|
||||
}
|
||||
return sessions.sorted { ($0.createdAt, $0.id.uuidString) > ($1.createdAt, $1.id.uuidString) }
|
||||
return keyed
|
||||
.sorted { lhs, rhs in
|
||||
(lhs.session.createdAt, lhs.folderCreatedAt, lhs.folderModifiedAt, lhs.session.id.uuidString)
|
||||
> (rhs.session.createdAt, rhs.folderCreatedAt, rhs.folderModifiedAt, rhs.session.id.uuidString)
|
||||
}
|
||||
.map(\.session)
|
||||
}
|
||||
|
||||
// MARK: - Reconciliation (static so they can run inside init)
|
||||
@@ -257,7 +427,8 @@ public actor SpoolStore {
|
||||
createdAt: session.createdAt,
|
||||
state: session.state,
|
||||
captures: finalCaptures,
|
||||
pdfFileName: session.pdfFileName)
|
||||
pdfFileName: session.pdfFileName,
|
||||
context: session.context)
|
||||
try AtomicFile.writeJSON(updated, to: manifestURL)
|
||||
Log.spool.warning("Reconciled session \(id.uuidString, privacy: .public): dropped \(missingCount) missing PNG(s), recovered \(recoveredOrphans.count) orphan(s).")
|
||||
return updated
|
||||
@@ -342,7 +513,10 @@ public actor SpoolStore {
|
||||
}
|
||||
}
|
||||
|
||||
private static func createFreshSession(paths: AppSupportPaths) throws -> CaptureSession {
|
||||
private static func createFreshSession(
|
||||
paths: AppSupportPaths,
|
||||
context: ReviewContext
|
||||
) throws -> CaptureSession {
|
||||
let id = UUID()
|
||||
let createdAt = Date()
|
||||
let dir = paths.sessionDirectory(id)
|
||||
@@ -351,7 +525,9 @@ public actor SpoolStore {
|
||||
} catch {
|
||||
throw ShotdeckError.spoolWriteFailed(path: dir.path, underlying: error.localizedDescription)
|
||||
}
|
||||
let session = CaptureSession(id: id, createdAt: createdAt, state: .open, captures: [], pdfFileName: nil)
|
||||
let session = CaptureSession(
|
||||
id: id, createdAt: createdAt, state: .open, captures: [], pdfFileName: nil,
|
||||
context: context)
|
||||
try AtomicFile.writeJSON(session, to: dir.appendingPathComponent("session.json"))
|
||||
return session
|
||||
}
|
||||
|
||||
@@ -11,12 +11,6 @@ public struct AppSupportPaths: Sendable {
|
||||
/// Production paths.
|
||||
public static func standard() throws -> AppSupportPaths {
|
||||
let fileManager = FileManager.default
|
||||
let appSupportParent = try fileManager.url(
|
||||
for: .applicationSupportDirectory,
|
||||
in: .userDomainMask,
|
||||
appropriateFor: nil,
|
||||
create: true
|
||||
)
|
||||
let desktop = try fileManager.url(
|
||||
for: .desktopDirectory,
|
||||
in: .userDomainMask,
|
||||
@@ -29,10 +23,25 @@ public struct AppSupportPaths: Sendable {
|
||||
appropriateFor: nil,
|
||||
create: true
|
||||
)
|
||||
let root = appSupportParent.appendingPathComponent("Shotdeck", isDirectory: true)
|
||||
let root = try standardRoot(fileManager: fileManager)
|
||||
return try AppSupportPaths(root: root, outbox: desktop, watchFolder: downloads)
|
||||
}
|
||||
|
||||
/// The standard `~/Library/Application Support/Shotdeck` root. Shared by
|
||||
/// `standard()`, `FolderSettings.resolvedAppSupportPaths()`, and
|
||||
/// `TransportSettings.resolvedAppSupportPaths()` so all three agree on where the
|
||||
/// root lives — the folder-resolution logic (AirDrop-only vs transport-aware)
|
||||
/// differs between those, the root computation never should.
|
||||
public static func standardRoot(fileManager: FileManager = .default) throws -> URL {
|
||||
let appSupportParent = try fileManager.url(
|
||||
for: .applicationSupportDirectory,
|
||||
in: .userDomainMask,
|
||||
appropriateFor: nil,
|
||||
create: true
|
||||
)
|
||||
return appSupportParent.appendingPathComponent("Shotdeck", isDirectory: true)
|
||||
}
|
||||
|
||||
/// Test paths rooted anywhere. Every directory is created if missing.
|
||||
public init(root: URL, outbox: URL, watchFolder: URL) throws {
|
||||
self.root = root
|
||||
|
||||
@@ -3,6 +3,11 @@ import Foundation
|
||||
public enum DubaiTime {
|
||||
private static let stampFormatter = LockedDateFormatter(dateFormat: "d MMM yyyy, HH:mm 'Dubai'")
|
||||
private static let fileStampFormatter = LockedDateFormatter(dateFormat: "yyyyMMdd-HHmmss")
|
||||
private static let fileMinuteStampFormatter = LockedDateFormatter(dateFormat: "yyyyMMdd-HHmm")
|
||||
private static let checkTimeFormatter = LockedDateFormatter(dateFormat: "HH:mm 'Dubai'")
|
||||
private static let shortStampFormatter = LockedDateFormatter(dateFormat: "d MMM yyyy, HH:mm")
|
||||
private static let dayStampFormatter = LockedDateFormatter(dateFormat: "d MMM yyyy")
|
||||
private static let keywordStampFormatter = LockedDateFormatter(dateFormat: "yyyy-MM-dd HH:mm 'Dubai'")
|
||||
|
||||
public static func stamp(_ date: Date) -> String {
|
||||
stampFormatter.string(from: date)
|
||||
@@ -11,6 +16,32 @@ public enum DubaiTime {
|
||||
public static func fileStamp(_ date: Date) -> String {
|
||||
fileStampFormatter.string(from: date)
|
||||
}
|
||||
|
||||
/// `yyyyMMdd-HHmm` — used in PDF file names where minutes are the useful detail.
|
||||
public static func fileMinuteStamp(_ date: Date) -> String {
|
||||
fileMinuteStampFormatter.string(from: date)
|
||||
}
|
||||
|
||||
/// "31 Oct 2026, 10:31" — compact session-list timestamp (the timezone is stated
|
||||
/// once in the list header, not on every row).
|
||||
public static func shortStamp(_ date: Date) -> String {
|
||||
shortStampFormatter.string(from: date)
|
||||
}
|
||||
|
||||
/// "31 Oct 2026" — for day-granular expiry notices.
|
||||
public static func dayStamp(_ date: Date) -> String {
|
||||
dayStampFormatter.string(from: date)
|
||||
}
|
||||
|
||||
/// "2026-10-31 11:00 Dubai" — for PDF keywords, where a comma would be read as a
|
||||
/// keyword separator by the PDF format itself.
|
||||
public static func keywordStamp(_ date: Date) -> String {
|
||||
keywordStampFormatter.string(from: date)
|
||||
}
|
||||
|
||||
public static func checkTime(_ date: Date) -> String {
|
||||
checkTimeFormatter.string(from: date)
|
||||
}
|
||||
}
|
||||
|
||||
/// DateFormatter is not Sendable. This holder is the only shared mutable state
|
||||
|
||||
@@ -70,15 +70,7 @@ public enum FolderSettings {
|
||||
defaults: UserDefaults = .standard,
|
||||
fileManager: FileManager = .default
|
||||
) throws -> AppSupportPaths {
|
||||
let resolvedRoot: URL
|
||||
if let root {
|
||||
resolvedRoot = root
|
||||
} else {
|
||||
let appSupportParent = try fileManager.url(
|
||||
for: .applicationSupportDirectory, in: .userDomainMask,
|
||||
appropriateFor: nil, create: true)
|
||||
resolvedRoot = appSupportParent.appendingPathComponent("Shotdeck", isDirectory: true)
|
||||
}
|
||||
let resolvedRoot = try root ?? AppSupportPaths.standardRoot(fileManager: fileManager)
|
||||
let folders = resolve(defaults: defaults, fileManager: fileManager)
|
||||
return try AppSupportPaths(root: resolvedRoot, outbox: folders.outbox, watchFolder: folders.watch)
|
||||
}
|
||||
|
||||
@@ -0,0 +1,69 @@
|
||||
import Foundation
|
||||
|
||||
/// How long Redline keeps a past session's captured screenshots.
|
||||
///
|
||||
/// The default is `.never`: every session is saved and nothing is deleted unless the
|
||||
/// user picks an age limit in Settings. Session folders are the only thing an age
|
||||
/// policy ever removes — a PDF that was already sent stays in the folder it went to.
|
||||
public enum SessionRetention: Sendable, Equatable, Hashable {
|
||||
case never
|
||||
case days(Int)
|
||||
|
||||
/// The one list Settings offers, in display order. `nil` day counts never expire.
|
||||
public static let presets: [SessionRetention] = [
|
||||
.never, .days(7), .days(14), .days(30), .days(90), .days(180), .days(365),
|
||||
]
|
||||
|
||||
public var dayCount: Int? {
|
||||
switch self {
|
||||
case .never: return nil
|
||||
case .days(let count): return count
|
||||
}
|
||||
}
|
||||
|
||||
/// "Never (default)", "7 days", "30 days", "1 year".
|
||||
public var displayName: String {
|
||||
switch self {
|
||||
case .never: return "Never (default)"
|
||||
case .days(365): return "1 year"
|
||||
case .days(let count): return "\(count) days"
|
||||
}
|
||||
}
|
||||
|
||||
/// Caption for the Settings row and the panel footer: what actually happens.
|
||||
public var policyDescription: String {
|
||||
switch self {
|
||||
case .never: return "All sessions kept."
|
||||
case .days(365): return "Sessions older than 1 year are deleted."
|
||||
case .days(let count): return "Sessions older than \(count) days are deleted."
|
||||
}
|
||||
}
|
||||
|
||||
/// Sessions created before this instant are expired; nil means nothing expires.
|
||||
public func cutoff(now: Date = Date()) -> Date? {
|
||||
guard let dayCount else { return nil }
|
||||
return Calendar(identifier: .gregorian).date(byAdding: .day, value: -dayCount, to: now)
|
||||
}
|
||||
}
|
||||
|
||||
/// Persistence for the age limit, backed by UserDefaults.
|
||||
///
|
||||
/// Stored as a day count; 0 (or no stored value at all) means `never`. A stored value
|
||||
/// is only ever written by `save`, so an absent key is the honest "user never chose"
|
||||
/// state, not a hidden default.
|
||||
public enum RetentionSettings {
|
||||
public static let defaultsKey = "ai.flowmaster.shotdeck.sessionRetentionDays"
|
||||
|
||||
public static func load(defaults: UserDefaults = .standard) -> SessionRetention {
|
||||
guard let stored = defaults.object(forKey: defaultsKey) as? Int else { return .never }
|
||||
return stored > 0 ? .days(stored) : .never
|
||||
}
|
||||
|
||||
public static func save(_ value: SessionRetention, defaults: UserDefaults = .standard) {
|
||||
guard let dayCount = value.dayCount else {
|
||||
defaults.removeObject(forKey: defaultsKey)
|
||||
return
|
||||
}
|
||||
defaults.set(dayCount, forKey: defaultsKey)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,221 @@
|
||||
import Foundation
|
||||
|
||||
/// The two ways a composed PDF can reach the iPad and come back marked up.
|
||||
public enum SendTransport: String, Codable, Sendable, CaseIterable {
|
||||
case airDrop
|
||||
case oneDrive
|
||||
|
||||
public var displayName: String {
|
||||
switch self {
|
||||
case .airDrop: return "AirDrop"
|
||||
case .oneDrive: return "OneDrive folder"
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// User-configurable transport choice plus the OneDrive folder override, backed by
|
||||
/// UserDefaults the same way `FolderSettings` is. See `FolderSettings` for why a plain
|
||||
/// path (not a security-scoped bookmark) is correct for this unsandboxed app.
|
||||
public enum TransportSettings {
|
||||
public static let transportDefaultsKey = "ai.flowmaster.shotdeck.transport"
|
||||
public static let oneDriveFolderDefaultsKey = "ai.flowmaster.shotdeck.oneDriveFolder"
|
||||
|
||||
/// Defaults to `.airDrop` when unset or when the stored value cannot be parsed.
|
||||
public static func transport(defaults: UserDefaults = .standard) -> SendTransport {
|
||||
guard let raw = defaults.string(forKey: transportDefaultsKey),
|
||||
let value = SendTransport(rawValue: raw)
|
||||
else { return .airDrop }
|
||||
return value
|
||||
}
|
||||
|
||||
public static func setTransport(_ value: SendTransport, defaults: UserDefaults = .standard) {
|
||||
defaults.set(value.rawValue, forKey: transportDefaultsKey)
|
||||
}
|
||||
|
||||
/// Raw stored path (or nil if never set / cleared). Does NOT validate that the
|
||||
/// directory still exists.
|
||||
public static func storedOneDriveFolderPath(defaults: UserDefaults = .standard) -> String? {
|
||||
defaults.string(forKey: oneDriveFolderDefaultsKey)
|
||||
}
|
||||
|
||||
public static func setOneDriveFolder(_ url: URL, defaults: UserDefaults = .standard) {
|
||||
defaults.set(url.path, forKey: oneDriveFolderDefaultsKey)
|
||||
}
|
||||
|
||||
public static func resetOneDriveFolder(defaults: UserDefaults = .standard) {
|
||||
defaults.removeObject(forKey: oneDriveFolderDefaultsKey)
|
||||
}
|
||||
|
||||
/// The outbox/watch folders Redline should actually use right now, for the current
|
||||
/// transport. AirDrop mode delegates to `FolderSettings.resolve()` unchanged.
|
||||
/// OneDrive mode uses the SAME folder for both outbox and watch — see
|
||||
/// `OneDriveLocator.resolveOneDriveFolder`. When no OneDrive folder can be resolved
|
||||
/// at all (no sync root, no override), this falls back to the AirDrop folders so the
|
||||
/// app always has somewhere to write; `send(anchor:)` performs its own live
|
||||
/// existence check before ever composing into a OneDrive send, so that fallback is
|
||||
/// never mistaken for a valid OneDrive destination.
|
||||
public static func effectiveFolders(
|
||||
defaults: UserDefaults = .standard,
|
||||
fileManager: FileManager = .default
|
||||
) -> (outbox: URL, watch: URL, transport: SendTransport) {
|
||||
let transport = transport(defaults: defaults)
|
||||
switch transport {
|
||||
case .airDrop:
|
||||
let folders = FolderSettings.resolve(defaults: defaults, fileManager: fileManager)
|
||||
return (folders.outbox, folders.watch, transport)
|
||||
case .oneDrive:
|
||||
if let folder = OneDriveLocator.resolveOneDriveFolder(
|
||||
defaults: defaults,
|
||||
home: fileManager.homeDirectoryForCurrentUser,
|
||||
fileManager: fileManager
|
||||
) {
|
||||
return (folder, folder, transport)
|
||||
}
|
||||
let folders = FolderSettings.resolve(defaults: defaults, fileManager: fileManager)
|
||||
return (folders.outbox, folders.watch, transport)
|
||||
}
|
||||
}
|
||||
|
||||
/// Builds an `AppSupportPaths` using `root` (defaults to the standard
|
||||
/// `~/Library/Application Support/Shotdeck` when nil) plus whatever
|
||||
/// `effectiveFolders()` returns for outbox/watch. Unlike
|
||||
/// `FolderSettings.resolvedAppSupportPaths()` (AirDrop-only), this is
|
||||
/// transport-aware — it is the ONLY function launch code should use to build its
|
||||
/// paths, so the watcher it feeds is never seeded with a stale AirDrop folder while
|
||||
/// OneDrive is the persisted transport. `root` is exposed purely so tests (and the
|
||||
/// ONEDRIVE-SELFTEST relaunch simulation) can point it at a temporary directory
|
||||
/// instead of the user's real Application Support folder.
|
||||
public static func resolvedAppSupportPaths(
|
||||
root: URL? = nil,
|
||||
defaults: UserDefaults = .standard,
|
||||
fileManager: FileManager = .default
|
||||
) throws -> AppSupportPaths {
|
||||
let resolvedRoot = try root ?? AppSupportPaths.standardRoot(fileManager: fileManager)
|
||||
let folders = effectiveFolders(defaults: defaults, fileManager: fileManager)
|
||||
return try AppSupportPaths(root: resolvedRoot, outbox: folders.outbox, watchFolder: folders.watch)
|
||||
}
|
||||
}
|
||||
|
||||
/// Pure path logic for locating a OneDrive sync root under
|
||||
/// `~/Library/CloudStorage` and the Redline folder inside it. No side effects — never
|
||||
/// creates a directory. Fully unit-testable with a fake home tree.
|
||||
public enum OneDriveLocator {
|
||||
/// Every directory directly under `<home>/Library/CloudStorage` whose name starts
|
||||
/// with "OneDrive-", sorted so a name containing "MMD" (case-insensitive) sorts
|
||||
/// first, then alphabetically. Empty when CloudStorage does not exist.
|
||||
public static func syncRoots(
|
||||
home: URL = FileManager.default.homeDirectoryForCurrentUser,
|
||||
fileManager: FileManager = .default
|
||||
) -> [URL] {
|
||||
let cloudStorage = home.appendingPathComponent("Library/CloudStorage", isDirectory: true)
|
||||
var isDirectory: ObjCBool = false
|
||||
guard fileManager.fileExists(atPath: cloudStorage.path, isDirectory: &isDirectory),
|
||||
isDirectory.boolValue
|
||||
else { return [] }
|
||||
|
||||
let items = (try? fileManager.contentsOfDirectory(
|
||||
at: cloudStorage,
|
||||
includingPropertiesForKeys: [.isDirectoryKey],
|
||||
options: [.skipsHiddenFiles]
|
||||
)) ?? []
|
||||
|
||||
let roots = items.filter { url in
|
||||
guard url.lastPathComponent.hasPrefix("OneDrive-") else { return false }
|
||||
var itemIsDirectory: ObjCBool = false
|
||||
let exists = fileManager.fileExists(atPath: url.path, isDirectory: &itemIsDirectory)
|
||||
return exists && itemIsDirectory.boolValue
|
||||
}
|
||||
|
||||
return roots.sorted { a, b in
|
||||
let aName = a.lastPathComponent
|
||||
let bName = b.lastPathComponent
|
||||
let aIsMMD = aName.localizedCaseInsensitiveContains("MMD")
|
||||
let bIsMMD = bName.localizedCaseInsensitiveContains("MMD")
|
||||
if aIsMMD != bIsMMD { return aIsMMD }
|
||||
return aName.localizedStandardCompare(bName) == .orderedAscending
|
||||
}
|
||||
}
|
||||
|
||||
/// First sync root's "Redline" subfolder, or nil when there is no sync root at all.
|
||||
public static func defaultRedlineFolder(
|
||||
home: URL = FileManager.default.homeDirectoryForCurrentUser,
|
||||
fileManager: FileManager = .default
|
||||
) -> URL? {
|
||||
guard let first = syncRoots(home: home, fileManager: fileManager).first else { return nil }
|
||||
return first.appendingPathComponent("Redline", isDirectory: true)
|
||||
}
|
||||
|
||||
/// The stored override when it is set AND still exists as a directory; otherwise
|
||||
/// `defaultRedlineFolder`. Never creates anything.
|
||||
public static func resolveOneDriveFolder(
|
||||
defaults: UserDefaults = .standard,
|
||||
home: URL = FileManager.default.homeDirectoryForCurrentUser,
|
||||
fileManager: FileManager = .default
|
||||
) -> URL? {
|
||||
if let storedPath = TransportSettings.storedOneDriveFolderPath(defaults: defaults) {
|
||||
var isDirectory: ObjCBool = false
|
||||
let exists = fileManager.fileExists(atPath: storedPath, isDirectory: &isDirectory)
|
||||
if exists, isDirectory.boolValue {
|
||||
return URL(fileURLWithPath: storedPath, isDirectory: true)
|
||||
}
|
||||
}
|
||||
return defaultRedlineFolder(home: home, fileManager: fileManager)
|
||||
}
|
||||
|
||||
/// True when `url` exists as a directory AND is writable by the current process.
|
||||
/// The live check `send(anchor:)` performs before ever composing into a OneDrive
|
||||
/// destination — a directory that exists but has had its permissions revoked (e.g.
|
||||
/// `chmod 500`) must be treated as unavailable, not silently attempted and
|
||||
/// surfaced as a generic PDF-composition failure.
|
||||
public static func isWritableDirectory(
|
||||
at url: URL,
|
||||
fileManager: FileManager = .default
|
||||
) -> Bool {
|
||||
var isDirectory: ObjCBool = false
|
||||
let exists = fileManager.fileExists(atPath: url.path, isDirectory: &isDirectory)
|
||||
guard exists, isDirectory.boolValue else { return false }
|
||||
return fileManager.isWritableFile(atPath: url.path)
|
||||
}
|
||||
|
||||
/// Writes a tiny probe file into `folder`, fsyncs it, then removes it — the only
|
||||
/// reliable way to catch a OneDrive Files-On-Demand directory whose provider domain
|
||||
/// is signed out: such a directory can report as existing and POSIX-writable
|
||||
/// (`isWritableDirectory` returns true) while an actual write fails. True only when
|
||||
/// the write, fsync, AND removal of the probe file all succeed; any failure at any
|
||||
/// of those steps means false, so the caller treats the folder as unavailable
|
||||
/// rather than proceeding to compose a real PDF into it.
|
||||
public static func probeWritable(
|
||||
at folder: URL,
|
||||
fileManager: FileManager = .default
|
||||
) -> Bool {
|
||||
let probeURL = folder.appendingPathComponent(".redline-probe-\(UUID().uuidString)")
|
||||
// Belt-and-suspenders cleanup, unconditional: AtomicFile.write renames the temp
|
||||
// file onto probeURL and THEN fsyncs the containing directory — if that last
|
||||
// fsync throws, the probe file already exists on disk but the catch below
|
||||
// returns false before ever reaching the explicit removeItem call. And if the
|
||||
// explicit removeItem itself throws, this is the only retry it gets. Either
|
||||
// way, never leave the probe file behind just because we're about to return.
|
||||
defer {
|
||||
if fileManager.fileExists(atPath: probeURL.path) {
|
||||
try? fileManager.removeItem(at: probeURL)
|
||||
}
|
||||
}
|
||||
|
||||
do {
|
||||
try AtomicFile.write(Data(), to: probeURL)
|
||||
} catch {
|
||||
return false
|
||||
}
|
||||
|
||||
do {
|
||||
try fileManager.removeItem(at: probeURL)
|
||||
} catch {
|
||||
return false
|
||||
}
|
||||
|
||||
// Only true when the explicit removal above actually succeeded AND the file is
|
||||
// confirmed gone — never trust a removeItem call that returned without throwing
|
||||
// as proof of anything on a File Provider domain.
|
||||
return !fileManager.fileExists(atPath: probeURL.path)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,125 @@
|
||||
import Foundation
|
||||
import Testing
|
||||
import ShotdeckCore
|
||||
|
||||
@Test
|
||||
func syncRootsFindsOneDriveDirsMMDFirstIgnoresNonDirsAndOtherProviders() throws {
|
||||
let home = try makeFakeHome()
|
||||
defer { try? FileManager.default.removeItem(at: home) }
|
||||
let cloudStorage = home.appendingPathComponent("Library/CloudStorage", isDirectory: true)
|
||||
try FileManager.default.createDirectory(at: cloudStorage, withIntermediateDirectories: true)
|
||||
|
||||
try FileManager.default.createDirectory(
|
||||
at: cloudStorage.appendingPathComponent("OneDrive-Flowmaster", isDirectory: true),
|
||||
withIntermediateDirectories: true
|
||||
)
|
||||
try FileManager.default.createDirectory(
|
||||
at: cloudStorage.appendingPathComponent("OneDrive-MMDGROUP", isDirectory: true),
|
||||
withIntermediateDirectories: true
|
||||
)
|
||||
try FileManager.default.createDirectory(
|
||||
at: cloudStorage.appendingPathComponent("GoogleDrive-x", isDirectory: true),
|
||||
withIntermediateDirectories: true
|
||||
)
|
||||
// A plain FILE (not a directory) named like a OneDrive root must be ignored.
|
||||
FileManager.default.createFile(
|
||||
atPath: cloudStorage.appendingPathComponent("OneDrive-notadir").path,
|
||||
contents: Data("not a directory".utf8)
|
||||
)
|
||||
|
||||
let roots = OneDriveLocator.syncRoots(home: home, fileManager: .default)
|
||||
|
||||
#expect(roots.map(\.lastPathComponent) == ["OneDrive-MMDGROUP", "OneDrive-Flowmaster"])
|
||||
}
|
||||
|
||||
@Test
|
||||
func syncRootsEmptyAndDefaultFolderNilWithNoCloudStorageDirectory() throws {
|
||||
let home = try makeFakeHome()
|
||||
defer { try? FileManager.default.removeItem(at: home) }
|
||||
// No Library/CloudStorage created at all.
|
||||
|
||||
let roots = OneDriveLocator.syncRoots(home: home, fileManager: .default)
|
||||
#expect(roots.isEmpty)
|
||||
|
||||
let defaultFolder = OneDriveLocator.defaultRedlineFolder(home: home, fileManager: .default)
|
||||
#expect(defaultFolder == nil)
|
||||
}
|
||||
|
||||
@Test
|
||||
func defaultRedlineFolderIsFirstSyncRootPlusRedline() throws {
|
||||
let home = try makeFakeHome()
|
||||
defer { try? FileManager.default.removeItem(at: home) }
|
||||
let cloudStorage = home.appendingPathComponent("Library/CloudStorage", isDirectory: true)
|
||||
try FileManager.default.createDirectory(
|
||||
at: cloudStorage.appendingPathComponent("OneDrive-MMDGROUP", isDirectory: true),
|
||||
withIntermediateDirectories: true
|
||||
)
|
||||
try FileManager.default.createDirectory(
|
||||
at: cloudStorage.appendingPathComponent("OneDrive-Flowmaster", isDirectory: true),
|
||||
withIntermediateDirectories: true
|
||||
)
|
||||
|
||||
let defaultFolder = try #require(
|
||||
OneDriveLocator.defaultRedlineFolder(home: home, fileManager: .default)
|
||||
)
|
||||
// Derive "expected" from syncRoots() itself (already covered by its own dedicated
|
||||
// test) rather than hand-building the path string — FileManager's directory
|
||||
// enumeration can canonicalize /var -> /private/var and the two constructions
|
||||
// otherwise disagree on that even for a URL that already exists.
|
||||
let expectedRoot = try #require(OneDriveLocator.syncRoots(home: home, fileManager: .default).first)
|
||||
let expected = expectedRoot.appendingPathComponent("Redline", isDirectory: true)
|
||||
#expect(defaultFolder.path == expected.path)
|
||||
}
|
||||
|
||||
@Test
|
||||
func resolveOneDriveFolderPrefersAnExistingStoredOverride() throws {
|
||||
let home = try makeFakeHome()
|
||||
defer { try? FileManager.default.removeItem(at: home) }
|
||||
let cloudStorage = home.appendingPathComponent("Library/CloudStorage", isDirectory: true)
|
||||
try FileManager.default.createDirectory(
|
||||
at: cloudStorage.appendingPathComponent("OneDrive-MMDGROUP", isDirectory: true),
|
||||
withIntermediateDirectories: true
|
||||
)
|
||||
|
||||
let suite = try makeTransportDefaultsSuite()
|
||||
defer { tearDownTransportSuite(suite) }
|
||||
let override = try makeTransportTemporaryDirectory(prefix: "shotdeck-onedrive-override")
|
||||
defer { try? FileManager.default.removeItem(at: override) }
|
||||
TransportSettings.setOneDriveFolder(override, defaults: suite.defaults)
|
||||
|
||||
let resolved = OneDriveLocator.resolveOneDriveFolder(
|
||||
defaults: suite.defaults, home: home, fileManager: .default
|
||||
)
|
||||
#expect(resolved?.path == override.path)
|
||||
}
|
||||
|
||||
@Test
|
||||
func resolveOneDriveFolderIgnoresAStoredPathThatNoLongerExists() throws {
|
||||
let home = try makeFakeHome()
|
||||
defer { try? FileManager.default.removeItem(at: home) }
|
||||
let cloudStorage = home.appendingPathComponent("Library/CloudStorage", isDirectory: true)
|
||||
try FileManager.default.createDirectory(
|
||||
at: cloudStorage.appendingPathComponent("OneDrive-MMDGROUP", isDirectory: true),
|
||||
withIntermediateDirectories: true
|
||||
)
|
||||
|
||||
let suite = try makeTransportDefaultsSuite()
|
||||
defer { tearDownTransportSuite(suite) }
|
||||
let goneOverride = try makeTransportTemporaryDirectory(prefix: "shotdeck-onedrive-gone")
|
||||
TransportSettings.setOneDriveFolder(goneOverride, defaults: suite.defaults)
|
||||
try FileManager.default.removeItem(at: goneOverride)
|
||||
|
||||
let resolved = OneDriveLocator.resolveOneDriveFolder(
|
||||
defaults: suite.defaults, home: home, fileManager: .default
|
||||
)
|
||||
let expectedRoot = try #require(OneDriveLocator.syncRoots(home: home, fileManager: .default).first)
|
||||
let expected = expectedRoot.appendingPathComponent("Redline", isDirectory: true)
|
||||
#expect(resolved?.path == expected.path)
|
||||
}
|
||||
|
||||
private func makeFakeHome() throws -> URL {
|
||||
let home = FileManager.default.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-fake-home-\(UUID().uuidString)", isDirectory: true)
|
||||
try FileManager.default.createDirectory(at: home, withIntermediateDirectories: true)
|
||||
return home
|
||||
}
|
||||
@@ -203,17 +203,123 @@ private func pixelWindow(
|
||||
return (pixelX0, pixelY0, pixelX1, pixelY1)
|
||||
}
|
||||
|
||||
@Test("fileName uses compose time, not session.createdAt, and matches Redline-yyyyMMdd-HHmmss.pdf")
|
||||
@Test("fileName is Redline-yyyyMMdd-HHmm-SHORTID.pdf and uses compose time")
|
||||
func fileNameUsesComposeTimeNotSessionCreatedAt() {
|
||||
let old = Date(timeIntervalSince1970: 1_600_000_000) // 2020-09-13
|
||||
let session = makeSession(captures: [], createdAt: old)
|
||||
let name = PDFComposer.fileName(for: session)
|
||||
#expect(name.wholeMatch(of: /^Redline-\d{8}-\d{6}\.pdf$/) != nil)
|
||||
#expect(!name.contains(DubaiTime.fileStamp(old)))
|
||||
let today = String(DubaiTime.fileStamp(Date()).prefix(8))
|
||||
#expect(name.wholeMatch(of: /^Redline-\d{8}-\d{4}-[0-9A-F]{8}\.pdf$/) != nil)
|
||||
#expect(name.contains(session.shortID))
|
||||
#expect(!name.contains(DubaiTime.fileMinuteStamp(old)))
|
||||
let today = String(DubaiTime.fileMinuteStamp(Date()).prefix(8))
|
||||
#expect(name.contains(today))
|
||||
}
|
||||
|
||||
@Test("fileName carries the lane slug between the timestamp and the session id")
|
||||
func fileNameCarriesTheLaneSlug() {
|
||||
let session = CaptureSession(
|
||||
id: UUID(uuidString: "4f2a9c1d-0000-4000-8000-000000000000")!,
|
||||
createdAt: fixtureDate,
|
||||
state: .open,
|
||||
captures: [],
|
||||
pdfFileName: nil,
|
||||
context: ReviewContext(lane: "OMS test lane"))
|
||||
let name = PDFComposer.fileName(for: session)
|
||||
#expect(name.wholeMatch(of: /^Redline-\d{8}-\d{4}-OMS-TEST-LANE-4F2A9C1D\.pdf$/) != nil)
|
||||
}
|
||||
|
||||
@Test("Review footer lines state the tool, date, session and the recorded review details")
|
||||
func footerLinesStateTheReviewDetails() {
|
||||
let session = CaptureSession(
|
||||
id: UUID(uuidString: "4f2a9c1d-0000-4000-8000-000000000000")!,
|
||||
createdAt: fixtureDate,
|
||||
state: .open,
|
||||
captures: [],
|
||||
pdfFileName: nil,
|
||||
context: ReviewContext(
|
||||
lane: "dev03", deployedVersion: "v1.4.2 (41)", commit: "a1b2c3d4",
|
||||
reviewer: "Ben Hippler", note: "checkout"))
|
||||
let lines = PDFComposer.footerLines(
|
||||
session: session, toolVersion: "0.5.0", composedAt: fixtureDate)
|
||||
#expect(lines.count == 2)
|
||||
#expect(lines[0].contains("Redline 0.5.0"))
|
||||
#expect(lines[0].contains("Session 4F2A9C1D"))
|
||||
#expect(lines[0].contains(DubaiTime.stamp(fixtureDate)))
|
||||
#expect(lines[1].contains("Lane dev03"))
|
||||
#expect(lines[1].contains("Deployed v1.4.2 (41)"))
|
||||
#expect(lines[1].contains("Commit a1b2c3d4"))
|
||||
#expect(lines[1].contains("Reviewer Ben Hippler"))
|
||||
#expect(lines[1].contains("Note checkout"))
|
||||
|
||||
// A session with no recorded details still identifies itself; nothing is faked.
|
||||
let bare = makeSession(captures: [])
|
||||
let bareLines = PDFComposer.footerLines(
|
||||
session: bare, toolVersion: "", composedAt: fixtureDate)
|
||||
#expect(bareLines.count == 1)
|
||||
#expect(bareLines[0].hasPrefix("Redline · "))
|
||||
}
|
||||
|
||||
@Test("Document info carries the reviewer and the lane/build/commit keywords")
|
||||
func documentInfoCarriesTheReviewDetails() {
|
||||
let session = CaptureSession(
|
||||
id: UUID(uuidString: "deadbeef-dead-4eef-8ead-deadbeef0001")!,
|
||||
createdAt: fixtureDate,
|
||||
state: .open,
|
||||
captures: [],
|
||||
pdfFileName: nil,
|
||||
context: ReviewContext(
|
||||
lane: "DEV03", deployedVersion: "v1.4.2", commit: "a1b2c3d4",
|
||||
reviewer: "Ben Hippler", note: "checkout"))
|
||||
let info = PDFComposer.documentInfo(
|
||||
session: session, title: "Redline – DEV03", toolVersion: "0.5.0", composedAt: fixtureDate)
|
||||
|
||||
#expect(info[kCGPDFContextAuthor as String] as? String == "Ben Hippler")
|
||||
#expect(info[kCGPDFContextCreator as String] as? String == "Redline 0.5.0")
|
||||
let keywords = try? #require(info[kCGPDFContextKeywords as String] as? String)
|
||||
#expect(keywords?.contains("lane=DEV03") == true)
|
||||
#expect(keywords?.contains("deployed=v1.4.2") == true)
|
||||
#expect(keywords?.contains("commit=a1b2c3d4") == true)
|
||||
#expect(keywords?.contains("reviewer=Ben Hippler") == true)
|
||||
#expect(keywords?.contains("built=\(DubaiTime.keywordStamp(fixtureDate))") == true)
|
||||
}
|
||||
|
||||
@Test("A composed PDF carries the footer text and document info a reader can see")
|
||||
func composedPDFCarriesTheReferenceBlock() throws {
|
||||
let directory = try makeScratchDirectory()
|
||||
defer { try? FileManager.default.removeItem(at: directory) }
|
||||
|
||||
let capture = makeCapture(sequence: 1, pixelWidth: 800, pixelHeight: 600)
|
||||
let png = try writePNG(for: capture, red: 60, green: 60, blue: 60, in: directory)
|
||||
let session = CaptureSession(
|
||||
id: UUID(uuidString: "4f2a9c1d-0000-4000-8000-000000000000")!,
|
||||
createdAt: fixtureDate,
|
||||
state: .open,
|
||||
captures: [capture],
|
||||
pdfFileName: nil,
|
||||
context: ReviewContext(
|
||||
lane: "dev03", deployedVersion: "v1.4.2", commit: "a1b2c3d4",
|
||||
reviewer: "Ben Hippler", note: "checkout"))
|
||||
let output = directory.appendingPathComponent("footer.pdf")
|
||||
_ = try PDFComposer().compose(
|
||||
session: session,
|
||||
imageURL: { _ in png },
|
||||
title: "Redline – dev03",
|
||||
to: output,
|
||||
toolVersion: "0.5.0",
|
||||
composedAt: fixtureDate
|
||||
)
|
||||
|
||||
let document = try openDocument(output)
|
||||
let pageText = try #require(document.page(at: 0)?.string ?? "")
|
||||
#expect(pageText.contains("Redline 0.5.0"))
|
||||
#expect(pageText.contains("Lane dev03"))
|
||||
#expect(pageText.contains("Commit a1b2c3d4"))
|
||||
#expect(pageText.contains("Ben Hippler"))
|
||||
|
||||
let attributes = try #require(document.documentAttributes)
|
||||
#expect(attributes[PDFDocumentAttribute.authorAttribute] as? String == "Ben Hippler")
|
||||
}
|
||||
|
||||
@Test("Three-page basic compose")
|
||||
func threePageBasicCompose() throws {
|
||||
let directory = try makeScratchDirectory()
|
||||
|
||||
@@ -230,3 +230,162 @@ func w27_fsEventsCallbackFiresOnRealArrival() async throws {
|
||||
await watcher.stop()
|
||||
}
|
||||
}
|
||||
|
||||
@Test("recordUncommented defaults to true: an unmarked PDF is still recorded (AirDrop behaviour unchanged)")
|
||||
func recordUncommentedDefaultTrueRecordsAnUnmarkedPDF() async throws {
|
||||
let (paths, cleanup) = try makeCasePaths()
|
||||
defer { try? FileManager.default.removeItem(at: cleanup) }
|
||||
|
||||
let ledger = try ReturnLedger(paths: paths)
|
||||
let watcher = ReturnWatcher(paths: paths, ledger: ledger)
|
||||
let pdfURL = paths.watchFolder.appendingPathComponent("Redline-20260905-090000.pdf")
|
||||
|
||||
try makePDF(at: pdfURL, pageCount: 1, creator: "Redline", annotations: [])
|
||||
|
||||
let found = try await watcher.scanNow()
|
||||
#expect(found.count == 1)
|
||||
#expect(found.first?.isCommented == false)
|
||||
|
||||
let all = try await ledger.all()
|
||||
#expect(all.count == 1)
|
||||
}
|
||||
|
||||
@Test("recordUncommented=false: an unmarked PDF is not recorded or returned; marking it up in place gets it recorded")
|
||||
func recordUncommentedFalseSkipsUnmarkedThenRecordsAfterInPlaceMarkup() async throws {
|
||||
let (paths, cleanup) = try makeCasePaths()
|
||||
defer { try? FileManager.default.removeItem(at: cleanup) }
|
||||
|
||||
let ledger = try ReturnLedger(paths: paths)
|
||||
let watcher = ReturnWatcher(paths: paths, ledger: ledger)
|
||||
await watcher.setRecordUncommented(false)
|
||||
let pdfURL = paths.watchFolder.appendingPathComponent("Redline-20260905-091500.pdf")
|
||||
|
||||
// OneDrive mode: the PDF is freshly written here (by "send"), unmarked so far.
|
||||
try makePDF(at: pdfURL, pageCount: 1, creator: "Redline", annotations: [])
|
||||
|
||||
let beforeMarkup = try await watcher.scanNow()
|
||||
#expect(beforeMarkup.isEmpty)
|
||||
let allBefore = try await ledger.all()
|
||||
#expect(allBefore.isEmpty)
|
||||
|
||||
// What the iPad does: mark it up in place, in the SAME folder, then save.
|
||||
let document = try #require(PDFDocument(url: pdfURL))
|
||||
let page = try #require(document.page(at: 0))
|
||||
page.addAnnotation(makeAnnotation(.ink, bounds: CGRect(x: 100, y: 100, width: 120, height: 50)))
|
||||
#expect(document.write(to: pdfURL))
|
||||
|
||||
let afterMarkup = try await watcher.scanNow()
|
||||
#expect(afterMarkup.count == 1)
|
||||
#expect(afterMarkup.first?.isCommented == true)
|
||||
|
||||
let commented = try await ledger.commented()
|
||||
#expect(commented.count == 1)
|
||||
#expect(commented.first?.fileURL.resolvingSymlinksInPath().path == pdfURL.resolvingSymlinksInPath().path)
|
||||
}
|
||||
|
||||
// MARK: - Launch-paths BLOCKER regression (adversarial review, 20260905)
|
||||
//
|
||||
// The bug: AppDelegate.makeLaunchModel() built `paths` via the AirDrop-only
|
||||
// FolderSettings.resolvedAppSupportPaths(), so ReturnWatcher's internal watchFolder
|
||||
// (seeded from paths.watchFolder in its own init) was the AirDrop folder even when
|
||||
// OneDrive was the persisted transport, and bootstrap() never reconciled it before
|
||||
// starting. Net effect: PDFs went to OneDrive but FSEvents kept watching the stale
|
||||
// AirDrop folder for the whole session — marked-up returns were never detected.
|
||||
// The fix: launch paths now come from TransportSettings.resolvedAppSupportPaths()
|
||||
// (transport-aware), and AppModel.bootstrap() unconditionally reconciles the watcher's
|
||||
// folder via updateWatchFolder() before it starts. These two tests characterize the
|
||||
// bug (still reproducible via the old AirDrop-only construction) and prove the fix
|
||||
// (the real launch-construction path, end to end).
|
||||
|
||||
@Test("Launch regression (fix): OneDrive persisted -> transport-aware launch paths -> bootstrap-style reconcile -> a marked PDF is detected")
|
||||
func launchStyleConstructionWithOneDriveTransportDetectsAMarkedReturn() async throws {
|
||||
let suite = try makeTransportDefaultsSuite()
|
||||
defer { tearDownTransportSuite(suite) }
|
||||
let oneDriveFolder = try makeTransportTemporaryDirectory(prefix: "shotdeck-launch-onedrive")
|
||||
defer { try? FileManager.default.removeItem(at: oneDriveFolder) }
|
||||
let appSupportRoot = try makeTransportTemporaryDirectory(prefix: "shotdeck-launch-approot")
|
||||
defer { try? FileManager.default.removeItem(at: appSupportRoot) }
|
||||
|
||||
TransportSettings.setTransport(.oneDrive, defaults: suite.defaults)
|
||||
TransportSettings.setOneDriveFolder(oneDriveFolder, defaults: suite.defaults)
|
||||
|
||||
// Exactly what AppDelegate.makeLaunchModel() now does: build launch paths from the
|
||||
// transport-aware resolver — the fix, NOT FolderSettings.resolvedAppSupportPaths(),
|
||||
// which is AirDrop-only and is the root cause the next test characterizes.
|
||||
let paths = try TransportSettings.resolvedAppSupportPaths(
|
||||
root: appSupportRoot, defaults: suite.defaults, fileManager: .default
|
||||
)
|
||||
#expect(paths.outbox.path == oneDriveFolder.path)
|
||||
#expect(paths.watchFolder.path == oneDriveFolder.path)
|
||||
|
||||
let ledger = try ReturnLedger(paths: paths)
|
||||
let watcher = ReturnWatcher(paths: paths, ledger: ledger)
|
||||
|
||||
// What AppModel.bootstrap() now does, unconditionally, before watcher.start():
|
||||
await watcher.setRecordUncommented(false) // transport == .oneDrive
|
||||
try await watcher.updateWatchFolder(paths.watchFolder)
|
||||
|
||||
let pdfURL = oneDriveFolder.appendingPathComponent("Redline-20260905-100000.pdf")
|
||||
try makePDF(
|
||||
at: pdfURL, pageCount: 1, creator: "Redline",
|
||||
annotations: [(page: 0, annotation: makeAnnotation(
|
||||
.ink, bounds: CGRect(x: 100, y: 100, width: 120, height: 50)
|
||||
))]
|
||||
)
|
||||
|
||||
let found = try await watcher.scanNow()
|
||||
#expect(found.contains(where: {
|
||||
$0.fileURL.resolvingSymlinksInPath().path == pdfURL.resolvingSymlinksInPath().path && $0.isCommented
|
||||
}))
|
||||
|
||||
let commented = try await ledger.commented()
|
||||
#expect(commented.contains(where: {
|
||||
$0.fileURL.resolvingSymlinksInPath().path == pdfURL.resolvingSymlinksInPath().path
|
||||
}))
|
||||
}
|
||||
|
||||
@Test("Launch regression (characterizes the bug): AirDrop-only launch paths with no reconcile miss an OneDrive-mode return")
|
||||
func airDropOnlyLaunchPathsWithoutReconcileMissesAMarkedOneDriveReturn() async throws {
|
||||
let suite = try makeTransportDefaultsSuite()
|
||||
defer { tearDownTransportSuite(suite) }
|
||||
let oneDriveFolder = try makeTransportTemporaryDirectory(prefix: "shotdeck-buggy-onedrive")
|
||||
defer { try? FileManager.default.removeItem(at: oneDriveFolder) }
|
||||
// A configured AirDrop watch-folder override, isolated to a temp dir — NOT the real
|
||||
// ~/Downloads, which may already hold real marked-up Redline PDFs from actual use
|
||||
// and would make this test's "found.isEmpty" assertion depend on the state of
|
||||
// Ben's real Downloads folder instead of the isolated fixture under test.
|
||||
let staleAirDropFolder = try makeTransportTemporaryDirectory(prefix: "shotdeck-buggy-airdrop-stale")
|
||||
defer { try? FileManager.default.removeItem(at: staleAirDropFolder) }
|
||||
let appSupportRoot = try makeTransportTemporaryDirectory(prefix: "shotdeck-buggy-approot")
|
||||
defer { try? FileManager.default.removeItem(at: appSupportRoot) }
|
||||
|
||||
TransportSettings.setTransport(.oneDrive, defaults: suite.defaults)
|
||||
TransportSettings.setOneDriveFolder(oneDriveFolder, defaults: suite.defaults)
|
||||
FolderSettings.setWatchFolder(staleAirDropFolder, defaults: suite.defaults)
|
||||
|
||||
// The BUG's exact construction: FolderSettings.resolvedAppSupportPaths() ignores
|
||||
// the persisted transport entirely and always resolves the AirDrop folders.
|
||||
let buggyPaths = try FolderSettings.resolvedAppSupportPaths(root: appSupportRoot, defaults: suite.defaults)
|
||||
#expect(buggyPaths.watchFolder.path == staleAirDropFolder.path)
|
||||
#expect(buggyPaths.watchFolder.path != oneDriveFolder.path)
|
||||
|
||||
let ledger = try ReturnLedger(paths: buggyPaths)
|
||||
let watcher = ReturnWatcher(paths: buggyPaths, ledger: ledger)
|
||||
// The old bootstrap(): recordUncommented was set, but there was NO
|
||||
// updateWatchFolder() call before start() to reconcile the folder.
|
||||
await watcher.setRecordUncommented(false)
|
||||
|
||||
let pdfURL = oneDriveFolder.appendingPathComponent("Redline-20260905-100100.pdf")
|
||||
try makePDF(
|
||||
at: pdfURL, pageCount: 1, creator: "Redline",
|
||||
annotations: [(page: 0, annotation: makeAnnotation(
|
||||
.ink, bounds: CGRect(x: 100, y: 100, width: 120, height: 50)
|
||||
))]
|
||||
)
|
||||
|
||||
// The watcher is still pointed at the stale (configured-AirDrop) watch folder, so
|
||||
// scanning it — NOT the OneDrive folder the PDF actually landed in — finds nothing.
|
||||
// This is the exact BLOCKER the fix above closes.
|
||||
let found = try await watcher.scanNow()
|
||||
#expect(found.isEmpty)
|
||||
}
|
||||
|
||||
@@ -0,0 +1,138 @@
|
||||
import Foundation
|
||||
import ShotdeckCore
|
||||
import Testing
|
||||
|
||||
// PDF naming scheme + the persisted session age limit.
|
||||
|
||||
// MARK: - PDF file names
|
||||
|
||||
@Test
|
||||
func laneSlugKeepsLettersDigitsAndSingleDashes() {
|
||||
#expect(PDFFileName.laneSlug("OMS test lane") == "OMS-TEST-LANE")
|
||||
#expect(PDFFileName.laneSlug(" dev03 ") == "DEV03")
|
||||
#expect(PDFFileName.laneSlug("v1.4.2 / stage") == "V1-4-2-STAGE")
|
||||
#expect(PDFFileName.laneSlug("") == "")
|
||||
#expect(PDFFileName.laneSlug("--") == "")
|
||||
}
|
||||
|
||||
@Test
|
||||
func laneSlugIsCappedSoTheFileNameStaysShort() {
|
||||
let long = String(repeating: "abcdefghij", count: 5)
|
||||
let slug = PDFFileName.laneSlug(long)
|
||||
#expect(slug.count == PDFFileName.laneMaxLength)
|
||||
#expect(!slug.hasSuffix("-"))
|
||||
}
|
||||
|
||||
@Test
|
||||
func fileNameIsSortableAndUniquePerSession() {
|
||||
let sessionID = UUID(uuidString: "4F2A9C1D-0000-4000-8000-000000000000")!
|
||||
let builtAt = Date(timeIntervalSince1970: 1_777_482_180)
|
||||
|
||||
let withLane = PDFFileName.make(builtAt: builtAt, lane: "dev03", sessionID: sessionID)
|
||||
#expect(withLane == "Redline-\(DubaiTime.fileMinuteStamp(builtAt))-DEV03-4F2A9C1D.pdf")
|
||||
|
||||
let withoutLane = PDFFileName.make(builtAt: builtAt, lane: "", sessionID: sessionID)
|
||||
#expect(withoutLane == "Redline-\(DubaiTime.fileMinuteStamp(builtAt))-4F2A9C1D.pdf")
|
||||
|
||||
// Two sessions in the same minute never collide.
|
||||
let other = UUID(uuidString: "9B8C7D6E-0000-4000-8000-000000000000")!
|
||||
#expect(PDFFileName.make(builtAt: builtAt, lane: "dev03", sessionID: other)
|
||||
!= withLane)
|
||||
}
|
||||
|
||||
@Test
|
||||
func sessionLabelIsLaneOrShortID() {
|
||||
let id = UUID(uuidString: "4F2A9C1D-0000-4000-8000-000000000000")!
|
||||
#expect(PDFFileName.sessionLabel(lane: "dev03", sessionID: id) == "DEV03-4F2A9C1D")
|
||||
#expect(PDFFileName.sessionLabel(lane: "", sessionID: id) == "4F2A9C1D")
|
||||
}
|
||||
|
||||
// MARK: - Retention setting
|
||||
|
||||
@Test
|
||||
func retentionDefaultsToNever() throws {
|
||||
let suite = try makeDefaults()
|
||||
defer { suite.defaults.removePersistentDomain(forName: suite.name) }
|
||||
|
||||
#expect(RetentionSettings.load(defaults: suite.defaults) == .never)
|
||||
#expect(RetentionSettings.load(defaults: suite.defaults).cutoff() == nil)
|
||||
}
|
||||
|
||||
@Test
|
||||
func retentionRoundTripsThroughDefaults() throws {
|
||||
let suite = try makeDefaults()
|
||||
defer { suite.defaults.removePersistentDomain(forName: suite.name) }
|
||||
|
||||
RetentionSettings.save(.days(30), defaults: suite.defaults)
|
||||
#expect(RetentionSettings.load(defaults: suite.defaults) == .days(30))
|
||||
|
||||
RetentionSettings.save(.never, defaults: suite.defaults)
|
||||
#expect(RetentionSettings.load(defaults: suite.defaults) == .never)
|
||||
#expect(suite.defaults.object(forKey: RetentionSettings.defaultsKey) == nil)
|
||||
}
|
||||
|
||||
@Test
|
||||
func retentionCutoffIsTheDayCountBeforeNow() {
|
||||
let now = Date(timeIntervalSince1970: 1_777_482_180)
|
||||
let cutoff = try? #require(SessionRetention.days(30).cutoff(now: now))
|
||||
let expected = Calendar(identifier: .gregorian).date(byAdding: .day, value: -30, to: now)
|
||||
#expect(cutoff == expected)
|
||||
}
|
||||
|
||||
@Test
|
||||
func retentionPresetsReadAsPlainEnglish() {
|
||||
#expect(SessionRetention.never.displayName == "Never (default)")
|
||||
#expect(SessionRetention.days(7).displayName == "7 days")
|
||||
#expect(SessionRetention.days(365).displayName == "1 year")
|
||||
#expect(SessionRetention.never.policyDescription == "All sessions kept.")
|
||||
#expect(SessionRetention.days(14).policyDescription == "Sessions older than 14 days are deleted.")
|
||||
}
|
||||
|
||||
// MARK: - Review context
|
||||
|
||||
@Test
|
||||
func reviewContextTrimsCapsAndCollapsesLineBreaks() {
|
||||
let long = String(repeating: "x", count: ReviewContext.maxFieldLength + 40)
|
||||
let context = ReviewContext(
|
||||
lane: " dev03 ", deployedVersion: "v1.4.2\n(build 41)", commit: " a1b2c3d4 ",
|
||||
reviewer: "Ben Hippler", note: long)
|
||||
#expect(context.lane == "dev03")
|
||||
#expect(context.deployedVersion == "v1.4.2 (build 41)")
|
||||
#expect(context.commit == "a1b2c3d4")
|
||||
#expect(context.note.count == ReviewContext.maxFieldLength)
|
||||
}
|
||||
|
||||
@Test
|
||||
func reviewContextSummaryDropsEmptyParts() {
|
||||
#expect(ReviewContext(lane: "dev03", commit: "a1b2c3d4").summaryLine == "dev03 · a1b2c3d4")
|
||||
#expect(ReviewContext().summaryLine == "")
|
||||
#expect(ReviewContext().isEmpty)
|
||||
}
|
||||
|
||||
@Test
|
||||
func reviewContextDecodesPartialJSON() throws {
|
||||
let json = Data(#"{"lane":"dev03","commit":"a1b2c3d4"}"#.utf8)
|
||||
let context = try JSONDecoder().decode(ReviewContext.self, from: json)
|
||||
#expect(context.lane == "dev03")
|
||||
#expect(context.commit == "a1b2c3d4")
|
||||
#expect(context.reviewer == "")
|
||||
#expect(context.note == "")
|
||||
}
|
||||
|
||||
// MARK: - Fixtures
|
||||
|
||||
private struct DefaultsSuite {
|
||||
let name: String
|
||||
let defaults: UserDefaults
|
||||
}
|
||||
|
||||
private func makeDefaults() throws -> DefaultsSuite {
|
||||
let name = "shotdeck-retention-settings-\(UUID().uuidString)"
|
||||
guard let defaults = UserDefaults(suiteName: name) else {
|
||||
throw SettingsFixtureError.noSuite
|
||||
}
|
||||
defaults.removePersistentDomain(forName: name)
|
||||
return DefaultsSuite(name: name, defaults: defaults)
|
||||
}
|
||||
|
||||
private enum SettingsFixtureError: Error { case noSuite }
|
||||
@@ -0,0 +1,358 @@
|
||||
import CoreGraphics
|
||||
import Foundation
|
||||
import ImageIO
|
||||
import Testing
|
||||
import ShotdeckCore
|
||||
|
||||
// Session lifecycle + retention: "Start new session" keeps the current screenshots as
|
||||
// a past session; every session is kept by default, and an age limit chosen in
|
||||
// Settings is the only thing that ever removes one.
|
||||
|
||||
// MARK: - 1. closeCurrentSession keeps the captures as a past session
|
||||
|
||||
@Test
|
||||
func closeCurrentSessionKeepsCapturesAsAPastSessionAndStartsFresh() async throws {
|
||||
let (root, paths) = try makeIsolatedPaths()
|
||||
defer { try? FileManager.default.removeItem(at: root) }
|
||||
|
||||
let store = try SpoolStore(paths: paths)
|
||||
let c1 = try await store.append(
|
||||
pngData: try makePNGData(width: 8, height: 8, red: 1, green: 0, blue: 0),
|
||||
pixelWidth: 8, pixelHeight: 8, scale: 1.0, capturedAt: Date())
|
||||
let c2 = try await store.append(
|
||||
pngData: try makePNGData(width: 8, height: 8, red: 0, green: 1, blue: 0),
|
||||
pixelWidth: 8, pixelHeight: 8, scale: 1.0, capturedAt: Date())
|
||||
|
||||
let closedID = try await store.currentSession().id
|
||||
let archived = try #require(try await store.closeCurrentSession())
|
||||
|
||||
#expect(archived.id == closedID)
|
||||
#expect(archived.state == .archived)
|
||||
#expect(archived.pdfFileName == nil) // never sent — shown as "Not sent"
|
||||
#expect(archived.captures.map(\.id) == [c1.id, c2.id])
|
||||
|
||||
// Nothing is deleted: both PNGs live on under archive/<id>/.
|
||||
let archiveDir = paths.archiveDirectory(closedID)
|
||||
for capture in archived.captures {
|
||||
#expect(FileManager.default.fileExists(
|
||||
atPath: archiveDir.appendingPathComponent(capture.fileName).path))
|
||||
}
|
||||
#expect(!FileManager.default.fileExists(atPath: paths.sessionDirectory(closedID).path))
|
||||
|
||||
let fresh = try await store.currentSession()
|
||||
#expect(fresh.id != closedID)
|
||||
#expect(fresh.state == .open)
|
||||
#expect(fresh.isEmpty)
|
||||
|
||||
let past = try await store.archivedSessions()
|
||||
#expect(past.map(\.id) == [closedID])
|
||||
#expect(past.first?.captures.count == 2)
|
||||
}
|
||||
|
||||
// MARK: - 2. closeCurrentSession on an empty open session just starts fresh
|
||||
|
||||
@Test
|
||||
func closeCurrentSessionOnAnEmptyOpenSessionStartsFreshWithoutArchiving() async throws {
|
||||
let (root, paths) = try makeIsolatedPaths()
|
||||
defer { try? FileManager.default.removeItem(at: root) }
|
||||
|
||||
let store = try SpoolStore(paths: paths)
|
||||
let before = try await store.currentSession().id
|
||||
|
||||
let archived = try await store.closeCurrentSession()
|
||||
#expect(archived == nil)
|
||||
|
||||
let after = try await store.currentSession()
|
||||
#expect(after.id != before)
|
||||
#expect(after.isEmpty)
|
||||
let past = try await store.archivedSessions()
|
||||
#expect(past.isEmpty)
|
||||
}
|
||||
|
||||
// MARK: - 3. sent and unsent sessions are distinguishable in the past list
|
||||
|
||||
@Test
|
||||
func pastSessionsDistinguishSentFromUnsentByPDFFileName() async throws {
|
||||
let (root, paths) = try makeIsolatedPaths()
|
||||
defer { try? FileManager.default.removeItem(at: root) }
|
||||
|
||||
let store = try SpoolStore(paths: paths)
|
||||
_ = try await store.append(
|
||||
pngData: try makePNGData(width: 6, height: 6, red: 1, green: 0, blue: 0),
|
||||
pixelWidth: 6, pixelHeight: 6, scale: 1.0, capturedAt: Date())
|
||||
let sent = try await store.archiveCurrent(pdfFileName: "Redline-20261011-120000.pdf")
|
||||
|
||||
_ = try await store.append(
|
||||
pngData: try makePNGData(width: 6, height: 6, red: 0, green: 0, blue: 1),
|
||||
pixelWidth: 6, pixelHeight: 6, scale: 1.0, capturedAt: Date())
|
||||
let closed = try #require(try await store.closeCurrentSession())
|
||||
|
||||
#expect(sent.pdfFileName == "Redline-20261011-120000.pdf")
|
||||
#expect(closed.pdfFileName == nil)
|
||||
|
||||
let past = try await store.archivedSessions()
|
||||
#expect(past.map(\.id) == [closed.id, sent.id]) // newest first
|
||||
#expect(past.map(\.pdfFileName) == [nil, "Redline-20261011-120000.pdf"])
|
||||
}
|
||||
|
||||
// MARK: - 4. nothing is deleted by default
|
||||
|
||||
@Test
|
||||
func defaultPolicyKeepsEverySession() async throws {
|
||||
let (root, paths) = try makeIsolatedPaths()
|
||||
defer { try? FileManager.default.removeItem(at: root) }
|
||||
|
||||
let store = try SpoolStore(paths: paths)
|
||||
#expect(await store.configuredRetention() == .never)
|
||||
|
||||
var closedIDs: [UUID] = []
|
||||
for index in 0..<12 {
|
||||
_ = try await store.append(
|
||||
pngData: try makePNGData(width: 4, height: 4, red: 0.1, green: 0.1, blue: 0.1),
|
||||
pixelWidth: 4, pixelHeight: 4, scale: 1.0,
|
||||
capturedAt: Date(timeIntervalSince1970: 1_700_000_000 + Double(index)))
|
||||
let closed = try #require(try await store.closeCurrentSession())
|
||||
closedIDs.append(closed.id)
|
||||
}
|
||||
|
||||
// All 12 sessions live on in the single archive/ folder; none was pruned.
|
||||
let fm = FileManager.default
|
||||
let entries = try fm.contentsOfDirectory(at: paths.archive, includingPropertiesForKeys: nil)
|
||||
let sessionDirs = entries.filter { UUID(uuidString: $0.lastPathComponent) != nil }
|
||||
#expect(sessionDirs.count == closedIDs.count)
|
||||
|
||||
let kept = try await store.archivedSessions().map(\.id)
|
||||
#expect(kept == closedIDs.reversed())
|
||||
|
||||
for id in closedIDs {
|
||||
#expect(fm.fileExists(atPath: paths.archiveDirectory(id).appendingPathComponent("session.json").path))
|
||||
}
|
||||
|
||||
// A prune under the default policy removes nothing at all.
|
||||
#expect(try await store.pruneExpiredSessions().isEmpty)
|
||||
#expect(try await store.expiredSessionIDs().isEmpty)
|
||||
}
|
||||
|
||||
// MARK: - 5. an age limit removes exactly the expired sessions
|
||||
|
||||
@Test
|
||||
func ageLimitRemovesOnlySessionsOlderThanTheCutoff() async throws {
|
||||
let (root, paths) = try makeIsolatedPaths()
|
||||
defer { try? FileManager.default.removeItem(at: root) }
|
||||
|
||||
let now = Date(timeIntervalSince1970: 1_700_000_000) // fixed "now" for the test
|
||||
let day: TimeInterval = 86_400
|
||||
let oldIDs = try [
|
||||
try writeArchivedSession(createdAt: now.addingTimeInterval(-40 * day), in: paths),
|
||||
try writeArchivedSession(createdAt: now.addingTimeInterval(-31 * day), in: paths),
|
||||
]
|
||||
let recentIDs = try [
|
||||
try writeArchivedSession(createdAt: now.addingTimeInterval(-29 * day), in: paths),
|
||||
try writeArchivedSession(createdAt: now.addingTimeInterval(-1 * day), in: paths),
|
||||
]
|
||||
|
||||
let store = try SpoolStore(paths: paths, retention: .days(30))
|
||||
|
||||
// Asking what would happen deletes nothing.
|
||||
#expect(Set(try await store.expiredSessionIDs(now: now)) == Set(oldIDs))
|
||||
#expect(try await store.archivedSessions().count == 4)
|
||||
|
||||
let removed = try await store.pruneExpiredSessions(now: now)
|
||||
#expect(Set(removed) == Set(oldIDs))
|
||||
|
||||
let fm = FileManager.default
|
||||
for id in oldIDs {
|
||||
#expect(!fm.fileExists(atPath: paths.archiveDirectory(id).path))
|
||||
}
|
||||
for id in recentIDs {
|
||||
#expect(fm.fileExists(atPath: paths.archiveDirectory(id).appendingPathComponent("session.json").path))
|
||||
}
|
||||
|
||||
// The open session is never a candidate, and a second pass is a no-op.
|
||||
#expect(try await store.currentSession().state == .open)
|
||||
#expect(try await store.pruneExpiredSessions(now: now).isEmpty)
|
||||
}
|
||||
|
||||
// MARK: - 6. the archive path applies the configured age limit
|
||||
|
||||
@Test
|
||||
func theArchivePathAppliesTheAgeLimit() async throws {
|
||||
let (root, paths) = try makeIsolatedPaths()
|
||||
defer { try? FileManager.default.removeItem(at: root) }
|
||||
|
||||
let day: TimeInterval = 86_400
|
||||
let expiredID = try writeArchivedSession(
|
||||
createdAt: Date().addingTimeInterval(-10 * day), in: paths)
|
||||
|
||||
let store = try SpoolStore(paths: paths, retention: .days(7))
|
||||
_ = try await store.append(
|
||||
pngData: try makePNGData(width: 4, height: 4, red: 0.3, green: 0.3, blue: 0.3),
|
||||
pixelWidth: 4, pixelHeight: 4, scale: 1.0, capturedAt: Date())
|
||||
let archived = try await store.archiveCurrent(pdfFileName: "Redline-20261031-1200-A1B2C3D4.pdf")
|
||||
|
||||
let kept = try await store.archivedSessions()
|
||||
#expect(kept.map(\.id) == [archived.id])
|
||||
#expect(!FileManager.default.fileExists(atPath: paths.archiveDirectory(expiredID).path))
|
||||
}
|
||||
|
||||
// MARK: - 7. review context is persisted, survives a relaunch and is inherited
|
||||
|
||||
@Test
|
||||
func reviewContextPersistsAndIsInheritedByTheNextSession() async throws {
|
||||
let (root, paths) = try makeIsolatedPaths()
|
||||
defer { try? FileManager.default.removeItem(at: root) }
|
||||
|
||||
let store = try SpoolStore(paths: paths)
|
||||
let context = ReviewContext(
|
||||
lane: "dev03", deployedVersion: "v1.4.2 (41)", commit: "a1b2c3d4",
|
||||
reviewer: "Ben Hippler", note: "checkout flow")
|
||||
|
||||
let updated = try await store.setContext(context)
|
||||
#expect(updated.context == context)
|
||||
|
||||
// A second store on the same directory is what a relaunch sees.
|
||||
let reopened = try SpoolStore(paths: paths)
|
||||
#expect(try await reopened.currentSession().context == context)
|
||||
|
||||
_ = try await store.append(
|
||||
pngData: try makePNGData(width: 4, height: 4, red: 0.4, green: 0.4, blue: 0.4),
|
||||
pixelWidth: 4, pixelHeight: 4, scale: 1.0, capturedAt: Date())
|
||||
let archived = try #require(try await store.closeCurrentSession())
|
||||
#expect(archived.context == context)
|
||||
|
||||
// The fresh session keeps the same review details.
|
||||
#expect(try await store.currentSession().context == context)
|
||||
}
|
||||
|
||||
// MARK: - 8. a manifest written before contexts existed still loads
|
||||
|
||||
@Test
|
||||
func legacyManifestWithoutContextDecodesAsEmptyContext() async throws {
|
||||
let (root, paths) = try makeIsolatedPaths()
|
||||
defer { try? FileManager.default.removeItem(at: root) }
|
||||
|
||||
let id = UUID()
|
||||
let dir = paths.archiveDirectory(id)
|
||||
try FileManager.default.createDirectory(at: dir, withIntermediateDirectories: true)
|
||||
let legacyJSON = """
|
||||
{
|
||||
"id": "\(id.uuidString)",
|
||||
"createdAt": "2026-10-11T12:00:00Z",
|
||||
"state": "archived",
|
||||
"captures": [],
|
||||
"pdfFileName": "Redline-20261011-120000.pdf"
|
||||
}
|
||||
"""
|
||||
try Data(legacyJSON.utf8).write(to: dir.appendingPathComponent("session.json"))
|
||||
|
||||
let store = try SpoolStore(paths: paths)
|
||||
let sessions = try await store.archivedSessions()
|
||||
#expect(sessions.map(\.id) == [id])
|
||||
#expect(sessions.first?.context == .empty)
|
||||
#expect(sessions.first?.pdfFileName == "Redline-20261011-120000.pdf")
|
||||
}
|
||||
|
||||
// MARK: - 7. a stale open session is never returned as current (truth guard)
|
||||
|
||||
@Test
|
||||
func aStaleOpenSessionIsNeverReturnedAsCurrent() async throws {
|
||||
let (root, paths) = try makeIsolatedPaths()
|
||||
defer { try? FileManager.default.removeItem(at: root) }
|
||||
|
||||
let store = try SpoolStore(paths: paths)
|
||||
_ = try await store.append(
|
||||
pngData: try makePNGData(width: 6, height: 6, red: 0.7, green: 0.7, blue: 0.1),
|
||||
pixelWidth: 6, pixelHeight: 6, scale: 1.0, capturedAt: Date())
|
||||
let archived = try await store.archiveCurrent(pdfFileName: "Redline-20261011-120200.pdf")
|
||||
|
||||
// Simulate the mid-run failure the truth guard exists for: the archived session
|
||||
// moved away and the replacement open session's folder is gone (e.g. the fresh
|
||||
// session could not be created / survive). The store must mint a real fresh
|
||||
// session — never report the already-archived one as open.
|
||||
let fresh = try await store.currentSession()
|
||||
try FileManager.default.removeItem(at: paths.sessionDirectory(fresh.id))
|
||||
|
||||
let recovered = try await store.currentSession()
|
||||
#expect(recovered.id != fresh.id)
|
||||
#expect(recovered.id != archived.id)
|
||||
#expect(recovered.state == .open)
|
||||
#expect(recovered.isEmpty)
|
||||
let past = try await store.archivedSessions()
|
||||
#expect(past.map(\.id) == [archived.id])
|
||||
}
|
||||
|
||||
// MARK: - Fixtures
|
||||
|
||||
/// Writes an archived session folder with the given creation date, exactly the shape
|
||||
/// production writes (a manifest plus one PNG), so retention can be exercised without
|
||||
/// waiting days.
|
||||
private func writeArchivedSession(createdAt: Date, in paths: AppSupportPaths) throws -> UUID {
|
||||
let id = UUID()
|
||||
let dir = paths.archiveDirectory(id)
|
||||
try FileManager.default.createDirectory(at: dir, withIntermediateDirectories: true)
|
||||
let pngName = "001-A1B2C3D4.png"
|
||||
try makePNGData(width: 4, height: 4, red: 0.5, green: 0.5, blue: 0.5)
|
||||
.write(to: dir.appendingPathComponent(pngName))
|
||||
let capture = Capture(
|
||||
id: UUID(), sequence: 1, fileName: pngName,
|
||||
pixelWidth: 4, pixelHeight: 4, scale: 1.0, capturedAt: createdAt)
|
||||
let session = CaptureSession(
|
||||
id: id, createdAt: createdAt, state: .archived, captures: [capture],
|
||||
pdfFileName: "Redline-\(DubaiTime.fileMinuteStamp(createdAt)).pdf")
|
||||
let encoder = JSONEncoder()
|
||||
encoder.dateEncodingStrategy = .iso8601
|
||||
try encoder.encode(session).write(to: dir.appendingPathComponent("session.json"))
|
||||
return id
|
||||
}
|
||||
|
||||
private enum FixtureError: Error {
|
||||
case pngGenerationFailed
|
||||
}
|
||||
|
||||
private func makeIsolatedPaths() throws -> (root: URL, paths: AppSupportPaths) {
|
||||
let root = FileManager.default.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-retention-\(UUID().uuidString)", isDirectory: true)
|
||||
let paths = try AppSupportPaths(
|
||||
root: root,
|
||||
outbox: root.appendingPathComponent("outbox", isDirectory: true),
|
||||
watchFolder: root.appendingPathComponent("watch", isDirectory: true)
|
||||
)
|
||||
return (root, paths)
|
||||
}
|
||||
|
||||
private func makePNGData(
|
||||
width: Int,
|
||||
height: Int,
|
||||
red: CGFloat,
|
||||
green: CGFloat,
|
||||
blue: CGFloat
|
||||
) throws -> Data {
|
||||
let colorSpace = CGColorSpaceCreateDeviceRGB()
|
||||
guard let context = CGContext(
|
||||
data: nil,
|
||||
width: width,
|
||||
height: height,
|
||||
bitsPerComponent: 8,
|
||||
bytesPerRow: width * 4,
|
||||
space: colorSpace,
|
||||
bitmapInfo: CGImageAlphaInfo.premultipliedLast.rawValue
|
||||
) else {
|
||||
throw FixtureError.pngGenerationFailed
|
||||
}
|
||||
context.setFillColor(red: red, green: green, blue: blue, alpha: 1)
|
||||
context.fill(CGRect(x: 0, y: 0, width: width, height: height))
|
||||
guard let image = context.makeImage() else {
|
||||
throw FixtureError.pngGenerationFailed
|
||||
}
|
||||
let data = NSMutableData()
|
||||
guard let destination = CGImageDestinationCreateWithData(
|
||||
data, "public.png" as CFString, 1, nil
|
||||
) else {
|
||||
throw FixtureError.pngGenerationFailed
|
||||
}
|
||||
CGImageDestinationAddImage(destination, image, nil)
|
||||
guard CGImageDestinationFinalize(destination) else {
|
||||
throw FixtureError.pngGenerationFailed
|
||||
}
|
||||
return data as Data
|
||||
}
|
||||
@@ -0,0 +1,227 @@
|
||||
import Foundation
|
||||
import Testing
|
||||
import ShotdeckCore
|
||||
|
||||
@Test
|
||||
func transportDefaultsToAirDropWhenUnset() throws {
|
||||
let suite = try makeTransportDefaultsSuite()
|
||||
defer { tearDownTransportSuite(suite) }
|
||||
|
||||
#expect(TransportSettings.transport(defaults: suite.defaults) == .airDrop)
|
||||
}
|
||||
|
||||
@Test
|
||||
func setTransportRoundTrips() throws {
|
||||
let suite = try makeTransportDefaultsSuite()
|
||||
defer { tearDownTransportSuite(suite) }
|
||||
|
||||
TransportSettings.setTransport(.oneDrive, defaults: suite.defaults)
|
||||
#expect(TransportSettings.transport(defaults: suite.defaults) == .oneDrive)
|
||||
|
||||
TransportSettings.setTransport(.airDrop, defaults: suite.defaults)
|
||||
#expect(TransportSettings.transport(defaults: suite.defaults) == .airDrop)
|
||||
}
|
||||
|
||||
@Test
|
||||
func garbageStoredTransportFallsBackToAirDrop() throws {
|
||||
let suite = try makeTransportDefaultsSuite()
|
||||
defer { tearDownTransportSuite(suite) }
|
||||
|
||||
suite.defaults.set("not-a-real-transport", forKey: TransportSettings.transportDefaultsKey)
|
||||
#expect(TransportSettings.transport(defaults: suite.defaults) == .airDrop)
|
||||
}
|
||||
|
||||
@Test
|
||||
func oneDriveFolderStoreAndReset() throws {
|
||||
let suite = try makeTransportDefaultsSuite()
|
||||
defer { tearDownTransportSuite(suite) }
|
||||
let folder = try makeTransportTemporaryDirectory(prefix: "shotdeck-onedrive-folder")
|
||||
defer { try? FileManager.default.removeItem(at: folder) }
|
||||
|
||||
#expect(TransportSettings.storedOneDriveFolderPath(defaults: suite.defaults) == nil)
|
||||
|
||||
TransportSettings.setOneDriveFolder(folder, defaults: suite.defaults)
|
||||
#expect(TransportSettings.storedOneDriveFolderPath(defaults: suite.defaults) == folder.path)
|
||||
|
||||
TransportSettings.resetOneDriveFolder(defaults: suite.defaults)
|
||||
#expect(TransportSettings.storedOneDriveFolderPath(defaults: suite.defaults) == nil)
|
||||
}
|
||||
|
||||
@Test
|
||||
func effectiveFoldersForAirDropMatchesFolderSettings() throws {
|
||||
let suite = try makeTransportDefaultsSuite()
|
||||
defer { tearDownTransportSuite(suite) }
|
||||
let outbox = try makeTransportTemporaryDirectory(prefix: "shotdeck-effective-outbox")
|
||||
defer { try? FileManager.default.removeItem(at: outbox) }
|
||||
FolderSettings.setOutbox(outbox, defaults: suite.defaults)
|
||||
|
||||
let effective = TransportSettings.effectiveFolders(defaults: suite.defaults)
|
||||
let expected = FolderSettings.resolve(defaults: suite.defaults)
|
||||
|
||||
#expect(effective.transport == .airDrop)
|
||||
#expect(effective.outbox.path == expected.outbox.path)
|
||||
#expect(effective.watch.path == expected.watch.path)
|
||||
}
|
||||
|
||||
@Test
|
||||
func effectiveFoldersForOneDriveWithAResolvableFolderUsesItForBoth() throws {
|
||||
let suite = try makeTransportDefaultsSuite()
|
||||
defer { tearDownTransportSuite(suite) }
|
||||
let folder = try makeTransportTemporaryDirectory(prefix: "shotdeck-effective-onedrive")
|
||||
defer { try? FileManager.default.removeItem(at: folder) }
|
||||
|
||||
TransportSettings.setTransport(.oneDrive, defaults: suite.defaults)
|
||||
TransportSettings.setOneDriveFolder(folder, defaults: suite.defaults)
|
||||
|
||||
let effective = TransportSettings.effectiveFolders(defaults: suite.defaults)
|
||||
|
||||
#expect(effective.transport == .oneDrive)
|
||||
#expect(effective.outbox.path == folder.path)
|
||||
#expect(effective.watch.path == folder.path)
|
||||
#expect(effective.outbox.path == effective.watch.path)
|
||||
}
|
||||
|
||||
@Test
|
||||
func oneDriveFolderUnavailableErrorDescriptionContainsThePath() throws {
|
||||
let path = "/Users/example/Library/CloudStorage/OneDrive-Example/Redline"
|
||||
let error = ShotdeckError.oneDriveFolderUnavailable(path: path)
|
||||
let description = try #require(error.errorDescription)
|
||||
#expect(!description.isEmpty)
|
||||
#expect(description.contains(path))
|
||||
}
|
||||
|
||||
@Test
|
||||
func isWritableDirectoryTrueForAnOrdinaryWritableDirectory() throws {
|
||||
let dir = try makeTransportTemporaryDirectory(prefix: "shotdeck-writable")
|
||||
defer { try? FileManager.default.removeItem(at: dir) }
|
||||
#expect(OneDriveLocator.isWritableDirectory(at: dir))
|
||||
}
|
||||
|
||||
@Test
|
||||
func isWritableDirectoryFalseForAnExistingButUnwritableDirectory() throws {
|
||||
let dir = try makeTransportTemporaryDirectory(prefix: "shotdeck-unwritable")
|
||||
defer {
|
||||
// Restore perms BEFORE removal — an unwritable dir can't otherwise be cleaned up.
|
||||
try? FileManager.default.setAttributes([.posixPermissions: 0o755], ofItemAtPath: dir.path)
|
||||
try? FileManager.default.removeItem(at: dir)
|
||||
}
|
||||
#expect(OneDriveLocator.isWritableDirectory(at: dir)) // sanity check before chmod
|
||||
|
||||
try FileManager.default.setAttributes([.posixPermissions: 0o500], ofItemAtPath: dir.path)
|
||||
#expect(!OneDriveLocator.isWritableDirectory(at: dir))
|
||||
}
|
||||
|
||||
@Test
|
||||
func isWritableDirectoryFalseForAPlainFileAndForANonexistentPath() throws {
|
||||
let dir = try makeTransportTemporaryDirectory(prefix: "shotdeck-writable-check-parent")
|
||||
defer { try? FileManager.default.removeItem(at: dir) }
|
||||
let filePath = dir.appendingPathComponent("plain-file.txt")
|
||||
FileManager.default.createFile(atPath: filePath.path, contents: Data("x".utf8))
|
||||
|
||||
#expect(!OneDriveLocator.isWritableDirectory(at: filePath))
|
||||
#expect(!OneDriveLocator.isWritableDirectory(at: dir.appendingPathComponent("does-not-exist")))
|
||||
}
|
||||
|
||||
@Test
|
||||
func probeWritableTrueForAnOrdinaryWritableDirectoryAndLeavesNoProbeFileBehind() throws {
|
||||
let dir = try makeTransportTemporaryDirectory(prefix: "shotdeck-probe-writable")
|
||||
defer { try? FileManager.default.removeItem(at: dir) }
|
||||
|
||||
#expect(OneDriveLocator.probeWritable(at: dir))
|
||||
|
||||
let leftovers = try FileManager.default.contentsOfDirectory(atPath: dir.path)
|
||||
#expect(leftovers.isEmpty)
|
||||
}
|
||||
|
||||
@Test
|
||||
func probeWritableFalseForAChmod500Directory() throws {
|
||||
// The File Provider edge case this probe exists for: isWritableDirectory can be
|
||||
// true (as verified by the isWritableDirectory tests above) while an actual write
|
||||
// still fails. A chmod 500 directory reproduces that "looks writable, isn't"
|
||||
// shape closely enough to prove the probe itself does a real write, not just
|
||||
// another permissions-bit check.
|
||||
let dir = try makeTransportTemporaryDirectory(prefix: "shotdeck-probe-unwritable")
|
||||
defer {
|
||||
try? FileManager.default.setAttributes([.posixPermissions: 0o755], ofItemAtPath: dir.path)
|
||||
try? FileManager.default.removeItem(at: dir)
|
||||
}
|
||||
try FileManager.default.setAttributes([.posixPermissions: 0o500], ofItemAtPath: dir.path)
|
||||
|
||||
#expect(!OneDriveLocator.probeWritable(at: dir))
|
||||
}
|
||||
|
||||
@Test
|
||||
func probeWritableFalseForAPlainFilePath() throws {
|
||||
let dir = try makeTransportTemporaryDirectory(prefix: "shotdeck-probe-file-parent")
|
||||
defer { try? FileManager.default.removeItem(at: dir) }
|
||||
let filePath = dir.appendingPathComponent("plain-file.txt")
|
||||
FileManager.default.createFile(atPath: filePath.path, contents: Data("x".utf8))
|
||||
|
||||
#expect(!OneDriveLocator.probeWritable(at: filePath))
|
||||
}
|
||||
|
||||
/// The write itself succeeds (a real probe file lands on disk via AtomicFile.write,
|
||||
/// which never touches this injected FileManager — it uses raw POSIX calls), but the
|
||||
/// FIRST call to `removeItem(at:)` throws, simulating a transient File Provider
|
||||
/// removal failure. probeWritable's own defer-based cleanup must retry and succeed
|
||||
/// (the second call through this same override falls through to `super`), so no
|
||||
/// probe file is left behind even though the function correctly still reports false
|
||||
/// (the removal it explicitly attempted did fail).
|
||||
private final class ThrowOnceOnRemoveFileManager: FileManager, @unchecked Sendable {
|
||||
private let lock = NSLock()
|
||||
private var hasThrown = false
|
||||
|
||||
override func removeItem(at URL: URL) throws {
|
||||
lock.lock()
|
||||
let shouldThrow = !hasThrown
|
||||
hasThrown = true
|
||||
lock.unlock()
|
||||
if shouldThrow {
|
||||
throw NSError(domain: "ShotdeckCoreTests.ThrowOnceOnRemove", code: 1)
|
||||
}
|
||||
try super.removeItem(at: URL)
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
func probeWritableFalseAndLeavesNoProbeFileWhenRemoveItemThrowsOnce() throws {
|
||||
// Directory fsync failure (the OTHER way probeWritable's cleanup can be needed) has
|
||||
// no injectable seam: AtomicFile.write's directory fsync is a raw Darwin fsync(2)
|
||||
// call on an already-open file descriptor, not parameterized by any FileManager or
|
||||
// other dependency this test can substitute, and there is no portable way to make
|
||||
// fsync(2) itself fail via chmod or other standard test techniques (fsync failures
|
||||
// are OS/filesystem/hardware-level events). Covering the removeItem-throws path
|
||||
// (below) is what this test does; the fsync-throws path is covered by code
|
||||
// inspection only — the same `defer` block guards both.
|
||||
let dir = try makeTransportTemporaryDirectory(prefix: "shotdeck-probe-remove-throws")
|
||||
defer { try? FileManager.default.removeItem(at: dir) }
|
||||
let injectedFileManager = ThrowOnceOnRemoveFileManager()
|
||||
|
||||
#expect(!OneDriveLocator.probeWritable(at: dir, fileManager: injectedFileManager))
|
||||
|
||||
let leftovers = try FileManager.default.contentsOfDirectory(atPath: dir.path)
|
||||
#expect(leftovers.isEmpty)
|
||||
}
|
||||
|
||||
struct TransportDefaultsSuite {
|
||||
let name: String
|
||||
let defaults: UserDefaults
|
||||
}
|
||||
|
||||
func makeTransportDefaultsSuite() throws -> TransportDefaultsSuite {
|
||||
let name = "shotdeck-transport-test-\(UUID().uuidString)"
|
||||
let defaults = try #require(UserDefaults(suiteName: name))
|
||||
defaults.removePersistentDomain(forName: name)
|
||||
return TransportDefaultsSuite(name: name, defaults: defaults)
|
||||
}
|
||||
|
||||
func tearDownTransportSuite(_ suite: TransportDefaultsSuite) {
|
||||
suite.defaults.removePersistentDomain(forName: suite.name)
|
||||
}
|
||||
|
||||
func makeTransportTemporaryDirectory(prefix: String) throws -> URL {
|
||||
let url = FileManager.default.temporaryDirectory
|
||||
.appendingPathComponent("\(prefix)-\(UUID().uuidString)", isDirectory: true)
|
||||
try FileManager.default.createDirectory(at: url, withIntermediateDirectories: true)
|
||||
return url
|
||||
}
|
||||
@@ -0,0 +1,142 @@
|
||||
import AppKit
|
||||
import Foundation
|
||||
import PDFKit
|
||||
import Testing
|
||||
import ShotdeckCore
|
||||
@testable import Shotdeck
|
||||
|
||||
/// Coverage gap closed (adversarial review, rounds 3 and 4): the Core-level regression
|
||||
/// tests in ShotdeckCoreTests hand-replicate what `AppDelegate.makeLaunchModel()` and
|
||||
/// `AppModel.bootstrap()` do, rather than calling them — so a future revert of
|
||||
/// `makeLaunchModel()` back to the AirDrop-only resolver, or a dropped
|
||||
/// `updateWatchFolder` call inside `bootstrap()`, would NOT fail `swift test`. This
|
||||
/// test goes through the real, unmodified call sites in the `Shotdeck` executable
|
||||
/// target via `@testable import`, which `ShotdeckCoreTests` cannot reach (it only
|
||||
/// depends on `ShotdeckCore`) — hence this separate `ShotdeckTests` target.
|
||||
///
|
||||
/// Round 4 correction: the first version of this test asserted only
|
||||
/// `model.watchFolderURL`, which `AppModel.init` computes independently via
|
||||
/// `TransportSettings.effectiveFolders()` — so it stayed correct (and the test kept
|
||||
/// passing) even when `makeLaunchModel()` was reverted to the AirDrop-only resolver,
|
||||
/// because `bootstrap()`'s own unconditional `updateWatchFolder` reconcile papered
|
||||
/// over the reverted resolver. That made the "verified this catches the blocker"
|
||||
/// claim in the previous round's commit message empirically false. This version
|
||||
/// asserts `model.paths`/the watcher's `currentWatchFolder` BEFORE `bootstrap()` runs,
|
||||
/// which actually depends on what `makeLaunchModel()` built — see this file's git
|
||||
/// history (or the round-4 commit message) for the verbatim before/after
|
||||
/// `swift test --filter` output proving it now discriminates correctly.
|
||||
@MainActor
|
||||
@Test("Real wiring: AppDelegate.makeLaunchModel() + AppModel.bootstrap() detect a marked OneDrive return")
|
||||
func realLaunchModelAndBootstrapDetectAMarkedOneDriveReturn() async throws {
|
||||
let fm = FileManager.default
|
||||
|
||||
// UserDefaults.standard is the ONLY defaults instance makeLaunchModel()/bootstrap()
|
||||
// actually read — there is no defaults-threading through AppModel/AppDelegate (the
|
||||
// same reasoning documented in PickerSelfTest.swift's ONEDRIVE-SELFTEST phase).
|
||||
// "Isolated" here means snapshot-and-restore around the real keys, not a separate
|
||||
// UserDefaults(suiteName:) instance that these real, unmodified call sites would
|
||||
// never actually consult.
|
||||
let defaults = UserDefaults.standard
|
||||
let previousTransport = defaults.string(forKey: TransportSettings.transportDefaultsKey)
|
||||
let previousFolder = defaults.string(forKey: TransportSettings.oneDriveFolderDefaultsKey)
|
||||
defer {
|
||||
if let previousTransport {
|
||||
defaults.set(previousTransport, forKey: TransportSettings.transportDefaultsKey)
|
||||
} else {
|
||||
defaults.removeObject(forKey: TransportSettings.transportDefaultsKey)
|
||||
}
|
||||
if let previousFolder {
|
||||
defaults.set(previousFolder, forKey: TransportSettings.oneDriveFolderDefaultsKey)
|
||||
} else {
|
||||
defaults.removeObject(forKey: TransportSettings.oneDriveFolderDefaultsKey)
|
||||
}
|
||||
}
|
||||
|
||||
let oneDriveFolderRaw = fm.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-real-wiring-onedrive-\(UUID().uuidString)", isDirectory: true)
|
||||
try fm.createDirectory(at: oneDriveFolderRaw, withIntermediateDirectories: true)
|
||||
defer { try? fm.removeItem(at: oneDriveFolderRaw) }
|
||||
// FileManager's directory enumeration (inside the real ReturnWatcher/AppSupportPaths
|
||||
// call sites this test exercises) can canonicalize /var -> /private/var for a path
|
||||
// that actually exists; resolve here so every comparison below agrees.
|
||||
let oneDriveFolder = oneDriveFolderRaw.resolvingSymlinksInPath()
|
||||
|
||||
let appSupportRoot = fm.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-real-wiring-approot-\(UUID().uuidString)", isDirectory: true)
|
||||
defer { try? fm.removeItem(at: appSupportRoot) }
|
||||
|
||||
TransportSettings.setTransport(.oneDrive, defaults: defaults)
|
||||
TransportSettings.setOneDriveFolder(oneDriveFolder, defaults: defaults)
|
||||
|
||||
// Best-effort: keeps AppModel.bootstrap()'s real update-check schedule (a real
|
||||
// HTTP GET after 10s, plus a RunLoop timer) from starting during this test.
|
||||
// ProcessInfo.processInfo.environment on Darwin reads `environ` fresh each call,
|
||||
// so a setenv() here is visible to bootstrap()'s own check immediately.
|
||||
setenv("SHOTDECK_ONEDRIVE_SELFTEST", "1", 1)
|
||||
defer { unsetenv("SHOTDECK_ONEDRIVE_SELFTEST") }
|
||||
|
||||
// The REAL, unmodified call sites — not a reimplementation. This is exactly what
|
||||
// launching Redline with OneDrive as the persisted transport does.
|
||||
let model = AppDelegate.makeLaunchModel(appSupportRoot: appSupportRoot)
|
||||
// bootstrap() registers a REAL, process-wide Carbon global hotkey (capture combo,
|
||||
// e.g. Option-Shift-2). Carbon registrations are not scoped to this test/model —
|
||||
// they must be released before this test ends, or ShotdeckCoreTests'
|
||||
// HotkeyCenterCarbonTests (a separate test target, same test process) can find the
|
||||
// combo already taken / the global hotkey table in an unexpected state.
|
||||
defer { model.hotkeys.unregisterAll() }
|
||||
|
||||
// PRE-bootstrap assertions — this is the actual proof of the launch RESOLVER
|
||||
// (AppDelegate.makeLaunchModel() -> TransportSettings.resolvedAppSupportPaths()),
|
||||
// independent of bootstrap()'s own reconcile. `model.watchFolderURL` alone does
|
||||
// NOT prove this: AppModel.init computes it separately via
|
||||
// TransportSettings.effectiveFolders(), so it would read as correct even if
|
||||
// makeLaunchModel's `paths` were built by the AirDrop-only resolver — which is
|
||||
// exactly how the first version of this test was empirically shown to be vacuous
|
||||
// for the launch-resolver path (see this commit's message). `model.paths` is
|
||||
// `internal` on AppModel, so @testable import already exposes it without any
|
||||
// production API change; `currentWatchFolder` is the one new (internal-facing,
|
||||
// `public` on the actor) seam added to ReturnWatcher for this purpose.
|
||||
#expect(model.paths.watchFolder.path == oneDriveFolder.path)
|
||||
#expect(model.paths.outbox.path == oneDriveFolder.path)
|
||||
let seededWatchFolder = await model.watcher.currentWatchFolder
|
||||
#expect(seededWatchFolder.path == oneDriveFolder.path)
|
||||
|
||||
#expect(model.transport == .oneDrive)
|
||||
#expect(model.watchFolderURL.path == oneDriveFolder.path)
|
||||
|
||||
await model.bootstrap()
|
||||
|
||||
// Drop a marked-up Redline PDF into the folder in place — what OneDrive syncing
|
||||
// down an already-marked copy after a relaunch looks like.
|
||||
let pdfURL = oneDriveFolder.appendingPathComponent("Redline-realwiring-\(UUID().uuidString).pdf")
|
||||
let document = PDFDocument()
|
||||
let page = PDFPage()
|
||||
page.setBounds(CGRect(x: 0, y: 0, width: 612, height: 792), for: .mediaBox)
|
||||
document.insert(page, at: 0)
|
||||
document.documentAttributes = [
|
||||
PDFDocumentAttribute.creatorAttribute: "Redline",
|
||||
PDFDocumentAttribute.subjectAttribute: UUID().uuidString,
|
||||
]
|
||||
let ink = PDFAnnotation(
|
||||
bounds: CGRect(x: 20, y: 20, width: 60, height: 60), forType: .ink, withProperties: nil
|
||||
)
|
||||
let stroke = NSBezierPath()
|
||||
stroke.move(to: NSPoint(x: 20, y: 20))
|
||||
stroke.line(to: NSPoint(x: 80, y: 80))
|
||||
ink.add(stroke)
|
||||
page.addAnnotation(ink)
|
||||
let written = document.write(to: pdfURL)
|
||||
#expect(written)
|
||||
guard written else { return }
|
||||
|
||||
// .resolvingSymlinksInPath().path — not plain URL equality — matching how the rest
|
||||
// of the suite compares a temp-dir-derived expected URL against a returned one.
|
||||
let expectedPath = pdfURL.resolvingSymlinksInPath().path
|
||||
let found = try await model.watcher.scanNow()
|
||||
#expect(found.first(where: { $0.fileURL.resolvingSymlinksInPath().path == expectedPath })?.isCommented == true)
|
||||
|
||||
let commented = try await model.ledger.commented()
|
||||
#expect(commented.contains(where: { $0.fileURL.resolvingSymlinksInPath().path == expectedPath }))
|
||||
|
||||
await model.watcher.stop()
|
||||
}
|
||||
@@ -0,0 +1,345 @@
|
||||
import AppKit
|
||||
import CoreGraphics
|
||||
import Foundation
|
||||
import ImageIO
|
||||
import Testing
|
||||
import ShotdeckCore
|
||||
@testable import Shotdeck
|
||||
|
||||
/// Through the REAL app-target seams the menu rows invoke (`AppModel` actions +
|
||||
/// `SpoolStore`): "Start new session" keeps the current screenshots as a past session,
|
||||
/// the Past sessions state reflects what was sent, every session is kept by default,
|
||||
/// and a chosen age limit is what removes one. `bootstrap()` itself is covered by
|
||||
/// LaunchWiringTests; here `addCapture` refreshes the session from the store exactly
|
||||
/// the way `AppModel.captureNow()` does after a real capture.
|
||||
@MainActor
|
||||
@Test("Menu actions: start new session keeps captures and lists past submissions")
|
||||
func startNewSessionKeepsCapturesAndListsPastSessions() async throws {
|
||||
let fm = FileManager.default
|
||||
let root = fm.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-session-workflow-\(UUID().uuidString)", isDirectory: true)
|
||||
defer { try? fm.removeItem(at: root) }
|
||||
let model = AppDelegate.makeLaunchModel(appSupportRoot: root)
|
||||
|
||||
// Two captures in the open session, then the menu's "Start new session".
|
||||
let c1 = try await addCapture(to: model, red: 1, green: 0, blue: 0)
|
||||
let c2 = try await addCapture(to: model, red: 0, green: 1, blue: 0)
|
||||
let closedID = model.session.id
|
||||
#expect(model.canStartNewSession)
|
||||
|
||||
await model.startNewSession()
|
||||
|
||||
// The fresh session is active and the captures are kept as a past session.
|
||||
#expect(model.session.id != closedID)
|
||||
#expect(model.session.isEmpty)
|
||||
#expect(!model.canStartNewSession)
|
||||
#expect(model.pastSessions.map(\.id) == [closedID])
|
||||
#expect(model.pastSessions.first?.captures.map(\.id) == [c1.id, c2.id])
|
||||
#expect(model.pastSessions.first?.pdfFileName == nil) // never sent
|
||||
#expect(model.statusLine?.contains("kept as a past session") == true)
|
||||
|
||||
// Nothing was deleted on close: both PNGs live in the single archive folder.
|
||||
let archiveDir = model.paths.archiveDirectory(closedID)
|
||||
for capture in [c1, c2] {
|
||||
#expect(fm.fileExists(atPath: archiveDir.appendingPathComponent(capture.fileName).path))
|
||||
}
|
||||
|
||||
// "PDF" on a never-sent row: visible missing state, no silent substitute.
|
||||
#expect(model.sentPDFURL(for: model.pastSessions[0]) == nil)
|
||||
model.revealSentPDF(model.pastSessions[0])
|
||||
#expect(model.statusLine == "That session was never sent.")
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test("Retention: 12 sessions through the menu action are all kept by default")
|
||||
func twelveSessionsStayOnDiskByDefault() async throws {
|
||||
let fm = FileManager.default
|
||||
let root = fm.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-session-workflow-\(UUID().uuidString)", isDirectory: true)
|
||||
defer { try? fm.removeItem(at: root) }
|
||||
let model = AppDelegate.makeLaunchModel(appSupportRoot: root)
|
||||
|
||||
var closedIDs: [UUID] = []
|
||||
for _ in 0..<12 {
|
||||
_ = try await addCapture(to: model, red: 0.2, green: 0.2, blue: 0.2)
|
||||
closedIDs.append(model.session.id)
|
||||
await model.startNewSession()
|
||||
}
|
||||
|
||||
#expect(model.retention == .never)
|
||||
#expect(model.pastSessions.map(\.id) == closedIDs.reversed())
|
||||
|
||||
let entries = try fm.contentsOfDirectory(at: model.paths.archive, includingPropertiesForKeys: nil)
|
||||
let sessionDirs = entries.filter { UUID(uuidString: $0.lastPathComponent) != nil }
|
||||
#expect(sessionDirs.count == closedIDs.count)
|
||||
for id in closedIDs {
|
||||
#expect(fm.fileExists(atPath: model.paths.archiveDirectory(id).path))
|
||||
}
|
||||
#expect(model.expiredSessionCount == 0)
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test("A review detail typed in the panel is saved and inherited by the next session")
|
||||
func reviewDetailsPersistThroughTheModel() async throws {
|
||||
let fm = FileManager.default
|
||||
let root = fm.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-session-workflow-\(UUID().uuidString)", isDirectory: true)
|
||||
defer { try? fm.removeItem(at: root) }
|
||||
let model = AppDelegate.makeLaunchModel(appSupportRoot: root)
|
||||
|
||||
let context = ReviewContext(
|
||||
lane: "dev03", deployedVersion: "v1.4.2", commit: "a1b2c3d4",
|
||||
reviewer: "Ben Hippler", note: "checkout")
|
||||
await model.setContextField(context)
|
||||
#expect(model.session.context == context)
|
||||
#expect(model.sessionContext.summaryLine == "dev03 · v1.4.2 · a1b2c3d4 · Ben Hippler")
|
||||
#expect(model.nextPDFFileNameHint.contains("-DEV03-"))
|
||||
|
||||
_ = try await addCapture(to: model, red: 0.1, green: 0.4, blue: 0.9)
|
||||
await model.startNewSession()
|
||||
|
||||
// The closed session keeps its details; the new one inherits them.
|
||||
#expect(model.pastSessions.first?.context == context)
|
||||
#expect(model.session.context == context)
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test("Settings age limit: cleanup removes only expired sessions, never a sent PDF")
|
||||
func cleanUpHonorsTheAgeLimit() async throws {
|
||||
let fm = FileManager.default
|
||||
let root = fm.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-session-workflow-\(UUID().uuidString)", isDirectory: true)
|
||||
defer { try? fm.removeItem(at: root) }
|
||||
let suite = try makeIsolatedDefaults()
|
||||
defer { suite.defaults.removePersistentDomain(forName: suite.name) }
|
||||
let model = AppDelegate.makeLaunchModel(
|
||||
appSupportRoot: root, retentionDefaults: suite.defaults)
|
||||
await model.bootstrap()
|
||||
|
||||
// One real session that was sent (its PDF is in the outbox) …
|
||||
_ = try await addCapture(to: model, red: 0.6, green: 0.2, blue: 0.2)
|
||||
let sentName = "Redline-20261001-0900-A1B2C3D4.pdf"
|
||||
_ = try await model.spool.archiveCurrent(pdfFileName: sentName)
|
||||
try Data("%PDF-1.4\n% test\n".utf8)
|
||||
.write(to: model.paths.outbox.appendingPathComponent(sentName))
|
||||
|
||||
// … and one archived session backdated past the limit, written in the exact shape
|
||||
// production writes, so the age comparison runs against real manifest dates.
|
||||
let expiredID = try await writeBackdatedSession(in: model.paths, daysAgo: 40)
|
||||
await model.reloadFromSpool()
|
||||
|
||||
#expect(model.pastSessions.count == 2)
|
||||
|
||||
// Nothing expires under .never, even with a cleanup.
|
||||
await model.cleanUpExpiredSessions()
|
||||
#expect(model.pastSessions.count == 2)
|
||||
#expect(model.expiredSessionCount == 0)
|
||||
#expect(model.statusLine?.contains("Nothing to remove") == true)
|
||||
|
||||
// A 30-day limit expires only the backdated session, and says so before deleting.
|
||||
await model.setRetention(.days(30))
|
||||
#expect(model.retention == .days(30))
|
||||
#expect(RetentionSettings.load(defaults: suite.defaults) == .days(30))
|
||||
#expect(model.expiredSessionCount == 1)
|
||||
|
||||
await model.cleanUpExpiredSessions()
|
||||
#expect(model.pastSessions.count == 1)
|
||||
#expect(model.statusLine?.contains("Removed 1 past session") == true)
|
||||
#expect(!fm.fileExists(atPath: model.paths.archiveDirectory(expiredID).path))
|
||||
#expect(fm.fileExists(atPath: model.paths.outbox.appendingPathComponent(sentName).path))
|
||||
|
||||
// Back to the default in this isolated suite, so the next test starts clean.
|
||||
await model.setRetention(.never)
|
||||
#expect(model.expiredSessionCount == 0)
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test("Menu action on an empty session reports it started without inventing a past session")
|
||||
func startNewSessionOnEmptySessionCreatesNoPastSession() async throws {
|
||||
let fm = FileManager.default
|
||||
let root = fm.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-session-workflow-\(UUID().uuidString)", isDirectory: true)
|
||||
defer { try? fm.removeItem(at: root) }
|
||||
let model = AppDelegate.makeLaunchModel(appSupportRoot: root)
|
||||
|
||||
#expect(model.session.isEmpty)
|
||||
await model.startNewSession()
|
||||
|
||||
#expect(model.session.isEmpty)
|
||||
#expect(model.pastSessions.isEmpty)
|
||||
#expect(model.statusLine == "New session started.")
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test("Send seam refreshes past submissions after archiving (menu count stays true)")
|
||||
func successfulSendRefreshesPastSubmissions() async throws {
|
||||
let fm = FileManager.default
|
||||
let root = fm.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-session-workflow-\(UUID().uuidString)", isDirectory: true)
|
||||
defer { try? fm.removeItem(at: root) }
|
||||
let model = AppDelegate.makeLaunchModel(appSupportRoot: root)
|
||||
|
||||
_ = try await addCapture(to: model, red: 0.4, green: 0.4, blue: 0.4)
|
||||
await model.handleDidShareItems(
|
||||
fileName: "Redline-20261011-120000.pdf", sentSummary: "Sent — 1 page.")
|
||||
|
||||
#expect(model.statusLine == "Sent — 1 page.")
|
||||
#expect(model.session.isEmpty)
|
||||
#expect(model.pastSessions.count == 1)
|
||||
#expect(model.pastSessions.first?.pdfFileName == "Redline-20261011-120000.pdf")
|
||||
#expect(model.pastSessions.first?.captures.count == 1)
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test("Start new session and send refuse to overlap (no mid-flight session close)")
|
||||
func sessionStartAndSendRefuseToOverlap() async throws {
|
||||
let fm = FileManager.default
|
||||
let root = fm.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-session-workflow-\(UUID().uuidString)", isDirectory: true)
|
||||
defer { try? fm.removeItem(at: root) }
|
||||
let model = AppDelegate.makeLaunchModel(appSupportRoot: root)
|
||||
|
||||
let capture = try await addCapture(to: model, red: 0.1, green: 0.1, blue: 0.1)
|
||||
let before = model.session.id
|
||||
|
||||
// A send in flight: "Start new session" must refuse instead of renaming the
|
||||
// session directory out from under the compose.
|
||||
model.setSending(true)
|
||||
await model.startNewSession()
|
||||
#expect(model.session.id == before)
|
||||
#expect(model.session.captures.map(\.id) == [capture.id])
|
||||
#expect(model.statusLine == "Finish the current send first.")
|
||||
model.setSending(false)
|
||||
|
||||
// A session start in flight: send must refuse before composing anything.
|
||||
model.setStartingNewSession(true)
|
||||
await model.send(anchor: nil)
|
||||
#expect(model.statusLine == "Finish starting the new session first.")
|
||||
#expect(model.session.id == before)
|
||||
#expect(model.session.captures.map(\.id) == [capture.id])
|
||||
model.setStartingNewSession(false)
|
||||
|
||||
// Both settled: the normal path still works.
|
||||
await model.startNewSession()
|
||||
#expect(model.session.id != before)
|
||||
#expect(model.pastSessions.count == 1)
|
||||
#expect(model.pastSessions.first?.captures.map(\.id) == [capture.id])
|
||||
}
|
||||
|
||||
@MainActor
|
||||
@Test("The OneDrive send summary survives archiving (never overwritten by the archive path)")
|
||||
func oneDriveSendSummarySurvivesArchiving() async throws {
|
||||
let fm = FileManager.default
|
||||
let root = fm.temporaryDirectory
|
||||
.appendingPathComponent("shotdeck-session-workflow-\(UUID().uuidString)", isDirectory: true)
|
||||
defer { try? fm.removeItem(at: root) }
|
||||
let model = AppDelegate.makeLaunchModel(appSupportRoot: root)
|
||||
|
||||
_ = try await addCapture(to: model, red: 0.6, green: 0.2, blue: 0.2)
|
||||
let summary = "Saved to OneDrive — 1 page. Open it in Files on your iPad."
|
||||
await model.handleDidShareItems(fileName: "Redline-20261011-120100.pdf", sentSummary: summary)
|
||||
|
||||
#expect(model.statusLine == summary)
|
||||
#expect(model.pastSessions.count == 1)
|
||||
#expect(model.pastSessions.first?.pdfFileName == "Redline-20261011-120100.pdf")
|
||||
}
|
||||
|
||||
// MARK: - Fixtures
|
||||
|
||||
/// Appends one generated PNG through the store and refreshes `model.session` from
|
||||
/// it — the same refresh `AppModel.captureNow()` performs after a real capture.
|
||||
@MainActor
|
||||
private func addCapture(
|
||||
to model: AppModel,
|
||||
red: CGFloat,
|
||||
green: CGFloat,
|
||||
blue: CGFloat
|
||||
) async throws -> Capture {
|
||||
let capture = try await model.spool.append(
|
||||
pngData: try makePNGData(width: 8, height: 8, red: red, green: green, blue: blue),
|
||||
pixelWidth: 8, pixelHeight: 8, scale: 1.0, capturedAt: Date())
|
||||
model.replaceSession(try await model.spool.currentSession())
|
||||
return capture
|
||||
}
|
||||
|
||||
private enum FixtureError: Error {
|
||||
case pngGenerationFailed
|
||||
}
|
||||
|
||||
// MARK: - Fixtures
|
||||
|
||||
private struct IsolatedDefaults {
|
||||
let name: String
|
||||
let defaults: UserDefaults
|
||||
}
|
||||
|
||||
/// A throwaway UserDefaults suite — never `.standard` — so the age-limit setting a
|
||||
/// test writes can never change Ben's real app preference.
|
||||
private func makeIsolatedDefaults() throws -> IsolatedDefaults {
|
||||
let name = "shotdeck-session-workflow-\(UUID().uuidString)"
|
||||
guard let defaults = UserDefaults(suiteName: name) else {
|
||||
throw FixtureError.pngGenerationFailed
|
||||
}
|
||||
defaults.removePersistentDomain(forName: name)
|
||||
return IsolatedDefaults(name: name, defaults: defaults)
|
||||
}
|
||||
|
||||
/// Writes an archived session folder dated `daysAgo` days in the past, in the exact
|
||||
/// on-disk shape the store produces, so an age policy can act on a real manifest date.
|
||||
@discardableResult
|
||||
private func writeBackdatedSession(in paths: AppSupportPaths, daysAgo: Int) async throws -> UUID {
|
||||
let id = UUID()
|
||||
let createdAt = Date().addingTimeInterval(-Double(daysAgo) * 86_400)
|
||||
let dir = paths.archiveDirectory(id)
|
||||
try FileManager.default.createDirectory(at: dir, withIntermediateDirectories: true)
|
||||
let pngName = "001-\(String(id.uuidString.prefix(8)).uppercased()).png"
|
||||
try makePNGData(width: 8, height: 8, red: 0.3, green: 0.3, blue: 0.3)
|
||||
.write(to: dir.appendingPathComponent(pngName))
|
||||
let capture = Capture(
|
||||
id: UUID(), sequence: 1, fileName: pngName,
|
||||
pixelWidth: 8, pixelHeight: 8, scale: 1.0, capturedAt: createdAt)
|
||||
let session = CaptureSession(
|
||||
id: id, createdAt: createdAt, state: .archived, captures: [capture],
|
||||
pdfFileName: nil,
|
||||
context: ReviewContext(lane: "DEV03", deployedVersion: "v1.0.0", commit: "abc1234"))
|
||||
let encoder = JSONEncoder()
|
||||
encoder.dateEncodingStrategy = .iso8601
|
||||
try encoder.encode(session).write(to: dir.appendingPathComponent("session.json"))
|
||||
return id
|
||||
}
|
||||
|
||||
|
||||
private func makePNGData(
|
||||
width: Int,
|
||||
height: Int,
|
||||
red: CGFloat,
|
||||
green: CGFloat,
|
||||
blue: CGFloat
|
||||
) throws -> Data {
|
||||
let colorSpace = CGColorSpaceCreateDeviceRGB()
|
||||
guard let context = CGContext(
|
||||
data: nil,
|
||||
width: width,
|
||||
height: height,
|
||||
bitsPerComponent: 8,
|
||||
bytesPerRow: width * 4,
|
||||
space: colorSpace,
|
||||
bitmapInfo: CGImageAlphaInfo.premultipliedLast.rawValue
|
||||
) else {
|
||||
throw FixtureError.pngGenerationFailed
|
||||
}
|
||||
context.setFillColor(red: red, green: green, blue: blue, alpha: 1)
|
||||
context.fill(CGRect(x: 0, y: 0, width: width, height: height))
|
||||
guard let image = context.makeImage() else {
|
||||
throw FixtureError.pngGenerationFailed
|
||||
}
|
||||
let buffer = NSMutableData()
|
||||
guard let destination = CGImageDestinationCreateWithData(buffer, "public.png" as CFString, 1, nil) else {
|
||||
throw FixtureError.pngGenerationFailed
|
||||
}
|
||||
CGImageDestinationAddImage(destination, image, nil)
|
||||
guard CGImageDestinationFinalize(destination) else {
|
||||
throw FixtureError.pngGenerationFailed
|
||||
}
|
||||
return buffer as Data
|
||||
}
|
||||
@@ -0,0 +1,118 @@
|
||||
import Foundation
|
||||
import Testing
|
||||
@testable import Shotdeck
|
||||
@testable import ShotdeckCore
|
||||
|
||||
@Test("DubaiTime.checkTime formats as HH:MM Dubai")
|
||||
func dubaiTimeCheckTimeFormat() {
|
||||
let now = Date()
|
||||
let result = DubaiTime.checkTime(now)
|
||||
|
||||
// Dubai timezone format: HH:MM Dubai
|
||||
let pattern = "^[0-9]{2}:[0-9]{2} Dubai$"
|
||||
let regex = try? NSRegularExpression(pattern: pattern, options: [])
|
||||
let range = NSRange(result.startIndex..<result.endIndex, in: result)
|
||||
let matches = regex?.matches(in: result, options: [], range: range) ?? []
|
||||
#expect(!matches.isEmpty, "checkTime should format as HH:MM Dubai, got: \(result)")
|
||||
}
|
||||
|
||||
@Test("Status message: up-to-date manual check includes Dubai timestamp")
|
||||
@MainActor
|
||||
func manualCheckUpToDateIncludesTimestamp() async {
|
||||
let checker = UpdateChecker()
|
||||
|
||||
// Inject a stub appcast showing the current version (no update available)
|
||||
let currentVersion = UpdateChecker.currentVersion()
|
||||
let stubAppcast = """
|
||||
{
|
||||
"version": "\(currentVersion)",
|
||||
"zipURL": "https://example.com/dummy.zip",
|
||||
"sha256": "0000000000000000000000000000000000000000000000000000000000000000"
|
||||
}
|
||||
"""
|
||||
checker.testAppcastJSON = stubAppcast
|
||||
|
||||
// Capture the status message
|
||||
var capturedStatus: String?
|
||||
checker.onChecked = {
|
||||
capturedStatus = checker.statusMessage
|
||||
}
|
||||
|
||||
// Run the manual check
|
||||
await checker.checkNow(manual: true)
|
||||
|
||||
// Verify the message matches the expected format and includes a timestamp
|
||||
guard let status = capturedStatus else {
|
||||
#expect(false, "statusMessage should not be nil for manual check finding no update")
|
||||
return
|
||||
}
|
||||
|
||||
// Message should be "Redline X.Y.Z is up to date, checked HH:MM Dubai"
|
||||
let pattern = "^Redline [0-9]+\\.[0-9]+\\.[0-9]+ is up to date, checked [0-9]{2}:[0-9]{2} Dubai$"
|
||||
let regex = try? NSRegularExpression(pattern: pattern, options: [])
|
||||
let range = NSRange(status.startIndex..<status.endIndex, in: status)
|
||||
let matches = regex?.matches(in: status, options: [], range: range) ?? []
|
||||
#expect(!matches.isEmpty, "Manual check up-to-date message should match format, got: \(status)")
|
||||
}
|
||||
|
||||
@Test("Status message: automatic check doesn't set message when up-to-date")
|
||||
@MainActor
|
||||
func automaticCheckUpToDateLeavesMessageNil() async {
|
||||
let checker = UpdateChecker()
|
||||
|
||||
// Inject a stub appcast showing the current version (no update available)
|
||||
let currentVersion = UpdateChecker.currentVersion()
|
||||
let stubAppcast = """
|
||||
{
|
||||
"version": "\(currentVersion)",
|
||||
"zipURL": "https://example.com/dummy.zip",
|
||||
"sha256": "0000000000000000000000000000000000000000000000000000000000000000"
|
||||
}
|
||||
"""
|
||||
checker.testAppcastJSON = stubAppcast
|
||||
|
||||
// Capture the status message
|
||||
var capturedStatus: String?
|
||||
checker.onChecked = {
|
||||
capturedStatus = checker.statusMessage
|
||||
}
|
||||
|
||||
// Run an AUTOMATIC check (manual: false)
|
||||
await checker.checkNow(manual: false)
|
||||
|
||||
// For automatic checks finding no update, statusMessage should be nil
|
||||
#expect(capturedStatus == nil,
|
||||
"Automatic check finding no update should leave statusMessage nil, got: \(capturedStatus ?? "(nil)")")
|
||||
}
|
||||
|
||||
@Test("Update status and general status are independent channels")
|
||||
@MainActor
|
||||
func statusChannelsAreIndependent() async throws {
|
||||
let fm = FileManager.default
|
||||
let appSupportRoot = fm.temporaryDirectory
|
||||
.appendingPathComponent("update-checker-channel-test-\(UUID().uuidString)", isDirectory: true)
|
||||
defer { try? fm.removeItem(at: appSupportRoot) }
|
||||
|
||||
// Create a real AppModel using the standard launch pattern
|
||||
let model = AppDelegate.makeLaunchModel(appSupportRoot: appSupportRoot)
|
||||
defer { model.hotkeys.unregisterAll() }
|
||||
|
||||
// Test 1: Setting statusLine should NOT affect updateStatusMessage
|
||||
model.setStatus("General status: captured 3")
|
||||
#expect(model.statusLine == "General status: captured 3", "statusLine should be set")
|
||||
#expect(model.updateStatusMessage == nil, "updateStatusMessage should remain nil")
|
||||
|
||||
// Test 2: Setting updateStatus should NOT affect statusLine
|
||||
model.setUpdateStatus("Update to 9.9.9 is ready")
|
||||
#expect(model.statusLine == "General status: captured 3", "statusLine should remain unchanged")
|
||||
#expect(model.updateStatusMessage == "Update to 9.9.9 is ready", "updateStatusMessage should be set")
|
||||
|
||||
// Test 3: Clearing statusLine leaves updateStatus intact
|
||||
model.setStatus(nil)
|
||||
#expect(model.statusLine == nil, "statusLine should be cleared")
|
||||
#expect(model.updateStatusMessage == "Update to 9.9.9 is ready", "updateStatusMessage should persist")
|
||||
|
||||
// Test 4: Clearing updateStatus leaves other state unaffected
|
||||
model.setUpdateStatus(nil)
|
||||
#expect(model.updateStatusMessage == nil, "updateStatusMessage should be cleared")
|
||||
}
|
||||
@@ -0,0 +1,480 @@
|
||||
<!doctype html>
|
||||
<html lang="en">
|
||||
<head>
|
||||
<meta charset="utf-8">
|
||||
<meta name="viewport" content="width=device-width, initial-scale=1">
|
||||
<title>Redline UX Rework</title>
|
||||
<meta name="description" content="From-scratch UX for Redline: a glance-and-act menu-bar popover, one main window for sessions, and a three-section Settings window. Light and dark, 1:1 sizes.">
|
||||
<style>
|
||||
/* Page chrome (the board the mockups sit on) */
|
||||
:root{--page:#e9e7e2;--ink:#1d1d1f;--mut:rgba(0,0,0,.55);--rule:rgba(0,0,0,.1);--acc:#0a64d6}
|
||||
@media (prefers-color-scheme:dark){:root:not([data-theme="light"]){--page:#141416;--ink:#ececec;--mut:rgba(255,255,255,.6);--rule:rgba(255,255,255,.12)}}
|
||||
:root[data-theme="dark"]{--page:#141416;--ink:#ececec;--mut:rgba(255,255,255,.6);--rule:rgba(255,255,255,.12)}
|
||||
body{margin:0;background:var(--page);color:var(--ink);font:13px/1.4 -apple-system,BlinkMacSystemFont,"SF Pro Text","Helvetica Neue",sans-serif;-webkit-font-smoothing:antialiased}
|
||||
a{color:var(--acc);text-decoration:none}a:hover{text-decoration:underline}
|
||||
.mac a{color:var(--accent)}
|
||||
header.board{padding:32px 40px 8px;max-width:1200px}
|
||||
header.board h1{margin:0 0 6px;font-size:22px;font-weight:600}
|
||||
header.board p{margin:0;color:var(--mut);max-width:760px}
|
||||
section.turn{padding:28px 40px 36px;border-top:1px solid var(--rule)}
|
||||
.thd{display:flex;align-items:baseline;gap:10px;margin:0 0 18px}
|
||||
.tid{font:600 10px ui-monospace,Menlo,monospace;padding:3px 7px;background:var(--ink);color:var(--page);text-decoration:none}
|
||||
.tname{font-weight:600}
|
||||
.tnote{color:var(--mut);font-size:12px}
|
||||
.row{display:flex;flex-wrap:wrap;gap:36px;align-items:flex-start}
|
||||
.opt{display:flex;flex-direction:column;gap:10px;max-width:100%}
|
||||
.olabel{font-size:12px;color:var(--mut);display:flex;gap:8px;align-items:baseline}
|
||||
.oid{font:600 10.5px ui-monospace,Menlo,monospace;padding:3px 7px;background:var(--rule);color:var(--ink);text-decoration:none}
|
||||
.scroller{max-width:100%;overflow-x:auto;padding:2px 2px 18px}
|
||||
@media (max-width:600px){header.board,section.turn{padding-left:16px;padding-right:16px}}
|
||||
|
||||
/* ---------- macOS semantic tokens, per mock theme ---------- */
|
||||
.mac{--win:#ececec;--content:#ffffff;--side:#e8e8e8;--side2:#dedede;--label:rgba(0,0,0,.88);--label2:rgba(0,0,0,.55);--label3:rgba(0,0,0,.3);
|
||||
--sep:rgba(0,0,0,.1);--ctl:#ffffff;--ctlBorder:rgba(0,0,0,.16);--ctlShadow:0 .5px 1px rgba(0,0,0,.12);--fill:rgba(0,0,0,.05);--fill2:rgba(0,0,0,.08);
|
||||
--accent:#0a64d6;--accentText:#ffffff;--selection:#0a64d6;--selText:#fff;--selMuted:rgba(0,0,0,.08);--red:#d70015;--green:#248a3d;--orange:#c45a00;
|
||||
--pop:rgba(246,246,246,.96);--group:#ffffff;--groupBorder:rgba(0,0,0,.08);--thumbA:#d9ded9;--thumbB:#c9d3e1;--thumbC:#e3d6cc;
|
||||
--shadow:0 0 0 .5px rgba(0,0,0,.22),0 18px 48px rgba(0,0,0,.22),0 4px 10px rgba(0,0,0,.08);
|
||||
color:var(--label);font:13px/1.35 -apple-system,BlinkMacSystemFont,"SF Pro Text","Helvetica Neue",sans-serif;-webkit-font-smoothing:antialiased;letter-spacing:-.003em}
|
||||
.mac.dark{--win:#2a2a2c;--content:#1e1e1e;--side:#2b2a2e;--side2:#353438;--label:rgba(255,255,255,.88);--label2:rgba(255,255,255,.55);--label3:rgba(255,255,255,.28);
|
||||
--sep:rgba(255,255,255,.1);--ctl:#5c5c60;--ctlBorder:rgba(255,255,255,.08);--ctlShadow:0 .5px 1px rgba(0,0,0,.4);--fill:rgba(255,255,255,.06);--fill2:rgba(255,255,255,.1);
|
||||
--accent:#0a7cff;--selection:#0a5fce;--selMuted:rgba(255,255,255,.1);--red:#ff453a;--green:#32d74b;--orange:#ff9f0a;
|
||||
--pop:rgba(40,40,42,.97);--group:#252527;--groupBorder:rgba(255,255,255,.07);--thumbA:#3d4441;--thumbB:#38404d;--thumbC:#4a4038;
|
||||
--shadow:0 0 0 .5px rgba(0,0,0,.9),0 0 0 1px rgba(255,255,255,.08) inset,0 18px 48px rgba(0,0,0,.55)}
|
||||
|
||||
/* ---------- controls ---------- */
|
||||
.btn{display:inline-flex;align-items:center;justify-content:center;gap:5px;height:22px;padding:0 10px;border-radius:6px;background:var(--ctl);color:var(--label);
|
||||
box-shadow:var(--ctlShadow),0 0 0 .5px var(--ctlBorder);font:500 13px/1 inherit;font-family:inherit;white-space:nowrap;border:0}
|
||||
.btn.sm{height:20px;font-size:12px;padding:0 9px;border-radius:5px}
|
||||
.btn.lg{height:28px;font-size:13px;padding:0 14px;border-radius:7px}
|
||||
.btn.primary{background:var(--accent);color:var(--accentText);box-shadow:0 .5px 1px rgba(0,0,0,.2)}
|
||||
.btn.plain{background:transparent;box-shadow:none;color:var(--accent);padding:0 4px}
|
||||
.btn.icon{width:24px;padding:0;background:transparent;box-shadow:none;color:var(--label2)}
|
||||
.btn[disabled]{opacity:.42}
|
||||
.kbd{font:500 11px/1 -apple-system,inherit;color:var(--label2);letter-spacing:.04em}
|
||||
.primary .kbd{color:rgba(255,255,255,.75)}
|
||||
.seg{display:inline-flex;background:var(--fill2);border-radius:6px;padding:1px;gap:1px}
|
||||
.seg span{padding:2px 12px;border-radius:5px;font-size:12px;color:var(--label)}
|
||||
.seg span.on{background:var(--ctl);box-shadow:var(--ctlShadow),0 0 0 .5px var(--ctlBorder)}
|
||||
.field{height:22px;border-radius:5px;background:var(--ctl);box-shadow:0 0 0 .5px var(--ctlBorder) inset;display:flex;align-items:center;padding:0 7px;color:var(--label);font-size:13px}
|
||||
.mac.dark .field{background:rgba(255,255,255,.06)}
|
||||
.mac.dark .grow-row .field{background:transparent}
|
||||
.mac.dark .grow-row .field.focus{background:rgba(255,255,255,.08)}
|
||||
.field.ph{color:var(--label3)}
|
||||
.field.focus{box-shadow:0 0 0 .5px var(--accent) inset,0 0 0 3px color-mix(in srgb,var(--accent) 35%,transparent)}
|
||||
.popup{display:inline-flex;align-items:center;gap:8px;height:22px;padding:0 6px 0 9px;border-radius:5px;background:var(--ctl);box-shadow:var(--ctlShadow),0 0 0 .5px var(--ctlBorder);font-size:13px}
|
||||
.popup i{display:inline-block;width:14px;height:16px;border-radius:4px;background:var(--accent);position:relative}
|
||||
.popup i:before,.popup i:after{content:"";position:absolute;left:4px;border:3px solid transparent}
|
||||
.popup i:before{top:2px;border-bottom-color:#fff;border-top:0}
|
||||
.popup i:after{bottom:2px;border-top-color:#fff;border-bottom:0}
|
||||
.mono{font-family:ui-monospace,"SF Mono",Menlo,monospace;font-size:12px}
|
||||
.sec{color:var(--label2)}
|
||||
.ter{color:var(--label3)}
|
||||
.cap{font-size:11px;color:var(--label2)}
|
||||
svg.sym{width:14px;height:14px;flex:none;stroke:currentColor;fill:none;stroke-width:1.5;stroke-linecap:round;stroke-linejoin:round}
|
||||
svg.sym.sm{width:12px;height:12px}
|
||||
|
||||
/* ---------- menu bar + popover ---------- */
|
||||
.menubar{height:24px;display:flex;justify-content:flex-end;align-items:center;gap:14px;padding:0 12px;font-size:13px;width:356px;box-sizing:border-box;
|
||||
background:rgba(236,236,236,.85);color:#111;border-radius:6px 6px 0 0}
|
||||
.mac.dark .menubar{background:rgba(28,28,30,.9);color:#eee}
|
||||
.menubar .extra{display:inline-flex;align-items:center;gap:3px;padding:1px 6px;border-radius:4px;background:rgba(0,0,0,.12)}
|
||||
.mac.dark .menubar .extra{background:rgba(255,255,255,.18)}
|
||||
.popwrap{position:relative;width:356px;padding-top:8px}
|
||||
.popover{width:340px;margin-left:8px;border-radius:12px;background:var(--pop);box-shadow:var(--shadow);overflow:hidden;position:relative}
|
||||
.popover:before{content:"";position:absolute;top:-6px;right:42px;width:12px;height:12px;background:var(--pop);transform:rotate(45deg)}
|
||||
.pp{padding:12px 12px 0}
|
||||
.pp-head{display:flex;align-items:flex-start;gap:8px}
|
||||
.pp-title{font-size:13px;font-weight:600}
|
||||
.pp-sub{font-size:11px;color:var(--label2);margin-top:1px}
|
||||
.pp-head .grow{flex:1;min-width:0}
|
||||
.badge{font:600 11px/1 inherit;padding:3px 6px;border-radius:99px;background:var(--fill2);color:var(--label2);font-variant-numeric:tabular-nums}
|
||||
.strip{display:flex;gap:6px;margin:12px 0 0;overflow:hidden}
|
||||
.thumb{position:relative;flex:none;height:62px;width:96px;border-radius:5px;background:var(--thumbA);box-shadow:0 0 0 .5px var(--sep) inset;overflow:hidden}
|
||||
.thumb:nth-child(3n+2){background:var(--thumbB)}.thumb:nth-child(3n){background:var(--thumbC)}
|
||||
.thumb .n{position:absolute;left:4px;top:4px;font:600 10px/1 inherit;color:#fff;background:rgba(0,0,0,.55);padding:2px 4px;border-radius:3px}
|
||||
.thumb .lines{position:absolute;left:10px;right:10px;top:22px;display:grid;gap:5px}
|
||||
.thumb .lines b{display:block;height:4px;border-radius:2px;background:rgba(0,0,0,.14)}
|
||||
.mac.dark .thumb .lines b{background:rgba(255,255,255,.14)}
|
||||
.thumb .lines b:nth-child(2){width:70%}.thumb .lines b:nth-child(3){width:45%}
|
||||
.thumb.more{width:44px;background:var(--fill)!important;display:flex;align-items:center;justify-content:center;font-size:11px;color:var(--label2)}
|
||||
.empty-strip{margin:12px 0 0;height:62px;border-radius:6px;background:var(--fill);display:flex;flex-direction:column;align-items:center;justify-content:center;gap:2px;text-align:center}
|
||||
.empty-strip .t{font-size:12px;color:var(--label)}
|
||||
.empty-strip .s{font-size:11px;color:var(--label2)}
|
||||
.actions{display:grid;grid-template-columns:1fr 1fr;gap:8px;margin:12px 0 0}
|
||||
.actions .btn{height:28px;font-size:13px;border-radius:7px}
|
||||
.secondary{display:flex;justify-content:space-between;align-items:center;margin:10px 0 0}
|
||||
.status{margin:10px -12px 0;padding:8px 12px;border-top:.5px solid var(--sep);display:flex;gap:8px;align-items:center;font-size:12px}
|
||||
.status .dot{width:7px;height:7px;border-radius:50%;background:var(--green);flex:none}
|
||||
.status .grow{flex:1}
|
||||
.pp-foot{margin:0 -12px;padding:6px 8px 6px 12px;border-top:.5px solid var(--sep);display:flex;align-items:center;justify-content:space-between;font-size:11px;color:var(--label2)}
|
||||
.capturing .thumb.live{box-shadow:0 0 0 2px var(--accent) inset}
|
||||
.spinner{width:12px;height:12px;border-radius:50%;border:1.6px solid rgba(255,255,255,.45);border-top-color:#fff;flex:none}
|
||||
.btn:not(.primary) .spinner{border-color:var(--fill2);border-top-color:var(--label2)}
|
||||
|
||||
/* ---------- main window ---------- */
|
||||
.window{border-radius:10px;background:var(--content);box-shadow:var(--shadow);overflow:hidden;display:grid;grid-template-columns:232px 1fr 300px;grid-template-rows:52px 1fr;position:relative}
|
||||
.window.noinsp{grid-template-columns:232px 1fr}
|
||||
.titlebar{grid-column:1/-1;display:grid;grid-template-columns:232px 1fr 300px;border-bottom:.5px solid var(--sep);background:var(--win)}
|
||||
.window.noinsp .titlebar{grid-template-columns:232px 1fr}
|
||||
.tb-side{display:flex;align-items:center;gap:8px;padding:0 12px 0 20px;background:var(--side);border-right:.5px solid var(--sep)}
|
||||
.lights{display:flex;gap:8px}
|
||||
.lights i{width:12px;height:12px;border-radius:50%;display:block;box-shadow:0 0 0 .5px rgba(0,0,0,.18) inset}
|
||||
.lights i:nth-child(1){background:#ff5f57}.lights i:nth-child(2){background:#febc2e}.lights i:nth-child(3){background:#28c840}
|
||||
.tb-main{display:flex;align-items:center;gap:8px;padding:0 12px 0 16px}
|
||||
.tb-main .title{font-size:15px;font-weight:600}
|
||||
.tb-main .subtitle{font-size:11px;color:var(--label2)}
|
||||
.tb-main .grow{flex:1}
|
||||
.tbbtn{display:inline-flex;align-items:center;gap:5px;height:28px;padding:0 9px;border-radius:7px;color:var(--label);font-size:13px}
|
||||
.tbbtn:hover{background:var(--fill)}
|
||||
.tbbtn.prom{background:var(--accent);color:#fff}
|
||||
.tbgroup{display:flex;gap:2px}
|
||||
.tb-insp{display:flex;align-items:center;justify-content:flex-end;padding:0 12px;border-left:.5px solid var(--sep)}
|
||||
.sidebar{background:var(--side);border-right:.5px solid var(--sep);padding:8px 10px;overflow:hidden}
|
||||
.search{height:26px;border-radius:7px;background:var(--fill2);display:flex;align-items:center;gap:6px;padding:0 8px;color:var(--label3);font-size:13px;margin:0 0 10px}
|
||||
.sgroup{font:600 11px/1 inherit;color:var(--label2);padding:10px 8px 5px}
|
||||
.srow{display:grid;grid-template-columns:1fr auto;gap:0 6px;padding:5px 8px;border-radius:6px;margin:0 0 1px}
|
||||
.srow .l1{font-size:13px;font-weight:500;white-space:nowrap;overflow:hidden;text-overflow:ellipsis}
|
||||
.srow .l2{grid-column:1/-1;font-size:11px;color:var(--label2);white-space:nowrap;overflow:hidden;text-overflow:ellipsis}
|
||||
.srow .tm{font-size:11px;color:var(--label2);font-variant-numeric:tabular-nums;align-self:center}
|
||||
.srow.sel{background:var(--selection);color:var(--selText)}
|
||||
.srow.sel .l2,.srow.sel .tm{color:rgba(255,255,255,.78)}
|
||||
.srow .st{display:inline-flex;align-items:center;gap:3px}
|
||||
.srow .st.ret{color:var(--orange)}
|
||||
.srow.sel .st.ret{color:#fff}
|
||||
.current-pill{font:600 10px/1 inherit;padding:2px 5px;border-radius:4px;background:var(--accent);color:#fff;margin-left:4px;vertical-align:1px}
|
||||
.srow.sel .current-pill{background:rgba(255,255,255,.25)}
|
||||
.content{padding:18px 20px;overflow:hidden;background:var(--content)}
|
||||
.chead{display:flex;align-items:baseline;gap:10px;margin:0 0 14px}
|
||||
.chead h2{margin:0;font-size:13px;font-weight:600}
|
||||
.chead .grow{flex:1}
|
||||
.grid{display:grid;grid-template-columns:repeat(3,1fr);gap:16px}
|
||||
.page{display:flex;flex-direction:column;gap:6px}
|
||||
.page .shot{position:relative;aspect-ratio:16/10;border-radius:6px;background:var(--thumbA);box-shadow:0 0 0 .5px var(--sep) inset;overflow:hidden}
|
||||
.page:nth-child(3n+2) .shot{background:var(--thumbB)}.page:nth-child(3n) .shot{background:var(--thumbC)}
|
||||
.page .shot .lines{position:absolute;left:14%;right:14%;top:28%;display:grid;gap:7px}
|
||||
.page .shot .lines b{display:block;height:6px;border-radius:3px;background:rgba(0,0,0,.12)}
|
||||
.mac.dark .page .shot .lines b{background:rgba(255,255,255,.12)}
|
||||
.page .shot .lines b:nth-child(2){width:72%}.page .shot .lines b:nth-child(3){width:48%}
|
||||
.page .shot .mark{position:absolute;right:8px;top:8px;font:600 10px/1 inherit;padding:3px 5px;border-radius:4px;background:var(--orange);color:#fff}
|
||||
.page .meta{display:flex;justify-content:space-between;font-size:11px;color:var(--label2);font-variant-numeric:tabular-nums}
|
||||
.page .meta b{color:var(--label);font-weight:600}
|
||||
.page.sel .shot{box-shadow:0 0 0 3px var(--accent)}
|
||||
.inspector{border-left:.5px solid var(--sep);background:var(--win);padding:14px 14px;overflow:hidden}
|
||||
.mac.dark .inspector{background:#232325}
|
||||
.ihead{font:600 11px/1 inherit;color:var(--label2);margin:6px 2px 7px}
|
||||
.group{background:var(--group);border-radius:8px;box-shadow:0 0 0 .5px var(--groupBorder);margin:0 0 14px}
|
||||
.grow-row{display:grid;grid-template-columns:78px 1fr;align-items:center;gap:8px;padding:6px 10px;min-height:22px}
|
||||
.grow-row + .grow-row{border-top:.5px solid var(--sep)}
|
||||
.grow-row .k{font-size:12px;color:var(--label2)}
|
||||
.grow-row .v{font-size:12px;min-width:0;overflow:hidden;text-overflow:ellipsis;white-space:nowrap}
|
||||
.grow-row .field{height:20px;font-size:12px;background:transparent;box-shadow:none;padding:0}
|
||||
.grow-row .field.focus{background:var(--ctl);box-shadow:0 0 0 .5px var(--accent) inset,0 0 0 3px color-mix(in srgb,var(--accent) 35%,transparent);padding:0 5px;margin:0 -5px}
|
||||
.note .v{white-space:normal}
|
||||
.ifoot{font-size:11px;color:var(--label2);margin:-6px 2px 12px;line-height:1.35}
|
||||
.ret-banner{display:flex;gap:8px;align-items:flex-start;padding:8px 10px;border-radius:8px;background:color-mix(in srgb,var(--orange) 12%,transparent);margin:0 0 14px;font-size:12px}
|
||||
.ret-banner .grow{flex:1}
|
||||
.ret-banner svg{color:var(--orange);margin-top:1px}
|
||||
.empty-main{display:flex;flex-direction:column;align-items:center;justify-content:center;text-align:center;height:100%;gap:8px;padding:0 40px}
|
||||
.empty-main .t{font-size:15px;font-weight:600}
|
||||
.empty-main .s{font-size:12px;color:var(--label2);max-width:320px}
|
||||
|
||||
/* ---------- settings ---------- */
|
||||
.settings{width:420px;border-radius:10px;background:var(--win);box-shadow:var(--shadow);overflow:hidden}
|
||||
.mac.dark .settings{background:#1f1f21}
|
||||
.st-title{height:52px;display:grid;grid-template-columns:70px 1fr 70px;align-items:center;padding:0 0 0 14px}
|
||||
.st-title .t{text-align:center;font-size:13px;font-weight:600}
|
||||
.st-body{padding:0 18px 18px}
|
||||
.st-body .ihead{margin:12px 2px 7px}
|
||||
.st-row{display:flex;align-items:center;justify-content:space-between;gap:12px;padding:7px 10px;min-height:22px}
|
||||
.st-row + .st-row{border-top:.5px solid var(--sep)}
|
||||
.st-row .k{font-size:13px}
|
||||
.st-row .v{display:flex;align-items:center;gap:8px;min-width:0}
|
||||
.st-row .path{font-size:12px;color:var(--label2);max-width:170px;white-space:nowrap;overflow:hidden;text-overflow:ellipsis}
|
||||
.recorder{display:inline-flex;align-items:center;height:22px;padding:0 10px;border-radius:5px;background:var(--fill2);font-size:13px;letter-spacing:.06em}
|
||||
.st-help{font-size:11px;color:var(--label2);margin:6px 2px 0;line-height:1.35}
|
||||
|
||||
/* annotations under each mock */
|
||||
.notes{max-width:360px;font-size:12px;color:var(--mut);line-height:1.45;margin:0;padding-left:16px}
|
||||
.notes li{margin:0 0 3px}
|
||||
</style>
|
||||
</head>
|
||||
<body>
|
||||
|
||||
<header class="board">
|
||||
<h1>Redline, rebuilt from the job outwards</h1>
|
||||
<p>The menu-bar popover only answers "what am I capturing, and what do I do next". Everything about past sessions, review details and PDF facts lives in one Redline window. Settings has three sections. Each mock is shown at 1:1 size in light and dark.</p>
|
||||
</header>
|
||||
|
||||
<section class="turn" id="t1">
|
||||
<div class="thd"><a class="tid" href="#t1">1</a><span class="tname">Menu-bar popover: glance and act</span><span class="tnote">340 pt wide · controlSize small · current session only</span></div>
|
||||
<div class="row" id="popovers"></div>
|
||||
</section>
|
||||
|
||||
<section class="turn" id="t2">
|
||||
<div class="thd"><a class="tid" href="#t2">2</a><span class="tname">Redline window: the session workspace</span><span class="tnote">1100 × 700 · sidebar · content · inspector · controlSize regular</span></div>
|
||||
<div class="row" id="mains"></div>
|
||||
</section>
|
||||
|
||||
<section class="turn" id="t3">
|
||||
<div class="thd"><a class="tid" href="#t3">3</a><span class="tname">Redline window: first run, nothing captured</span><span class="tnote">1100 × 700</span></div>
|
||||
<div class="row" id="empties"></div>
|
||||
</section>
|
||||
|
||||
<section class="turn" id="t4">
|
||||
<div class="thd"><a class="tid" href="#t4">4</a><span class="tname">Settings</span><span class="tnote">420 × 484 · three groups, no tabs</span></div>
|
||||
<div class="row" id="settings"></div>
|
||||
</section>
|
||||
|
||||
<script>
|
||||
/* Inline SVG stand-ins for the SF Symbols the app will use (names in data-sf). */
|
||||
const SYM = {
|
||||
camera: '<svg class="sym" viewBox="0 0 16 16" data-sf="camera.viewfinder"><path d="M2 5V3.5A1.5 1.5 0 0 1 3.5 2H5M11 2h1.5A1.5 1.5 0 0 1 14 3.5V5M14 11v1.5a1.5 1.5 0 0 1-1.5 1.5H11M5 14H3.5A1.5 1.5 0 0 1 2 12.5V11"/><circle cx="8" cy="8" r="2.4"/></svg>',
|
||||
send: '<svg class="sym" viewBox="0 0 16 16" data-sf="paperplane"><path d="M14 2 2 7l5 2 2 5 5-12Z"/><path d="m7 9 3-3"/></svg>',
|
||||
plus: '<svg class="sym" viewBox="0 0 16 16" data-sf="plus.rectangle.on.rectangle"><rect x="2.5" y="4.5" width="9" height="9" rx="1.5"/><path d="M5 2.5h7a1.5 1.5 0 0 1 1.5 1.5v7M7 9h0M7 7v4M5 9h4"/></svg>',
|
||||
window: '<svg class="sym" viewBox="0 0 16 16" data-sf="macwindow"><rect x="2" y="3" width="12" height="10" rx="1.5"/><path d="M2 6h12"/></svg>',
|
||||
more: '<svg class="sym" viewBox="0 0 16 16" data-sf="ellipsis.circle"><circle cx="8" cy="8" r="6"/><circle cx="5.5" cy="8" r=".4" fill="currentColor"/><circle cx="8" cy="8" r=".4" fill="currentColor"/><circle cx="10.5" cy="8" r=".4" fill="currentColor"/></svg>',
|
||||
pencil: '<svg class="sym sm" viewBox="0 0 16 16" data-sf="pencil.tip.crop.circle"><path d="M10.5 2.5 13.5 5.5 6 13H3v-3Z"/></svg>',
|
||||
search: '<svg class="sym" viewBox="0 0 16 16" data-sf="magnifyingglass"><circle cx="7" cy="7" r="4.5"/><path d="m10.5 10.5 3 3"/></svg>',
|
||||
sidebar: '<svg class="sym" viewBox="0 0 16 16" data-sf="sidebar.left"><rect x="2" y="3" width="12" height="10" rx="1.5"/><path d="M6 3v10"/></svg>',
|
||||
inspector: '<svg class="sym" viewBox="0 0 16 16" data-sf="sidebar.right"><rect x="2" y="3" width="12" height="10" rx="1.5"/><path d="M10 3v10"/></svg>',
|
||||
finder: '<svg class="sym" viewBox="0 0 16 16" data-sf="folder"><path d="M2 4.5A1.5 1.5 0 0 1 3.5 3h2.6l1.4 1.5h5A1.5 1.5 0 0 1 14 6v5.5a1.5 1.5 0 0 1-1.5 1.5h-9A1.5 1.5 0 0 1 2 11.5Z"/></svg>',
|
||||
check: '<svg class="sym sm" viewBox="0 0 16 16" data-sf="checkmark.circle"><circle cx="8" cy="8" r="6"/><path d="m5.5 8 1.8 1.8L10.8 6.3"/></svg>',
|
||||
marked: '<svg class="sym sm" viewBox="0 0 16 16" data-sf="pencil.and.outline"><path d="M10.5 2.5 13.5 5.5 6 13H3v-3Z"/></svg>',
|
||||
warn: '<svg class="sym" viewBox="0 0 16 16" data-sf="exclamationmark.triangle"><path d="M8 2.5 14 13H2Z"/><path d="M8 6.5v3M8 11.3v.1"/></svg>',
|
||||
menuIcon: '<svg class="sym" viewBox="0 0 16 16" data-sf="viewfinder"><path d="M2 5V3.5A1.5 1.5 0 0 1 3.5 2H5M11 2h1.5A1.5 1.5 0 0 1 14 3.5V5M14 11v1.5a1.5 1.5 0 0 1-1.5 1.5H11M5 14H3.5A1.5 1.5 0 0 1 2 12.5V11"/></svg>'
|
||||
};
|
||||
const thumbs = n => Array.from({length:n},(_,i)=>`<div class="thumb${i===n-1?' live':''}"><span class="n">${i+1}</span><div class="lines"><b></b><b></b><b></b></div></div>`).join('');
|
||||
|
||||
function opt(id,label,html,notes){
|
||||
return `<div class="opt" id="${id}"><div class="olabel"><a class="oid" href="#${id}">${id}</a>${label}</div><div class="scroller">${html}</div>${notes?`<ul class="notes">${notes.map(n=>`<li>${n}</li>`).join('')}</ul>`:''}</div>`;
|
||||
}
|
||||
|
||||
/* ---------- popover ---------- */
|
||||
function popover(theme,state){
|
||||
const dark = theme==='dark'?' dark':'';
|
||||
const count = state==='idle'?0:(state==='capturing'?4:3);
|
||||
const head = `
|
||||
<div class="pp-head">
|
||||
<div class="grow">
|
||||
<div class="pp-title">DEV03 · v1.4.2 (41)</div>
|
||||
<div class="pp-sub">a1b2c3d · Ben Hippler · started 10:31</div>
|
||||
</div>
|
||||
${count?`<span class="badge" aria-label="${count} pages">${count} pages</span>`:''}
|
||||
<button class="btn icon" aria-label="Edit review details" title="Edit review details">${SYM.pencil}</button>
|
||||
</div>`;
|
||||
const body = state==='idle'
|
||||
? `<div class="empty-strip"><div class="t">Nothing captured yet</div><div class="s">⌥⇧2 captures 800 × 600 on Display 1</div></div>`
|
||||
: `<div class="strip${state==='capturing'?' capturing':''}">${thumbs(count===4?3:3)}${count>3?'<div class="thumb more">+1</div>':''}</div>`;
|
||||
const capBtn = state==='capturing'
|
||||
? `<button class="btn" disabled><span class="spinner"></span>Capturing…</button>`
|
||||
: `<button class="btn">${SYM.camera}Capture <span class="kbd">⌥⇧2</span></button>`;
|
||||
const sendBtn = state==='idle'
|
||||
? `<button class="btn primary" disabled>${SYM.send}Send</button>`
|
||||
: `<button class="btn primary">${SYM.send}Send ${count} pages…</button>`;
|
||||
const status = state==='with'
|
||||
? `<div class="status"><span class="dot" style="background:var(--orange)"></span><span class="grow">1 PDF came back with marks on 2 pages</span><button class="btn plain sm">Show</button></div>`
|
||||
: '';
|
||||
return `<div class="mac${dark}">
|
||||
<div class="menubar"><span>Fri 31 Oct 10:42</span><span class="extra">${SYM.menuIcon}<span style="font-size:11px;font-weight:600">${count||''}</span></span></div>
|
||||
<div class="popwrap"><div class="popover" role="dialog" aria-label="Redline">
|
||||
<div class="pp">
|
||||
${head}
|
||||
${body}
|
||||
<div class="actions">${capBtn}${sendBtn}</div>
|
||||
<div class="secondary">
|
||||
<button class="btn plain sm" ${state==='idle'?'disabled':''}>${SYM.plus}New Session</button>
|
||||
<button class="btn plain sm">${SYM.window}Open Redline</button>
|
||||
</div>
|
||||
${status}
|
||||
<div class="pp-foot" style="${status?'border-top:0;margin-top:0':'margin-top:12px'}">
|
||||
<span>Sends via AirDrop · All sessions kept</span>
|
||||
<button class="btn icon" aria-label="More">${SYM.more}</button>
|
||||
</div>
|
||||
</div>
|
||||
</div></div></div>`;
|
||||
}
|
||||
|
||||
const popNotes = {
|
||||
idle:['The session already carries the inherited review details, so the title is never empty after first use.','Send is disabled, not hidden, so the layout never jumps.'],
|
||||
with:['Send states the page count it will produce.','One status line appears only when something happened: a return, a send, or an error.'],
|
||||
capturing:['The newest thumbnail gets the accent ring; Capture shows progress and is disabled until the PNG is on disk.','The More menu holds Settings…, Check for Updates…, Quit Redline.']
|
||||
};
|
||||
document.getElementById('popovers').innerHTML =
|
||||
['idle','with','capturing'].flatMap(s=>['light','dark'].map(t=>
|
||||
opt(`1${s[0]}${t[0]}`,`${{idle:'Idle, empty session',with:'Captures present + a return',capturing:'Capturing'}[s]} · ${t}`,popover(t,s),t==='light'?popNotes[s]:null))).join('');
|
||||
|
||||
/* ---------- main window ---------- */
|
||||
const sessions = [
|
||||
{g:'Today'},
|
||||
{lane:'DEV03',tm:'10:31',l2:'3 pages · not sent',cur:true,sel:true},
|
||||
{lane:'DEV03',tm:'09:12',l2:'5 pages · sent',st:'sent'},
|
||||
{lane:'OMS test lane',tm:'08:40',l2:'2 pages · came back marked',st:'ret'},
|
||||
{g:'Yesterday'},
|
||||
{lane:'STAGE',tm:'17:04',l2:'7 pages · sent',st:'sent'},
|
||||
{lane:'DEV03',tm:'14:22',l2:'4 pages · sent',st:'sent'},
|
||||
{g:'This week'},
|
||||
{lane:'PROD',tm:'Tue',l2:'1 page · not sent'},
|
||||
{lane:'4F2A9C1D',tm:'Mon',l2:'6 pages · sent',st:'sent'},
|
||||
];
|
||||
function sidebarRows(list){
|
||||
return list.map(s=>s.g?`<div class="sgroup">${s.g}</div>`:
|
||||
`<div class="srow${s.sel?' sel':''}"><span class="l1">${s.lane}${s.cur?'<span class="current-pill">Current</span>':''}</span><span class="tm">${s.tm}</span><span class="l2">${s.st==='ret'?`<span class="st ret">${SYM.marked} ${s.l2}</span>`:s.l2}</span></div>`).join('');
|
||||
}
|
||||
function titlebar(title,sub,canSend){
|
||||
return `<div class="titlebar">
|
||||
<div class="tb-side"><div class="lights"><i></i><i></i><i></i></div><span style="flex:1"></span><span class="tbbtn" aria-label="Hide sidebar">${SYM.sidebar}</span></div>
|
||||
<div class="tb-main"><div><div class="title">${title}</div><div class="subtitle">${sub}</div></div><span class="grow"></span>
|
||||
<div class="tbgroup">
|
||||
<span class="tbbtn" title="New Session ⌘N">${SYM.plus}New Session</span>
|
||||
<span class="tbbtn" title="Capture ⌥⇧2">${SYM.camera}Capture</span>
|
||||
<span class="tbbtn prom" style="${canSend?'':'opacity:.4'}" title="Send ⌘S">${SYM.send}Send…</span>
|
||||
</div></div>
|
||||
<div class="tb-insp"><span class="tbbtn" aria-label="Hide inspector">${SYM.inspector}</span></div>
|
||||
</div>`;
|
||||
}
|
||||
function inspector(opts){
|
||||
const f = opts.focus;
|
||||
return `<aside class="inspector" aria-label="Session inspector">
|
||||
<div class="ihead">Review details</div>
|
||||
<div class="group">
|
||||
<div class="grow-row"><span class="k">Lane</span><span class="field${f==='lane'?' focus':''}">DEV03</span></div>
|
||||
<div class="grow-row"><span class="k">Deployed</span><span class="field">v1.4.2 (41)</span></div>
|
||||
<div class="grow-row"><span class="k">Commit</span><span class="field mono">a1b2c3d4</span></div>
|
||||
<div class="grow-row"><span class="k">Reviewer</span><span class="field">Ben Hippler</span></div>
|
||||
<div class="grow-row note"><span class="k">Note</span><span class="field ph">Add a note</span></div>
|
||||
</div>
|
||||
<div class="ifoot">Printed on every page of the PDF. A new session starts with these values.</div>
|
||||
<div class="ihead">PDF</div>
|
||||
<div class="group">
|
||||
<div class="grow-row"><span class="k">File name</span><span class="v mono" title="Redline-20261031-1042-DEV03-4F2A9C1D.pdf">Redline-20261031-1042-DEV03-4F2A9C1D.pdf</span></div>
|
||||
<div class="grow-row"><span class="k">Pages</span><span class="v">${opts.pages}</span></div>
|
||||
<div class="grow-row"><span class="k">Sends via</span><span class="v">AirDrop</span></div>
|
||||
<div class="grow-row"><span class="k">Status</span><span class="v sec">Not sent yet</span></div>
|
||||
</div>
|
||||
<div class="ihead">Session</div>
|
||||
<div class="group">
|
||||
<div class="grow-row"><span class="k">Started</span><span class="v">31 Oct 2026, 10:31 Dubai</span></div>
|
||||
<div class="grow-row"><span class="k">ID</span><span class="v mono">4F2A9C1D</span></div>
|
||||
<div class="grow-row"><span class="k">Captures</span><span class="v"><a href="#t2">Show in Finder</a></span></div>
|
||||
</div>
|
||||
</aside>`;
|
||||
}
|
||||
function mainWindow(theme){
|
||||
const dark = theme==='dark'?' dark':'';
|
||||
const pages = [['1','10:31'],['2','10:34'],['3','10:39']];
|
||||
return `<div class="mac${dark}"><div class="window" style="width:1100px;height:700px">
|
||||
${titlebar('DEV03','Current session · 3 pages · not sent',true)}
|
||||
<nav class="sidebar" aria-label="Sessions">
|
||||
<div class="search">${SYM.search}Search</div>
|
||||
${sidebarRows(sessions)}
|
||||
</nav>
|
||||
<main class="content">
|
||||
<div class="chead"><h2>Pages</h2><span class="sec" style="font-size:12px">In PDF order · Delete removes the selected page</span><span class="grow"></span><button class="btn">${SYM.camera}Capture <span class="kbd">⌥⇧2</span></button></div>
|
||||
<div class="grid">${pages.map((p,i)=>`<div class="page${i===1?' sel':''}"><div class="shot"><div class="lines"><b></b><b></b><b></b></div></div><div class="meta"><span><b>Page ${p[0]}</b></span><span>${p[1]}</span></div></div>`).join('')}</div>
|
||||
</main>
|
||||
${inspector({pages:3,focus:'lane'})}
|
||||
</div></div>`;
|
||||
}
|
||||
function returnedWindow(theme){
|
||||
const dark = theme==='dark'?' dark':'';
|
||||
const list = sessions.map(s=>s.sel?{...s,sel:false}:s.lane==='OMS test lane'?{...s,sel:true}:s);
|
||||
const pages = [['1','08:40',false],['2','08:43',true]];
|
||||
return `<div class="mac${dark}"><div class="window" style="width:1100px;height:700px">
|
||||
${titlebar('OMS test lane','Sent 08:52 · came back 09:30 with marks',false)}
|
||||
<nav class="sidebar" aria-label="Sessions"><div class="search">${SYM.search}Search</div>${sidebarRows(list)}</nav>
|
||||
<main class="content">
|
||||
<div class="ret-banner">${SYM.marked}<span class="grow"><b>Came back with marks on page 2.</b><br><span class="sec">Redline-20261031-0852-OMS-TEST-LANE-9B8C7D6E.pdf, in Downloads</span></span><button class="btn sm">Open PDF</button><button class="btn sm">Copy Link</button></div>
|
||||
<div class="chead"><h2>Pages</h2><span class="grow"></span></div>
|
||||
<div class="grid">${pages.map(p=>`<div class="page"><div class="shot"><div class="lines"><b></b><b></b><b></b></div>${p[2]?'<span class="mark">Marked</span>':''}</div><div class="meta"><span><b>Page ${p[0]}</b></span><span>${p[1]}</span></div></div>`).join('')}</div>
|
||||
</main>
|
||||
<aside class="inspector" aria-label="Session inspector">
|
||||
<div class="ihead">Review details</div>
|
||||
<div class="group">
|
||||
<div class="grow-row"><span class="k">Lane</span><span class="v">OMS test lane</span></div>
|
||||
<div class="grow-row"><span class="k">Deployed</span><span class="v">v2.0.0-rc3</span></div>
|
||||
<div class="grow-row"><span class="k">Commit</span><span class="v mono">9f3e2d1</span></div>
|
||||
<div class="grow-row"><span class="k">Reviewer</span><span class="v">Ben Hippler</span></div>
|
||||
</div>
|
||||
<div class="ifoot">Past sessions are read-only: the PDF already carries these values.</div>
|
||||
<div class="ihead">PDF</div>
|
||||
<div class="group">
|
||||
<div class="grow-row"><span class="k">File name</span><span class="v mono">Redline-20261031-0852-OMS-TEST-LANE-9B8C7D6E.pdf</span></div>
|
||||
<div class="grow-row"><span class="k">Sent</span><span class="v">31 Oct 2026, 08:52 via AirDrop</span></div>
|
||||
<div class="grow-row"><span class="k">Returned</span><span class="v">09:30 · marks on 1 of 2 pages</span></div>
|
||||
<div class="grow-row"><span class="k"></span><span class="v"><a href="#t2">Show PDF in Finder</a></span></div>
|
||||
</div>
|
||||
</aside>
|
||||
</div></div>`;
|
||||
}
|
||||
document.getElementById('mains').innerHTML =
|
||||
opt('2a','Current session selected, Lane field focused · light',mainWindow('light'),[
|
||||
'Sidebar: every kept session grouped by day; the current one is pinned at the top with a Current tag.',
|
||||
'Content: the pages exactly as the PDF will order them. Selection ring shows the focused page.',
|
||||
'Inspector: the three facts a reader of the PDF needs (review details, PDF, session). Editable only for the current session.'])
|
||||
+ opt('2b','Current session · dark',mainWindow('dark'))
|
||||
+ opt('2c','Past session that came back marked · light',returnedWindow('light'),[
|
||||
'A returned PDF is news, so it gets the one tinted banner in the app, with the two things you do next.',
|
||||
'No Send, no Capture on a past session: the toolbar dims Send and the content drops the Capture button.'])
|
||||
+ opt('2d','Past session that came back marked · dark',returnedWindow('dark'));
|
||||
|
||||
/* ---------- empty window ---------- */
|
||||
function emptyWindow(theme){
|
||||
const dark = theme==='dark'?' dark':'';
|
||||
return `<div class="mac${dark}"><div class="window" style="width:1100px;height:700px">
|
||||
${titlebar('New session','Nothing captured yet',false)}
|
||||
<nav class="sidebar" aria-label="Sessions"><div class="search">${SYM.search}Search</div><div class="sgroup">Today</div>
|
||||
<div class="srow sel"><span class="l1">New session<span class="current-pill">Current</span></span><span class="tm">10:31</span><span class="l2">No pages yet</span></div></nav>
|
||||
<main class="content"><div class="empty-main">
|
||||
<div class="t">No pages in this session</div>
|
||||
<div class="s">Press ⌥⇧2 anywhere to capture the saved area, or choose an area now. Each capture becomes one page of the PDF.</div>
|
||||
<div style="display:flex;gap:8px;margin-top:6px"><button class="btn lg">Choose Area…</button><button class="btn lg primary">${SYM.camera}Capture</button></div>
|
||||
</div></main>
|
||||
<aside class="inspector" aria-label="Session inspector">
|
||||
<div class="ihead">Review details</div>
|
||||
<div class="group">
|
||||
<div class="grow-row"><span class="k">Lane</span><span class="field ph focus">dev03, customer test lane…</span></div>
|
||||
<div class="grow-row"><span class="k">Deployed</span><span class="field ph">Build that is live</span></div>
|
||||
<div class="grow-row"><span class="k">Commit</span><span class="field ph mono">Git SHA</span></div>
|
||||
<div class="grow-row"><span class="k">Reviewer</span><span class="field">Ben Hippler</span></div>
|
||||
<div class="grow-row note"><span class="k">Note</span><span class="field ph">Add a note</span></div>
|
||||
</div>
|
||||
<div class="ifoot">Fill these in once. They print on every page and carry over to the next session.</div>
|
||||
</aside>
|
||||
</div></div>`;
|
||||
}
|
||||
document.getElementById('empties').innerHTML =
|
||||
opt('3a','First run · light',emptyWindow('light'),['The first thing the window asks for is the lane, because it names the file and heads every page.','Reviewer is pre-filled from the Mac account; nothing else is guessed.'])
|
||||
+ opt('3b','First run · dark',emptyWindow('dark'));
|
||||
|
||||
/* ---------- settings ---------- */
|
||||
function settings(theme){
|
||||
const dark = theme==='dark'?' dark':'';
|
||||
return `<div class="mac${dark}"><div class="settings" style="height:484px">
|
||||
<div class="st-title"><div class="lights"><i></i><i style="background:var(--fill2)"></i><i style="background:var(--fill2)"></i></div><div class="t">Redline Settings</div><div></div></div>
|
||||
<div class="st-body">
|
||||
<div class="ihead">Capture</div>
|
||||
<div class="group">
|
||||
<div class="st-row"><span class="k">Capture shortcut</span><span class="v"><span class="recorder">⌥⇧2</span></span></div>
|
||||
<div class="st-row"><span class="k">Area</span><span class="v"><span class="sec" style="font-size:12px">800 × 600 on Display 1</span><button class="btn sm">Choose…</button></span></div>
|
||||
</div>
|
||||
<div class="ihead">Sending</div>
|
||||
<div class="group">
|
||||
<div class="st-row"><span class="k">Send with</span><span class="v"><span class="seg"><span class="on">AirDrop</span><span>OneDrive</span></span></span></div>
|
||||
<div class="st-row"><span class="k">Save PDFs to</span><span class="v"><span class="path">~/Desktop</span><button class="btn sm">Choose…</button></span></div>
|
||||
<div class="st-row"><span class="k">Watch for returns in</span><span class="v"><span class="path">~/Downloads</span><button class="btn sm">Choose…</button></span></div>
|
||||
</div>
|
||||
<div class="ihead">Sessions</div>
|
||||
<div class="group">
|
||||
<div class="st-row"><span class="k">Delete sessions older than</span><span class="v"><span class="popup">Never<i></i></span></span></div>
|
||||
<div class="st-row"><span class="k sec" style="font-size:12px">18 sessions kept</span><span class="v"><button class="btn sm" disabled>Clean Up Now…</button></span></div>
|
||||
</div>
|
||||
<div class="st-help">Deleting removes Redline's own screenshots only. PDFs you sent stay where they are.</div>
|
||||
</div>
|
||||
</div></div>`;
|
||||
}
|
||||
document.getElementById('settings').innerHTML =
|
||||
opt('4a','Settings · light',settings('light'),['Three labelled groups replace headings-plus-grid. Every row is "what it is" on the left, the control on the right.','Clean Up Now… is enabled only when a limit is set, and confirms with the exact count before deleting.'])
|
||||
+ opt('4b','Settings · dark',settings('dark'));
|
||||
</script>
|
||||
</body>
|
||||
</html>
|
||||
Executable
+27
@@ -0,0 +1,27 @@
|
||||
#!/usr/bin/env bash
|
||||
set -euo pipefail
|
||||
|
||||
# Renders the headless panel PNGs and a sample review PDF for visual verification.
|
||||
#
|
||||
# ./scripts/render-panels.sh [output-directory]
|
||||
#
|
||||
# Builds nothing: run `swift build` (or ./scripts/build-app.sh) first. The output
|
||||
# directory is printed at the end; nothing outside it is touched, and the isolated
|
||||
# model means the real Application Support spool and the real age-limit preference
|
||||
# are never read or written.
|
||||
|
||||
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
|
||||
OUT_DIR="${1:-$(mktemp -d /tmp/redline-panels.XXXXXX)}"
|
||||
BINARY="${ROOT}/.build/Redline.app/Contents/MacOS/Shotdeck"
|
||||
|
||||
if [[ ! -x "${BINARY}" ]]; then
|
||||
BINARY="${ROOT}/.build/debug/Shotdeck"
|
||||
fi
|
||||
if [[ ! -x "${BINARY}" ]]; then
|
||||
echo "No Shotdeck binary found. Run swift build or ./scripts/build-app.sh first." >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
mkdir -p "${OUT_DIR}"
|
||||
SHOTDECK_SNAPSHOT_DIR="${OUT_DIR}" "${BINARY}"
|
||||
echo "Panels written to ${OUT_DIR}"
|
||||
Executable
+66
@@ -0,0 +1,66 @@
|
||||
#!/usr/bin/env bash
|
||||
set -euo pipefail
|
||||
|
||||
# End-to-end UI run: the real panel, in the ACTIVE app, typed into with the keyboard
|
||||
# and clicked with the mouse. Launched through LaunchServices ("open -n") because a
|
||||
# background shell launch can never get a key window — macOS will not let it activate.
|
||||
#
|
||||
# ./scripts/run-e2e-ui.sh
|
||||
#
|
||||
# Builds a throwaway copy of the signed app under a separate bundle identifier
|
||||
# (ai.flowmaster.shotdeck.e2e) so it can run alongside the installed Redline without
|
||||
# touching /Applications, Ben's real captures, or his real preferences. It writes its
|
||||
# results to a file and exits.
|
||||
|
||||
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
|
||||
SOURCE_APP="${ROOT}/.build/Redline.app"
|
||||
E2E_APP="${ROOT}/.build/RedlineE2E.app"
|
||||
IDENTITY="Apple Development: ben@flow-master.ai (QH2H9G2LK5)"
|
||||
BUNDLE_ID="ai.flowmaster.shotdeck.e2e"
|
||||
WORK_DIR="$(mktemp -d /tmp/redline-e2e.XXXXXX)"
|
||||
RESULT="${WORK_DIR}/result.txt"
|
||||
|
||||
if [[ ! -d "${SOURCE_APP}" ]]; then
|
||||
echo "No ${SOURCE_APP} found. Run ./scripts/build-app.sh first." >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# A leftover instance from an interrupted run would hold the bundle identifier and
|
||||
# make "open -n" a no-op.
|
||||
pkill -f "RedlineE2E.app/Contents/MacOS/Shotdeck" >/dev/null 2>&1 || true
|
||||
for _ in $(seq 1 20); do
|
||||
pgrep -f "RedlineE2E.app/Contents/MacOS/Shotdeck" >/dev/null 2>&1 || break
|
||||
sleep 0.2
|
||||
done
|
||||
rm -rf "${E2E_APP}"
|
||||
ditto "${SOURCE_APP}" "${E2E_APP}"
|
||||
/usr/libexec/PlistBuddy -c "Set :CFBundleIdentifier ${BUNDLE_ID}" "${E2E_APP}/Contents/Info.plist"
|
||||
/usr/libexec/PlistBuddy -c "Set :CFBundleName Redline E2E" "${E2E_APP}/Contents/Info.plist"
|
||||
# A menu-bar app (LSUIElement) is never activated by LaunchServices, and macOS only
|
||||
# lets an active app own the key window the keyboard goes to. The test copy is a
|
||||
# regular app for the duration of the run; the shipped app keeps LSUIElement.
|
||||
/usr/libexec/PlistBuddy -c "Set :LSUIElement false" "${E2E_APP}/Contents/Info.plist"
|
||||
codesign --force --options runtime \
|
||||
--sign "${IDENTITY}" \
|
||||
--identifier "${BUNDLE_ID}" \
|
||||
"${E2E_APP}"
|
||||
|
||||
open -n "${E2E_APP}" --args --selftest e2e --root "${WORK_DIR}/storage" --result "${RESULT}"
|
||||
|
||||
for _ in $(seq 1 120); do
|
||||
if [[ -f "${RESULT}" ]] && grep -qE "^E2E (PASS|FAIL)$" "${RESULT}"; then
|
||||
break
|
||||
fi
|
||||
sleep 0.25
|
||||
done
|
||||
|
||||
sleep 0.5
|
||||
osascript -e "tell application id \"${BUNDLE_ID}\" to quit" >/dev/null 2>&1 || true
|
||||
|
||||
if [[ ! -f "${RESULT}" ]]; then
|
||||
echo "E2E FAIL: no result file was written (${RESULT})" >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
cat "${RESULT}"
|
||||
grep -q "^E2E PASS$" "${RESULT}"
|
||||
Executable
+24
@@ -0,0 +1,24 @@
|
||||
#!/usr/bin/env bash
|
||||
set -euo pipefail
|
||||
|
||||
# Runs one in-process self-test phase against the built binary.
|
||||
#
|
||||
# ./scripts/run-selftest.sh panel
|
||||
# ./scripts/run-selftest.sh onedrive
|
||||
# ./scripts/run-selftest.sh sendtruth
|
||||
#
|
||||
# Prints the phase's PASS/FAIL lines and exits with the binary's status.
|
||||
|
||||
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
|
||||
PHASE="${1:-panel}"
|
||||
BINARY="${ROOT}/.build/Redline.app/Contents/MacOS/Shotdeck"
|
||||
|
||||
if [[ ! -x "${BINARY}" ]]; then
|
||||
BINARY="${ROOT}/.build/debug/Shotdeck"
|
||||
fi
|
||||
if [[ ! -x "${BINARY}" ]]; then
|
||||
echo "No Shotdeck binary found. Run swift build or ./scripts/build-app.sh first." >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
REDLINE_SELFTEST_PHASE="${PHASE}" "${BINARY}"
|
||||
Reference in New Issue
Block a user