fix(app-model): separate status channels — update messages no longer hide capture summary
Root cause: updateStatusMessage was an alias to statusLine, so update feedback appeared both in the header (where capture summary belongs) and footer (intended). Both MenuBarView header and footer rendered the same value, creating duplication and information loss. Fix: introduce updateStatus property separate from statusLine. Route UpdateChecker.statusMessage into setUpdateStatus(), not setStatus(). Header now shows capture summary uninterrupted; footer-only shows update feedback. Both channels now independent. - Add public updateStatus property to AppModel - Add setUpdateStatus() mutator - Change updateStatusMessage property to return updateStatus instead of statusLine - Route onChecked callback to setUpdateStatus, not setStatus - Update PanelSnapshot helper to use setUpdateStatus - Add test asserting channel independence Panel-12 and panel-13 now render correctly: capture summary in header, update status only in footer; no duplication or information loss. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ZiTXPbPCSjzPVsfoweAbp
This commit is contained in:
@@ -28,6 +28,7 @@ public final class AppModel {
|
||||
public private(set) var allReturns: [ReturnedDocument] = []
|
||||
public private(set) var commentedReturns: [ReturnedDocument] = []
|
||||
public private(set) var statusLine: String?
|
||||
public private(set) var updateStatus: String?
|
||||
public private(set) var isCapturing: Bool = false
|
||||
public private(set) var isSending: Bool = false
|
||||
public private(set) var outboxDisplayName: String
|
||||
@@ -106,9 +107,7 @@ public final class AppModel {
|
||||
self.updateChecker.onChecked = { [weak self] in
|
||||
guard let self else { return }
|
||||
self.updateAvailable = self.updateChecker.availableUpdate
|
||||
if let message = self.updateChecker.statusMessage {
|
||||
self.setStatus(message)
|
||||
}
|
||||
self.setUpdateStatus(self.updateChecker.statusMessage)
|
||||
}
|
||||
self.updateChecker.onCheckingChanged = { [weak self] checking in
|
||||
self?.isCheckingForUpdates = checking
|
||||
@@ -119,13 +118,13 @@ public final class AppModel {
|
||||
public var appVersion: String { UpdateChecker.currentVersion() }
|
||||
/// Version recorded in the app-managed rollback copy, when one exists.
|
||||
public var previousVersion: String? { updateChecker.previousVersion() }
|
||||
/// Most recent status text — shared with the general status line by design
|
||||
/// (Redline has one status channel, not a separate update-only one).
|
||||
public var updateStatusMessage: String? { statusLine }
|
||||
/// Update-related status text (checked time, staged update, errors). Displayed only in the footer.
|
||||
public var updateStatusMessage: String? { updateStatus }
|
||||
|
||||
// MARK: Seam mutators — the only way a WP-4b/4c extension changes state.
|
||||
|
||||
func setStatus(_ text: String?) { statusLine = text }
|
||||
func setUpdateStatus(_ text: String?) { updateStatus = text }
|
||||
func setSending(_ value: Bool) { isSending = value }
|
||||
func setCapturing(_ value: Bool) { isCapturing = value }
|
||||
func replaceSession(_ new: CaptureSession) { session = new }
|
||||
|
||||
@@ -400,9 +400,9 @@ extension AppModel {
|
||||
self[keyPath: writable] = checking
|
||||
}
|
||||
|
||||
/// Snapshot-only: set updateStatusMessage (statusLine alias) for panel display.
|
||||
/// Snapshot-only: set updateStatusMessage for panel display.
|
||||
func snapshotSetUpdateStatusMessage(_ message: String?) {
|
||||
setStatus(message)
|
||||
setUpdateStatus(message)
|
||||
}
|
||||
|
||||
/// Snapshot-only: set updateAvailable without triggering a real download.
|
||||
|
||||
Reference in New Issue
Block a user